Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename query APIs in Logs and Metrics Client #24318

Closed
srnagar opened this issue Sep 24, 2021 · 0 comments · Fixed by #24523
Closed

Rename query APIs in Logs and Metrics Client #24318

srnagar opened this issue Sep 24, 2021 · 0 comments · Fixed by #24523
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Monitor Monitor, Monitor Ingestion, Monitor Query

Comments

@srnagar
Copy link
Member

srnagar commented Sep 24, 2021

To prepare for supporting resource-centric logs queries, make the following name changes to the query APIs in Logs and Metrics clients.

public class LogsQueryClient {
 public LogsQueryResult queryWorkspace(String workspaceId, String query, QueryTimeInterval timeInterval) 
}
 
// batch query
public class LogsBatchQuery {
 public String addWorkspaceQuery(String workspaceId, String query, QueryTimeInterval timeInterval)
}

public class MetricsClient {
  public MetricsQueryResult queryResource(String resourceid, ...);
}
@srnagar srnagar added Client This issue points to a problem in the data-plane of the library. Monitor - Query labels Sep 24, 2021
@srnagar srnagar added this to the [2021] October milestone Sep 24, 2021
@srnagar srnagar self-assigned this Sep 24, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
@srnagar srnagar added Monitor Monitor, Monitor Ingestion, Monitor Query and removed Monitor - Query labels Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Monitor Monitor, Monitor Ingestion, Monitor Query
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant