From 6fb90c44506ae8faa5327c1fd16ef5ba36f73605 Mon Sep 17 00:00:00 2001 From: Jesse Squire Date: Mon, 11 Mar 2024 11:32:47 -0700 Subject: [PATCH] [CODEOWNERS] Fix duplicate entries for messaging (#39155) The focus of these changes is to fix service label duplication that would cause inappropriate matches for the messaging services. ### Important context: - The `Service Attention` label is ignored during match logic. - Service label matches follow the same rules as paths for pull requests. This means that ordering of rules is important; scanning starts at the bottom of the file and progresses towards the top. Once the first match is found, it is used and scanning stops. This means that the `//` section at the bottom of this file will be the first matches found for most service tags, causing automated triage to consider these tags to be service-owned and assigned. --- .github/CODEOWNERS | 24 ++++++++++-------------- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 90c9f92f47fe6..d25b5d5f1826c 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -122,12 +122,16 @@ /sdk/modelsrepository/ @drwill-ms @timtay-microsoft @abhipsaMisra @digimaun @andyk-ms @brycewang-microsoft @tmahmood-microsoft @ngastelum-ms # AzureSdkOwners: @billwert +# ServiceOwners: @jfggdl # ServiceLabel: %Event Grid + # PRLabel: %Event Grid /sdk/eventgrid/ @billwert @mssfang @srnagar @lmolkova # AzureSdkOwners: @conniey @anuchandy @lmolkova +# ServiceOwners: @serkantkaraca @sjkwak # ServiceLabel: %Event Hubs + # PRLabel: %Event Hubs /sdk/eventhubs/ @conniey @anuchandy @lmolkova @@ -196,9 +200,11 @@ /sdk/remoterendering/ @MichaelZp0 @ChristopherManthei # AzureSdkOwners: @conniey +# ServiceOwners: @hmlam # ServiceLabel: %Schema Registry + # PRLabel: %Schema Registry -/sdk/schemaregistry/ @conniey @sjkwak @srnagar +/sdk/schemaregistry/ @conniey @srnagar # AzureSdkOwners: @alzimmermsft @jairmyree # ServiceLabel: %Search @@ -211,11 +217,13 @@ /sdk/serialization/ @alzimmermsft @srnagar # AzureSdkOwners: @anuchandy +# ServiceOwners: @EldertGrootenboer # ServiceLabel: %Service Bus + # PRLabel: %Service Bus /sdk/servicebus/ @anuchandy @conniey @lmolkova -# ServiceLabel: %Service Bus %Service Attention %Track 1 +# ServiceLabel: %Service Bus %Track 1 # PRLabel: %Service Bus /sdk/servicebus/microsoft-azure-servicebus/ @shankarsama @yvgopal @@ -533,12 +541,6 @@ # ServiceLabel: %Digital Twins %Service Attention #// @@drwill-ms @@timtay-microsoft @@abhipsaMisra @@vinagesh @@azabbasi @@barustum @@jamdavi -# ServiceLabel: %Event Grid %Service Attention -#// @jfggdl - -# ServiceLabel: %Event Hubs %Service Attention -#// @kasun04 - # ServiceLabel: %Functions %Service Attention #// @ahmedelnably @fabiocav @@ -701,15 +703,9 @@ # ServiceLabel: %Security %Service Attention #// @chlahav -# ServiceLabel: %Service Attention %Service Bus -#// @EldertGrootenboer - # ServiceLabel: %Service Attention %Service Fabric #// @QingChenmsft @vaishnavk @juhacket -# ServiceLabel: %Schema Registry %Service Attention -#// @arerlend @alzimmermsft - # ServiceLabel: %Service Attention %SignalR #// @sffamily @chenkennt