Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update swagger_to_sdk_config.json and ignore *.zip files #5334

Merged
merged 1 commit into from
Jul 25, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ _testmain.go
*.exe
*.test
*.prof
*.zip

# Editor swap files
*.swp
Expand Down
3 changes: 2 additions & 1 deletion swagger_to_sdk_config.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"$schema": "https://openapistorageprod.blob.core.windows.net/sdkautomation/prod/schemas/swagger_to_sdk_config.schema.json",
"meta": {
"after_scripts": [
"dep ensure",
Expand All @@ -22,7 +23,7 @@
"advanced_options": {
"clone_dir": "./src/github.com/Azure/azure-sdk-for-go",
"sdk_generation_pull_request_base": "integration_branch",
"main_branch": "latest"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is main_branch no longer needed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main branch is now defined in the specificationRepositoryConfiguration.json file in the specification repository. That way when SDK Automation reads information about the SDK repository, it already knows which branch it should treat as the main branch. This is much better than reading the swagger_to_sdk_config.json file in the master branch to determine which branch should be treated as the main branch.

"create_sdk_pull_requests": false
},
"version": "0.2.0"
}
Expand Down