From 8ff05a7770f1c84395dc85e5e28a16d1a2a3d00c Mon Sep 17 00:00:00 2001 From: Tamer Sherif Date: Tue, 25 Jul 2023 11:56:21 -0700 Subject: [PATCH 1/2] fixed string to sign issue --- sdk/storage/azblob/internal/exported/shared_key_credential.go | 2 +- sdk/storage/azfile/internal/exported/shared_key_credential.go | 2 +- sdk/storage/azqueue/internal/exported/shared_key_credential.go | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/sdk/storage/azblob/internal/exported/shared_key_credential.go b/sdk/storage/azblob/internal/exported/shared_key_credential.go index d1563105423f..bd0bd5e260db 100644 --- a/sdk/storage/azblob/internal/exported/shared_key_credential.go +++ b/sdk/storage/azblob/internal/exported/shared_key_credential.go @@ -172,7 +172,7 @@ func (c *SharedKeyCredential) buildCanonicalizedResource(u *url.URL) (string, er // Join the sorted key values separated by ',' // Then prepend "keyName:"; then add this string to the buffer - cr.WriteString("\n" + paramName + ":" + strings.Join(paramValues, ",")) + cr.WriteString("\n" + strings.ToLower(paramName) + ":" + strings.Join(paramValues, ",")) } } return cr.String(), nil diff --git a/sdk/storage/azfile/internal/exported/shared_key_credential.go b/sdk/storage/azfile/internal/exported/shared_key_credential.go index 439617d07ba1..50aaf889942f 100644 --- a/sdk/storage/azfile/internal/exported/shared_key_credential.go +++ b/sdk/storage/azfile/internal/exported/shared_key_credential.go @@ -172,7 +172,7 @@ func (c *SharedKeyCredential) buildCanonicalizedResource(u *url.URL) (string, er // Join the sorted key values separated by ',' // Then prepend "keyName:"; then add this string to the buffer - cr.WriteString("\n" + paramName + ":" + strings.Join(paramValues, ",")) + cr.WriteString("\n" + strings.ToLower(paramName) + ":" + strings.Join(paramValues, ",")) } } return cr.String(), nil diff --git a/sdk/storage/azqueue/internal/exported/shared_key_credential.go b/sdk/storage/azqueue/internal/exported/shared_key_credential.go index a8d648104cad..775220acc6de 100644 --- a/sdk/storage/azqueue/internal/exported/shared_key_credential.go +++ b/sdk/storage/azqueue/internal/exported/shared_key_credential.go @@ -172,7 +172,7 @@ func (c *SharedKeyCredential) buildCanonicalizedResource(u *url.URL) (string, er // Join the sorted key values separated by ',' // Then prepend "keyName:"; then add this string to the buffer - cr.WriteString("\n" + paramName + ":" + strings.Join(paramValues, ",")) + cr.WriteString("\n" + strings.ToLower(paramName) + ":" + strings.Join(paramValues, ",")) } } return cr.String(), nil From ed7f1a594d8281583027356b1312f7816e4f7491 Mon Sep 17 00:00:00 2001 From: Tamer Sherif Date: Wed, 26 Jul 2023 18:00:02 -0700 Subject: [PATCH 2/2] fixed test and added changelog --- sdk/storage/azblob/CHANGELOG.md | 1 + sdk/storage/azblob/assets.json | 2 +- sdk/storage/azfile/CHANGELOG.md | 1 + sdk/storage/azqueue/CHANGELOG.md | 3 ++- 4 files changed, 5 insertions(+), 2 deletions(-) diff --git a/sdk/storage/azblob/CHANGELOG.md b/sdk/storage/azblob/CHANGELOG.md index 235250a0b328..ef02f3def4d1 100644 --- a/sdk/storage/azblob/CHANGELOG.md +++ b/sdk/storage/azblob/CHANGELOG.md @@ -7,6 +7,7 @@ ### Breaking Changes ### Bugs Fixed +* Fixed issue where some requests fail with mismatch in string to sign. ### Other Changes diff --git a/sdk/storage/azblob/assets.json b/sdk/storage/azblob/assets.json index 4db1d7209d92..7301bd69d694 100644 --- a/sdk/storage/azblob/assets.json +++ b/sdk/storage/azblob/assets.json @@ -2,5 +2,5 @@ "AssetsRepo": "Azure/azure-sdk-assets", "AssetsRepoPrefixPath": "go", "TagPrefix": "go/storage/azblob", - "Tag": "go/storage/azblob_a772b9c866" + "Tag": "go/storage/azblob_0776f1b95b" } diff --git a/sdk/storage/azfile/CHANGELOG.md b/sdk/storage/azfile/CHANGELOG.md index 88e69f3c796b..79470a10c599 100644 --- a/sdk/storage/azfile/CHANGELOG.md +++ b/sdk/storage/azfile/CHANGELOG.md @@ -7,6 +7,7 @@ ### Breaking Changes ### Bugs Fixed +* Fixed issue where some requests fail with mismatch in string to sign. ### Other Changes diff --git a/sdk/storage/azqueue/CHANGELOG.md b/sdk/storage/azqueue/CHANGELOG.md index b9078af0b455..a6b4e5fd701d 100644 --- a/sdk/storage/azqueue/CHANGELOG.md +++ b/sdk/storage/azqueue/CHANGELOG.md @@ -7,7 +7,8 @@ #### Breaking Changes #### Bugs Fixed - +* Fixed issue where some requests fail with mismatch in string to sign. +* #### Other Changes ### 1.0.0 (2023-05-09)