Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute: AvailabilitySetsClient, VirtualMachinesClient, VirtualMachineScaleSetsClient return incorrect casing for the Proximity placement group ID (resource group name is lower cased) #5699

Closed
katbyte opened this issue Sep 5, 2019 · 12 comments
Assignees
Labels
Compute customer-reported Issues that are reported by GitHub users external to the Azure organization. Mgmt This issue is related to a management-plane library. Service Attention Workflow: This issue is responsible by Azure service team.

Comments

@katbyte
Copy link

katbyte commented Sep 5, 2019

Bug Report

  • import path of package in question, e.g. .../services/compute/mgmt/2018-06-01/compute
    "github.com/Azure/azure-sdk-for-go/services/compute/mgmt/2018-06-01/compute"
  • SDK version e.g. master, latest, 18.1.0
    github.com/Azure/azure-sdk-for-go v32.5.0+incompatible
  • output of go version
go version go1.12.6 darwin/amd64
  • What happened?
    The clients AvailabilitySetsClient, VirtualMachinesClient, VirtualMachineScaleSetsClient return incorrect casing for the Proximity placement group ID (resource group name is lower cased)

  • What did you expect or want to happen?
    The PPG id returned with the correct casing.

  • How can we reproduce it?
    Create one of the affected resources with a PPG in a resource group with capitals & check the casing returned

  • Anything we should know about your environment.

@loarabia loarabia added Compute customer-reported Issues that are reported by GitHub users external to the Azure organization. Mgmt This issue is related to a management-plane library. labels Sep 5, 2019
@triage-new-issues triage-new-issues bot removed the triage label Sep 5, 2019
@ArcturusZhang
Copy link
Member

Hi @katbyte could you please provide some more detailed information? Such as the parameters you are using and the response the service returns, etc.

@katbyte
Copy link
Author

katbyte commented Sep 18, 2019

It happens no matter what parameter we send, the service always returns it in lower case. see discussion here: hashicorp/terraform-provider-azurerm#4020

@ArcturusZhang ArcturusZhang added the Service Attention Workflow: This issue is responsible by Azure service team. label Sep 19, 2019
@ghost
Copy link

ghost commented Sep 19, 2019

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @mjconnection, @Drewm3

@Drewm3
Copy link
Member

Drewm3 commented Sep 19, 2019

Is the problem in the casing of the resource group name or the PPG? The resource group name casing is not guaranteed in the responses from the Microsoft.Compute resource provider.

@Drewm3 Drewm3 self-assigned this Sep 20, 2019
@katbyte
Copy link
Author

katbyte commented Sep 26, 2019

@Drewm3, the problem is the casing of the resource group name does not match the actual case of the resource group name. This behaviour does not match the majority of azure APIs.

@Drewm3
Copy link
Member

Drewm3 commented Sep 27, 2019

Thanks for the feedback. I do understand it is a bit challenging when the casing is inconsistent, but this is "by design" currently for VMs and associated resources. The development team does have a replacement design that will support retaining case in the future, but this is unfortunately a very large work item due to the current backend implementation. So I do not know when we will be able to update the platform to support the retaining of the case based on what is first seen by the compute resource provider.

@Drewm3 Drewm3 closed this as completed Sep 27, 2019
@ghost
Copy link

ghost commented Sep 27, 2019

Thanks for working with Microsoft on GitHub! Tell us how you feel about your experience using the reactions on this comment.

@katbyte
Copy link
Author

katbyte commented Sep 27, 2019

@Drewm3, @jhendrixMSFT,

I'm not sure why this issue was closed? I don't see any resolution other then an explanation for why a fix will take a while. Could we please keep this issue open for tracking until it is actually fixed as it is linked to in code & PRs?

@ArcturusZhang ArcturusZhang reopened this Sep 29, 2019
@Drewm3
Copy link
Member

Drewm3 commented Sep 29, 2019

This is closed because it is by design. Please feel free to open design changes or feature requests here: https://feedback.azure.com/forums/216843-virtual-machines.

Unfortunately, it is exceptionally difficult to manually manage feature requests for the entire surface of the VM product in GitHub.

@Drewm3 Drewm3 closed this as completed Sep 29, 2019
@ghost
Copy link

ghost commented Sep 29, 2019

Thanks for working with Microsoft on GitHub! Tell us how you feel about your experience using the reactions on this comment.

@katbyte
Copy link
Author

katbyte commented Oct 17, 2019

@Drewm3,

I'm not sure what by "design" implies but as a consumer of this API & SDK this is very much a bug. The service is changing the resource group name in a way inconsistent with the rest of Azure so i'm not sure why this is a feature request?

@Drewm3
Copy link
Member

Drewm3 commented Oct 18, 2019

I cannot speak for the behavior of other resources. However, for VMs the behavior is the expected behavior from the backend system. Changing the expected behavior is going to be a design change which we typically call a feature. I cannot say that I 100% agree that the current expectation is the best. I am only sharing that the current behavior is what is expected.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Compute customer-reported Issues that are reported by GitHub users external to the Azure organization. Mgmt This issue is related to a management-plane library. Service Attention Workflow: This issue is responsible by Azure service team.
Projects
None yet
Development

No branches or pull requests

4 participants