Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency check tool doesn't handle v2 modules #18350

Closed
jhendrixMSFT opened this issue Jun 9, 2022 · 3 comments · Fixed by #18409
Closed

Dependency check tool doesn't handle v2 modules #18350

jhendrixMSFT opened this issue Jun 9, 2022 · 3 comments · Fixed by #18409
Assignees
Labels
Mgmt-EngSys Engineering System (Management Plane Specific)

Comments

@jhendrixMSFT
Copy link
Member

https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1629059&view=logs&j=b70e5e73-bbb6-5567-0939-8415943fadb9&t=bdeefc16-b669-5ebd-ad94-a2c19ade53b0

github.com/Azure/azure-sdk-for-go/sdk/depcheck imports github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/communication/armcommunication/v2: module github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/communication/armcommunication@latest found (v1.0.0), but does not contain package github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/communication/armcommunication/v2

@jhendrixMSFT jhendrixMSFT added the Mgmt-EngSys Engineering System (Management Plane Specific) label Jun 9, 2022
@tadelesh
Copy link
Member

tadelesh commented Jun 10, 2022

I reran the pipeline and came with a sucess. It is a little tricky here. After we merge the v2 release code into main, we need wait for the release ci and approve for release, and then we can have tag and package can be indexed by pkg.go.dev. During the time before tag finished, there will be no v2 package can be get, so other ci which include this v2 source code will fail then. We will make this gap time as short as possible, but it seems some ci broken are unavoidable. BTW, why some data plane package's ci will be trigged when the change happens in mgmt. plane.

@jhendrixMSFT
Copy link
Member Author

How often will this race happen? It might be better to skip depcheck for a module in this state than fail the CI so we don't have to always investigate the failure. I think the risk of skipping is much less. What do you think?

@tadelesh
Copy link
Member

I changed the script to use tag to verify the version and fall back to use replace if race.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Mgmt-EngSys Engineering System (Management Plane Specific)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants