Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[azservicebus] Recreate the ATOM client using the autorest generator #17041

Closed
1 of 4 tasks
richardpark-msft opened this issue Feb 11, 2022 · 1 comment
Closed
1 of 4 tasks
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved. Service Bus

Comments

@richardpark-msft
Copy link
Member

richardpark-msft commented Feb 11, 2022

The ATOM client in the azservicebus package was generated from an older client, and is not standardized like the rest of our autogenerated libraries (for instance, it has it's own "custom" retry policy, etc..).

We need to regenerate this, based on the swagger for the API.

My first pass at this has shown that it does generate some parts of the client correctly. This has been done in Python and Java, so this might be a case of some limitation of our current autorest generator.

Swagger link: sb-swagger

If the generation is correct, it should fix:

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Feb 11, 2022
@richardpark-msft richardpark-msft added Client This issue points to a problem in the data-plane of the library. Service Bus labels Feb 11, 2022
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Feb 11, 2022
@RickWinter RickWinter added the feature-request This issue requires a new behavior in the product in order be resolved. label Feb 14, 2022
@richardpark-msft
Copy link
Member Author

At this point we're far past GA. Regenerating might have some utility now but it's far less needed than it would have been before. Closing for now.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved. Service Bus
Projects
None yet
Development

No branches or pull requests

2 participants