Upgrade Machinelearningservices to 2021-04-01

[gro1m]

Feature Request

The REST API is on version 2021-04-01 for machinelearningservices: https://github.com/Azure/azure-rest-api-specs/tree/master/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/stable/2021-04-01.
The GO SDK is one year behind (2020-04-01): https://pkg.go.dev/github.com/Azure/azure-sdk-for-go/services/machinelearningservices/[email protected]+incompatible.

I want to do the terraform azure provider implementation for the Machine Learning Computing "Suite":

1. Machine Learning Compute Instance - this Compute type is unfortunately unavailable in the version 2020-04-01. (Support for Azure Machine Learning Compute Instance (new resource) hashicorp/terraform-provider-azurerm#11255 / Support for azureml compute  hashicorp/terraform-provider-azurerm#6827)

2. Machine Learning Compute Cluster - I cannot do the update operation. PR is here: new resource - azurerm_machine_learning_compute_cluster hashicorp/terraform-provider-azurerm#11675. Looked into it with @favoretti from Terraform Azure Providers Team and this seems to be due to outdated versions:
   portal sends payload to PATCH request in form of:

{"properties":
    {"properties":
        {"scaleSettings":
            {"minNodeCount":2,
              "maxNodeCount":3,
              "nodeIdleTimeBeforeScaleDown":"PT900S"
             }
         }
     }
}

, whereas Go SDK sends:

{"properties":
    {"scaleSettings":
        {"maxNodeCount":2,
         "minNodeCount":1,
         "nodeIdleTimeBeforeScaleDown":"PT60S"
        }
     }
}

, but portal seems to use a newer API version.

3. Machine Learning Inference Cluster: not sure if that has an issue with the 2020-04-01 version. PR is here: new resource azurerm_machine_learning_inference_cluster hashicorp/terraform-provider-azurerm#11550.

The following part in https://github.com/Azure/azure-rest-api-specs/blob/master/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/stable/2021-04-01/machineLearningServices.json#L713 describes best the Get operation I need (of course also all other necessary operations for implementing the CRUD):

        "operationId": "MachineLearningCompute_Get",
        "description": "Gets compute definition by its name. Any secrets (storage keys, service credentials, etc) are not returned - use 'keys' nested resource to get them.",
        "x-ms-examples": {
          "Get a AKS Compute": {
            "$ref": "./examples/getAKSCompute.json"
          },
          "Get a AML Compute": {
            "$ref": "./examples/getAmlCompute.json"
          },
          "Get an ComputeInstance": {
            "$ref": "./examples/getComputeInstance.json"
          }
        },

Would look forward to a rather quick implementation (rough expectation: 1 week), but I am a bit irritated that the versions have not been pulled after consequently. So if there is a way I can contribute so that this moves quicker, I will be happy to do so :)

[favoretti]

@ArcturusZhang would this be a trivial fix or?..

[ghost]

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @azureml-github.

Issue Details

---

Feature Request

The REST API is on version 2021-04-01 for machinelearningservices: https://github.com/Azure/azure-rest-api-specs/tree/master/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/stable/2021-04-01.
The GO SDK is one year behind (2020-04-01): https://pkg.go.dev/github.com/Azure/azure-sdk-for-go/services/machinelearningservices/[email protected]+incompatible.

I want to do the terraform azure provider implementation for the Machine Learning Computing "Suite":

1. Machine Learning Compute Instance - this Compute type is unfortunately unavailable in the version 2020-04-01. (Support for Azure Machine Learning Compute Instance (new resource) hashicorp/terraform-provider-azurerm#11255 / Support for azureml compute  hashicorp/terraform-provider-azurerm#6827)

2. Machine Learning Compute Cluster - I cannot do the update operation. PR is here: new resource - azurerm_machine_learning_compute_cluster hashicorp/terraform-provider-azurerm#11675. Looked into it with @favoretti from Terraform Azure Providers Team and this seems to be due to outdated versions:
   portal sends payload to PATCH request in form of:

{"properties":
    {"properties":
        {"scaleSettings":
            {"minNodeCount":2,
              "maxNodeCount":3,
              "nodeIdleTimeBeforeScaleDown":"PT900S"
             }
         }
     }
}

, whereas Go SDK sends:

{"properties":
    {"scaleSettings":
        {"maxNodeCount":2,
         "minNodeCount":1,
         "nodeIdleTimeBeforeScaleDown":"PT60S"
        }
     }
}

, but portal seems to use a newer API version.

3. Machine Learning Inference Cluster: not sure if that has an issue with the 2020-04-01 version. PR is here: new resource azurerm_machine_learning_inference_cluster hashicorp/terraform-provider-azurerm#11550.

The following part in https://github.com/Azure/azure-rest-api-specs/blob/master/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/stable/2021-04-01/machineLearningServices.json#L713 describes best the Get operation I need (of course also all other necessary operations for implementing the CRUD):

        "operationId": "MachineLearningCompute_Get",
        "description": "Gets compute definition by its name. Any secrets (storage keys, service credentials, etc) are not returned - use 'keys' nested resource to get them.",
        "x-ms-examples": {
          "Get a AKS Compute": {
            "$ref": "./examples/getAKSCompute.json"
          },
          "Get a AML Compute": {
            "$ref": "./examples/getAmlCompute.json"
          },
          "Get an ComputeInstance": {
            "$ref": "./examples/getComputeInstance.json"
          }
        },

Would look forward to a rather quick implementation (rough expectation: 1 week), but I am a bit irritated that the versions have not been pulled after consequently. So if there is a way I can contribute so that this moves quicker, I will be happy to do so :)

Author:	gro1m
Assignees:	-
Labels:	Machine Learning, Service Attention, customer-reported, feature-request, needs-triage, question
Milestone:	-

[ArcturusZhang]

Hi @gro1m @favoretti thanks for opening this issue.

The SDK team cannot release an api-version without the release requests from the corresponding service team - therefore I tagged this issue so that the corresponding service team could get a notice of this.

[ArcturusZhang]

Hey @gro1m and @favoretti I just found that this issue comes from the swagger and the new api-version cannot solve this issue. More details can be found in this issue #14669

[github-actions]

Hi @gro1m, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.