Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Gen2 for PowerBI Embedded #14399

Closed
kosinsky opened this issue Mar 6, 2021 · 6 comments
Closed

Support Gen2 for PowerBI Embedded #14399

kosinsky opened this issue Mar 6, 2021 · 6 comments
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. feature-request This issue requires a new behavior in the product in order be resolved. PowerBI Service Attention Workflow: This issue is responsible by Azure service team.

Comments

@kosinsky
Copy link

kosinsky commented Mar 6, 2021

Feature Request

Current version of the SDK supports only Gen 1 for Power BI Embedded. Please, add support for Gen 2. ARM templates already support that: https://docs.microsoft.com/en-us/power-bi/developer/embedded/azure-pbie-create-capacity?tabs=ARM-template#embedded-gen2-preview

That will allow to add support for PBI Embedded Gen 2 to terraform azurerm provider https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/powerbi_embedded
@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Mar 6, 2021
@ArcturusZhang
Copy link
Member

Hi @kosinsky thanks for this issue!

Unfortunately because the SDKs in this repo are almost generated from the swaggers, we cannot release it if it does not have swaggers and power BI Embeded is the case: we only have a very old api-version here: https://github.com/Azure/azure-rest-api-specs/tree/master/specification/powerbiembedded/resource-manager/Microsoft.PowerBI/stable, but the doc link you send requires 2018-09-01-preview in the ARM template.

I have added the tags to draw service team's attention on this. But in the meantime, could you please open an issue in the swagger repo?

@ArcturusZhang ArcturusZhang added PowerBI Service Attention Workflow: This issue is responsible by Azure service team. labels Mar 10, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Mar 10, 2021
@ArcturusZhang ArcturusZhang added feature-request This issue requires a new behavior in the product in order be resolved. and removed question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Mar 10, 2021
@kosinsky kosinsky mentioned this issue Apr 23, 2021
Open
@kosinsky
Copy link
Author

kosinsky commented May 6, 2021

@ArcturusZhang Looks like PowerBI Dedicated is the next step. They recently added version 2021-01-01 to the swagger:

https://github.com/Azure/azure-rest-api-specs/tree/master/specification/powerbidedicated/resource-manager/Microsoft.PowerBIdedicated/stable/2021-01-01 and it does support Gen2 (https://github.com/Azure/azure-rest-api-specs/blob/master/specification/powerbidedicated/resource-manager/Microsoft.PowerBIdedicated/stable/2021-01-01/powerbidedicated.json#L864)
Older 2017 version doesn't have that property and GO SDK supports only 2017 version: https://github.com/Azure/azure-sdk-for-go/tree/master/services/powerbidedicated/mgmt/2017-10-01/powerbidedicated

Could 2021-01-01 version be exposed to GO SDK?

@ArcturusZhang
Copy link
Member

@ArcturusZhang Looks like PowerBI Dedicated is the next step. They recently added version 2021-01-01 to the swagger:

https://github.com/Azure/azure-rest-api-specs/tree/master/specification/powerbidedicated/resource-manager/Microsoft.PowerBIdedicated/stable/2021-01-01 and it does support Gen2 (https://github.com/Azure/azure-rest-api-specs/blob/master/specification/powerbidedicated/resource-manager/Microsoft.PowerBIdedicated/stable/2021-01-01/powerbidedicated.json#L864)
Older 2017 version doesn't have that property and GO SDK supports only 2017 version: https://github.com/Azure/azure-sdk-for-go/tree/master/services/powerbidedicated/mgmt/2017-10-01/powerbidedicated

Could 2021-01-01 version be exposed to GO SDK?

Unfortunately exposing a new package or updating an existing api-version should be initiated by the service team, so that we would know the corresponding swaggers are ready to ship SDKs.
I will try let the service team know about this package request in our SDK.

@kosinsky
Copy link
Author

@ArcturusZhang did you hear back form Power BI team? Python SDK was updated to use new version of the API ~2 month ago: Azure/azure-sdk-for-python#17585

@ArcturusZhang
Copy link
Member

Hi @kosinsky sorry for the delay but I just pinged the corresponding service team again using internal email.

@kosinsky
Copy link
Author

We could close that. v55.1.0 added support for 2021-01-01 API for Power BI which includes Gen2 support: https://github.com/Azure/azure-sdk-for-go/pull/14727/files#diff-71e3b93c89042c183f656c256a4f0023bba0ac2987a70fa6db58504c916eed5e

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. feature-request This issue requires a new behavior in the product in order be resolved. PowerBI Service Attention Workflow: This issue is responsible by Azure service team.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kosinsky @ArcturusZhang