Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't create DataDisk with compute.CachingTypesReadWrite or compute.StorageAccountTypesStandardSSDLRS #12309

Closed
nyetwurk opened this issue Aug 22, 2020 · 6 comments
Assignees
Labels
Compute - VM customer-reported Issues that are reported by GitHub users external to the Azure organization. Mgmt This issue is related to a management-plane library. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team.

Comments

@nyetwurk
Copy link

nyetwurk commented Aug 22, 2020

Bug Report

github.com/Azure/azure-sdk-for-go/services/compute/mgmt/2018-10-01/compute

github.com/Azure/azure-sdk-for-go v40.6.0+incompatible

go1.14.6

	vm.StorageProfile.DataDisks = &[]compute.DataDisk{{
		Lun:          to.Int32Ptr(0),
		Name:         to.StringPtr(diskName),
		CreateOption: compute.DiskCreateOptionTypesEmpty,
		DiskSizeGB:   to.Int32Ptr(sizeGB),
		Caching:      compute.CachingTypesReadWrite, // doesn't work
		ManagedDisk: &compute.ManagedDiskParameters{ // doesn't work
			StorageAccountType: compute.StorageAccountTypesStandardSSDLRS,
			ID:                 &id,
		},
	}}

I still end up with CachingTypesNone and StandardHDD

@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Aug 22, 2020
@nyetwurk nyetwurk changed the title Can't create Can't create DataDisk with compute.CachingTypesReadWrite or compute.CachingTypesReadWrite Aug 22, 2020
@nyetwurk nyetwurk changed the title Can't create DataDisk with compute.CachingTypesReadWrite or compute.CachingTypesReadWrite Can't create DataDisk with compute.CachingTypesReadWrite or compute.StorageAccountTypesStandardSSDLRS Aug 22, 2020
@ArcturusZhang ArcturusZhang added Compute - VM and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Aug 27, 2020
@nyetwurk
Copy link
Author

I'm guessing those parameters are read only and have to create a storage account first with storageAccountsClient.Create()?

@tzhanl tzhanl added the Mgmt This issue is related to a management-plane library. label Nov 23, 2020
@lirenhe lirenhe added the Service Attention Workflow: This issue is responsible by Azure service team. label Sep 10, 2021
@ghost
Copy link

ghost commented Sep 10, 2021

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @Drewm3, @avirishuv.

Issue Details

Bug Report

"github.com/Azure/azure-sdk-for-go/services/compute/mgmt/2018-10-01/compute"

github.com/Azure/azure-sdk-for-go v40.6.0+incompatible

go1.14.6

	vm.StorageProfile.DataDisks = &[]compute.DataDisk{{
		Lun:          to.Int32Ptr(0),
		Name:         to.StringPtr(diskName),
		CreateOption: compute.DiskCreateOptionTypesEmpty,
		DiskSizeGB:   to.Int32Ptr(sizeGB),
		Caching:      compute.CachingTypesReadWrite, // doesn't work
		ManagedDisk: &compute.ManagedDiskParameters{ // doesn't work
			StorageAccountType: compute.StorageAccountTypesStandardSSDLRS,
			ID:                 &id,
		},
	}}

I still end up with CachingTypesNone and StandardHDD

Author: nyetwurk
Assignees: -
Labels:

question, Compute - VM, Service Attention, Mgmt, customer-reported

Milestone: -

@ghost ghost added the needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team label Sep 10, 2021
@jaylabell
Copy link

@Drewm3 Do you mind taking a look at this issue please?

@Drewm3
Copy link
Member

Drewm3 commented Oct 26, 2021

Hi @nyetwurk, I apologize that this issue was not triaged over to the correct team for over a year.

I am not an expert in the Go SDK, but I see that I am able to create a VM through the Azure Portal and Rest APIs that has a StandardSSD data disk with the caching set to ReadWrite caching. Could you attempt to recreate the issue using the current API version (2021-07-01) to see if the problem still occurs? If the problem does still occur with the current SDK, then I will need to find someone with Go expertise to help debug why it is not working for you or if there is some weird issue that is only showing up in the Go SDK instead of the backend service.

@nyetwurk
Copy link
Author

I will test this time permitting. We have mostly abandoned this project partially due to this issue, but will revisit this if the issue is resolved. Is there documentation that confirms this is the correct way to instantiate an SSD drive?

That is to say, storageAccountsClient.Create() is not needed, only that storageAccountType is set in vm.StorageProfile.DataDisks? Because the latter method appears to be read-only.

@Drewm3
Copy link
Member

Drewm3 commented Nov 4, 2021

Correct, you only need to set the storage account type in the VM create. No storageAccountClient.Create() is needed.

@Drewm3 Drewm3 closed this as completed Nov 4, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Compute - VM customer-reported Issues that are reported by GitHub users external to the Azure organization. Mgmt This issue is related to a management-plane library. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team.
Projects
None yet
Development

No branches or pull requests

6 participants