You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If we are keeping these flags enum, I believe we should keep the operators specific to the two enums, duplicating them, rather than "templatizing" them. That's what Storage did for their Flags enums, so there's precedence.
And rather than having all the extra bitwise operators (like XOR or NOT), we can simplify to only the 4 that's most likely to be needed by customers (OR/AND): &, &=, |, |=
Here are the set of enums that need to be updated:
enum class AccountSasPermissions
enum class AccountSasServices
enum class AccountSasResourceType
enum class TablesSasPermissions
This one is correct (although it doesn't seem to be used anywhere within QueryTables() - #6155):
Use this as an example, from Storage:
azure-sdk-for-cpp/sdk/storage/azure-storage-blobs/inc/azure/storage/blobs/rest_client.hpp
Lines 441 to 477 in c168d73
Flags enums should be suffixed with
Flags
:Change Request: Bitflag enums must be named with Flags suffix for C++ azure-sdk#2315
If we are keeping these flags enum, I believe we should keep the operators specific to the two enums, duplicating them, rather than "templatizing" them. That's what Storage did for their Flags enums, so there's precedence.
And rather than having all the extra bitwise operators (like XOR or NOT), we can simplify to only the 4 that's most likely to be needed by customers (OR/AND): &, &=, |, |=
Here are the set of enums that need to be updated:
This one is correct (although it doesn't seem to be used anywhere within
QueryTables()
- #6155):azure-sdk-for-cpp/sdk/tables/azure-data-tables/inc/azure/data/tables/account_sas_builder.hpp
Lines 89 to 128 in c168d73
cc @gearama, @LarryOsterman, @RickWinter
The text was updated successfully, but these errors were encountered: