Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[azure-core-tracing-opentelemetry] Adopt OpenTelemetry HTTP semconv 1.23.0 #5162

Open
Tracked by #4120
lmolkova opened this issue Nov 14, 2023 · 0 comments
Open
Tracked by #4120
Labels
Client This issue points to a problem in the data-plane of the library. OpenTelemetry OpenTelemetry instrumentation (not Monitor-specific)

Comments

@lmolkova
Copy link
Member

Update HTTP attributes to comply with HTTP semconv vTBD (likely 1.23.0 will declare them as stable):

  1. Rename attributes according to docs:
    • http.method -> http.request.method
    • http.status_code -> http.response.status_code
    • net.peer.name -> server.address
    • net.peer.port -> server.port
    • http.url -> url.full
    • http.user_agent -> remove
  2. Add new attributes:
    • error.type - some error-code or a full exception name if an exception happens. Also includes status code (as string) for responses we consider to be an error.
    • http.request.resend_count - try count
  3. Update HTTP span names according to the new conventions
  4. Check if there is anything else in the list of changes that needs attention
@lmolkova lmolkova added Client This issue points to a problem in the data-plane of the library. OpenTelemetry OpenTelemetry instrumentation (not Monitor-specific) labels Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. OpenTelemetry OpenTelemetry instrumentation (not Monitor-specific)
Projects
None yet
Development

No branches or pull requests

1 participant