Skip to content

Commit

Permalink
Change property name to ReleaseStatus
Browse files Browse the repository at this point in the history
  • Loading branch information
praveenkuttappan authored and azure-sdk committed Jun 24, 2021
1 parent 8fdba8a commit 7b735c5
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion eng/common/scripts/Create-APIReview.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ if ($packages)
# Ignore API review status for prerelease version
Write-Host "Package version is not GA. Ignoring API view approval status"
}
elseif (!$pkgInfo.ReleaseDate -or $pkgInfo.ReleaseDate -eq "Unreleased")
elseif (!$pkgInfo.ReleaseStatus -or $pkgInfo.ReleaseStatus -eq "Unreleased")
{
Write-Host "Release date is not set for current version in change log file for package. Ignoring API review approval status since package is not yet ready for release."
}
Expand Down
6 changes: 3 additions & 3 deletions eng/common/scripts/Package-Properties.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ class PackageProps
[string]$SdkType
[boolean]$IsNewSdk
[string]$ArtifactName
[string]$ReleaseDate
[string]$ReleaseStatus

PackageProps([string]$name, [string]$version, [string]$directoryPath, [string]$serviceDirectory)
{
Expand Down Expand Up @@ -51,9 +51,9 @@ class PackageProps
$this.ChangeLogPath = Join-Path $directoryPath "CHANGELOG.md"
# Get release date for current version and set in package property
$changeLogEntry = Get-ChangeLogEntry -ChangeLogLocation $this.ChangeLogPath -VersionString $this.Version
if ($changeLogEntry -and ![System.String]::IsNullOrEmpty($changeLogEntry.ReleaseStatus))
if ($changeLogEntry -and !$changeLogEntry.ReleaseStatus)
{
$this.ReleaseDate = $changeLogEntry.ReleaseStatus.Trim().Trim("()")
$this.ReleaseStatus = $changeLogEntry.ReleaseStatus.Trim().Trim("()")
}
}
else
Expand Down
2 changes: 1 addition & 1 deletion eng/common/scripts/Save-Package-Properties.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ if ($allPackageProperties)
Write-Host "Package Version: $($pkg.Version)"
Write-Host "Package SDK Type: $($pkg.SdkType)"
Write-Host "Artifact Name: $($pkg.ArtifactName)"
Write-Host "Release date: $($pkg.ReleaseDate)"
Write-Host "Release date: $($pkg.ReleaseStatus)"
$configFilePrefix = $pkg.Name
if ($pkg.ArtifactName)
{
Expand Down

0 comments on commit 7b735c5

Please sign in to comment.