Create a new version of API 2020-03-31 #8533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You don't have permission to trigger SDK Automation. |
|
|
|
Can one of the admins verify this patch? |
akning-ms
added
the
WaitForARMFeedback
|
Hi @gubalasu can you help fix 2 validation error in the check(Avocado & Prettier check)? |
ryansbenson
added
ARMSignedOff
I have fixed the 2 validation erros |
ravbhatnagar
approved these changes
Mar 6, 2020
nachakra
reviewed
Mar 9, 2020
nachakra
reviewed
Mar 9, 2020
specification/cdn/resource-manager/Microsoft.Cdn/stable/2020-03-31/cdn.json
Outdated
Show resolved
Hide resolved
nachakra
reviewed
Mar 9, 2020
| "SHA256" | ||
| ] | ||
| }, | ||
| "parameterNameOverride": { |
There was a problem hiding this comment.
I am getting confused looking at this. Is this really an override? These are paramters that define how url signing will work for that request. Please correct me if I am wrong.
There was a problem hiding this comment.
This is an override for the query parameter names. Essentially what we are trying to say is, we have three query parameters ("expires", "keyId", "signature"). We want to give the ability for the customers to change the name of these parameters so that we and the customer are on the same page.
For example,
<baseurl>?expires=<timestamp>&keyid=<somekeyid>&signature=<somesignature>
is the default set of query parameters the customer should use. We can allow the customer to change this to something like:
<baseurl>?expirationtimestamp=<timestamp>&hashingkeyid=<somekeyid>&signature=<somesignature>
if the customer chooses to do so.
We are not explicitly using the name query parameter name override here because in the future we might want to support Cookies or Headers for these values and we would have to come back and change the swagger at that time.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
azure-sdk-for-java - Release
|
azure-sdk-for-js - Release
|
azure-sdk-for-net - Release
|
azure-sdk-for-go - Release
|
azure-sdk-for-python - Release
|
This was referenced Mar 16, 2020
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
azure-cli-extensions - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
akning-ms
reviewed
Mar 19, 2020
...ion/cdn/resource-manager/Microsoft.Cdn/stable/2020-03-31/examples/CheckNameAvailability.json
Outdated
Show resolved
Hide resolved
akning-ms
reviewed
Mar 26, 2020
...cdn/resource-manager/Microsoft.Cdn/preview/2019-06-15-preview/cdnwebapplicationfirewall.json
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
00Kai0
pushed a commit
to 00Kai0/azure-rest-api-specs
that referenced
this pull request
Oct 12, 2020
* Create a new version based on version 2019-12-31 * Examples for the new version * Copied WAF features into the stable version * Update specs for Url Signing feature * Url signing feature updates * Fixing odata type * Adding latest changes from previous version * Update the preview version with the WAF changes * Fix api version in examples * Remove unnecessary value from enum * Remove unnecessary value from enum in previous version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.