Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ACR] Update policy schema with default values. #7006

Merged
merged 3 commits into from
Aug 23, 2019
Merged

[ACR] Update policy schema with default values. #7006

merged 3 commits into from
Aug 23, 2019

Conversation

ankurkhemani
Copy link
Contributor

@ankurkhemani ankurkhemani commented Aug 21, 2019 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 21, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from 287fcbf, Iteration 8)

In-Progress .NET: test-repo-billy/azure-sdk-for-net [Logs]
  • Package generation in progress.
In-Progress Python: test-repo-billy/azure-sdk-for-python [Logs]
  • Package generation in progress.
In-Progress Java: test-repo-billy/azure-sdk-for-java [Logs]
  • Package generation in progress.
In-Progress Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
  • In-Progress containerregistry/mgmt/2017-03-01 [Logs]
  • In-Progress containerregistry/mgmt/2017-10-01 [Logs]
  • In-Progress containerregistry/mgmt/2018-09-01 [Logs]
  • In-Progress containerregistry/mgmt/2019-04-01 [Logs]
  • In-Progress containerregistry/mgmt/2019-05-01-preview [Logs]
  • In-Progress containerregistry/mgmt/2019-05-01 [Logs]
  • In-Progress containerregistry/mgmt/2019-06-01-preview [Logs]
  • In-Progress preview/containerregistry/mgmt/2016-06-27-preview [Logs]
  • In-Progress preview/containerregistry/mgmt/2017-06-01-preview [Logs]
  • In-Progress preview/containerregistry/mgmt/2018-02-01 [Logs]
In-Progress JavaScript: test-repo-billy/azure-sdk-for-js [Logs]
  • Package generation in progress.
Warning Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]
  • No packages generated.

@azuresdkci azuresdkci requested a review from yungezz August 21, 2019 00:01
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI AutorestCI mentioned this pull request Aug 21, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Aug 21, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#6915

@AutorestCI AutorestCI mentioned this pull request Aug 21, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Aug 21, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5602

@ankurkhemani ankurkhemani force-pushed the ankheman/retention-policy-schema branch from 1afeec1 to db88103 Compare August 21, 2019 00:16
@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Aug 21, 2019
Merged
@yungezz yungezz added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 21, 2019
@ankurkhemani ankurkhemani changed the title [ACR] Update retention policy schema [ACR] Update policy schema with default values. Aug 21, 2019
@ankurkhemani
Copy link
Contributor Author

ankurkhemani commented Aug 21, 2019 •
edited
Loading

@nschonni @yungezz Ready to merge. Thanks!

@yungezz yungezz merged commit 6eb8551 into Azure:master Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nschonni nschonni nschonni left review comments

@yungezz yungezz yungezz approved these changes

Assignees

@yungezz yungezz

Labels
WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ankurkhemani @azuresdkci @AutorestCI @nschonni @yungezz