Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Data Factory] Refactor table option #6970

Merged
merged 2 commits into from
Aug 16, 2019
Merged

[Data Factory] Refactor table option #6970

merged 2 commits into from
Aug 16, 2019

Conversation

qingyhe
Copy link
Contributor

@qingyhe qingyhe commented Aug 15, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 15, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from 3c745e4, Iteration 3)

In-Progress .NET: test-repo-billy/azure-sdk-for-net [Logs]
  • Package generation in progress.
In-Progress Python: test-repo-billy/azure-sdk-for-python [Logs]
  • Package generation in progress.
In-Progress Java: test-repo-billy/azure-sdk-for-java [Logs]
  • Package generation in progress.
In-Progress Go: test-repo-billy/azure-sdk-for-go [Logs]
  • Package generation in progress.
In-Progress JavaScript: test-repo-billy/azure-sdk-for-js [Logs]
  • Package generation in progress.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@azuresdkci azuresdkci requested a review from yaohaizh August 15, 2019 10:18
@AutorestCI AutorestCI mentioned this pull request Aug 15, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Aug 15, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#6814

@AutorestCI AutorestCI mentioned this pull request Aug 15, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Aug 15, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5544

This was referenced Aug 15, 2019
Closed
Closed
@qingyhe qingyhe changed the title Qingyhe/refactor table option [Data Factory] Refactor table option Aug 15, 2019
@yaohaizh yaohaizh added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 16, 2019
@yaohaizh
Copy link
Contributor

#6819

@yaohaizh yaohaizh removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 16, 2019
@PhoenixHe-NV PhoenixHe-NV mentioned this pull request Aug 16, 2019
Closed
@yaohaizh yaohaizh closed this Aug 16, 2019
@yaohaizh yaohaizh reopened this Aug 16, 2019
This was referenced Aug 16, 2019
Closed
Merged
@yungezz yungezz merged commit 23326b9 into Azure:master Aug 16, 2019
@yaohaizh
Copy link
Contributor

yaohaizh commented Aug 16, 2019 •
edited
Loading

According to the agreement between the service team and the PR review board, this PR doesn't need APR board review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaohaizh yaohaizh yaohaizh approved these changes

@nicolaszhang nicolaszhang nicolaszhang approved these changes

Assignees

@yaohaizh yaohaizh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@qingyhe @azuresdkci @AutorestCI @yaohaizh @nicolaszhang @yungezz