Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hub Generated] Review request for Microsoft.Portal to add version preview/2018-10-01-preview #6825

Merged
merged 4 commits into from
Aug 5, 2019
Merged

[Hub Generated] Review request for Microsoft.Portal to add version preview/2018-10-01-preview #6825

merged 4 commits into from
Aug 5, 2019

Conversation

jjbfour
Copy link
Contributor

@jjbfour jjbfour commented Jul 31, 2019 •
edited
Loading

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 31, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from 611a94a, Iteration 4)

Warning Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
  • No packages generated.
Failed Java: test-repo-billy/azure-sdk-for-java [Logs]
  • No packages generated.
Warning Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Warning JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]
  • No packages generated.
Failed Ruby: test-repo-billy/azure-sdk-for-ruby [Logs]
  • No packages generated.

@azuresdkci azuresdkci requested a review from praries880 July 31, 2019 20:28
@AutorestCI AutorestCI mentioned this pull request Jul 31, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jul 31, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5670

@AutorestCI
Copy link

AutorestCI commented Jul 31, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5439

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@praries880 praries880 added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 31, 2019
@AutorestCI AutorestCI mentioned this pull request Aug 5, 2019
Merged
@anthony-c-martin anthony-c-martin added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 5, 2019
anthony-c-martin
anthony-c-martin approved these changes Aug 5, 2019
View reviewed changes
Copy link
Member

@anthony-c-martin anthony-c-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@praries880 praries880 merged commit 651efd1 into Azure:master Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthony-c-martin anthony-c-martin anthony-c-martin approved these changes

@praries880 praries880 praries880 approved these changes

Assignees

@praries880 praries880

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jjbfour @AutorestCI @azuresdkci @praries880 @anthony-c-martin