RosettaNet Process configuration apis #6702

praveensri · 2019-07-23T01:42:01Z

Integration account - RosettaNet CRUD APIs
Integration account- agreement changes for RosettaNet agreement type.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

Integration account - RosettaNet CRUD APIs Integration account- agreement changes for RosettaNet agreement type.

openapi-sdkautomation · 2019-07-23T01:42:05Z

SDK Automation [Logs] (Generated from 2838c11, Iteration 24)

Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]

azure-mgmt-logic [Logs] [Instructions] [Generation PR]
- azure-mgmt-logic-4.0.0rc2.zip
- azure_mgmt_logic-4.0.0rc2-py2.py3-none-any.whl

Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]

logic/resource-manager/v2016_06_01 [Logs]
logic/resource-manager/v2018_07_01_preview [Logs]

Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]

logic/mgmt/2016-06-01 [Logs] [Instructions] [Generation PR]
- logic.mgmt.2016-06-01.zip
preview/logic/mgmt/2015-02-01-preview [Logs]
preview/logic/mgmt/2015-08-01-preview [Logs]
preview/logic/mgmt/2018-07-01-preview [Logs]

JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]

@azure/arm-logic [Logs]

Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]

No packages generated.

msftclas · 2019-07-23T01:42:25Z

All CLA requirements met.

AutorestCI · 2019-07-23T01:43:24Z

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#6627

AutorestCI · 2019-07-23T01:43:35Z

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#5416

azuresdkci · 2019-07-23T02:23:06Z

Can one of the admins verify this patch?

mmyyrroonn · 2019-07-23T03:03:41Z

@praveensri Add ARM Review. Meanwhile, please solve the CI errors.

Fixed casing as required by CI

praveensri

Fixed the casing

praveensri · 2019-07-24T22:33:35Z

Hi,
Some of the failures under following CI run are not related with my changes.

public.rest-api-specs Failing after 1m — Build #Azure OpenAPI failed

e.g 👍

error :
	operationId: ListOperations
	scenario: List Microsoft.Logic operations
	source: response
	responseCode: '200'
	severity: 0
	code: RESPONSE_BODY_NOT_IN_EXAMPLE
	details:
	code: RESPONSE_BODY_NOT_IN_EXAMPLE
	id: OAV130
	message: >-
	Response statusCode "200" for operation "ListOperations" has no response
	body provided in the example, however the response does have a "schema"
	defined in the swagger spec.
	position:
	line: 5333
	column: 14
	url: >-
	specification/logic/resource-manager/Microsoft.Logic/stable/2016-06-01/logic.json
	title: '#/paths/~~1providers~~1Microsoft.Logic~1operations/get'
	directives:
	R3016: .*
	level: error

Thanks,
Praveen

praveensri · 2019-07-24T22:35:30Z

Please review

mmyyrroonn · 2019-07-29T02:12:17Z

@raych1 I checked the error messages. They are exited errors. Based on my understanding, the error messages should be suppressed.

mmyyrroonn · 2019-07-29T02:46:02Z

@praveensri Hello. I talked with @raych1 offline. Recently, several new checks are enabled in ModelValidation. So you and your team need to fix these errors.

…into AzureLogic-rosettanet-apis

majastrz · 2019-07-31T00:26:34Z

specification/logic/resource-manager/Microsoft.Logic/stable/2016-06-01/logic.json

@@ -4921,6 +4921,232 @@
        "x-ms-odata": "#/definitions/IntegrationAccountSessionFilter"
      }
    },
+    "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Logic/integrationAccounts/{integrationAccountName}/rosettanetprocessconfigurations": {


rosettanetprocessconfigurations [](start = 143, length = 31)

nit - The resource type should be camelCased for readability and to match existing convention.

specification/logic/resource-manager/Microsoft.Logic/stable/2016-06-01/logic.json

majastrz

You're adding an enum value to an enum that is not modeled as string in a stable API version. This is considered a breaking change because an existing client will not be able to deserialize a GET response. You need to introduce a new API version for this.

majastrz

Looks good to me.

nschonni · 2019-07-31T05:38:11Z

The spellcheck with pass if the words are camelCased, or if you add them to https://github.com/Azure/azure-rest-api-specs/blob/master/custom-words.txt if they can't be

praveensri

The spellcheck with pass if the words are camelCased, or if you add them to https://github.com/Azure/azure-rest-api-specs/blob/master/custom-words.txt if they can't be

Created PR #6815 to update the words under https://github.com/Azure/azure-rest-api-specs/blob/master/custom-words.txt

specification/logic/resource-manager/Microsoft.Logic/stable/2016-06-01/logic.json

nschonni · 2019-07-31T06:07:33Z

OK, might be better to just include that in this PR

praveensri · 2019-07-31T06:22:10Z

OK, might be better to just include that in this PR

Yep, added in this PR

praveensri · 2019-07-31T16:57:56Z

by mistake I clicked re-review icon for @majastrz, Please ignore

majastrz

Resigned off :)

praveensri · 2019-07-31T22:55:01Z

Resigned off :)

Thanks majastrz, Any updates on merging?

mmyyrroonn · 2019-08-01T02:10:26Z

@OpenAPIBot sdkautomation rebuild

mmyyrroonn · 2019-08-01T02:15:24Z

@NullMDR Could you please check the SDK Automation process?

mmyyrroonn · 2019-08-01T02:52:21Z

@yaohaizh @michaeljqzq Hello. Please check this PR to make sure it will not influence the SDK.

michaeljqzq · 2019-08-01T05:46:42Z

Wait for @NullMDR for the issue fix

michaeljqzq · 2019-08-02T07:00:10Z

@myronfanqiu LGTM for js sdk part

RosettaNet Process configuration apis

c650305

Integration account - RosettaNet CRUD APIs Integration account- agreement changes for RosettaNet agreement type.

azuresdkci assigned mmyyrroonn Jul 23, 2019

azuresdkci requested a review from mmyyrroonn July 23, 2019 01:54

updated examples path

eaa9b18

mmyyrroonn added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 23, 2019

fixes CI errors

68568e9

Fixed casing as required by CI

praveensri commented Jul 24, 2019

View reviewed changes

ModelValidation fixes

3989550

SrivastavaPraveen added 9 commits July 29, 2019 15:39

merge conflicts

3cd428e

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs …

4f9ff73

…into AzureLogic-rosettanet-apis

merge conflicts resoultion

f2b26ab

CI fixes

8b94f52

Additional model validation fixes

74d5ef8

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs …

6ae032d

…into AzureLogic-rosettanet-apis

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs …

3c9e174

…into AzureLogic-rosettanet-apis

test fixes

92c8d59

operation test fix

9107ad8

majastrz reviewed Jul 31, 2019

View reviewed changes

specification/logic/resource-manager/Microsoft.Logic/stable/2016-06-01/logic.json Show resolved Hide resolved

majastrz reviewed Jul 31, 2019

View reviewed changes

specification/logic/resource-manager/Microsoft.Logic/stable/2016-06-01/logic.json Outdated Show resolved Hide resolved

majastrz added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jul 31, 2019

majastrz requested changes Jul 31, 2019

View reviewed changes

SrivastavaPraveen added 2 commits July 30, 2019 18:19

removed breaking changes

b2fdc88

pr feedback

901423e

majastrz approved these changes Jul 31, 2019

View reviewed changes

praveensri commented Jul 31, 2019

View reviewed changes

specification/logic/resource-manager/Microsoft.Logic/stable/2016-06-01/logic.json Outdated Show resolved Hide resolved

added custom words for spell check

22562b1

praveensri requested a review from majastrz July 31, 2019 16:56

majastrz approved these changes Jul 31, 2019

View reviewed changes

Merge branch 'master' into AzureLogic-rosettanet-apis

2838c11

mmyyrroonn merged commit f0ba9ec into master Aug 2, 2019

This was referenced Aug 2, 2019

[AutoPR logic/resource-manager] RosettaNet Process configuration apis Azure/azure-sdk-for-python#6627

Closed

[AutoPR logic/resource-manager] RosettaNet Process configuration apis Azure/azure-sdk-for-go#5416

Merged

JackTn deleted the AzureLogic-rosettanet-apis branch August 9, 2021 09:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RosettaNet Process configuration apis #6702

RosettaNet Process configuration apis #6702

praveensri commented Jul 23, 2019 •

edited

Loading

openapi-sdkautomation bot commented Jul 23, 2019 •

edited

Loading

msftclas commented Jul 23, 2019 •

edited

Loading

AutorestCI commented Jul 23, 2019 •

edited

Loading

AutorestCI commented Jul 23, 2019 •

edited

Loading

azuresdkci commented Jul 23, 2019

mmyyrroonn commented Jul 23, 2019

praveensri left a comment

praveensri commented Jul 24, 2019

praveensri commented Jul 24, 2019

mmyyrroonn commented Jul 29, 2019

mmyyrroonn commented Jul 29, 2019

majastrz Jul 31, 2019

majastrz left a comment

majastrz left a comment

nschonni commented Jul 31, 2019 •

edited

Loading

praveensri left a comment

nschonni commented Jul 31, 2019

praveensri commented Jul 31, 2019

praveensri commented Jul 31, 2019

majastrz left a comment

praveensri commented Jul 31, 2019

mmyyrroonn commented Aug 1, 2019

mmyyrroonn commented Aug 1, 2019

mmyyrroonn commented Aug 1, 2019

michaeljqzq commented Aug 1, 2019

michaeljqzq commented Aug 2, 2019

RosettaNet Process configuration apis #6702

RosettaNet Process configuration apis #6702

Conversation

praveensri commented Jul 23, 2019 • edited Loading

Latest improvements:

Contribution checklist:

ARM API Review Checklist

openapi-sdkautomation bot commented Jul 23, 2019 • edited Loading

SDK Automation [Logs] (Generated from 2838c11, Iteration 24)

msftclas commented Jul 23, 2019 • edited Loading

AutorestCI commented Jul 23, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Jul 23, 2019 • edited Loading

Automation for azure-sdk-for-go

azuresdkci commented Jul 23, 2019

mmyyrroonn commented Jul 23, 2019

praveensri left a comment

Choose a reason for hiding this comment

praveensri commented Jul 24, 2019

praveensri commented Jul 24, 2019

mmyyrroonn commented Jul 29, 2019

mmyyrroonn commented Jul 29, 2019

majastrz Jul 31, 2019

Choose a reason for hiding this comment

majastrz left a comment

Choose a reason for hiding this comment

majastrz left a comment

Choose a reason for hiding this comment

nschonni commented Jul 31, 2019 • edited Loading

praveensri left a comment

Choose a reason for hiding this comment

nschonni commented Jul 31, 2019

praveensri commented Jul 31, 2019

praveensri commented Jul 31, 2019

majastrz left a comment

Choose a reason for hiding this comment

praveensri commented Jul 31, 2019

mmyyrroonn commented Aug 1, 2019

mmyyrroonn commented Aug 1, 2019

mmyyrroonn commented Aug 1, 2019

michaeljqzq commented Aug 1, 2019

michaeljqzq commented Aug 2, 2019

praveensri commented Jul 23, 2019 •

edited

Loading

openapi-sdkautomation bot commented Jul 23, 2019 •

edited

Loading

msftclas commented Jul 23, 2019 •

edited

Loading

AutorestCI commented Jul 23, 2019 •

edited

Loading

AutorestCI commented Jul 23, 2019 •

edited

Loading

nschonni commented Jul 31, 2019 •

edited

Loading