-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding new resource type for alerts meta data #6459
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
54b18e0
Alerts meta data api
ShivGhatbale 8bea075
Added example for alerts meta data resource type
ShivGhatbale 23c247a
Added identifier parameter to examples/AlertsMetaData_MonitorService.…
ShivGhatbale 92dba59
Fix value of identifier parameter in examples/AlertsMetaData_MonitorS…
ShivGhatbale 03b411b
Fix value of identifier parameter in examples/AlertsMetaData_MonitorS…
ShivGhatbale aae2b1f
Added one more enum value for identifier enum
ShivGhatbale 2c41550
Added remove added extra enum value for identifier enum
ShivGhatbale 8c6477f
Added enum for identifier in definitions
ShivGhatbale b687abd
Rename identifier in definitions to metadataIdentifier
ShivGhatbale a24ef5c
Added enum for metadataIdentifier in definitions
ShivGhatbale ad474c8
Added enum for metadataIdentifier in definitions
ShivGhatbale 955962b
Update test title in AlertsManagement.json
ShivGhatbale eef581e
Schematic changes
ShivGhatbale f03e82f
Added defination for monitor service
ShivGhatbale 8b99a2e
Added defination for monitor service
ShivGhatbale f34e808
Added defination for monitor service
ShivGhatbale 72f9866
Use discriminator for data of alerts meta properties
ShivGhatbale 7072efc
Fix error
ShivGhatbale 748917a
Fix error
ShivGhatbale File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
89 changes: 89 additions & 0 deletions
89
...t.AlertsManagement/preview/2019-05-05-preview/examples/AlertsMetaData_MonitorService.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,89 @@ | ||
| { | ||
| "parameters": { | ||
| "api-version": "2019-05-05-preview", | ||
| "identifier": "MonitorServiceList" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "properties": { | ||
| "metadataIdentifier": "MonitorServiceList", | ||
| "data": [ | ||
| { | ||
| "name": "ActivityLog Administrative", | ||
| "displayName": "Activity Log - Administrative" | ||
| }, | ||
| { | ||
| "name": "ActivityLog Autoscale", | ||
| "displayName": "Activity Log - Autoscale" | ||
| }, | ||
| { | ||
| "name": "ActivityLog Policy", | ||
| "displayName": "Activity Log - Policy" | ||
| }, | ||
| { | ||
| "name": "ActivityLog Recommendation", | ||
| "displayName": "Activity Log - Recommendation" | ||
| }, | ||
| { | ||
| "name": "ActivityLog Security", | ||
| "displayName": "Activity Log - Security" | ||
| }, | ||
| { | ||
| "name": "Application Insights", | ||
| "displayName": "Application Insights" | ||
| }, | ||
| { | ||
| "name": "Azure Backup", | ||
| "displayName": "Azure Backup" | ||
| }, | ||
| { | ||
| "name": "Custom", | ||
| "displayName": "Custom" | ||
| }, | ||
| { | ||
| "name": "Data Box Edge", | ||
| "displayName": "Data Box Edge" | ||
| }, | ||
| { | ||
| "name": "VM Insights", | ||
| "displayName": "VM Insights" | ||
| }, | ||
| { | ||
| "name": "Log Analytics", | ||
| "displayName": "Log Analytics" | ||
| }, | ||
| { | ||
| "name": "Nagios", | ||
| "displayName": "NAGIOS" | ||
| }, | ||
| { | ||
| "name": "Platform", | ||
| "displayName": "Platform" | ||
| }, | ||
| { | ||
| "name": "Resource Health", | ||
| "displayName": "Resource Health" | ||
| }, | ||
| { | ||
| "name": "SCOM", | ||
| "displayName": "SCOM" | ||
| }, | ||
| { | ||
| "name": "ServiceHealth", | ||
| "displayName": "Service Health" | ||
| }, | ||
| { | ||
| "name": "Smart Detector", | ||
| "displayName": "SmartDetector" | ||
| }, | ||
| { | ||
| "name": "Zabbix", | ||
| "displayName": "ZABBIX" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alertsMetadata is very generic name for this operation. Can you make it more specific. Like monitorProviders. What other things will you add to this meta data? If its not going to be lot of new things, may be you can have specific APIs to surface that information instead of clubbing it all in this API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We wanted a generic name only. Since we want to use this resource type for utility APIs. I mean we're going to return some or other meta data info with this resource type API based on identifier passed in API param