Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding new resource type for alerts meta data #6459

Merged
merged 19 commits into from
Jul 9, 2019
Merged

Adding new resource type for alerts meta data #6459

merged 19 commits into from
Jul 9, 2019

Conversation

ShivGhatbale
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 26, 2019 •
edited
Loading

SDK Automation [Logs] (Generated from 748917a)

Pending Python: Azure/azure-sdk-for-python
  • Package generation pending.
Pending Go: Azure/azure-sdk-for-go
  • Package generation pending.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@azuresdkci azuresdkci requested a review from tjprescott June 26, 2019 14:08
@AutorestCI
Copy link

AutorestCI commented Jun 26, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Jun 26, 2019 •
edited
Loading

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link

AutorestCI commented Jun 26, 2019 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI AutorestCI mentioned this pull request Jun 26, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jun 26, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5200

@tjprescott tjprescott added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 26, 2019
tjprescott
tjprescott requested changes Jun 28, 2019
View reviewed changes
Copy link
Member

@tjprescott tjprescott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for ARM feedback.

ravbhatnagar
ravbhatnagar reviewed Jul 1, 2019
View reviewed changes
...resource-manager/Microsoft.AlertsManagement/preview/2019-05-05-preview/AlertsManagement.json Outdated
}
}
},
"alertsMetaDataValue": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we have strongly typed schema for this? from example it looks like when type is monitor service, the properties are name and displayName. You can have different schema when you introduce new type. it will make it more usable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ravbhatnagar how to achieve this strongly typed schema? by using discriminator?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

...resource-manager/Microsoft.AlertsManagement/preview/2019-05-05-preview/AlertsManagement.json
@@ -52,6 +52,36 @@
}
}
},
"/providers/Microsoft.AlertsManagement/alertsMetaData": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alertsMetadata is very generic name for this operation. Can you make it more specific. Like monitorProviders. What other things will you add to this meta data? If its not going to be lot of new things, may be you can have specific APIs to surface that information instead of clubbing it all in this API.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We wanted a generic name only. Since we want to use this resource type for utility APIs. I mean we're going to return some or other meta data info with this resource type API based on identifier passed in API param

@ravbhatnagar ravbhatnagar added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jul 1, 2019
@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jul 8, 2019
@ShivGhatbale
Copy link
Contributor Author

@tjprescott Can you please sign off & merge the PR as ARM team has signed off the changes

@tjprescott tjprescott merged commit a55e3b3 into Azure:master Jul 9, 2019
celikcigdem pushed a commit to celikcigdem/azure-rest-api-specs that referenced this pull request Jul 17, 2019
@ShivGhatbale @celikcigdem
Adding new resource type for alerts meta data (Azure#6459)
54f111d 
* Alerts meta data api

* Added example for alerts meta data resource type

* Added identifier parameter to examples/AlertsMetaData_MonitorService.json file

* Fix value of identifier parameter in examples/AlertsMetaData_MonitorService.json file

* Fix value of identifier parameter in examples/AlertsMetaData_MonitorService.json file

* Added one more enum value for identifier enum

* Added remove added extra enum value for identifier enum

* Added enum for identifier in definitions

* Rename identifier in definitions to metadataIdentifier

* Added enum for metadataIdentifier in definitions

* Added enum for metadataIdentifier in definitions

* Update test title in AlertsManagement.json

* Schematic changes

* Added defination for monitor service

* Added defination for monitor service

* Added defination for monitor service

* Use discriminator for data of alerts meta properties

* Fix error

* Fix error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravbhatnagar ravbhatnagar ravbhatnagar left review comments

@tjprescott tjprescott tjprescott approved these changes

Assignees

@tjprescott tjprescott

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ShivGhatbale @azuresdkci @AutorestCI @ravbhatnagar @tjprescott