Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ready To Merge] SSH and Quota changes #6432

Merged
merged 9 commits into from
Aug 23, 2019
Merged

[Ready To Merge] SSH and Quota changes #6432

merged 9 commits into from
Aug 23, 2019

Conversation

akshataP
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

akshataP and others added 3 commits May 31, 2019 17:23
@akshataP
Merge pull request #1 from Azure/master
b0957b1 
Update to latest Azure rest api specs
@akshataP
Merge pull request #2 from Azure/master
eeb58f2 
Update to latest  Azure-rest-api spcs
Version change
b779d41
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 24, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from a9e6716, Iteration 7)

Warning .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
  • No packages generated.
Failed Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Succeeded Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
Failed JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]

@AutorestCI
Copy link

AutorestCI commented Jun 24, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI AutorestCI mentioned this pull request Jun 24, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Jun 24, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#6892

@AutorestCI
Copy link

AutorestCI commented Jun 24, 2019 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@azuresdkci azuresdkci requested a review from yaohaizh June 24, 2019 20:25
@AutorestCI AutorestCI mentioned this pull request Jun 24, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Jun 24, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5601

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@akshataP
Copy link
Contributor Author

@yaohaizh Can you please add WaitDorAMLFeedback tag?

@akshataP
Copy link
Contributor Author

akshataP commented Jun 25, 2019 •
edited
Loading

Version change : commit b779d41
Properties added: commit 1e3cc93

Version change does not have any property related changes
Please review the Properties changes commit for the new properties added

@ravbhatnagar ravbhatnagar added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 25, 2019
@ravbhatnagar
Copy link
Contributor

ravbhatnagar commented Jun 25, 2019 •
edited
Loading

As per commit id provided by @akshataP (8f0af71) few read only properties have been added in this PR. looks fine. Signing off from ARM side.

@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 25, 2019
@amarzavery amarzavery changed the title {Do Not Merge] SSH and Quota changes [Do Not Merge] SSH and Quota changes Jun 25, 2019
@jhendrixMSFT jhendrixMSFT mentioned this pull request Jun 25, 2019
Closed
@jhendrixMSFT
Copy link
Member

Opened Azure/oav#433 to track the OAV failure. Since model validation is passing please ignore the OAV failure.

This was referenced Jun 25, 2019
Closed
Closed
@yaohaizh
Copy link
Contributor

@akshataP when this PR ready for merge?

This was referenced Aug 21, 2019
Merged
Merged
@akshataP akshataP changed the title [Do Not Merge] SSH and Quota changes [Ready To Merge] SSH and Quota changes Aug 22, 2019
@akshataP
Copy link
Contributor Author

@yaohaizh please merge the PR

@yaohaizh yaohaizh merged commit d3bc9fd into Azure:master Aug 23, 2019
@akshataP akshataP mentioned this pull request Sep 18, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaohaizh yaohaizh yaohaizh approved these changes

Assignees

@yaohaizh yaohaizh

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@akshataP @AutorestCI @azuresdkci @ravbhatnagar @jhendrixMSFT @yaohaizh