Improve documentation for App Insights/Log Analytics purge #5851

alexeldeib · 2019-05-03T00:37:05Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

AutorestCI · 2019-05-03T00:37:42Z

Automation for azure-sdk-for-ruby

A PR has been created for you:
Azure/azure-sdk-for-ruby#2440

AutorestCI · 2019-05-03T00:38:01Z

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#5777

AutorestCI · 2019-05-03T00:38:08Z

Automation for azure-sdk-for-js

A PR has been created for you:
Azure/azure-sdk-for-js#3621

AutorestCI · 2019-05-03T00:39:43Z

Automation for azure-sdk-for-java

Encountered a Subprocess error: (azure-sdk-for-java)

Command: ['/usr/local/bin/autorest', '/tmp/tmpx084f4u7/rest/specification/applicationinsights/resource-manager/readme.md', '--perform-load=false', '--swagger-to-sdk', '--output-artifact=configuration.json', '--input-file=foo', '--output-folder=/tmp/tmpk5aeehjy']
Finished with return code 7
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Failure:
Error: Unable to start AutoRest Core from /root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core
Error: Unable to start AutoRest Core from /root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core
    at main (/opt/node_modules/autorest/dist/app.js:232:19)
    at <anonymous>

/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist/app.js:33
    autorest_core_1.Shutdown();
    ^
ReferenceError: autorest_core_1 is not defined
    at process.on (/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist/app.js:33:5)
    at emitOne (events.js:121:20)
    at process.emit (events.js:211:7)
    at process.emit (/node_modules/source-map-support/source-map-support.js:439:21)
fs.js:612
  return binding.close(fd);
                 ^

Error: EBADF: bad file descriptor, close
    at Object.fs.closeSync (fs.js:612:18)
    at StaticVolumeFile.shutdown (/opt/node_modules/autorest/dist/static-loader.js:352:10)
    at StaticFilesystem.shutdown (/opt/node_modules/autorest/dist/static-loader.js:406:17)
    at process.exit.n [as exit] (/opt/node_modules/autorest/dist/static-loader.js:169:11)
    at printErrorAndExit (/node_modules/source-map-support/source-map-support.js:423:11)
    at process.emit (/node_modules/source-map-support/source-map-support.js:435:16)
    at process._fatalException (bootstrap_node.js:391:26)

AutorestCI · 2019-05-03T00:39:53Z

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#4742

azuresdkci · 2019-05-03T00:58:29Z

Can one of the admins verify this patch?

...pplicationinsights/resource-manager/Microsoft.Insights/stable/2015-05-01/components_API.json

...ts/resource-manager/Microsoft.OperationalInsights/stable/2015-03-20/OperationalInsights.json

nschonni

behaviour -> behavior
The original spelling is correct for me, but I think the docs are generally US spelling

…perationalInsights/stable/2015-03-20/OperationalInsights.json Co-Authored-By: alexeldeib <[email protected]>

…nsights/stable/2015-05-01/components_API.json Co-Authored-By: alexeldeib <[email protected]>

shahabhijeet

While you are at it, can you also fix the model validation failures. I understand those failures are not related to your changes, but take this opportunity to fix the examples.

Add required parameter 'savedSearchId' in the example 'WorkspacesDeleteSavedSearches'
Add required parameter 'savedSearchId' in the example 'WorkspacesSavedSearchesCreateOrUpdate'
There are additional similar errors take a look at
https://dev.azure.com/azure-sdk/public/_build/results?buildId=25819

…into ace/docs

…pi-specs into ace/docs

alexeldeib · 2019-05-06T22:20:10Z

Sure, these look simple enough to fix. cc @yoramsinger as FYI since I'm touching saved search (I think this is you Yoram?).

yoramsinger · 2019-05-07T09:23:39Z

Look fine.

alexeldeib · 2019-05-07T18:55:10Z

Yeah, ended up being very simple. @shahabhijeet let me know if there's anything else

alexeldeib · 2019-05-22T20:57:40Z

@shahabhijeet I noticed this hasn't merged, seems like a bug in the .NET test pipeline handling multiple RPs?

Successfully fetched all files modified in the REST spec PR. Calculating the resource provider name.
15:55:57      1>c:\Jenkins\workspace\DotNetSwaggerToSdkCI\scripts\stostools\SToS.proj(17,9): error : Exception: Cannot handle multiple RPs: applicationinsights/resource-manager, operationalinsights/resource-manager

alexeldeib · 2019-06-05T07:27:15Z

@nschonni @shahabhijeet any update here? Circling back because I checked the docs and realized the PR still hadn't merged.. Our team receives customer questions on the allowed operators in this doc fairly regularly, would love to get this change merged.

nschonni · 2019-06-05T14:26:02Z

Sorry, I'm not an MS employee. There is an internal link in the PR template that might have steps/contacts for getting something pushed forward, but I can't see whet it says 😄

alexeldeib · 2019-06-05T14:58:42Z

Sorry @nschonni! I assumed we simply hadn't crossed paths yet 😄

@lmazuel @sarangan12 could one of you please take a look at the above error?

openapi-sdkautomation · 2019-06-10T18:50:15Z

SDK Automation [Logs] (Generated from 625784c)

Python: Azure/azure-sdk-for-python

Package generation pending.

Java: Azure/azure-sdk-for-java

Package generation pending.

Go: Azure/azure-sdk-for-go

Package generation pending.

JavaScript: Azure/azure-sdk-for-js

Package generation pending.

Ruby: Azure/azure-sdk-for-ruby

Package generation pending.

task: improve documentation for purge

8326dde

AutorestCI mentioned this pull request May 3, 2019

[AutoPR applicationinsights/resource-manager] Improve documentation for App Insights purge Azure/azure-sdk-for-python#5062

Closed

AutorestCI mentioned this pull request May 3, 2019

[AutoPR applicationinsights/resource-manager] Improve documentation for App Insights purge Azure/azure-sdk-for-js#2684

Closed

AutorestCI mentioned this pull request May 3, 2019

[AutoPR applicationinsights/resource-manager] Improve documentation for App Insights purge Azure/azure-sdk-for-java#3518

Closed

AutorestCI mentioned this pull request May 3, 2019

[AutoPR applicationinsights/resource-manager] Improve documentation for App Insights purge Azure/azure-sdk-for-go#4741

Closed

fix: add Log Analytics purge description

d7c5b44

alexeldeib changed the title ~~Improve documentation for App Insights purge~~ Improve documentation for App Insights/Log Analytics purge May 3, 2019

azuresdkci assigned shahabhijeet May 3, 2019

azuresdkci requested a review from shahabhijeet May 3, 2019 00:49

nschonni reviewed May 3, 2019

View reviewed changes

...pplicationinsights/resource-manager/Microsoft.Insights/stable/2015-05-01/components_API.json Outdated Show resolved Hide resolved

nschonni reviewed May 3, 2019

View reviewed changes

...ts/resource-manager/Microsoft.OperationalInsights/stable/2015-03-20/OperationalInsights.json Outdated Show resolved Hide resolved

nschonni reviewed May 3, 2019

View reviewed changes

nschonni and others added 2 commits May 2, 2019 22:27

Update specification/operationalinsights/resource-manager/Microsoft.O…

a2be6f6

…perationalInsights/stable/2015-03-20/OperationalInsights.json Co-Authored-By: alexeldeib <[email protected]>

Update specification/applicationinsights/resource-manager/Microsoft.I…

03fe2bf

…nsights/stable/2015-05-01/components_API.json Co-Authored-By: alexeldeib <[email protected]>

shahabhijeet requested changes May 4, 2019

View reviewed changes

alexeldeib added 3 commits May 6, 2019 15:07

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs …

1b68609

…into ace/docs

Merge branch 'ace/docs' of https://github.com/alexeldeib/azure-rest-a…

35da887

…pi-specs into ace/docs

fix: example CI and whitespace

625784c

shahabhijeet approved these changes May 15, 2019

View reviewed changes

shahabhijeet merged commit a9b42c0 into Azure:master Jun 10, 2019

mccleanp pushed a commit that referenced this pull request Mar 23, 2022

Update resource move and validate resource move (#5851)

1dd6fa0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve documentation for App Insights/Log Analytics purge #5851

Improve documentation for App Insights/Log Analytics purge #5851

alexeldeib commented May 3, 2019 •

edited

Loading

AutorestCI commented May 3, 2019 •

edited

Loading

AutorestCI commented May 3, 2019 •

edited

Loading

AutorestCI commented May 3, 2019 •

edited

Loading

AutorestCI commented May 3, 2019 •

edited

Loading

AutorestCI commented May 3, 2019 •

edited

Loading

azuresdkci commented May 3, 2019

nschonni left a comment

shahabhijeet left a comment

alexeldeib commented May 6, 2019

yoramsinger commented May 7, 2019

alexeldeib commented May 7, 2019

alexeldeib commented May 22, 2019

alexeldeib commented Jun 5, 2019

nschonni commented Jun 5, 2019

alexeldeib commented Jun 5, 2019

openapi-sdkautomation bot commented Jun 10, 2019 •

edited

Loading

Improve documentation for App Insights/Log Analytics purge #5851

Improve documentation for App Insights/Log Analytics purge #5851

Conversation

alexeldeib commented May 3, 2019 • edited Loading

Latest improvements:

Contribution checklist:

ARM API Review Checklist

AutorestCI commented May 3, 2019 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented May 3, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented May 3, 2019 • edited Loading

Automation for azure-sdk-for-js

AutorestCI commented May 3, 2019 • edited Loading

Automation for azure-sdk-for-java

AutorestCI commented May 3, 2019 • edited Loading

Automation for azure-sdk-for-go

azuresdkci commented May 3, 2019

nschonni left a comment

Choose a reason for hiding this comment

shahabhijeet left a comment

Choose a reason for hiding this comment

alexeldeib commented May 6, 2019

yoramsinger commented May 7, 2019

alexeldeib commented May 7, 2019

alexeldeib commented May 22, 2019

alexeldeib commented Jun 5, 2019

nschonni commented Jun 5, 2019

alexeldeib commented Jun 5, 2019

openapi-sdkautomation bot commented Jun 10, 2019 • edited Loading

SDK Automation [Logs] (Generated from 625784c)

alexeldeib commented May 3, 2019 •

edited

Loading

AutorestCI commented May 3, 2019 •

edited

Loading

AutorestCI commented May 3, 2019 •

edited

Loading

AutorestCI commented May 3, 2019 •

edited

Loading

AutorestCI commented May 3, 2019 •

edited

Loading

AutorestCI commented May 3, 2019 •

edited

Loading

openapi-sdkautomation bot commented Jun 10, 2019 •

edited

Loading