Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tag change to generate SDK #32037

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Tag change to generate SDK #32037

wants to merge 1 commit into from

Conversation

schaudhari6254888
Copy link
Contributor

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

Click here to open a PR for only SDK configuration.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jan 8, 2025 •
edited
Loading

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This is the public specs repo main branch which is not intended for iterative development.
    You must acknowledge that you understand that after this PR is merged, you won't be able to stop your changes from being published to Azure customers.
    If this is what you intend, add PublishToCustomers label to your PR.
    Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR is awaiting ARM reviewer feedback (label: WaitForARMFeedback).
    To learn when this PR will get reviewed, see ARM review queue at aka.ms/azsdk/pr-arm-review
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review
  • ❌ The required check named SpellCheck has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jan 8, 2025 •
edited
Loading

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/eventhub/armeventhub There is no API change compared with the previous version
Java azure-resourcemanager-eventhubs-generated https://apiview.dev/Assemblies/Review/fa3caf8f9ce24f678df38d6e7b020a21?revisionId=cb14b5c63e2043538459e2f82ae1b388
JavaScript @azure/arm-eventhub https://apiview.dev/Assemblies/Review/4c326c472ed54963a534f4bafaf05bec?revisionId=10d4251398904e649735a38a724c4f70
.Net Azure.ResourceManager.EventHubs There is no API change compared with the previous version
Python azure-mgmt-eventhub https://apiview.dev/Assemblies/Review/dcb5d1bec6c34bdf9094b8500b51e3e1?revisionId=15d9f1955a944bd8b087d6829bc61a25

@azure-sdk azure-sdk mentioned this pull request Jan 8, 2025
Draft
@AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 8, 2025
@schaudhari6254888
Copy link
Contributor Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

This was referenced Jan 8, 2025
Draft
Draft
Draft
Draft
Draft
@razvanbadea-msft
Copy link
Contributor

What is the purpose of this pr?

@razvanbadea-msft razvanbadea-msft added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jan 9, 2025
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 9, 2025
@schaudhari6254888
Copy link
Contributor Author

What is the purpose of this pr?

We want to generate the SDK's for 2024-05-preview
So this is tag mismatch. Just updated the targeted tag pkg

@schaudhari6254888 schaudhari6254888 added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review labels Jan 9, 2025
@schaudhari6254888
Copy link
Contributor Author

What is the purpose of this pr?

We want to generate the SDK's for 2024-05-preview So this is tag mismatch. Just updated the targeted tag pkg

We have done this before also
pr link - https://github.com/Azure/azure-rest-api-specs/pull/29775/files

@schaudhari6254888
Copy link
Contributor Author

What is the purpose of this pr?

Hey @razvanbadea-msft, We want to generate the SDK's for 2024-05-preview So this is tag mismatch. Just updated the targeted tag pkg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v-Ajnava v-Ajnava Awaiting requested review from v-Ajnava v-Ajnava is a code owner

@dsouzaarun dsouzaarun Awaiting requested review from dsouzaarun dsouzaarun is a code owner

@damodaravadhani damodaravadhani Awaiting requested review from damodaravadhani damodaravadhani is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ARMReview Event Hubs resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schaudhari6254888 @razvanbadea-msft @AzureRestAPISpecReview