Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ApplicationId to Registered Server Update params #31342

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

add ApplicationId to Registered Server Update params #31342

wants to merge 8 commits into from
+23 −1

Conversation

stefong99
Copy link

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 30, 2024 •
edited
Loading

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ Your PR modified the suppressions for JavaScript SDK breaking changes (label: BreakingChange-JavaScript-Sdk-Suppression). Refer to step 3 in the PR workflow diagram.
  • ❌ The required check named Automated merging requirements met has failed. This is the final check that must pass. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide. In addition, refer to step 4 in the PR workflow diagram

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 30, 2024 •
edited
Loading

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/storagesync/armstoragesync https://apiview.dev/Assemblies/Review/b19525b81cd94d5992a4305e83139cf6?revisionId=3b41cda1fffc47988d24e9e734108804
JavaScript @azure/arm-storagesync https://apiview.dev/Assemblies/Review/2d5aa20666ee43bebf7cec6b2e5a627a?revisionId=2221383fa5b2489397282023658aa169
Java azure-resourcemanager-storagesync https://apiview.dev/Assemblies/Review/5816bbfd1dc44c04a22509f9f5295ffe?revisionId=d9d8454b56594a91a393fc651b723255
.Net Azure.ResourceManager.StorageSync There is no API change compared with the previous version
Python azure-mgmt-storagesync https://apiview.dev/Assemblies/Review/e46f94e47e854d4f8e50bc2f2e3c7ba7?revisionId=53c8b3a9fd274d72a779e50f7a89515e

@azure-sdk azure-sdk mentioned this pull request Oct 30, 2024
Draft
@AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview NotReadyForARMReview ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required labels Oct 30, 2024
This was referenced Oct 30, 2024
Draft
Draft
Draft
This was referenced Oct 30, 2024
Draft
Draft
@JeffreyRichter JeffreyRichter added the Versioning-Approved-Benign https://github.com/Azure/azure-sdk-tools/issues/6374 label Nov 4, 2024
@azure-sdk
Copy link
Collaborator

azure-sdk commented Nov 15, 2024 •
edited
Loading

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.StorageSync

@AzureRestAPISpecReview AzureRestAPISpecReview added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed NotReadyForARMReview labels Nov 15, 2024
@razvanbadea-msft razvanbadea-msft added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Nov 15, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 15, 2024
@ankushbindlish2 ankushbindlish2 added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankushbindlish2 ankushbindlish2 ankushbindlish2 approved these changes

Assignees
No one assigned
Labels
ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-JavaScript-Sdk-Suppression BreakingChange-Python-Sdk-Approved BreakingChange-Python-Sdk-Suppression BreakingChange-Python-Sdk-Suppression-Approved PublishToCustomers Acknowledgement the changes will be published to Azure customers. ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager StorageSync Versioning-Approved-Benign https://github.com/Azure/azure-sdk-tools/issues/6374 VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@stefong99 @azure-sdk @ankushbindlish2 @JeffreyRichter @AzureRestAPISpecReview @msyyc @razvanbadea-msft @kazrael2119