Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TLS 1_3 support for storage #29175

Merged
merged 4 commits into from
May 30, 2024
Merged

Add TLS 1_3 support for storage #29175

merged 4 commits into from
May 30, 2024

Conversation

usharma6
Copy link
Contributor

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

@usharma6 usharma6 requested a review from JasonYang-MSFT as a code owner May 21, 2024 05:20
@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented May 21, 2024 •
edited
Loading

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented May 21, 2024 •
edited
Loading

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail]
Compared specs (v0.10.9) new version base version
storage.json 2023-05-01(3e9f560) 2023-05-01(main)
Rule Message
❌ 1020 - AddedEnumValue The new version is adding enum value(s) 'Cold' from the old version.
New: Microsoft.Storage/stable/2023-05-01/storage.json#L3186:9
Old: Microsoft.Storage/stable/2023-05-01/storage.json#L3186:9
❌ 1020 - AddedEnumValue The new version is adding enum value(s) 'TLS1_3' from the old version.
New: Microsoft.Storage/stable/2023-05-01/storage.json#L3251:9
Old: Microsoft.Storage/stable/2023-05-01/storage.json#L3250:9
❌ 1020 - AddedEnumValue The new version is adding enum value(s) 'Cold' from the old version.
New: Microsoft.Storage/stable/2023-05-01/storage.json#L3853:9
Old: Microsoft.Storage/stable/2023-05-01/storage.json#L3851:9
❌ 1020 - AddedEnumValue The new version is adding enum value(s) 'TLS1_3' from the old version.
New: Microsoft.Storage/stable/2023-05-01/storage.json#L3951:9
Old: Microsoft.Storage/stable/2023-05-01/storage.json#L3948:9
❌ 1020 - AddedEnumValue The new version is adding enum value(s) 'Cold' from the old version.
New: Microsoft.Storage/stable/2023-05-01/storage.json#L4207:9
Old: Microsoft.Storage/stable/2023-05-01/storage.json#L4203:9
❌ 1020 - AddedEnumValue The new version is adding enum value(s) 'TLS1_3' from the old version.
New: Microsoft.Storage/stable/2023-05-01/storage.json#L4272:9
Old: Microsoft.Storage/stable/2023-05-01/storage.json#L4267:9
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand] 
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand] 
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
Compared specs (v2.2.2) new version base version
package-2023-05 package-2023-05(3e9f560) package-2023-05(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
❌ GetCollectionResponseSchema The response in the GET collection operation 'Queue_List' does not match the response definition in the individual GET operation 'Queue_Get' .
Location: Microsoft.Storage/stable/2023-05-01/storage.json#L18
❌ GetCollectionResponseSchema The response in the GET collection operation 'BlobContainers_List' does not match the response definition in the individual GET operation 'BlobContainers_Get' .
Location: Microsoft.Storage/stable/2023-05-01/storage.json#L18
❌ GetCollectionResponseSchema The response in the GET collection operation 'FileShares_List' does not match the response definition in the individual GET operation 'FileShares_Get' .
Location: Microsoft.Storage/stable/2023-05-01/storage.json#L18
❌ RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
Location: Microsoft.Storage/stable/2023-05-01/storage.json#L36
❌ OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.Storage/operations' does not match the ARM specification. Please standardize the schema.
Location: Microsoft.Storage/stable/2023-05-01/storage.json#L39
❌ OperationsApiSchemaUsesCommonTypes Operations API path must follow the schema provided in the common types.
Location: Microsoft.Storage/stable/2023-05-01/storage.json#L40
❌ RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
Location: Microsoft.Storage/stable/2023-05-01/storage.json#L69
❌ GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
Location: Microsoft.Storage/stable/2023-05-01/storage.json#L72
❌ PostResponseCodes Synchronous POST operations must have one of the following combinations of responses - 200 and default ; 204 and default. They also must not have other response codes.
Location: Microsoft.Storage/stable/2023-05-01/storage.json#L83
❌ RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
Location: Microsoft.Storage/stable/2023-05-01/storage.json#L111
❌ ProvisioningStateSpecifiedForLROPut 201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes.
Location: Microsoft.Storage/stable/2023-05-01/storage.json#L122
❌ PutRequestResponseSchemeArm A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'StorageAccounts_Create' Request Model: 'parameters[2].schema' Response Model: 'responses[200].schema'
Location: Microsoft.Storage/stable/2023-05-01/storage.json#L122
❌ PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.Storage/stable/2023-05-01/storage.json#L122
❌ RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
Location: Microsoft.Storage/stable/2023-05-01/storage.json#L189
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Storage/stable/2023-05-01/storage.json#L196
❌ DeleteResponseCodes Synchronous delete operations must have responses with 200, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.Storage/stable/2023-05-01/storage.json#L202
❌ RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
Location: Microsoft.Storage/stable/2023-05-01/storage.json#L227
❌ ParametersInPointGet Query parameter $expand should be removed. Point Get's MUST not have query parameters other than api version.
Location: Microsoft.Storage/stable/2023-05-01/storage.json#L262
❌ RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
Location: Microsoft.Storage/stable/2023-05-01/storage.json#L291
❌ PatchResponseCodes Synchronous PATCH operations must have responses with 200 and default return codes. They also must not have other response codes.
Location: Microsoft.Storage/stable/2023-05-01/storage.json#L300
❌ PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:type.
Location: Microsoft.Storage/stable/2023-05-01/storage.json#L343
❌ PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:name.
Location: Microsoft.Storage/stable/2023-05-01/storage.json#L343
❌ PatchBodyParametersSchema Properties of a PATCH request body must not have default value, property:keySource.
Location: Microsoft.Storage/stable/2023-05-01/storage.json#L343
❌ PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:sasExpirationPeriod.
Location: Microsoft.Storage/stable/2023-05-01/storage.json#L343
❌ PatchBodyParametersSchema Properties of a PATCH request body must not have default value, property:expirationAction.
Location: Microsoft.Storage/stable/2023-05-01/storage.json#L343
❌ PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:expirationAction.
Location: Microsoft.Storage/stable/2023-05-01/storage.json#L343
❌ PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:keyExpirationPeriodInDays.
Location: Microsoft.Storage/stable/2023-05-01/storage.json#L343
❌ PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:directoryServiceOptions.
Location: Microsoft.Storage/stable/2023-05-01/storage.json#L343
❌ PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:domainName.
Location: Microsoft.Storage/stable/2023-05-01/storage.json#L343
❌ PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:domainGuid.
Location: Microsoft.Storage/stable/2023-05-01/storage.json#L343
️️✔️Avocado succeeded [Detail] [Expand] 
Validation passes for Avocado.
️❌SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand] 
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand] 
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand] 
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand] 
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand] 
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented May 21, 2024 •
edited
Loading

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand] 
 Please click here to preview with your @microsoft account.
️❌ azure-sdk-for-net-track2 failed [Detail]
  • ❌Failed in generating from 8c98e8318b147dd51fa7d423b49216dd611ce8a4. SDK Automation 14.0.0 
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] GeneratePackage: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
cmderr	[Invoke-GenerateAndBuildV2.ps1]  714 |          GeneratePackage -projectFolder $projectFolder -sdkRootPath $s …
cmderr	[Invoke-GenerateAndBuildV2.ps1]      |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Failed to generate sdk. exit code: False
cmderr	[Invoke-GenerateAndBuildV2.ps1] Get-ChildItem: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:807
cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
cmderr	[Invoke-GenerateAndBuildV2.ps1]  807 |  … rtifacts += Get-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s …
cmderr	[Invoke-GenerateAndBuildV2.ps1]      |                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Cannot find path
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | it does not exist.
cmderr	[Invoke-GenerateAndBuildV2.ps1] GeneratePackage: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
cmderr	[Invoke-GenerateAndBuildV2.ps1]  714 |          GeneratePackage -projectFolder $projectFolder -sdkRootPath $s …
cmderr	[Invoke-GenerateAndBuildV2.ps1]      |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Failed to generate sdk artifact
  • ❌Azure.ResourceManager.Storage [Preview SDK Changes] 
    info	[Changelog]
️⚠️ azure-sdk-for-python warning [Detail]
  • ⚠️Warning in generating from 8c98e8318b147dd51fa7d423b49216dd611ce8a4. SDK Automation 14.0.0 
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
  • ️✔️azure-mgmt-storage [Preview SDK Changes]
    • azure-mgmt-storage-21.1.0.zip
    • azure_mgmt_storage-21.1.0-py3-none-any.whl
    info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Added operation group NetworkSecurityPerimeterConfigurationsOperations
info	[Changelog]   - Added operation group StorageTaskAssignmentInstancesReportOperations
info	[Changelog]   - Added operation group StorageTaskAssignmentsInstancesReportOperations
info	[Changelog]   - Added operation group StorageTaskAssignmentsOperations
info	[Changelog]   - Model LocalUser has a new parameter allow_acl_authorization
info	[Changelog]   - Model LocalUser has a new parameter extended_groups
info	[Changelog]   - Model LocalUser has a new parameter group_id
info	[Changelog]   - Model LocalUser has a new parameter is_nf_sv3_enabled
info	[Changelog]   - Model LocalUser has a new parameter user_id
info	[Changelog]   - Model LocalUsers has a new parameter next_link
info	[Changelog]   - Model StorageAccount has a new parameter enable_extended_groups
info	[Changelog]   - Model StorageAccountCreateParameters has a new parameter enable_extended_groups
info	[Changelog]   - Model StorageAccountUpdateParameters has a new parameter enable_extended_groups
info	[Changelog]   - Operation LocalUsersOperations.list has a new optional parameter filter
info	[Changelog]   - Operation LocalUsersOperations.list has a new optional parameter include
info	[Changelog]   - Operation LocalUsersOperations.list has a new optional parameter maxpagesize
️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from 8c98e8318b147dd51fa7d423b49216dd611ce8a4. SDK Automation 14.0.0 
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  • ️✔️azure-resourcemanager-storage-generated [Preview SDK Changes]
    • pom.xml
    • azure-resourcemanager-storage-generated-1.0.0-beta.1-sources.jar
    • azure-resourcemanager-storage-generated-1.0.0-beta.1.jar
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from 8c98e8318b147dd51fa7d423b49216dd611ce8a4. SDK Automation 14.0.0 
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/storage/armstorage [Preview SDK Changes] 
    info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New value `AccessTierCold` added to enum type `AccessTier`
info	[Changelog] - New value `ExpirationActionBlock` added to enum type `ExpirationAction`
info	[Changelog] - New value `MinimumTLSVersionTLS13` added to enum type `MinimumTLSVersion`
info	[Changelog] - New value `ProvisioningStateCanceled`, `ProvisioningStateDeleting`, `ProvisioningStateFailed`, `ProvisioningStateValidateSubscriptionQuotaBegin`, `ProvisioningStateValidateSubscriptionQuotaEnd` added to enum type `ProvisioningState`
info	[Changelog] - New value `PublicNetworkAccessSecuredByPerimeter` added to enum type `PublicNetworkAccess`
info	[Changelog] - New enum type `IssueType` with values `IssueTypeConfigurationPropagationFailure`, `IssueTypeUnknown`
info	[Changelog] - New enum type `ListLocalUserIncludeParam` with values `ListLocalUserIncludeParamNfsv3`
info	[Changelog] - New enum type `NetworkSecurityPerimeterConfigurationProvisioningState` with values `NetworkSecurityPerimeterConfigurationProvisioningStateAccepted`, `NetworkSecurityPerimeterConfigurationProvisioningStateCanceled`, `NetworkSecurityPerimeterConfigurationProvisioningStateDeleting`, `NetworkSecurityPerimeterConfigurationProvisioningStateFailed`, `NetworkSecurityPerimeterConfigurationProvisioningStateSucceeded`
info	[Changelog] - New enum type `NspAccessRuleDirection` with values `NspAccessRuleDirectionInbound`, `NspAccessRuleDirectionOutbound`
info	[Changelog] - New enum type `ResourceAssociationAccessMode` with values `ResourceAssociationAccessModeAudit`, `ResourceAssociationAccessModeEnforced`, `ResourceAssociationAccessModeLearning`
info	[Changelog] - New enum type `RunResult` with values `RunResultFailed`, `RunResultSucceeded`
info	[Changelog] - New enum type `RunStatusEnum` with values `RunStatusEnumFinished`, `RunStatusEnumInProgress`
info	[Changelog] - New enum type `Severity` with values `SeverityError`, `SeverityWarning`
info	[Changelog] - New enum type `TriggerType` with values `TriggerTypeOnSchedule`, `TriggerTypeRunOnce`
info	[Changelog] - New function `*ClientFactory.NewNetworkSecurityPerimeterConfigurationsClient() *NetworkSecurityPerimeterConfigurationsClient`
info	[Changelog] - New function `*ClientFactory.NewTaskAssignmentInstancesReportClient() *TaskAssignmentInstancesReportClient`
info	[Changelog] - New function `*ClientFactory.NewTaskAssignmentsClient() *TaskAssignmentsClient`
info	[Changelog] - New function `*ClientFactory.NewTaskAssignmentsInstancesReportClient() *TaskAssignmentsInstancesReportClient`
info	[Changelog] - New function `NewTaskAssignmentInstancesReportClient(string, azcore.TokenCredential, *arm.ClientOptions) (*TaskAssignmentInstancesReportClient, error)`
info	[Changelog] - New function `*TaskAssignmentInstancesReportClient.NewListPager(string, string, string, *TaskAssignmentInstancesReportClientListOptions) *runtime.Pager[TaskAssignmentInstancesReportClientListResponse]`
info	[Changelog] - New function `NewTaskAssignmentsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*TaskAssignmentsClient, error)`
info	[Changelog] - New function `*TaskAssignmentsClient.BeginCreate(context.Context, string, string, string, TaskAssignment, *TaskAssignmentsClientBeginCreateOptions) (*runtime.Poller[TaskAssignmentsClientCreateResponse], error)`
info	[Changelog] - New function `*TaskAssignmentsClient.BeginDelete(context.Context, string, string, string, *TaskAssignmentsClientBeginDeleteOptions) (*runtime.Poller[TaskAssignmentsClientDeleteResponse], error)`
info	[Changelog] - New function `*TaskAssignmentsClient.Get(context.Context, string, string, string, *TaskAssignmentsClientGetOptions) (TaskAssignmentsClientGetResponse, error)`
info	[Changelog] - New function `*TaskAssignmentsClient.NewListPager(string, string, *TaskAssignmentsClientListOptions) *runtime.Pager[TaskAssignmentsClientListResponse]`
info	[Changelog] - New function `*TaskAssignmentsClient.BeginUpdate(context.Context, string, string, string, TaskAssignmentUpdateParameters, *TaskAssignmentsClientBeginUpdateOptions) (*runtime.Poller[TaskAssignmentsClientUpdateResponse], error)`
info	[Changelog] - New function `NewTaskAssignmentsInstancesReportClient(string, azcore.TokenCredential, *arm.ClientOptions) (*TaskAssignmentsInstancesReportClient, error)`
info	[Changelog] - New function `*TaskAssignmentsInstancesReportClient.NewListPager(string, string, *TaskAssignmentsInstancesReportClientListOptions) *runtime.Pager[TaskAssignmentsInstancesReportClientListResponse]`
info	[Changelog] - New function `NewNetworkSecurityPerimeterConfigurationsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*NetworkSecurityPerimeterConfigurationsClient, error)`
info	[Changelog] - New function `*NetworkSecurityPerimeterConfigurationsClient.Get(context.Context, string, string, string, *NetworkSecurityPerimeterConfigurationsClientGetOptions) (NetworkSecurityPerimeterConfigurationsClientGetResponse, error)`
info	[Changelog] - New function `*NetworkSecurityPerimeterConfigurationsClient.NewListPager(string, string, *NetworkSecurityPerimeterConfigurationsClientListOptions) *runtime.Pager[NetworkSecurityPerimeterConfigurationsClientListResponse]`
info	[Changelog] - New function `*NetworkSecurityPerimeterConfigurationsClient.BeginReconcile(context.Context, string, string, string, *NetworkSecurityPerimeterConfigurationsClientBeginReconcileOptions) (*runtime.Poller[NetworkSecurityPerimeterConfigurationsClientReconcileResponse], error)`
info	[Changelog] - New struct `ExecutionTarget`
info	[Changelog] - New struct `ExecutionTargetUpdate`
info	[Changelog] - New struct `ExecutionTrigger`
info	[Changelog] - New struct `ExecutionTriggerUpdate`
info	[Changelog] - New struct `NetworkSecurityPerimeter`
info	[Changelog] - New struct `NetworkSecurityPerimeterConfiguration`
info	[Changelog] - New struct `NetworkSecurityPerimeterConfigurationList`
info	[Changelog] - New struct `NetworkSecurityPerimeterConfigurationProperties`
info	[Changelog] - New struct `NetworkSecurityPerimeterConfigurationPropertiesProfile`
info	[Changelog] - New struct `NetworkSecurityPerimeterConfigurationPropertiesResourceAssociation`
info	[Changelog] - New struct `NspAccessRule`
info	[Changelog] - New struct `NspAccessRuleProperties`
info	[Changelog] - New struct `NspAccessRulePropertiesSubscriptionsItem`
info	[Changelog] - New struct `ProvisioningIssue`
info	[Changelog] - New struct `ProvisioningIssueProperties`
info	[Changelog] - New struct `ProxyResourceAutoGenerated`
info	[Changelog] - New struct `ResourceAutoGenerated`
info	[Changelog] - New struct `TaskAssignment`
info	[Changelog] - New struct `TaskAssignmentExecutionContext`
info	[Changelog] - New struct `TaskAssignmentProperties`
info	[Changelog] - New struct `TaskAssignmentReport`
info	[Changelog] - New struct `TaskAssignmentUpdateExecutionContext`
info	[Changelog] - New struct `TaskAssignmentUpdateParameters`
info	[Changelog] - New struct `TaskAssignmentUpdateProperties`
info	[Changelog] - New struct `TaskAssignmentUpdateReport`
info	[Changelog] - New struct `TaskAssignmentsList`
info	[Changelog] - New struct `TaskReportInstance`
info	[Changelog] - New struct `TaskReportProperties`
info	[Changelog] - New struct `TaskReportSummary`
info	[Changelog] - New struct `TriggerParameters`
info	[Changelog] - New struct `TriggerParametersUpdate`
info	[Changelog] - New field `EnableExtendedGroups` in struct `AccountProperties`
info	[Changelog] - New field `EnableExtendedGroups` in struct `AccountPropertiesCreateParameters`
info	[Changelog] - New field `EnableExtendedGroups` in struct `AccountPropertiesUpdateParameters`
info	[Changelog] - New field `AllowACLAuthorization`, `ExtendedGroups`, `GroupID`, `IsNFSv3Enabled`, `UserID` in struct `LocalUserProperties`
info	[Changelog] - New field `NextLink` in struct `LocalUsers`
info	[Changelog] - New field `Filter`, `Include`, `Maxpagesize` in struct `LocalUsersClientListOptions`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 125 additive change(s).
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from 8c98e8318b147dd51fa7d423b49216dd611ce8a4. SDK Automation 14.0.0 
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure/arm-storage [Preview SDK Changes]
    • azure-arm-storage-18.3.0.tgz
    info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation group NetworkSecurityPerimeterConfigurations
info	[Changelog]   - Added operation group StorageTaskAssignmentInstancesReport
info	[Changelog]   - Added operation group StorageTaskAssignments
info	[Changelog]   - Added operation group StorageTaskAssignmentsInstancesReport
info	[Changelog]   - Added Interface ExecutionTarget
info	[Changelog]   - Added Interface ExecutionTargetUpdate
info	[Changelog]   - Added Interface ExecutionTrigger
info	[Changelog]   - Added Interface ExecutionTriggerUpdate
info	[Changelog]   - Added Interface NetworkSecurityPerimeter
info	[Changelog]   - Added Interface NetworkSecurityPerimeterConfiguration
info	[Changelog]   - Added Interface NetworkSecurityPerimeterConfigurationList
info	[Changelog]   - Added Interface NetworkSecurityPerimeterConfigurationPropertiesProfile
info	[Changelog]   - Added Interface NetworkSecurityPerimeterConfigurationPropertiesResourceAssociation
info	[Changelog]   - Added Interface NetworkSecurityPerimeterConfigurationsGetOptionalParams
info	[Changelog]   - Added Interface NetworkSecurityPerimeterConfigurationsListOptionalParams
info	[Changelog]   - Added Interface NetworkSecurityPerimeterConfigurationsReconcileHeaders
info	[Changelog]   - Added Interface NetworkSecurityPerimeterConfigurationsReconcileOptionalParams
info	[Changelog]   - Added Interface NspAccessRule
info	[Changelog]   - Added Interface NspAccessRuleProperties
info	[Changelog]   - Added Interface NspAccessRulePropertiesSubscriptionsItem
info	[Changelog]   - Added Interface ProvisioningIssue
info	[Changelog]   - Added Interface ProvisioningIssueProperties
info	[Changelog]   - Added Interface ProxyResourceAutoGenerated
info	[Changelog]   - Added Interface ResourceAutoGenerated
info	[Changelog]   - Added Interface StorageTaskAssignment
info	[Changelog]   - Added Interface StorageTaskAssignmentExecutionContext
info	[Changelog]   - Added Interface StorageTaskAssignmentInstancesReportListNextOptionalParams
info	[Changelog]   - Added Interface StorageTaskAssignmentInstancesReportListOptionalParams
info	[Changelog]   - Added Interface StorageTaskAssignmentProperties
info	[Changelog]   - Added Interface StorageTaskAssignmentReport
info	[Changelog]   - Added Interface StorageTaskAssignmentsCreateHeaders
info	[Changelog]   - Added Interface StorageTaskAssignmentsCreateOptionalParams
info	[Changelog]   - Added Interface StorageTaskAssignmentsDeleteHeaders
info	[Changelog]   - Added Interface StorageTaskAssignmentsDeleteOptionalParams
info	[Changelog]   - Added Interface StorageTaskAssignmentsGetOptionalParams
info	[Changelog]   - Added Interface StorageTaskAssignmentsInstancesReportListNextOptionalParams
info	[Changelog]   - Added Interface StorageTaskAssignmentsInstancesReportListOptionalParams
info	[Changelog]   - Added Interface StorageTaskAssignmentsList
info	[Changelog]   - Added Interface StorageTaskAssignmentsListNextOptionalParams
info	[Changelog]   - Added Interface StorageTaskAssignmentsListOptionalParams
info	[Changelog]   - Added Interface StorageTaskAssignmentsUpdateHeaders
info	[Changelog]   - Added Interface StorageTaskAssignmentsUpdateOptionalParams
info	[Changelog]   - Added Interface StorageTaskAssignmentUpdateExecutionContext
info	[Changelog]   - Added Interface StorageTaskAssignmentUpdateParameters
info	[Changelog]   - Added Interface StorageTaskAssignmentUpdateProperties
info	[Changelog]   - Added Interface StorageTaskAssignmentUpdateReport
info	[Changelog]   - Added Interface StorageTaskReportInstance
info	[Changelog]   - Added Interface StorageTaskReportProperties
info	[Changelog]   - Added Interface StorageTaskReportSummary
info	[Changelog]   - Added Interface TriggerParameters
info	[Changelog]   - Added Interface TriggerParametersUpdate
info	[Changelog]   - Added Type Alias IssueType
info	[Changelog]   - Added Type Alias ListLocalUserIncludeParam
info	[Changelog]   - Added Type Alias NetworkSecurityPerimeterConfigurationProvisioningState
info	[Changelog]   - Added Type Alias NetworkSecurityPerimeterConfigurationsGetResponse
info	[Changelog]   - Added Type Alias NetworkSecurityPerimeterConfigurationsListResponse
info	[Changelog]   - Added Type Alias NetworkSecurityPerimeterConfigurationsReconcileResponse
info	[Changelog]   - Added Type Alias NspAccessRuleDirection
info	[Changelog]   - Added Type Alias ResourceAssociationAccessMode
info	[Changelog]   - Added Type Alias RunResult
info	[Changelog]   - Added Type Alias RunStatusEnum
info	[Changelog]   - Added Type Alias Severity
info	[Changelog]   - Added Type Alias StorageTaskAssignmentInstancesReportListNextResponse
info	[Changelog]   - Added Type Alias StorageTaskAssignmentInstancesReportListResponse
info	[Changelog]   - Added Type Alias StorageTaskAssignmentsCreateResponse
info	[Changelog]   - Added Type Alias StorageTaskAssignmentsDeleteResponse
info	[Changelog]   - Added Type Alias StorageTaskAssignmentsGetResponse
info	[Changelog]   - Added Type Alias StorageTaskAssignmentsInstancesReportListNextResponse
info	[Changelog]   - Added Type Alias StorageTaskAssignmentsInstancesReportListResponse
info	[Changelog]   - Added Type Alias StorageTaskAssignmentsListNextResponse
info	[Changelog]   - Added Type Alias StorageTaskAssignmentsListResponse
info	[Changelog]   - Added Type Alias StorageTaskAssignmentsUpdateResponse
info	[Changelog]   - Added Type Alias TriggerType
info	[Changelog]   - Interface LocalUser has a new optional parameter allowAclAuthorization
info	[Changelog]   - Interface LocalUser has a new optional parameter extendedGroups
info	[Changelog]   - Interface LocalUser has a new optional parameter groupId
info	[Changelog]   - Interface LocalUser has a new optional parameter isNFSv3Enabled
info	[Changelog]   - Interface LocalUser has a new optional parameter userId
info	[Changelog]   - Interface LocalUsers has a new optional parameter nextLink
info	[Changelog]   - Interface LocalUsersListOptionalParams has a new optional parameter filter
info	[Changelog]   - Interface LocalUsersListOptionalParams has a new optional parameter include
info	[Changelog]   - Interface LocalUsersListOptionalParams has a new optional parameter maxpagesize
info	[Changelog]   - Interface StorageAccount has a new optional parameter enableExtendedGroups
info	[Changelog]   - Interface StorageAccountCreateParameters has a new optional parameter enableExtendedGroups
info	[Changelog]   - Interface StorageAccountUpdateParameters has a new optional parameter enableExtendedGroups
info	[Changelog]   - Added Enum KnownIssueType
info	[Changelog]   - Added Enum KnownListLocalUserIncludeParam
info	[Changelog]   - Added Enum KnownNetworkSecurityPerimeterConfigurationProvisioningState
info	[Changelog]   - Added Enum KnownNspAccessRuleDirection
info	[Changelog]   - Added Enum KnownResourceAssociationAccessMode
info	[Changelog]   - Added Enum KnownRunResult
info	[Changelog]   - Added Enum KnownRunStatusEnum
info	[Changelog]   - Added Enum KnownSeverity
info	[Changelog]   - Enum KnownExpirationAction has a new value Block
info	[Changelog]   - Enum KnownMinimumTlsVersion has a new value TLS13
info	[Changelog]   - Enum KnownPublicNetworkAccess has a new value SecuredByPerimeter
️❌ azure-resource-manager-schemas failed [Detail]
  • ❌Code Generator Failed in generating from 8c98e8318b147dd51fa7d423b49216dd611ce8a4. Schema Automation 14.0.0 
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] Submodule 'bicep-types-az' (https://github.com/Azure/bicep-types-az) registered for path 'bicep-types-az'
cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az'...
cmderr	[initScript.sh] Submodule 'bicep-types' (https://github.com/Azure/bicep-types) registered for path 'bicep-types-az/bicep-types'
cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az/bicep-types'...
cmderr	[initScript.sh] npm notice
cmderr	[initScript.sh] npm notice New minor version of npm available! 10.7.0 -> 10.8.1
cmderr	[initScript.sh] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.1
cmderr	[initScript.sh] npm notice To update run: npm install -g [email protected]
cmderr	[initScript.sh] npm notice
error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/initScript.sh
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
cmderr	[generateScript.sh] /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:500
cmderr	[generateScript.sh]     return new TSError(diagnosticText, diagnosticCodes)
cmderr	[generateScript.sh]            ^
cmderr	[generateScript.sh] TSError: ⨯ Unable to compile TypeScript:
cmderr	[generateScript.sh] cmd/generateall.ts(6,20): error TS2307: Cannot find module 'colors' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(10,19): error TS2307: Cannot find module 'yargs' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(11,18): error TS2307: Cannot find module 'path' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(13,35): error TS2307: Cannot find module 'fs' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(14,23): error TS2307: Cannot find module 'strip-ansi' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(42,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(53,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(69,67): error TS7006: Parameter 'x' implicitly has an 'any' type.
cmderr	[generateScript.sh] cmd/generateall.ts(70,49): error TS7006: Parameter 'f' implicitly has an 'any' type.
cmderr	[generateScript.sh] cmd/generateall.ts(94,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(105,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(106,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(157,13): error TS2591: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node` and then add 'node' to the types field in your tsconfig.
cmderr	[generateScript.sh]     at createTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:500:12)
cmderr	[generateScript.sh]     at reportTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:504:19)
cmderr	[generateScript.sh]     at getOutput (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:739:36)
cmderr	[generateScript.sh]     at Object.compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:955:32)
cmderr	[generateScript.sh]     at Module.m._compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:1043:43)
cmderr	[generateScript.sh]     at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
cmderr	[generateScript.sh]     at Object.require.extensions.<computed> [as .ts] (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:1046:12)
cmderr	[generateScript.sh]     at Module.load (node:internal/modules/cjs/loader:1203:32)
cmderr	[generateScript.sh]     at Function.Module._load (node:internal/modules/cjs/loader:1019:12)
cmderr	[generateScript.sh]     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12)
error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/generateScript.sh
warn	Skip package processing as generation is failed
error	ERROR: The 'breakingChangesLabel' configuration is missing or incorrect from the 'swagger_to_sdk_config.json file.
️️✔️ azure-powershell succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from 8c98e8318b147dd51fa7d423b49216dd611ce8a4. SDK Automation 14.0.0 
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
  • ️✔️Az.storage.DefaultTag [Preview SDK Changes]
    • Az.Storage.0.1.0.nupkg
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented May 21, 2024 •
edited
Loading

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/storage/armstorage Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
Java azure-resourcemanager-storage-generated Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
JavaScript @azure/arm-storage Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
Swagger Microsoft.Storage Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

@microsoft-github-policy-service microsoft-github-policy-service bot added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label May 21, 2024
@azure-sdk azure-sdk mentioned this pull request May 21, 2024
Closed
@AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 21, 2024
This was referenced May 21, 2024
Closed
Closed
Closed
Closed
Closed
@TimLovellSmith TimLovellSmith added the VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required label May 23, 2024
@TimLovellSmith
Copy link
Member

Tagging for version review as I think new enum values are supposed to be in a new version .

@usharma6
Copy link
Contributor Author

Tagging for version review as I think new enum values are supposed to be in a new version .

This version is not yet released, hence adding the new enum values to this version

@AzureRestAPISpecReview AzureRestAPISpecReview removed the VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required label May 24, 2024
@razvanbadea-msft razvanbadea-msft added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label May 26, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 26, 2024
@usharma6
Copy link
Contributor Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Commenter does not have sufficient privileges for PR 29175 in repo Azure/azure-rest-api-specs

@HimanshuChhabra
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Commenter does not have sufficient privileges for PR 29175 in repo Azure/azure-rest-api-specs

@HimanshuChhabra
Copy link
Member

/pr RequestMerge

@gary-x-li gary-x-li merged commit ce625c0 into Azure:main May 30, 2024
28 of 32 checks passed
Francisco-Gamino pushed a commit to Francisco-Gamino/azure-rest-api-specs that referenced this pull request Jun 5, 2024
@usharma6 @Francisco-Gamino
Add TLS 1_3 support for storage (Azure#29175)
450376a 
* Add TLS 1_3 support for storage

* Add support for account level cold access tier

---------

Co-authored-by: Udit Sharma <[email protected]>
trangevi added a commit to trangevi/azure-rest-api-specs that referenced this pull request Jun 12, 2024
@trangevi
Squashed commit of the following:
380272c 
commit 4ee5306
Author: Darren Cohen <[email protected]>
Date:   Mon Jun 10 16:53:36 2024 -0700

    Move Python class renaming to client.tsp

commit 36d9e57
Author: Darren Cohen <[email protected]>
Date:   Mon Jun 10 12:06:34 2024 -0700

    Regenerate examples

commit ac08a31
Author: Darren Cohen <[email protected]>
Date:   Mon Jun 10 12:04:19 2024 -0700

    Add missing public access of ModelType

commit 1e69395
Author: Darren Cohen <[email protected]>
Date:   Mon Jun 10 11:20:08 2024 -0700

    limit scope of text and image embedding clients to Python only

commit 4478a53
Author: Darren Cohen <[email protected]>
Date:   Mon Jun 10 07:59:52 2024 -0700

    Support image input in chat completions

commit 6dee548
Merge: 54ca985 f45a76f
Author: Darren Cohen <[email protected]>
Date:   Mon Jun 10 07:54:14 2024 -0700

    Merge remote-tracking branch 'origin/main' into dargilco/ai-model-inference

commit f45a76f
Author: Ayush Gupta - SQL <[email protected]>
Date:   Mon Jun 10 13:20:39 2024 +0530

    Downgraded the version of ManagedInstances to generate .Net SDK for sql/resource manager (Azure#29316)

    * Downgraded the version of ManagedInstances and DistributedAvailabilityGroups Api due to .Net Sdk build failures caused by error : MembersMustExist  in these API's

    * restored the version of ManagedInstance Api as previous

    * Update the version of ManagedInstance APi to previous version 22-08-01 as having build erros while building .net sdk with error 'implementation but it does exist in the contract.'

    ---------

    Co-authored-by: Ji Wang <[email protected]>

commit 1cb8cb0
Author: InbalZim <[email protected]>
Date:   Mon Jun 10 10:48:40 2024 +0300

    [Microsoft.StorageMover] [UploadLimitSchedule] [v2024-07-01] (Azure#29082)

    * Implemented ULS - copied v2024-07-01 files (incl. readme) from RPSaaSMaster branch

    * Removed reference to `v2024-05-01-preview`

commit 224f1c7
Author: Weidong Xu <[email protected]>
Date:   Mon Jun 10 00:01:56 2024 +0800

    vmware, mgmt, tsp, bug fix for leaseTime to int64 (Azure#29351)

commit c2f037e
Author: Steven Nguyen <[email protected]>
Date:   Sun Jun 9 11:57:40 2024 -0400

    update(acns): advanced networking profile to note addition costs (Azure#29146)

commit e8ead1c
Author: nnagarajanmsft <[email protected]>
Date:   Sun Jun 9 21:27:21 2024 +0530

    Nnagarajanmsft elasticsan microsoft.elastic san 2024 05 01 (Azure#28828)

    * Adds base for updating Microsoft.ElasticSan from version stable/2023-01-01 to version 2024-05-01

    * Updates readme

    * Updates API version in new specs and examples

    * Add EnforceDataIntegrityCheck and generate and validate examples

    * Run swagger prettier check for files reported in checks

    * Run prettier for all jsons

    * add modelerfour to disable flatten to avoid JS breaking

    * Add new field in VolumeGroupUpdateProperties

    ---------

    Co-authored-by: kazrael2119 <[email protected]>

commit 25afa22
Author: Libba Lawrence <[email protected]>
Date:   Fri Jun 7 16:16:19 2024 -0700

    [EG] mark internal all (Azure#29366)

    * internal csharp

    * remove - apply to all

    * update - js doesnt recognize internal?

    * try this

    * tsp format

    * update

    * update version

commit 54ca985
Merge: 0aeb368 e90dc8b
Author: Darren Cohen <[email protected]>
Date:   Fri Jun 7 15:30:18 2024 -0700

    Merge remote-tracking branch 'origin/main' into dargilco/ai-model-inference

commit e90dc8b
Author: Konrad Jamrozik <[email protected]>
Date:   Fri Jun 7 14:26:15 2024 -0700

    Update uniform-versioning.md and glossary.md: minor fixups (Azure#29368)

    * Update uniform-versioning.md

    * Update glossary.md

commit 86b70ce
Author: pjohari-ms <[email protected]>
Date:   Fri Jun 7 15:56:05 2024 -0500

    [Microsoft.DocumentDB] Bug fix for preview API Version 2024-05-15-preview (Azure#29344)

    * Bug fix for version 05-15-preview

    * Renamed models for better naming

commit 0d5a422
Author: Jim Chou <[email protected]>
Date:   Fri Jun 7 08:52:52 2024 -0700

    [ACS][Communication][Chat] 2024-06-05-preview public preview API spec (Azure#28875)

commit b22c642
Author: Konrad Jamrozik <[email protected]>
Date:   Thu Jun 6 14:11:56 2024 -0700

    Update directory-structure.md: clarify service, service group, uniform versioning. (Azure#28929)

commit 0aeb368
Author: Darren Cohen <[email protected]>
Date:   Thu Jun 6 09:48:55 2024 -0700

    Remove CapacityType

commit bf820ef
Author: miaxzhitong <[email protected]>
Date:   Thu Jun 6 08:25:30 2024 -0700

    Azure Map Rendering 20240401 (Azure#27950)

    * Adds base for updating Render from version stable/2022-08-01 to version 2024-04-01

    * Updates readme

    * Updates API version in new specs and examples

    * update static map API doc

    * small change on static map doc

    * update tilesetId section

    * add static map supported tilesetid and trafficLayer

    * update range table and static image example

    * fix typo

    * add additional static image example

    * error fix

    * run prettier on static image example json

    * set tilesetId as optional

    * update max/min latitude/longitude table

    * update Accept header for static image API

    * error fix

    * add explanation for Accept header

    * typo

    * add parameter limitation

    * improve wording

    * add path and pin parameter type

    * fix tables

    * improve on example

    * typo fix

    * run prettier

    * wording fix

    * map attribution description update

    Co-authored-by: steve munk <[email protected]>

    * state tile description update

    Co-authored-by: steve munk <[email protected]>

    * map tile description update

    Co-authored-by: steve munk <[email protected]>

    * map tileset description update

    Co-authored-by: steve munk <[email protected]>

    * map copyright caption description change

    Co-authored-by: steve munk <[email protected]>

    * map copyright bounding description update

    Co-authored-by: steve munk <[email protected]>

    * weather radar tile description update

    Co-authored-by: steve munk <[email protected]>

    * weather infrared tiles description update

    Co-authored-by: steve munk <[email protected]>

    * map copyright tile description update

    Co-authored-by: steve munk <[email protected]>

    * map copyright world description update

    Co-authored-by: steve munk <[email protected]>

    * remove pricing tiers applies

    * Adds base for updating Render from version stable/2022-08-01 to version 2024-04-01

    * Updates readme

    * Updates API version in new specs and examples

    * update static map API doc

    * small change on static map doc

    * update tilesetId section

    * add static map supported tilesetid and trafficLayer

    * update range table and static image example

    * fix typo

    * add additional static image example

    * error fix

    * run prettier on static image example json

    * set tilesetId as optional

    * update max/min latitude/longitude table

    * update Accept header for static image API

    * error fix

    * add explanation for Accept header

    * typo

    * add parameter limitation

    * improve wording

    * add path and pin parameter type

    * fix tables

    * improve on example

    * typo fix

    * run prettier

    * wording fix

    * map attribution description update

    Co-authored-by: steve munk <[email protected]>

    * state tile description update

    Co-authored-by: steve munk <[email protected]>

    * map tile description update

    Co-authored-by: steve munk <[email protected]>

    * map tileset description update

    Co-authored-by: steve munk <[email protected]>

    * map copyright caption description change

    Co-authored-by: steve munk <[email protected]>

    * map copyright bounding description update

    Co-authored-by: steve munk <[email protected]>

    * weather radar tile description update

    Co-authored-by: steve munk <[email protected]>

    * weather infrared tiles description update

    Co-authored-by: steve munk <[email protected]>

    * map copyright tile description update

    Co-authored-by: steve munk <[email protected]>

    * map copyright world description update

    Co-authored-by: steve munk <[email protected]>

    * remove pricing tiers applies

    * reduce get copyright example length

    * add summary for render 20240401

    * remove summary from static image

    * remove please from language and view

    * add package-2024-04-01 to readme

    * revert back common change

    * revert changes in maps readme

    * \n fix

    Co-authored-by: steve munk <[email protected]>

    * typo fix

    Co-authored-by: steve munk <[email protected]>

    * typo fix for map copyright caption

    Co-authored-by: steve munk <[email protected]>

    * typo fix for statetile

    Co-authored-by: steve munk <[email protected]>

    * typo fix for map copyright world

    Co-authored-by: steve munk <[email protected]>

    ---------

    Co-authored-by: steve munk <[email protected]>
    Co-authored-by: Joel Hendrix <[email protected]>

commit f98d676
Author: Alan Zimmer <[email protected]>
Date:   Wed Jun 5 22:38:52 2024 -0400

    Enable stream-stype serialization for Java Communication Job Router (Azure#29328)

commit d88c94b
Author: Priyanshi Jain <[email protected]>
Date:   Thu Jun 6 03:34:21 2024 +0530

    [Microsoft.AzureStackHCI] Add 2024-04-01 for StackHCI (Azure#29110)

    * Add 2024-04-01 for StackHCI

    * add missing properties

    * add log collection job type

    * changes in sdk suppressions

    * sdk suppression changes

commit 491e00d
Author: Dylan Martinez <[email protected]>
Date:   Wed Jun 5 15:03:47 2024 -0700

    Update `securityPostureReference` in VMScaleSet API (Azure#28891)

    * update securityPostureRef properties in VMScaleSet spec

    * add securityPostureReference to UpdateVMProfile definition and fix min version

    * add prettier changes

    * remove unsupported 'major.*' from spec

    * add optional fields in security posture example

    * add required fields

    * correct minimum api version

    * add prettier fixes

    * remove extensionsSettings property

    * create new Update model for security posture reference & update

    * fix validation issue

    * Create sdk-suppressions.yaml

    * add azure-sdk-for-go suppression

    * Update sdk-suppressions.yaml

    ---------

    Co-authored-by: Dylan Martinez <[email protected]>
    Co-authored-by: Yuchao Yan <[email protected]>
    Co-authored-by: Alancere <[email protected]>
    Co-authored-by: kazrael2119 <[email protected]>

commit d9f06f3
Author: Francisco Gamino <[email protected]>
Date:   Wed Jun 5 11:13:49 2024 -0700

    Update 2023-12-01 Microsoft.Web functionAppConfig definition (Azure#29226)

    * Rename enum to functionsDeploymentStorageType

    * Update enum name to camel case

    * Update enum names to camel case

commit 336fc73
Author: Jose Alvarez <[email protected]>
Date:   Wed Jun 5 18:50:53 2024 +0200

    Fixed typo in documentation (Azure#29341)

commit 32f566e
Author: Samir Solanki <[email protected]>
Date:   Tue Jun 4 20:42:48 2024 -0700

    Merge release api management 2023 09 01 preview - Active (Azure#29184)

    * Adds base for updating Microsoft.ApiManagement from version preview/2023-05-01-preview to version 2023-09-01-preview

    * Updates readme

    * Updates API version in new specs and examples

    * feat(apim): Introduce gateway resource (Azure#27757)

    * WIP

    * Update sample

    * WIP

    * Add GatewayNameParameter

    * Clean up

    * Update sample

    * Add another sample

    * Add sample for delete gateway

    * Remove endpoints

    * Fix typo

    * Add list sample

    * Clean up

    Signed-off-by: Tom Kerkhove <[email protected]>

    * Add disclaimer

    Signed-off-by: Tom Kerkhove <[email protected]>

    * Make it pretty 💄

    Signed-off-by: Tom Kerkhove <[email protected]>

    * Refer to new file

    Signed-off-by: Tom Kerkhove <[email protected]>

    * Add missing ApiManagementGatewayListResult

    Signed-off-by: Tom Kerkhove <[email protected]>

    * Update sample reference

    Signed-off-by: Tom Kerkhove <[email protected]>

    * Remove ApiManagementGatewayIdentity + List by operation

    Signed-off-by: Tom Kerkhove <[email protected]>

    * Add more sample

    Signed-off-by: Tom Kerkhove <[email protected]>

    * Latest version of common types

    Signed-off-by: Tom Kerkhove <[email protected]>

    * Remove 200 for delete

    Signed-off-by: Tom Kerkhove <[email protected]>

    * Formatting and re-order

    Signed-off-by: Tom Kerkhove <[email protected]>

    * Align with spec

    Signed-off-by: Tom Kerkhove <[email protected]>

    * Align sample with spec

    Signed-off-by: Tom Kerkhove <[email protected]>

    * Error response from common types

    Signed-off-by: Tom Kerkhove <[email protected]>

    * Rename SKU name

    * Have seperate SKU for patch to not make it mandatory

    * Remove empty required

    * Improve note

    * Rename schema

    * Remove unused type

    * sku.capacity should not be required

    ---------

    Signed-off-by: Tom Kerkhove <[email protected]>

    * Add loggers, diagnostics, certificates and backends to workspace (Azure#27262)

    * Add loggers to workspaces

    * Add diagnostics to workspace

    * Add certificates to workspace

    * Add backends to workspaces

    * Change DiagnosticContract to DiagnosticContractProperties in patch

    * Revert back DiagnosticContractProperties to DiagnosticContract

    * Fix CI and add files to readme

    * Fix example

    * remove reconnect endpoint

    * Add suppressions

    * Try different suppression where

    * Try different suppression

    * Try other suppression

    * another test

    * finally working suppression

    * remove unwanted line

    * remove secret examples (Azure#28409)

    * Modify CircuitBreaker and BackendPool Contract (Azure#28397)

    * md cb contract

    * modify pool contract

    * correct the limits

    ---------

    Co-authored-by: Samir Solanki <[email protected]>

    * Common Error Response (Azure#28408)

    * add operation statuses resource (Azure#28591)

    * add operation statuses resource

    * fix api-version

    * Add locations/operationsResults endpoint for DELETE workflow (Azure#28808)

    * add operation results

    * fix spec

    * operationresults

    * fix file name

    * feat(Workspace): Add new SkuType for Workspace (Azure#28903)

    * new skutype

    * virtualNetworkType

    * remove default from patch

    * List skus API

    * add model for sku

    * caps enums

    * feat)Gateway): Adding gateway config resource (Azure#28478)

    * added gateway config resource

    * removing Head gateway Config call

    * updates

    * resolving errors

    * trying to resolve more model validations

    * resolving some model validations

    * resolving model validations

    * resoloving delete example errors

    * Swagger Prettier

    * prettier

    * updating so patch has same response as get and put

    * removing path for gateway config

    * addressing comment

    * addressing comments

    * nit

    * path updatess

    * updating as per comments

    * Adding workspaceLinks

    * resolving some of the errors

    * resolved some errors

    * resolving some of the errors

    * resolving some more errors

    * npx prettier

    * addressing comments

    * updated based on comments

    * lint updates

    * nit updates

    ---------

    Co-authored-by: Samir Solanki <[email protected]>

    * Fix generation errors (Azure#29207)

    * fix(apim): Remove duplicate ErrorResponse schema due to move to common schema

    * Gateway -> ApiGateway to prevent SDK collision with self-hosted gateway

    * Revert "Gateway -> ApiGateway to prevent SDK collision with self-hosted gateway"

    This reverts commit 8d4753d.

    * Remove ApiManagement Prefix for GatewayConfigConnections

    * Revert "Remove ApiManagement Prefix for GatewayConfigConnections"

    This reverts commit 3e8197f.

    * Gateway -> ApiGateway to prevent SDK collision with self-hosted gateway

    * Create sdk-suppressions.yaml

    ---------

    Signed-off-by: Tom Kerkhove <[email protected]>
    Co-authored-by: Tom Kerkhove <[email protected]>
    Co-authored-by: Rafał Mielowski <[email protected]>
    Co-authored-by: Mahsa Sadi <[email protected]>
    Co-authored-by: Vidisha Shah <[email protected]>
    Co-authored-by: Yuchao Yan <[email protected]>

commit ceb3b7f
Author: jaclin1111 <[email protected]>
Date:   Tue Jun 4 20:41:22 2024 -0700

    Update virtualMachine.json (Azure#29112)

    remove "feature in preview"

    Co-authored-by: Theodore Chang <[email protected]>

commit 09c187c
Author: Tricia Rosario <[email protected]>
Date:   Tue Jun 4 20:39:42 2024 -0700

    Storage Task Assignment Swagger Updates (Azure#29050)

    * SDK team improvements

    * Report APIs contain filtering

    * PR comment add more examples

    * Fix example path

    * Fix duplicate schema issue

    ---------

    Co-authored-by: Tricia Rosario <[email protected]>

commit f6f50c6
Author: Sean McCullough <[email protected]>
Date:   Tue Jun 4 17:39:18 2024 -0500

    Storage STG 94 (Azure#28327)

    * added swagger (Azure#28199)

    * [STG94] Updated STG94 Files Readme (Azure#28201)

    * added swagger

    * updated readme

    * small fix

    * added new blob swagger (Azure#28245)

    * added blob readme (Azure#28246)

    * Ran prettier on the 2024-08-04 files swagger file (Azure#28358)

    * Added AuthenticationErrorDetail to StorageError (Azure#28360)

    * NFS Share Snapshot (Azure#28362)

    * Added GetAccountInfo() API to Container and Blob level (Azure#28297)

    * Storage Error Codes for Copies (Azure#28359)

    * Revert "Storage Error Codes for Copies (Azure#28359)"

    This reverts commit 8b14ba4.

    ---------

    Co-authored-by: Tamer Sherif <[email protected]>

commit 814c367
Author: shraddhasun <[email protected]>
Date:   Tue Jun 4 14:39:17 2024 -0700

    Add new api-version 2024-02-01-preview to main (Azure#29105)

    * Add 2024-02-01-preview to main

    * fix typespec errors

    * remove operations.json

    * fix linters

    * delete unusued file

    * edit readme

    * remove suppressions

    * Update specification/azurestackhci/Operations.Management/tspconfig.yaml

    Co-authored-by: Mike Harder <[email protected]>

    * Update specification/azurestackhci/AzureStackHCI.StackHCIVM.Management/tspconfig.yaml

    Co-authored-by: Mike Harder <[email protected]>

    * ID to id

    * remove unnecessary suppress

    * fix examples

    * copy private folder changes

    ---------

    Co-authored-by: Mike Harder <[email protected]>

commit 1c0fd99
Author: Ralf Beckers <[email protected]>
Date:   Tue Jun 4 22:04:04 2024 +0200

    Add v3.2 for Speech to text (3.2p2 as base) (Azure#28664)

    * Add v3.2 for Speech to text (3.2p2 as base)

    * Update swagger with new changes and updated version number

    * Update readme.md with new version

    * Added evaluation token errors

    * Revert ttl changes for transcriptions

    * Finalized api changes for GA

    * Try fix avocado error

commit f6fbf63
Author: Jose Alvarez <[email protected]>
Date:   Tue Jun 4 20:35:33 2024 +0200

    [OpenAI] [Inference] TSP definition updates for `v2024_05_01_preview` service release (Azure#29182)

    * Azure OpenAI: 2024-04-01-preview updates

    * add audio formats

    * post-merge fix incl. tool update for enum conversion to union

    * minor: spellcheck fix

    * refine duration encoding for word start/end

    * enable serialization into azure json and rename customization class name

    * Added new customBlockList filter and fields to OYD

    * Adding changes to authentication for Vector Search

    * Adjusted docs for OYD vector search auth models

    * Added missing field and retrieved documents

    * Examples added

    * corrected examples api-versions in json

    * Reformat

    * Recompile after reformat

    * PR comments: wrong plural and type precision

    * Revert added tab to service spec

    Co-authored-by: Shawn Fang <[email protected]>

    * Added readme entry for generated openAPI doc

    * Trying to improve folder structure

    * Removed moved and renamed generated.json files

    * Reverted last 3 commits

    * Added entry for generated.json swagger in the readme

    * Changed enum to nonExpandable

    * Ran formatter

    ---------

    Co-authored-by: Travis Wilson <[email protected]>
    Co-authored-by: Travis Wilson <[email protected]>
    Co-authored-by: Shawn Fang <[email protected]>
    Co-authored-by: Shawn Fang <[email protected]>

commit cb458eb
Author: Shawn Fang <[email protected]>
Date:   Tue Jun 4 11:35:09 2024 -0700

    [OAI-Assistant] Added Missing annotation and delete unnecessary  annotation (Azure#29297)

    * fixed the error

    * npx tsp compile updates

    ---------

    Co-authored-by: Travis Wilson <[email protected]>
    Co-authored-by: Jose Alvarez <[email protected]>

commit fbf0006
Author: will <[email protected]>
Date:   Tue Jun 4 22:32:04 2024 +0800

    RouteMatrix 2024-06-01-preview (Azure#29153)

    * first commit

    * fix

    * Add operationType

    * rename to pointType

    * fix

    * update

    * Update example

    * update

    * update description for default value

    * update description

    * Remove axleCount for RouteMatrix

    * Update vehicleSpec

    * update description

    * Update description

    * remove async result

    * Revert "remove async result"

    This reverts commit b7b2728.

    * Remove Summary

    * follow azure's convention

    * Remove Accept-Language for RouteMatrix

    * Update retention period to 24 hours

    * Add createdDateTime

    * Add suppressions

    * Update description

    ---------

    Co-authored-by: Will Huang <[email protected]>
    Co-authored-by: Joel Hendrix <[email protected]>

commit b77b86f
Author: Konrad Jamrozik <[email protected]>
Date:   Tue Jun 4 02:58:08 2024 -0700

    Update ci-fix.md: clarify that `SDK azure-powershell` is owned by `Azure.Core`. (Azure#29318)

    * Update ci-fix.md

    * Update ci-fix.md

    * Update ci-fix.md

commit 67e8e17
Author: Konrad Jamrozik <[email protected]>
Date:   Mon Jun 3 22:57:42 2024 -0700

    Add info about `SDK azure-sdk-for-*` checks and `SDK azure-powershell` to `ci-fix` doc; Clean up markdownlint rules and `ci-fix` doc. (Azure#29311)

commit ca620a2
Author: ChenxiJiang333 <[email protected]>
Date:   Tue Jun 4 13:54:51 2024 +0800

    Update readme.md (Azure#29313)

commit a5a01e0
Author: ChenxiJiang333 <[email protected]>
Date:   Tue Jun 4 11:35:03 2024 +0800

    Update readme.python.md (Azure#29309)

    * Update readme.python.md

    * Update readme.md

    ---------

    Co-authored-by: Yuchao Yan <[email protected]>

commit b1a1498
Author: raghumunukutla <[email protected]>
Date:   Mon Jun 3 18:33:48 2024 -0700

    Update readme.md to show up documentation for preview version (Azure#29165)

commit d687907
Author: zdelacerda-microsoft <[email protected]>
Date:   Mon Jun 3 21:33:16 2024 -0400

    Imagebuilder API Release 2024-02-01 (Azure#28896)

    * Copy files from stable/2023-07-01

    Copied the files in a separate commit.
    This allows reviewers to easily diff subsequent changes against the previous spec.

    * Update version to stable/2024-02-01

    Updated the API version from stable/2023-07-01 to stable/2024-02-01.

    * Added tag for 2024-02-01 in readme file

    * copying over 2024-02-01 changes from ADO

    * Revert "copying over 2024-02-01 changes from ADO"

    This reverts commit aa54d74.

    * adding changes from ado

    * adding autorun as custom word

    * adding autorun to custom-words.txt

    * fixing UpdateImageTemplateVmProfile.json reference and additionalProperties error

    * fixing UpdateImageTemplateVmProfile.json reference and additionalProperties error

    * changing type from string back to object

    * changing type from string back to object

    * Revert "changing type from string back to object"

    This reverts commit b0b5122.

    revert commit

    * Revert "fixing UpdateImageTemplateVmProfile.json reference and additionalProperties error"

    This reverts commit 0e52ddf.

    * referencing examples file

    * writing suppression for lintdiff

    * removing userassignedidentity

    * fixing bad version mismatch

    * fixing suppression

    * prettier changes

    * fixing where syntax

    * fixing where suppress 2

    * where suppress 3

    * where supress 4

    * where suppress 5

    * suppressing entire file

commit 0031475
Author: Chenjie Shi <[email protected]>
Date:   Tue Jun 4 09:32:44 2024 +0800

     Microsoft.ScVmm TypeSpec onboarding (Azure#26644)

    * Init tsp for Microsoft.ScVmm

    * Some changes towards passing tsv

    * Updates to fix lint errors, remove unused types, regenerate examples, etc.

    * Created shareable 'force' param

    * Figured out the incantation to rename a file case-sensitively

    * Restored string bool enums.

    * Removed all examples

    * Regenerate examples

    * Updated ARM ID properties. Added script to sort output to compare with sorted old swagger

    * Additional changes.

    * Removed unused XXUpdate models, Added @secret for password,

    * Fixed Azure#8, Azure#6, #5

    * Fixed #2

    * Update swagger to be in sync with previous fixes.

    * Workaround for CloudCapacity readonly

    * Additional fixes.

    * fix ModelValidation

    * update void

    * VM Instance Update Properties changes

    * spell check and prettier validation fix

    * fix for identifier bug

    * workaround for Azure/typespec-azure#449

    * format

    * spell and prettier check improvements

    * use encodedName replace projectdName

    * Add summary annotations

    * summary

    * update kind and void

    * lro azure-async-operation

    * fix

    * tsp compilation warning

    * TypeSpec Validation fix

    * Update tspconfig.yaml

    * config change

    * Removed Read Only Property from Examples to fix Swagger ModelValidation

    * Revert Boolean to Enum with type Union in TypeSpec

    * specs-pr repo PR review changes to specs repo

    * Remove sorted json file used for comparison

    * Fix TypeSpec PR pipeline failure

    * make extendedLocation for VM Instance read and create

    * typespec validation fix

    ---------

    Co-authored-by: Will Temple <[email protected]>
    Co-authored-by: Allen Zhang <[email protected]>
    Co-authored-by: Alancere <[email protected]>
    Co-authored-by: Harshit Surana <[email protected]>

commit 12ff370
Author: Sherylueen <[email protected]>
Date:   Tue Jun 4 07:25:20 2024 +0800

    Sherylueen appcomplianceautomation microsoft.app compliance automation 2024 06 27 (Azure#28981)

    * Adds base for updating Microsoft.AppComplianceAutomation from version preview/2022-11-16-preview to version 2024-06-27

    * Updates readme

    * Updates API version in new specs and examples

    * add new stable version for Microsoft.AppComplianceAutomation

    * remove the useless example file

    * fix spell check

    * remove query in get evidence api

    * remove the singleton annotation

    * fix compile error

    * fix compile error of v56

    * fix compile error

    * fix all compile error and make the swagger align with before

    * tsp prettier

    * change scoping name

    * upgrade the commontypes from v3 to v5

    * change commonTypes version to v3

    * add service-dir

    * format tspconfig.yaml

    * modify tspconfig.yaml

    * remove custom operations

    * modify re pattern of snapshot name

    * make the resource x-ms-client-name properties

    * format typespec

    * remove suffix of snapshot

    * use requestBody replace parameters

    * Revert "use requestBody replace parameters"

    This reverts commit e4dd975.

    * tsp format

    * remove dotnet from tspconfig.yaml and add azure-sdk-for-net-track2 in readme

    * add sdk-suppressions.yaml

    * Update tspconfig.yaml

    * Update tspconfig.yaml

    * rename operationid

    * rename getScopingQuestions and move model reportBaseProperties to alias

    ---------

    Co-authored-by: Yanwen Liu <[email protected]>
    Co-authored-by: Mark Cowlishaw <[email protected]>
    Co-authored-by: Yuchao Yan <[email protected]>
    Co-authored-by: Alancere <[email protected]>
    Co-authored-by: Weidong Xu <[email protected]>

commit ad9955f
Author: Joanna-Yang-Art <[email protected]>
Date:   Mon Jun 3 15:57:55 2024 -0700

    Add new networking code owner (Azure#29281)

commit a58614a
Author: Libba Lawrence <[email protected]>
Date:   Mon Jun 3 12:44:29 2024 -0700

    [EG] System events reformat (Azure#28706)

    * refactor

    * updayrd

    * format

    * add apicenter

    * update new events

    * tsp format

    * new events

    * modelAsString for Media Union as False

    * tsp format

    * Revert "tsp format"

    This reverts commit 1a01cf8.

    * Revert "modelAsString for Media Union as False"

    This reverts commit 6b60581.

    * remove ReadOnly

    * rename resources

    * remove duplicate vault

    * remove Optional from Nullable Types part 1

    * add csharp to x-ms-client-names

    * typo

    * swagger typo

    * formatting

    * Client Name Overrides JS EG System Events

    * Adding in renames for Go

    * fix RecordingDurationMs casing

    * Fixing something that Libba refused to for like months now.

    * Removing SystemEvents from the constant names

    * Should be a number == float64.

    * Field name is labelOperator, not operator.

    (as shown here: https://github.com/Azure/azure-rest-api-specs/blob/0a8300f818c1df4018e2586540bed4c72c7c5375/specification/eventgrid/data-plane/Microsoft.Communication/stable/2018-01-01/AzureCommunicationServices.json#L2120)

    * Field is state, not selectorState:

    https://github.com/Azure/azure-rest-api-specs/blob/0a8300f818c1df4018e2586540bed4c72c7c5375/specification/eventgrid/data-plane/Microsoft.Communication/stable/2018-01-01/AzureCommunicationServices.json#L2171

    * More renames to bring us to par with what we had before.

    * Adding in some docs that were missing for unions.

    * format

    * fix warnigns

    * moving around clientNames

    * spellcheck

    * try to update csharp clientNames

    * tsp format

    * missing labelValue x-ms-client-name

    * format

    * nit typo

    * update csharp

    ---------

    Co-authored-by: Sarangan Rajamanickam <[email protected]>
    Co-authored-by: ripark <[email protected]>

commit 8713240
Author: Libba Lawrence <[email protected]>
Date:   Mon Jun 3 12:43:59 2024 -0700

    [EG] GA client.tsp updates (Azure#29208)

    * try this

    * ver

    * update

    * details

    * update

    * renew locks result rename

    * add new version - testing

    * remove diff

    * ga version

    * update

    * try alias

    * all operations mark as internal to allow for topic/sub customization

    * remove

    * tsp format

    * alias change

    * details

    * changes

    * after merge required regen

    * nit

    * try

    * tsp format

    * edits off of lang

    * only python

    * nit

    * Fixing some names for Go, based on Go arch feedback.

    * One more rename

    * Update specification/eventgrid/Azure.Messaging.EventGrid/client.tsp

    * fixing go diff

    * update

    * update internal

    ---------

    Co-authored-by: ripark <[email protected]>

commit bf97382
Author: ChenxiJiang333 <[email protected]>
Date:   Mon Jun 3 17:44:55 2024 +0800

    Update readme.python.md (Azure#29301)

commit cd47418
Author: Asaf Levi <[email protected]>
Date:   Mon Jun 3 10:28:33 2024 +0300

    Add Entra ID OAuthe2 token support (Azure#29032)

    * Add AAD OAuthe2 token support

    * EntraIdToken

    * Update specification/ai/HealthInsights/HealthInsights.OpenAPI/service.tsp

    Co-authored-by: catalinaperalta <[email protected]>

    * remove suppression

    * update spec after merge

    ---------

    Co-authored-by: koen-mertens <[email protected]>
    Co-authored-by: catalinaperalta <[email protected]>

commit 92a02c9
Author: Alex Matei (Microsoft) <[email protected]>
Date:   Fri May 31 19:39:07 2024 -0700

    Added Common Types, Managed Identity v6  (Azure#29155)

commit f4c6c86
Author: Mark Cowlishaw <[email protected]>
Date:   Fri May 31 16:42:11 2024 -0700

    Fix deprecated linter reference (Azure#29294)

commit 01d1832
Author: YunsongB <[email protected]>
Date:   Fri May 31 11:41:41 2024 -0600

    Fix spec error for OpenAI api ver 2024-05-01-preview; (Azure#29293)

    Co-authored-by: Yunsong Bai <[email protected]>

commit 5b4680d
Author: Jose Alvarez <[email protected]>
Date:   Fri May 31 18:46:46 2024 +0200

    Assistant SDK V2 changes (depending on the Assistant V1 PR) (Azure#29067)

    * initial commit for models in support of streaming Assistants calls

    * merge + pr feedback

    * [OpenAI] [Assistants] PR feedback (Azure#28786)

    * Adding streaming events and modified class visibilities

    * Represented the alias as a union to align better with the swagger and have a class generated

    * Adding chunk classes to be included on code emission

    * Update specification/ai/OpenAI.Assistants/streaming/events.tsp

    * Added usage models for run and runStep (Azure#28864)

    * Added usage models for run and runStep

    * Added added annotation

    * Added warning suppresion for nullable fields

    * Compiled with new models and unions

    * back ported everything to a past version. Extracted SubmitToolOutputsOptions model

    * re-compile

    * Removed toolresources for now and added warning supressions

    * Brought up to date the classes related to streaming for AssistantStreamEvent

    * Making filename mandatory uploadFile operation

    * Project compilation

    * Re-formated definitiones according to CI instructions

    * Added new service version

    * Figuring out error highlights in vscode

    * Added get method listVectorStore

    * extracted union

    * Added create vector store method

    * Adding method to get single vector store

    * Added update methods for vector store

    * Added deletion method for vector stores

    * Removed assistant specific file models and operations

    * Added operation for listing vector store files

    * Added create file for vector store method

    * Added the rest of the file operations

    * Re-structured files under vector_store

    * Reformated correctly

    * Added first operation for vector store file batch

    * Added file listing per vector store file batch

    * WIP: AssistantsApiResponseFormatOption generates as anyOf of instead of oneOf

    * corrected values for enum

    * Adjusted Assistant response object

    * Added browse azure tool call type and renamed retrieval to file_search

    * Adding models for createAssistantsOptions

    * Updated assistant update models

    * Added TruncationObject

    * Added tool_choice to run related objects

    * Added new fields to ThreadRun model

    * Added attachements and tool resources to thread and message related models

    * 2nd pass to thread and message related files

    * Renamed 'retrieva'->'file_search' added 'browse'

    * Removed deprecated file endpoints and add java customizations for code gen

    * Spellchecks

    * Added missing documentation

    * -clear

    * Renamed union

    * TSP validation check

    * Reverted nullability of fileName

    * re-compiled

    * Added new file purposes

    * Removed openapi v2 and v3 files generated with the placeholder version

    * reformating

    * Added AOAI fields for Files

    * Added missing tool_resource object to createThreadAndRunRequest

    * Updated docs and removed Browse tools for this release

    * Maded the stream events public to expose types and docs to users

    * Made stream events publics

    * PR feedback and solved one open comment left for UpdateThreadOptions

    * remove single-use options model, merge into route params directly

    * proactively add 2024-05-01-preview label

    * Removed model removed in upstream branch

    * Recompile

    * Removed 05_01 from service version enum ... for now

    * Restored example

    * Added string type to AssistantStreamEvent

    * tsp validation check

    * Duplicate doc annotation

    * Removed duplicate entries

    * Added documentation for API response formats

    * Applied formatter

    * Removed package and annotation usage causing issues in Java emitter

    * Made temperature and top_p nullable for assistant create request

    * Commented out linter rule breaking code emission

    * Corrected double dot in documentation

    * Restored linter rules for formater and adjusted definition of JSON polymorphic type

    * Cleaned up comment

    * Split out the string variants into their own union

    * tsp format

    * PR feedback

    ---------

    Co-authored-by: Travis Wilson <[email protected]>
    Co-authored-by: Travis Wilson <[email protected]>

commit 4328382
Author: zhejiao <[email protected]>
Date:   Fri May 31 07:22:49 2024 -0700

    Review request for Microsoft.HybridCompute to add version preview/2024-05-20-preview (Azure#29070)

    * Copy files from preview/2024-03-31-preview

    Copied the files in a separate commit.
    This allows reviewers to easily diff subsequent changes against the previous spec.

    * Update version to preview/2024-05-20-preview

    Updated the API version from preview/2024-03-31-preview to preview/2024-05-20-preview.

    * Added tag for 2024-05-20-preview in readme file

    * Add more SubscriptionStatus values, ErrorDetails, BillingEndDate and Hotpatch Management Properties

    * Make prettier happy

commit 061b617
Author: Akshit Goyal <[email protected]>
Date:   Fri May 31 07:20:59 2024 -0700

    Add NSP API to multiple services under Microsoft.Insights RP (Azure#28680)

    * Add API and examples for NSP in ScheduledQueryRules

    * Add API and examples for NSP in DataCollectionEndpoints

    * Minor fixes for the api specs for ScheduledQueryRules and DCE

    * Add NSP API for Action Groups

    * Add new API to README.md

    * Fix examples to include right param names

    * Fix styling errors

    * Include old version in default package tag

    * Fix Swagger LintDiff validation issues

    * Resolve resource name pattern restriction for configName in NSP

    * Fix typo in param name

    * Fix LintDiff warnings and errors

    * Update spec title

    * Update README with the correct package ver

    * Rever back to original NSP swagger model

    * Update README

    * Replace 200 with 202 for reconcile

    * Update reconcile examples with 202 response

    * Fix 202 response headers for reconcile

    * Update error object ref for LintDiff validation

    * Fix LintDiff Warnings: Update swagger to use v5 types

    * Fix LintDiff warnings

    * Fix LintDiff warnings

    * Fix Prettier check

    * Resolve comments and update Data models

    * Resolve merge conflicts for README

    * Fix README

    * Create sdk-suppressions.yaml

    * Refactor NSP definitions into a common file

    * Resolve merge conflicts

    * Refactor code to use NSP Common types

    * update API paths with nsp param name

    * Fix param declaration in paths and add parameter definition

    * Change str to int accross all API examples for accessRule ver property

    ---------

    Co-authored-by: Akshit Goyal <[email protected]>
    Co-authored-by: kazrael2119 <[email protected]>

commit 775b4ba
Author: mmorr-msft <[email protected]>
Date:   Fri May 31 07:02:17 2024 -0700

    Create Mircosoft.VerifiedId Resource Provider public preview (Azure#28933)

    * copy verifiedid from private

    * fix latest style rules

    * rerun validate

    * change key name

    * re-run local validation

    * update examples

    * manually fix generated docs

    * trying to make it pass validation, local validation won't run

    * maybe fixed?

    * fix lists?

commit bc06df2
Author: Saurabh Chugh <[email protected]>
Date:   Thu May 30 19:03:03 2024 -0700

    Getting rid of redundant credential resources in dotnet sdk (Azure#29093)

    Co-authored-by: Saurabh Chugh <[email protected]>
    Co-authored-by: Heng Lu <[email protected]>

commit 9582151
Author: Weidong Xu <[email protected]>
Date:   Fri May 31 06:46:37 2024 +0800

    radiologyinsights, tsp-config, java on final-type of LRO (Azure#29273)

    Co-authored-by: catalinaperalta <[email protected]>

commit dc27f9b
Author: jonathanserbent <[email protected]>
Date:   Thu May 30 15:09:34 2024 -0500

    Azure Search DataPlane 2024-07-01 (Azure#29058)

    * Copy over old spec

    * Update version to 07-01

    * Add feature spec changes

    * Update docs.microsoft.com to learn.microsoft.com

    * Use common error response instead of our own model

    * Make skillsetCount required

    * Add additional feature changes

    * update readme tags

    * Fix error in readme

    * Update Examples

    * Running Prettier

    * Running Prettier

    * Addition feature change

    * Applying Feedback

    * Apply feedback to update Description

    Co-authored-by: Alan Zimmer <[email protected]>

    * Applying feedback on vectorizerName description change

    Co-authored-by: Alan Zimmer <[email protected]>

    * Adding x-ms-client-name to RawVectorQuery

    ---------

    Co-authored-by: Jonathan Serbent <[email protected]>
    Co-authored-by: Alan Zimmer <[email protected]>

commit 51031c3
Author: qfai <[email protected]>
Date:   Thu May 30 22:13:12 2024 +0800

    Qfai developerhub microsoft.dev hub 2024 05 01 preview (Azure#29229)

    * add iac endpoints

    * change workflow v3 to v5

    * fix module validation error

    ---------

    Co-authored-by: qfai <[email protected]>

commit ce625c0
Author: Udit Sharma <[email protected]>
Date:   Thu May 30 07:12:36 2024 -0700

    Add TLS 1_3 support for storage (Azure#29175)

    * Add TLS 1_3 support for storage

    * Add support for account level cold access tier

    ---------

    Co-authored-by: Udit Sharma <[email protected]>

commit 7605afe
Author: ChenxiJiang333 <[email protected]>
Date:   Thu May 30 16:06:44 2024 +0800

    [mongocluster] update python config (Azure#29259)

    * update python config

    * java config

    ---------

    Co-authored-by: XiaofeiCao <[email protected]>

commit fba917f
Author: Jingshu918 <[email protected]>
Date:   Thu May 30 11:07:35 2024 +0800

    Add Credential Property In DynamicsCrm For New Feature (Azure#29238)

commit 34f8f3f
Author: Mike Harder <[email protected]>
Date:   Wed May 29 17:35:07 2024 -0700

    [TypeSpecValidation/LinterRuleset] Fail if deprecated rulesets detected (Azure#29270)

commit 19b6661
Author: Mike Harder <[email protected]>
Date:   Wed May 29 14:23:03 2024 -0700

    [TypeSpecValidation] Add tests for LinterRuleset (Azure#29267)

commit b692152
Author: Chandan Agrawal <[email protected]>
Date:   Thu May 30 02:49:44 2024 +0530

    Updating Swagger for new xlsAccountServiceMetada EnableExtendedGroups (Azure#29142)
@blueww blueww removed the request for review from JasonYang-MSFT June 26, 2024 02:43
@blueww blueww mentioned this pull request Jul 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blueww blueww blueww approved these changes

Assignees
No one assigned
Labels
ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review customer-reported Issues that are reported by GitHub users external to the Azure organization. ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@usharma6 @TimLovellSmith @HimanshuChhabra @blueww @gary-x-li @AzureRestAPISpecReview @razvanbadea-msft