From de892e3ee864beb1cb65247b513fe946d8bdf156 Mon Sep 17 00:00:00 2001 From: Mike Harder Date: Thu, 18 Jan 2024 23:05:48 +0000 Subject: [PATCH 1/2] [docs] Add to "Swagger LintDiff for TypeSpec" --- documentation/ci-fix.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/documentation/ci-fix.md b/documentation/ci-fix.md index 204d7347edf2..42dac5fcd46d 100644 --- a/documentation/ci-fix.md +++ b/documentation/ci-fix.md @@ -137,6 +137,10 @@ We believe this is a false positive: https://github.com/Azure/azure-openapi-vali We believe this is a false positive: https://github.com/Azure/azure-openapi-validator/issues/642. Until fixed, spec authors should **not** suppress the violations in `readme.md`, but rather have label `Approved-LintDiff` applied to their PR to ignore the errors. +### `@singleton` causes `EvenSegmentedPathForPutOperation` and `XmsPageableForListCalls` + +If `EvenSegmentedPathForPutOperation` and/or `XmsPageableForListCalls` are failing for OpenAPI generated from TypeSpec using `@singleton` (OpenAPI path ends with `/default`), we believe this is a false positive: https://github.com/Azure/azure-openapi-validator/issues/646. Until fixed, spec authors should **not** suppress the violations in `readme.md`, but rather have label `Approved-LintDiff` applied to their PR to ignore the errors. + ## Avocado ### Get help fixing Avocado validation failures From 007c0a6228eaed436f42be80bc4c93649bf9a413 Mon Sep 17 00:00:00 2001 From: Mike Harder Date: Tue, 23 Jan 2024 01:18:16 +0000 Subject: [PATCH 2/2] Fix bad merge --- documentation/ci-fix.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/documentation/ci-fix.md b/documentation/ci-fix.md index 5706b2d9342f..da861ae9d34b 100644 --- a/documentation/ci-fix.md +++ b/documentation/ci-fix.md @@ -173,10 +173,10 @@ If `EvenSegmentedPathForPutOperation` and/or `XmsPageableForListCalls` are faili ## `Swagger Avocado` -[!IMPORTANT] -`Swagger Avocado` check is not a blocking for merging your PR, even if it fails. -It is left to the discretion of the PR reviewer if the Avocado failure actually -needs to be addressed or suppressed. +>[!IMPORTANT] +> `Swagger Avocado` check is not a blocking for merging your PR, even if it fails. +> It is left to the discretion of the PR reviewer if the Avocado failure actually +> needs to be addressed or suppressed. ### Get help fixing Avocado validation failures