From a4dc52cfc89646fb4079063f4082a2f6564445cf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rafa=C5=82=20Mielowski?= Date: Wed, 3 May 2023 13:17:58 +0200 Subject: [PATCH 01/10] Add new tracing api --- .../2023-03-01-preview/apimgateways.json | 148 ++++++++++++++++++ .../2023-03-01-preview/definitions.json | 67 ++++++++ 2 files changed, 215 insertions(+) diff --git a/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/apimgateways.json b/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/apimgateways.json index b6e3526d57f8..7b6d4c9372ef 100644 --- a/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/apimgateways.json +++ b/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/apimgateways.json @@ -1318,6 +1318,154 @@ } } } + }, + "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ApiManagement/service/{serviceName}/gateways/{gatewayId}/invalidateDebugCredentials": { + "post": { + "tags": [ + "GatewayInvalidateDebugCredentials" + ], + "operationId": "Gateway_InvalidateDebugCredentials", + "description": "TODO", + "x-ms-examples": { + "ApiManagementGatewayInvalidateDebugCredentials": { + "$ref": "./examples/ApiManagementGatewayInvalidateDebugCredentials.json" + } + }, + "parameters": [ + { + "$ref": "../../../../../common-types/resource-management/v3/types.json#/parameters/SubscriptionIdParameter" + }, + { + "$ref": "../../../../../common-types/resource-management/v3/types.json#/parameters/ResourceGroupNameParameter" + }, + { + "$ref": "./apimanagement.json#/parameters/ServiceNameParameter" + }, + { + "$ref": "./apimanagement.json#/parameters/GatewayIdParameter" + }, + { + "$ref": "../../../../../common-types/resource-management/v3/types.json#/parameters/ApiVersionParameter" + } + ], + "responses": { + "204": { + "description": "TODO" + }, + "default": { + "description": "Error response describing why the operation failed.", + "schema": { + "$ref": "./apimanagement.json#/definitions/ErrorResponse" + } + } + } + }, + "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ApiManagement/service/{serviceName}/gateways/{gatewayId}/getDebugCredentials": { + "post": { + "tags": [ + "GatewayGetDebugCredentials" + ], + "operationId": "Gateway_GetDebugCredentials", + "description": "TODO", + "x-ms-examples": { + "ApiManagementGatewayGetDebugCredentials": { + "$ref": "./examples/ApiManagementGatewayGetDebugCredentials.json" + } + }, + "parameters": [ + { + "$ref": "../../../../../common-types/resource-management/v3/types.json#/parameters/SubscriptionIdParameter" + }, + { + "$ref": "../../../../../common-types/resource-management/v3/types.json#/parameters/ResourceGroupNameParameter" + }, + { + "$ref": "./apimanagement.json#/parameters/ServiceNameParameter" + }, + { + "$ref": "./apimanagement.json#/parameters/GatewayIdParameter" + }, + { + "$ref": "../../../../../common-types/resource-management/v3/types.json#/parameters/ApiVersionParameter" + }, + { + "name": "parameters", + "in": "body", + "required": true, + "schema": { + "$ref": "./definitions.json#/definitions/GatewayGetDebugCredentialsContract" + } + } + ], + "responses": { + "200": { + "description": "TODO", + "schema": { + "$ref": "./apimanagement.json#/definitions/GatewayDebugCredentialsContract" + } + }, + "default": { + "description": "Error response describing why the operation failed.", + "schema": { + "$ref": "./apimanagement.json#/definitions/ErrorResponse" + } + } + } + } + }, + "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ApiManagement/service/{serviceName}/gateways/{gatewayId}/getTrace": { + "post": { + "tags": [ + "GatewayGetTrace" + ], + "operationId": "Gateway_GetTrace", + "description": "TODO", + "x-ms-examples": { + "ApiManagementGatewayGetTrace": { + "$ref": "./examples/ApiManagementGatewayGetTrace.json" + } + }, + "parameters": [ + { + "$ref": "../../../../../common-types/resource-management/v3/types.json#/parameters/SubscriptionIdParameter" + }, + { + "$ref": "../../../../../common-types/resource-management/v3/types.json#/parameters/ResourceGroupNameParameter" + }, + { + "$ref": "./apimanagement.json#/parameters/ServiceNameParameter" + }, + { + "$ref": "./apimanagement.json#/parameters/GatewayIdParameter" + }, + { + "$ref": "../../../../../common-types/resource-management/v3/types.json#/parameters/ApiVersionParameter" + }, + { + "name": "parameters", + "in": "body", + "required": true, + "schema": { + "$ref": "./definitions.json#/definitions/GatewayGetTraceContract" + } + } + ], + "responses": { + "200": { + "description": "TODO", + "schema": { + "$ref": "./apimanagement.json#/definitions/GatewayTraceContract" + } + }, + "default": { + "description": "Error response describing why the operation failed.", + "schema": { + "$ref": "./apimanagement.json#/definitions/ErrorResponse" + } + } + } + } + } } }, "definitions": {}, diff --git a/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/definitions.json b/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/definitions.json index 14a9013c9c40..7898aef9e028 100644 --- a/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/definitions.json +++ b/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/definitions.json @@ -8761,6 +8761,73 @@ "productId" ], "description": "Tag-product link entity properties." + }, + "GatewayGetDebugCredentialsContract": { + "type": "object", + "properties": { + "credentialsExpireAfter": { + "type": "string", + "format": "duration", + "description": "After what period of time to make credentials expire." + }, + "purposes": { + "type": "array", + "description": "Purposes of debug credential.", + "items": { + "type": "string", + "description": "Purpose of debug credential.", + "enum": [ + "tracing" + ], + "x-ms-enum": { + "name": "GatewayGetDebugCredentialsContractPurpose", + "modelAsString": true, + "values": [ + { + "value": "tracing", + "description": "The tracing purpose." + } + ] + } + } + }, + "apiId": { + "type": "string", + "description": "Full resource Id of an API." + }, + "required": [ + "credentialsExpireAfter", + "purposes", + "apiId" + ] + }, + "description": "Get debug credentials properties." + }, + "GatewayDebugCredentialsContract": { + "type": "object", + "properties": { + "token":{ + "type": "string", + "description": "Gateway debug token." + } + }, + "description": "Gateway debug credentials." + }, + "GatewayGetTraceContract": { + "type": "object", + "properties": { + "traceId":{ + "type": "string", + "description": "Trace id." + } + }, + "description": "Get trace properties." + }, + "GatewayTraceContract": { + "type": "object", + "properties": {}, + "additionalProperties": true, + "description": "Trace collected in gateway" } }, "parameters": {} From 280eac8dc57bf3c1e116e6477ba410779a129df4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rafa=C5=82=20Mielowski?= Date: Wed, 3 May 2023 13:29:13 +0200 Subject: [PATCH 02/10] Remove TODOs descriptions --- .../preview/2023-03-01-preview/apimgateways.json | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/apimgateways.json b/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/apimgateways.json index 7b6d4c9372ef..4ab073690ae3 100644 --- a/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/apimgateways.json +++ b/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/apimgateways.json @@ -1325,7 +1325,7 @@ "GatewayInvalidateDebugCredentials" ], "operationId": "Gateway_InvalidateDebugCredentials", - "description": "TODO", + "description": "Action is invalidating all issued debug credentials.", "x-ms-examples": { "ApiManagementGatewayInvalidateDebugCredentials": { "$ref": "./examples/ApiManagementGatewayInvalidateDebugCredentials.json" @@ -1350,7 +1350,7 @@ ], "responses": { "204": { - "description": "TODO" + "description": "All debug credentials are now invalidated." }, "default": { "description": "Error response describing why the operation failed.", @@ -1366,7 +1366,7 @@ "GatewayGetDebugCredentials" ], "operationId": "Gateway_GetDebugCredentials", - "description": "TODO", + "description": "Create new debug credentials.", "x-ms-examples": { "ApiManagementGatewayGetDebugCredentials": { "$ref": "./examples/ApiManagementGatewayGetDebugCredentials.json" @@ -1399,7 +1399,7 @@ ], "responses": { "200": { - "description": "TODO", + "description": "The response body contains debug credentials to use in gateway.", "schema": { "$ref": "./apimanagement.json#/definitions/GatewayDebugCredentialsContract" } @@ -1419,7 +1419,7 @@ "GatewayGetTrace" ], "operationId": "Gateway_GetTrace", - "description": "TODO", + "description": "Fetches trace collected by gateway.", "x-ms-examples": { "ApiManagementGatewayGetTrace": { "$ref": "./examples/ApiManagementGatewayGetTrace.json" @@ -1452,7 +1452,7 @@ ], "responses": { "200": { - "description": "TODO", + "description": "The response body contains trace collected by gateway.", "schema": { "$ref": "./apimanagement.json#/definitions/GatewayTraceContract" } From 7efaeae5d9d3c7507672bfb330f0fd28aea6f915 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rafa=C5=82=20Mielowski?= Date: Wed, 3 May 2023 13:31:22 +0200 Subject: [PATCH 03/10] Improve descriptions --- .../preview/2023-03-01-preview/apimgateways.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/apimgateways.json b/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/apimgateways.json index 4ab073690ae3..23e779796f0a 100644 --- a/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/apimgateways.json +++ b/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/apimgateways.json @@ -1325,7 +1325,7 @@ "GatewayInvalidateDebugCredentials" ], "operationId": "Gateway_InvalidateDebugCredentials", - "description": "Action is invalidating all issued debug credentials.", + "description": "Action is invalidating all debug credentials issued for gateway.", "x-ms-examples": { "ApiManagementGatewayInvalidateDebugCredentials": { "$ref": "./examples/ApiManagementGatewayInvalidateDebugCredentials.json" @@ -1350,7 +1350,7 @@ ], "responses": { "204": { - "description": "All debug credentials are now invalidated." + "description": "All debug credentials for gateway are now invalidated." }, "default": { "description": "Error response describing why the operation failed.", @@ -1366,7 +1366,7 @@ "GatewayGetDebugCredentials" ], "operationId": "Gateway_GetDebugCredentials", - "description": "Create new debug credentials.", + "description": "Create new debug credentials for gateway.", "x-ms-examples": { "ApiManagementGatewayGetDebugCredentials": { "$ref": "./examples/ApiManagementGatewayGetDebugCredentials.json" From 96357cb0b33dfee7a32ee2f37a12d8ed4a54fd25 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rafa=C5=82=20Mielowski?= Date: Wed, 3 May 2023 13:45:31 +0200 Subject: [PATCH 04/10] Fix dot --- .../preview/2023-03-01-preview/definitions.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/definitions.json b/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/definitions.json index 7898aef9e028..d9736c81ad03 100644 --- a/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/definitions.json +++ b/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/definitions.json @@ -8827,7 +8827,7 @@ "type": "object", "properties": {}, "additionalProperties": true, - "description": "Trace collected in gateway" + "description": "Trace collected in gateway." } }, "parameters": {} From f600819dac99b1795246ff092a1256844fbc97a8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rafa=C5=82=20Mielowski?= Date: Thu, 4 May 2023 18:58:40 +0200 Subject: [PATCH 05/10] Add missing examples --- ...iManagementGatewayGetDebugCredentials.json | 21 ++++ .../ApiManagementGatewayGetTrace.json | 112 ++++++++++++++++++ ...mentGatewayInvalidateDebugCredentials.json | 12 ++ 3 files changed, 145 insertions(+) create mode 100644 specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/examples/ApiManagementGatewayGetDebugCredentials.json create mode 100644 specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/examples/ApiManagementGatewayGetTrace.json create mode 100644 specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/examples/ApiManagementGatewayInvalidateDebugCredentials.json diff --git a/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/examples/ApiManagementGatewayGetDebugCredentials.json b/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/examples/ApiManagementGatewayGetDebugCredentials.json new file mode 100644 index 000000000000..5aa09ab7a85f --- /dev/null +++ b/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/examples/ApiManagementGatewayGetDebugCredentials.json @@ -0,0 +1,21 @@ +{ + "parameters": { + "serviceName": "apimService1", + "resourceGroupName": "rg1", + "api-version": "2023-03-01-preview", + "subscriptionId": "subid", + "gatewayId": "gw1", + "parameters": { + "credentialsExpireAfter": "PT1H", + "apiId": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.ApiManagement/service/apimService1/apis/a1", + "purposes": ["tracing"] + } + }, + "responses": { + "200": { + "body": { + "token": "p=tracing&aid=a1&ex=20230504000000&sn=ZdfxSJoCsOJE0/XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX/8LchGl7gu/Q==" + } + } + } +} diff --git a/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/examples/ApiManagementGatewayGetTrace.json b/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/examples/ApiManagementGatewayGetTrace.json new file mode 100644 index 000000000000..af91e2e2271c --- /dev/null +++ b/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/examples/ApiManagementGatewayGetTrace.json @@ -0,0 +1,112 @@ +{ + "parameters": { + "serviceName": "apimService1", + "resourceGroupName": "rg1", + "api-version": "2023-03-01-preview", + "subscriptionId": "subid", + "gatewayId": "gw1", + "parameters": { + "traceId": "CrDvXXXXXXXXXXXXXVU3ZA2-1" + } + }, + "responses": { + "200": { + "body": { + "serviceName": "apimService1", + "traceId": "1e0447d4-XXXX-XXXX-XXXX-dbdb8098a0d3", + "traceEntries": { + "inbound": [ + { + "source": "api-inspector", + "timestamp": "2023-05-03T12:03:04.6899436Z", + "elapsed": "00:00:00.2983315", + "data": { + "request": { + "method": "GET", + "url": "https://proxy.msitesting.net/6452XXXXXXXXXXXX9c2facb1/64524dXXXXXXXXXXXX2facb3?subscription-key=117313e70XXXXXXXXXXXX38ba4658ca3", + "headers": [ + { + "name": "Host", + "value": "proxy.msitesting.net" + } + ] + } + } + }, + { + "source": "api-inspector", + "timestamp": "2023-05-03T12:03:04.6969650Z", + "elapsed": "00:00:00.3046329", + "data": { + "configuration": { + "api": { + "from": "/6452XXXXXXXXXXXX9c2facb1", + "to": { + "scheme": "http", + "host": "msitesting.net", + "port": 80, + "path": "/", + "queryString": "", + "query": {}, + "isDefaultPort": true + }, + "version": null, + "revision": "1" + }, + "operation": { + "method": "GET", + "uriTemplate": "/64524dXXXXXXXXXXXX2facb3" + }, + "user": "-", + "product": "-" + } + } + }, + { + "source": "cors", + "timestamp": "2023-05-03T12:03:04.9901631Z", + "elapsed": "00:00:00.5972352", + "data": "Origin header was missing or empty and the request was classified as not cross-domain. CORS policy was not applied." + }, + { + "source": "set-status", + "timestamp": "2023-05-03T12:03:05.0031202Z", + "elapsed": "00:00:00.6107970", + "data": { + "message": [ + "Response status code was set to 200", + "Response status reason was set to 'OK'" + ] + } + }, + { + "source": "return-response", + "timestamp": "2023-05-03T12:03:05.0086543Z", + "elapsed": "00:00:00.6164228", + "data": { + "message": "Return response was applied", + "response": { + "status": { + "code": "OK", + "reason": "OK" + }, + "headers": [] + } + } + } + ], + "outbound": [ + { + "source": "transfer-response", + "timestamp": "2023-05-03T12:03:05.0438287Z", + "elapsed": "00:00:00.6510195", + "data": { + "message": "Response has been sent to the caller in full" + } + } + ] + } + } + } + } +} diff --git a/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/examples/ApiManagementGatewayInvalidateDebugCredentials.json b/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/examples/ApiManagementGatewayInvalidateDebugCredentials.json new file mode 100644 index 000000000000..8c1eaf059732 --- /dev/null +++ b/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/examples/ApiManagementGatewayInvalidateDebugCredentials.json @@ -0,0 +1,12 @@ +{ + "parameters": { + "serviceName": "apimService1", + "resourceGroupName": "rg1", + "api-version": "2023-03-01-preview", + "subscriptionId": "subid", + "gatewayId": "gw1" + }, + "responses": { + "204": {} + } +} From c7ff6f1a2a2c6306ca67df6a2179f1ee772e533f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rafa=C5=82=20Mielowski?= Date: Fri, 5 May 2023 10:02:25 +0200 Subject: [PATCH 06/10] prettier fixes --- .../2023-03-01-preview/definitions.json | 4 +- ...iManagementGatewayGetDebugCredentials.json | 4 +- .../ApiManagementGatewayGetTrace.json | 176 +++++++++--------- 3 files changed, 93 insertions(+), 91 deletions(-) diff --git a/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/definitions.json b/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/definitions.json index d9736c81ad03..d0d39deb4ab4 100644 --- a/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/definitions.json +++ b/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/definitions.json @@ -8806,7 +8806,7 @@ "GatewayDebugCredentialsContract": { "type": "object", "properties": { - "token":{ + "token": { "type": "string", "description": "Gateway debug token." } @@ -8816,7 +8816,7 @@ "GatewayGetTraceContract": { "type": "object", "properties": { - "traceId":{ + "traceId": { "type": "string", "description": "Trace id." } diff --git a/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/examples/ApiManagementGatewayGetDebugCredentials.json b/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/examples/ApiManagementGatewayGetDebugCredentials.json index 5aa09ab7a85f..c9c7400e8d0d 100644 --- a/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/examples/ApiManagementGatewayGetDebugCredentials.json +++ b/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/examples/ApiManagementGatewayGetDebugCredentials.json @@ -8,7 +8,9 @@ "parameters": { "credentialsExpireAfter": "PT1H", "apiId": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.ApiManagement/service/apimService1/apis/a1", - "purposes": ["tracing"] + "purposes": [ + "tracing" + ] } }, "responses": { diff --git a/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/examples/ApiManagementGatewayGetTrace.json b/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/examples/ApiManagementGatewayGetTrace.json index af91e2e2271c..001f01dc3b1b 100644 --- a/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/examples/ApiManagementGatewayGetTrace.json +++ b/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/examples/ApiManagementGatewayGetTrace.json @@ -15,98 +15,98 @@ "serviceName": "apimService1", "traceId": "1e0447d4-XXXX-XXXX-XXXX-dbdb8098a0d3", "traceEntries": { - "inbound": [ - { - "source": "api-inspector", - "timestamp": "2023-05-03T12:03:04.6899436Z", - "elapsed": "00:00:00.2983315", - "data": { - "request": { - "method": "GET", - "url": "https://proxy.msitesting.net/6452XXXXXXXXXXXX9c2facb1/64524dXXXXXXXXXXXX2facb3?subscription-key=117313e70XXXXXXXXXXXX38ba4658ca3", - "headers": [ - { - "name": "Host", - "value": "proxy.msitesting.net" - } - ] - } - } - }, - { - "source": "api-inspector", - "timestamp": "2023-05-03T12:03:04.6969650Z", - "elapsed": "00:00:00.3046329", - "data": { - "configuration": { - "api": { - "from": "/6452XXXXXXXXXXXX9c2facb1", - "to": { - "scheme": "http", - "host": "msitesting.net", - "port": 80, - "path": "/", - "queryString": "", - "query": {}, - "isDefaultPort": true - }, - "version": null, - "revision": "1" - }, - "operation": { - "method": "GET", - "uriTemplate": "/64524dXXXXXXXXXXXX2facb3" - }, - "user": "-", - "product": "-" - } - } - }, - { - "source": "cors", - "timestamp": "2023-05-03T12:03:04.9901631Z", - "elapsed": "00:00:00.5972352", - "data": "Origin header was missing or empty and the request was classified as not cross-domain. CORS policy was not applied." - }, - { - "source": "set-status", - "timestamp": "2023-05-03T12:03:05.0031202Z", - "elapsed": "00:00:00.6107970", - "data": { - "message": [ - "Response status code was set to 200", - "Response status reason was set to 'OK'" - ] - } - }, - { - "source": "return-response", - "timestamp": "2023-05-03T12:03:05.0086543Z", - "elapsed": "00:00:00.6164228", - "data": { - "message": "Return response was applied", - "response": { - "status": { - "code": "OK", - "reason": "OK" - }, - "headers": [] - } + "inbound": [ + { + "source": "api-inspector", + "timestamp": "2023-05-03T12:03:04.6899436Z", + "elapsed": "00:00:00.2983315", + "data": { + "request": { + "method": "GET", + "url": "https://proxy.msitesting.net/6452XXXXXXXXXXXX9c2facb1/64524dXXXXXXXXXXXX2facb3?subscription-key=117313e70XXXXXXXXXXXX38ba4658ca3", + "headers": [ + { + "name": "Host", + "value": "proxy.msitesting.net" } + ] } - ], - "outbound": [ - { - "source": "transfer-response", - "timestamp": "2023-05-03T12:03:05.0438287Z", - "elapsed": "00:00:00.6510195", - "data": { - "message": "Response has been sent to the caller in full" - } + } + }, + { + "source": "api-inspector", + "timestamp": "2023-05-03T12:03:04.6969650Z", + "elapsed": "00:00:00.3046329", + "data": { + "configuration": { + "api": { + "from": "/6452XXXXXXXXXXXX9c2facb1", + "to": { + "scheme": "http", + "host": "msitesting.net", + "port": 80, + "path": "/", + "queryString": "", + "query": {}, + "isDefaultPort": true + }, + "version": null, + "revision": "1" + }, + "operation": { + "method": "GET", + "uriTemplate": "/64524dXXXXXXXXXXXX2facb3" + }, + "user": "-", + "product": "-" + } + } + }, + { + "source": "cors", + "timestamp": "2023-05-03T12:03:04.9901631Z", + "elapsed": "00:00:00.5972352", + "data": "Origin header was missing or empty and the request was classified as not cross-domain. CORS policy was not applied." + }, + { + "source": "set-status", + "timestamp": "2023-05-03T12:03:05.0031202Z", + "elapsed": "00:00:00.6107970", + "data": { + "message": [ + "Response status code was set to 200", + "Response status reason was set to 'OK'" + ] + } + }, + { + "source": "return-response", + "timestamp": "2023-05-03T12:03:05.0086543Z", + "elapsed": "00:00:00.6164228", + "data": { + "message": "Return response was applied", + "response": { + "status": { + "code": "OK", + "reason": "OK" + }, + "headers": [] } - ] + } + } + ], + "outbound": [ + { + "source": "transfer-response", + "timestamp": "2023-05-03T12:03:05.0438287Z", + "elapsed": "00:00:00.6510195", + "data": { + "message": "Response has been sent to the caller in full" + } + } + ] } - } + } } } } From bc53b69077e3fb778537c2745731e04473821d31 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rafa=C5=82=20Mielowski?= Date: Fri, 5 May 2023 10:37:57 +0200 Subject: [PATCH 07/10] Fix model and semantic problems --- .../2023-03-01-preview/apimgateways.json | 192 +++++++++--------- .../2023-03-01-preview/definitions.json | 12 +- 2 files changed, 102 insertions(+), 102 deletions(-) diff --git a/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/apimgateways.json b/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/apimgateways.json index 23e779796f0a..74b0a5e1f37d 100644 --- a/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/apimgateways.json +++ b/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/apimgateways.json @@ -1359,109 +1359,109 @@ } } } - }, - "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ApiManagement/service/{serviceName}/gateways/{gatewayId}/getDebugCredentials": { - "post": { - "tags": [ - "GatewayGetDebugCredentials" - ], - "operationId": "Gateway_GetDebugCredentials", - "description": "Create new debug credentials for gateway.", - "x-ms-examples": { - "ApiManagementGatewayGetDebugCredentials": { - "$ref": "./examples/ApiManagementGatewayGetDebugCredentials.json" - } + } + }, + "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ApiManagement/service/{serviceName}/gateways/{gatewayId}/getDebugCredentials": { + "post": { + "tags": [ + "GatewayGetDebugCredentials" + ], + "operationId": "Gateway_GetDebugCredentials", + "description": "Create new debug credentials for gateway.", + "x-ms-examples": { + "ApiManagementGatewayGetDebugCredentials": { + "$ref": "./examples/ApiManagementGatewayGetDebugCredentials.json" + } + }, + "parameters": [ + { + "$ref": "../../../../../common-types/resource-management/v3/types.json#/parameters/SubscriptionIdParameter" }, - "parameters": [ - { - "$ref": "../../../../../common-types/resource-management/v3/types.json#/parameters/SubscriptionIdParameter" - }, - { - "$ref": "../../../../../common-types/resource-management/v3/types.json#/parameters/ResourceGroupNameParameter" - }, - { - "$ref": "./apimanagement.json#/parameters/ServiceNameParameter" - }, - { - "$ref": "./apimanagement.json#/parameters/GatewayIdParameter" - }, - { - "$ref": "../../../../../common-types/resource-management/v3/types.json#/parameters/ApiVersionParameter" - }, - { - "name": "parameters", - "in": "body", - "required": true, - "schema": { - "$ref": "./definitions.json#/definitions/GatewayGetDebugCredentialsContract" - } + { + "$ref": "../../../../../common-types/resource-management/v3/types.json#/parameters/ResourceGroupNameParameter" + }, + { + "$ref": "./apimanagement.json#/parameters/ServiceNameParameter" + }, + { + "$ref": "./apimanagement.json#/parameters/GatewayIdParameter" + }, + { + "$ref": "../../../../../common-types/resource-management/v3/types.json#/parameters/ApiVersionParameter" + }, + { + "name": "parameters", + "in": "body", + "required": true, + "schema": { + "$ref": "./definitions.json#/definitions/GatewayGetDebugCredentialsContract" } - ], - "responses": { - "200": { - "description": "The response body contains debug credentials to use in gateway.", - "schema": { - "$ref": "./apimanagement.json#/definitions/GatewayDebugCredentialsContract" - } - }, - "default": { - "description": "Error response describing why the operation failed.", - "schema": { - "$ref": "./apimanagement.json#/definitions/ErrorResponse" - } + } + ], + "responses": { + "200": { + "description": "The response body contains debug credentials to use in gateway.", + "schema": { + "$ref": "./definitions.json#/definitions/GatewayDebugCredentialsContract" + } + }, + "default": { + "description": "Error response describing why the operation failed.", + "schema": { + "$ref": "./apimanagement.json#/definitions/ErrorResponse" } } } - }, - "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ApiManagement/service/{serviceName}/gateways/{gatewayId}/getTrace": { - "post": { - "tags": [ - "GatewayGetTrace" - ], - "operationId": "Gateway_GetTrace", - "description": "Fetches trace collected by gateway.", - "x-ms-examples": { - "ApiManagementGatewayGetTrace": { - "$ref": "./examples/ApiManagementGatewayGetTrace.json" - } + } + }, + "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ApiManagement/service/{serviceName}/gateways/{gatewayId}/getTrace": { + "post": { + "tags": [ + "GatewayGetTrace" + ], + "operationId": "Gateway_GetTrace", + "description": "Fetches trace collected by gateway.", + "x-ms-examples": { + "ApiManagementGatewayGetTrace": { + "$ref": "./examples/ApiManagementGatewayGetTrace.json" + } + }, + "parameters": [ + { + "$ref": "../../../../../common-types/resource-management/v3/types.json#/parameters/SubscriptionIdParameter" }, - "parameters": [ - { - "$ref": "../../../../../common-types/resource-management/v3/types.json#/parameters/SubscriptionIdParameter" - }, - { - "$ref": "../../../../../common-types/resource-management/v3/types.json#/parameters/ResourceGroupNameParameter" - }, - { - "$ref": "./apimanagement.json#/parameters/ServiceNameParameter" - }, - { - "$ref": "./apimanagement.json#/parameters/GatewayIdParameter" - }, - { - "$ref": "../../../../../common-types/resource-management/v3/types.json#/parameters/ApiVersionParameter" - }, - { - "name": "parameters", - "in": "body", - "required": true, - "schema": { - "$ref": "./definitions.json#/definitions/GatewayGetTraceContract" - } + { + "$ref": "../../../../../common-types/resource-management/v3/types.json#/parameters/ResourceGroupNameParameter" + }, + { + "$ref": "./apimanagement.json#/parameters/ServiceNameParameter" + }, + { + "$ref": "./apimanagement.json#/parameters/GatewayIdParameter" + }, + { + "$ref": "../../../../../common-types/resource-management/v3/types.json#/parameters/ApiVersionParameter" + }, + { + "name": "parameters", + "in": "body", + "required": true, + "schema": { + "$ref": "./definitions.json#/definitions/GatewayGetTraceContract" } - ], - "responses": { - "200": { - "description": "The response body contains trace collected by gateway.", - "schema": { - "$ref": "./apimanagement.json#/definitions/GatewayTraceContract" - } - }, - "default": { - "description": "Error response describing why the operation failed.", - "schema": { - "$ref": "./apimanagement.json#/definitions/ErrorResponse" - } + } + ], + "responses": { + "200": { + "description": "The response body contains trace collected by gateway.", + "schema": { + "$ref": "./definitions.json#/definitions/GatewayTraceContract" + } + }, + "default": { + "description": "Error response describing why the operation failed.", + "schema": { + "$ref": "./apimanagement.json#/definitions/ErrorResponse" } } } diff --git a/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/definitions.json b/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/definitions.json index d0d39deb4ab4..be7f559d6112 100644 --- a/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/definitions.json +++ b/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/definitions.json @@ -8794,13 +8794,13 @@ "apiId": { "type": "string", "description": "Full resource Id of an API." - }, - "required": [ - "credentialsExpireAfter", - "purposes", - "apiId" - ] + } }, + "required": [ + "credentialsExpireAfter", + "purposes", + "apiId" + ], "description": "Get debug credentials properties." }, "GatewayDebugCredentialsContract": { From 6d8e727f69b9ace5a1a22d6fe0b9a4851e5121ae Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rafa=C5=82=20Mielowski?= Date: Fri, 5 May 2023 18:29:12 +0200 Subject: [PATCH 08/10] Remove get prefix in post operations --- .../2023-03-01-preview/apimgateways.json | 24 +++++++++---------- .../2023-03-01-preview/definitions.json | 10 ++++---- ...agementGatewayCreateDebugCredentials.json} | 0 ...son => ApiManagementGatewayShowTrace.json} | 0 4 files changed, 17 insertions(+), 17 deletions(-) rename specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/examples/{ApiManagementGatewayGetDebugCredentials.json => ApiManagementGatewayCreateDebugCredentials.json} (100%) rename specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/examples/{ApiManagementGatewayGetTrace.json => ApiManagementGatewayShowTrace.json} (100%) diff --git a/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/apimgateways.json b/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/apimgateways.json index 74b0a5e1f37d..80662ab42adc 100644 --- a/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/apimgateways.json +++ b/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/apimgateways.json @@ -1361,16 +1361,16 @@ } } }, - "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ApiManagement/service/{serviceName}/gateways/{gatewayId}/getDebugCredentials": { + "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ApiManagement/service/{serviceName}/gateways/{gatewayId}/createDebugCredentials": { "post": { "tags": [ - "GatewayGetDebugCredentials" + "GatewayCreateDebugCredentials" ], - "operationId": "Gateway_GetDebugCredentials", + "operationId": "Gateway_CreateDebugCredentials", "description": "Create new debug credentials for gateway.", "x-ms-examples": { - "ApiManagementGatewayGetDebugCredentials": { - "$ref": "./examples/ApiManagementGatewayGetDebugCredentials.json" + "ApiManagementGatewayCreateDebugCredentials": { + "$ref": "./examples/ApiManagementGatewayCreateDebugCredentials.json" } }, "parameters": [ @@ -1394,7 +1394,7 @@ "in": "body", "required": true, "schema": { - "$ref": "./definitions.json#/definitions/GatewayGetDebugCredentialsContract" + "$ref": "./definitions.json#/definitions/GatewayCreateDebugCredentialsContract" } } ], @@ -1414,16 +1414,16 @@ } } }, - "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ApiManagement/service/{serviceName}/gateways/{gatewayId}/getTrace": { + "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ApiManagement/service/{serviceName}/gateways/{gatewayId}/showTrace": { "post": { "tags": [ - "GatewayGetTrace" + "GatewayShowTrace" ], - "operationId": "Gateway_GetTrace", + "operationId": "Gateway_ShowTrace", "description": "Fetches trace collected by gateway.", "x-ms-examples": { - "ApiManagementGatewayGetTrace": { - "$ref": "./examples/ApiManagementGatewayGetTrace.json" + "ApiManagementGatewayShowTrace": { + "$ref": "./examples/ApiManagementGatewayShowTrace.json" } }, "parameters": [ @@ -1447,7 +1447,7 @@ "in": "body", "required": true, "schema": { - "$ref": "./definitions.json#/definitions/GatewayGetTraceContract" + "$ref": "./definitions.json#/definitions/GatewayShowTraceContract" } } ], diff --git a/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/definitions.json b/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/definitions.json index be7f559d6112..80712f7b90d8 100644 --- a/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/definitions.json +++ b/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/definitions.json @@ -8762,7 +8762,7 @@ ], "description": "Tag-product link entity properties." }, - "GatewayGetDebugCredentialsContract": { + "GatewayCreateDebugCredentialsContract": { "type": "object", "properties": { "credentialsExpireAfter": { @@ -8780,7 +8780,7 @@ "tracing" ], "x-ms-enum": { - "name": "GatewayGetDebugCredentialsContractPurpose", + "name": "GatewayCreateDebugCredentialsContractPurpose", "modelAsString": true, "values": [ { @@ -8801,7 +8801,7 @@ "purposes", "apiId" ], - "description": "Get debug credentials properties." + "description": "Create debug credentials properties." }, "GatewayDebugCredentialsContract": { "type": "object", @@ -8813,7 +8813,7 @@ }, "description": "Gateway debug credentials." }, - "GatewayGetTraceContract": { + "GatewayShowTraceContract": { "type": "object", "properties": { "traceId": { @@ -8821,7 +8821,7 @@ "description": "Trace id." } }, - "description": "Get trace properties." + "description": "Show trace properties." }, "GatewayTraceContract": { "type": "object", diff --git a/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/examples/ApiManagementGatewayGetDebugCredentials.json b/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/examples/ApiManagementGatewayCreateDebugCredentials.json similarity index 100% rename from specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/examples/ApiManagementGatewayGetDebugCredentials.json rename to specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/examples/ApiManagementGatewayCreateDebugCredentials.json diff --git a/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/examples/ApiManagementGatewayGetTrace.json b/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/examples/ApiManagementGatewayShowTrace.json similarity index 100% rename from specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/examples/ApiManagementGatewayGetTrace.json rename to specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/examples/ApiManagementGatewayShowTrace.json From f33ca10a3f77e5977736977549c6bbea47810d32 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rafa=C5=82=20Mielowski?= Date: Wed, 10 May 2023 09:41:36 +0200 Subject: [PATCH 09/10] Use list prefix --- .../2023-03-01-preview/apimgateways.json | 24 +++++++++---------- .../2023-03-01-preview/definitions.json | 10 ++++---- ...anagementGatewayListDebugCredentials.json} | 0 ...son => ApiManagementGatewayListTrace.json} | 0 4 files changed, 17 insertions(+), 17 deletions(-) rename specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/examples/{ApiManagementGatewayCreateDebugCredentials.json => ApiManagementGatewayListDebugCredentials.json} (100%) rename specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/examples/{ApiManagementGatewayShowTrace.json => ApiManagementGatewayListTrace.json} (100%) diff --git a/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/apimgateways.json b/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/apimgateways.json index 80662ab42adc..c7a436533c45 100644 --- a/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/apimgateways.json +++ b/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/apimgateways.json @@ -1361,16 +1361,16 @@ } } }, - "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ApiManagement/service/{serviceName}/gateways/{gatewayId}/createDebugCredentials": { + "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ApiManagement/service/{serviceName}/gateways/{gatewayId}/listDebugCredentials": { "post": { "tags": [ - "GatewayCreateDebugCredentials" + "GatewayListDebugCredentials" ], - "operationId": "Gateway_CreateDebugCredentials", + "operationId": "Gateway_ListDebugCredentials", "description": "Create new debug credentials for gateway.", "x-ms-examples": { - "ApiManagementGatewayCreateDebugCredentials": { - "$ref": "./examples/ApiManagementGatewayCreateDebugCredentials.json" + "ApiManagementGatewayListDebugCredentials": { + "$ref": "./examples/ApiManagementGatewayListDebugCredentials.json" } }, "parameters": [ @@ -1394,7 +1394,7 @@ "in": "body", "required": true, "schema": { - "$ref": "./definitions.json#/definitions/GatewayCreateDebugCredentialsContract" + "$ref": "./definitions.json#/definitions/GatewayListDebugCredentialsContract" } } ], @@ -1414,16 +1414,16 @@ } } }, - "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ApiManagement/service/{serviceName}/gateways/{gatewayId}/showTrace": { + "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ApiManagement/service/{serviceName}/gateways/{gatewayId}/listTrace": { "post": { "tags": [ - "GatewayShowTrace" + "GatewayListTrace" ], - "operationId": "Gateway_ShowTrace", + "operationId": "Gateway_ListTrace", "description": "Fetches trace collected by gateway.", "x-ms-examples": { - "ApiManagementGatewayShowTrace": { - "$ref": "./examples/ApiManagementGatewayShowTrace.json" + "ApiManagementGatewayListTrace": { + "$ref": "./examples/ApiManagementGatewayListTrace.json" } }, "parameters": [ @@ -1447,7 +1447,7 @@ "in": "body", "required": true, "schema": { - "$ref": "./definitions.json#/definitions/GatewayShowTraceContract" + "$ref": "./definitions.json#/definitions/GatewayListTraceContract" } } ], diff --git a/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/definitions.json b/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/definitions.json index 80712f7b90d8..d2a9dc8bb15c 100644 --- a/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/definitions.json +++ b/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/definitions.json @@ -8762,7 +8762,7 @@ ], "description": "Tag-product link entity properties." }, - "GatewayCreateDebugCredentialsContract": { + "GatewayListDebugCredentialsContract": { "type": "object", "properties": { "credentialsExpireAfter": { @@ -8780,7 +8780,7 @@ "tracing" ], "x-ms-enum": { - "name": "GatewayCreateDebugCredentialsContractPurpose", + "name": "GatewayListDebugCredentialsContractPurpose", "modelAsString": true, "values": [ { @@ -8801,7 +8801,7 @@ "purposes", "apiId" ], - "description": "Create debug credentials properties." + "description": "List debug credentials properties." }, "GatewayDebugCredentialsContract": { "type": "object", @@ -8813,7 +8813,7 @@ }, "description": "Gateway debug credentials." }, - "GatewayShowTraceContract": { + "GatewayListTraceContract": { "type": "object", "properties": { "traceId": { @@ -8821,7 +8821,7 @@ "description": "Trace id." } }, - "description": "Show trace properties." + "description": "List trace properties." }, "GatewayTraceContract": { "type": "object", diff --git a/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/examples/ApiManagementGatewayCreateDebugCredentials.json b/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/examples/ApiManagementGatewayListDebugCredentials.json similarity index 100% rename from specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/examples/ApiManagementGatewayCreateDebugCredentials.json rename to specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/examples/ApiManagementGatewayListDebugCredentials.json diff --git a/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/examples/ApiManagementGatewayShowTrace.json b/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/examples/ApiManagementGatewayListTrace.json similarity index 100% rename from specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/examples/ApiManagementGatewayShowTrace.json rename to specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/examples/ApiManagementGatewayListTrace.json From 547cff4b064e4b8a13084a485c69b7c3a4460e1b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rafa=C5=82=20Mielowski?= Date: Thu, 11 May 2023 11:16:48 +0200 Subject: [PATCH 10/10] Fix PR comments --- .../preview/2023-03-01-preview/definitions.json | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/definitions.json b/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/definitions.json index d2a9dc8bb15c..851cb6b99c2d 100644 --- a/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/definitions.json +++ b/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/definitions.json @@ -8768,7 +8768,7 @@ "credentialsExpireAfter": { "type": "string", "format": "duration", - "description": "After what period of time to make credentials expire." + "description": "Credentials expiration in ISO8601 format. Maximum duration of the credentials is PT1H. When property is not specified, them value PT1H is used." }, "purposes": { "type": "array", @@ -8793,11 +8793,21 @@ }, "apiId": { "type": "string", + "format": "arm-id", + "x-ms-arm-id-details": { + "allowedResources": [ + { + "type": "Microsoft.ApiManagement/service/apis" + }, + { + "type": "Microsoft.ApiManagement/service/workspaces/apis" + } + ] + }, "description": "Full resource Id of an API." } }, "required": [ - "credentialsExpireAfter", "purposes", "apiId" ], @@ -8808,6 +8818,7 @@ "properties": { "token": { "type": "string", + "x-ms-secret": true, "description": "Gateway debug token." } },