Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate create & update scheduled action examples #22227

Closed
wants to merge 1 commit into from
Closed

Separate create & update scheduled action examples #22227

wants to merge 1 commit into from

Conversation

pednekarpraj
Copy link
Contributor

@pednekarpraj pednekarpraj commented Jan 18, 2023 •
edited by openapi-workflow-bot bot
Loading

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @pednekarpraj Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 18, 2023 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    compared swaggers (via Oad v0.10.4)] new version base version
    scheduledActions.json 2022-10-01(9de513c) 2022-10-01(main)
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v2.0.0) new version base version
    package-2022-10 package-2022-10(9de513c) package-2022-10(main)

    The following errors/warnings exist before current PR submission:

    Rule Message
    ❌ PathForPutOperation The path for 'put' operation must be under a subscription and resource group.
    Location: Microsoft.CostManagement/stable/2022-10-01/scheduledActions.json#L137
    ❌ RepeatedPathInfo The 'scope' already appears in the path, please don't repeat it in the request body.
    Location: Microsoft.CostManagement/stable/2022-10-01/scheduledActions.json#L287
    ❌ TopLevelResourcesListBySubscription The top-level resource 'ScheduledAction' does not have list by subscription operation, please add it.
    Location: Microsoft.CostManagement/stable/2022-10-01/scheduledActions.json#L680
    ⚠️ PostOperationIdContainsUrlVerb OperationId should contain the verb: 'execute' in:'ScheduledActions_Run'. Consider updating the operationId
    Location: Microsoft.CostManagement/stable/2022-10-01/scheduledActions.json#L413
    ⚠️ PostOperationIdContainsUrlVerb OperationId should contain the verb: 'execute' in:'ScheduledActions_RunByScope'. Consider updating the operationId
    Location: Microsoft.CostManagement/stable/2022-10-01/scheduledActions.json#L446
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

    API Test is not triggered due to precheck failure. Check pipeline log for details.

    ️️✔️~[Staging] SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️~[Staging] CadlAPIView succeeded [Detail] [Expand]
    ️❌ModelValidation: 9 Errors, 0 Warnings failed [Detail]
    Rule Message
    ❌ RESPONSE_STATUS_CODE_NOT_IN_EXAMPLE Following response status codes 200 for operation ScheduledActions_CreateOrUpdate were present in the swagger spec, however they were not present in x-ms-examples. Please provide them.
    Url: Microsoft.CostManagement/stable/2022-10-01/scheduledActions.json#L170:18
    ExampleUrl: 2022-10-01/examples/scheduledActions/scheduledAction-create-private.json#L34:16
    ❌ READONLY_PROPERTY_NOT_ALLOWED_IN_REQUEST ReadOnly property "eTag" cannot be sent in the request
    Url: Microsoft.CostManagement/stable/2022-10-01/scheduledActions.json#L658:17
    ExampleUrl: 2022-10-01/examples/scheduledActions/scheduledAction-update-private.json#L5:24
    ❌ RESPONSE_STATUS_CODE_NOT_IN_EXAMPLE Following response status codes 201 for operation ScheduledActions_CreateOrUpdate were present in the swagger spec, however they were not present in x-ms-examples. Please provide them.
    Url: Microsoft.CostManagement/stable/2022-10-01/scheduledActions.json#L176:18
    ExampleUrl: 2022-10-01/examples/scheduledActions/scheduledAction-update-private.json#L35:16
    ❌ RESPONSE_STATUS_CODE_NOT_IN_EXAMPLE Following response status codes 200 for operation ScheduledActions_CreateOrUpdateByScope were present in the swagger spec, however they were not present in x-ms-examples. Please provide them.
    Url: Microsoft.CostManagement/stable/2022-10-01/scheduledActions.json#L307:18
    ExampleUrl: 2022-10-01/examples/scheduledActions/scheduledAction-create-shared.json#L40:16
    ❌ READONLY_PROPERTY_NOT_ALLOWED_IN_REQUEST ReadOnly property "eTag" cannot be sent in the request
    Url: Microsoft.CostManagement/stable/2022-10-01/scheduledActions.json#L658:17
    ExampleUrl: 2022-10-01/examples/scheduledActions/scheduledAction-update-shared.json#L6:24
    ❌ RESPONSE_STATUS_CODE_NOT_IN_EXAMPLE Following response status codes 201 for operation ScheduledActions_CreateOrUpdateByScope were present in the swagger spec, however they were not present in x-ms-examples. Please provide them.
    Url: Microsoft.CostManagement/stable/2022-10-01/scheduledActions.json#L313:18
    ExampleUrl: 2022-10-01/examples/scheduledActions/scheduledAction-update-shared.json#L41:16
    ❌ RESPONSE_STATUS_CODE_NOT_IN_EXAMPLE Following response status codes 200 for operation ScheduledActions_CreateOrUpdateByScope were present in the swagger spec, however they were not present in x-ms-examples. Please provide them.
    Url: Microsoft.CostManagement/stable/2022-10-01/scheduledActions.json#L307:18
    ExampleUrl: 2022-10-01/examples/scheduledActions/scheduledAction-insightAlert-create-shared.json#L27:16
    ❌ READONLY_PROPERTY_NOT_ALLOWED_IN_REQUEST ReadOnly property "eTag" cannot be sent in the request
    Url: Microsoft.CostManagement/stable/2022-10-01/scheduledActions.json#L658:17
    ExampleUrl: 2022-10-01/examples/scheduledActions/scheduledAction-insightAlert-update-shared.json#L6:24
    ❌ RESPONSE_STATUS_CODE_NOT_IN_EXAMPLE Following response status codes 201 for operation ScheduledActions_CreateOrUpdateByScope were present in the swagger spec, however they were not present in x-ms-examples. Please provide them.
    Url: Microsoft.CostManagement/stable/2022-10-01/scheduledActions.json#L313:18
    ExampleUrl: 2022-10-01/examples/scheduledActions/scheduledAction-insightAlert-update-shared.json#L28:16
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand] 
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand] 
    Validation passes for CadlValidation.
    ️️✔️PR Summary succeeded [Detail] [Expand] 
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 18, 2023 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    ❌azure-sdk-for-go - sdk/resourcemanager/costmanagement/armcostmanagement - 2.0.0
    +	Const `QueryColumnTypeTag` from type alias `QueryColumnType` has been removed
+	Type alias `ReportConfigColumnType` has been removed
+	Type of `AlertPropertiesDetails.MeterFilter` has been changed from `[]interface{}` to `[]any`
+	Type of `AlertPropertiesDetails.ResourceFilter` has been changed from `[]interface{}` to `[]any`
+	Type of `AlertPropertiesDetails.ResourceGroupFilter` has been changed from `[]interface{}` to `[]any`
+	Type of `AlertPropertiesDetails.TagFilter` has been changed from `interface{}` to `any`
+	Type of `QueryProperties.Rows` has been changed from `[][]interface{}` to `[][]any`
+	Type of `ReportConfigGrouping.Type` has been changed from `*ReportConfigColumnType` to `*QueryColumnType`
    ️❌ azure-sdk-for-net failed [Detail]
    • ❌Code Generator Failed [Logs] Generate from 1d9bf6880735987cf65df9cda79b7714b0919df7. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-6.0
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/cost-management/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
    • ❌Microsoft.Azure.Management.CostManagement [View full logs]  [Preview SDK Changes] 
      cmderr	[msbuild] The command could not be loaded, possibly because:
cmderr	[msbuild]   * You intended to execute a .NET application:
cmderr	[msbuild]       The application 'msbuild' does not exist.
cmderr	[msbuild]   * You intended to execute a .NET SDK command:
cmderr	[msbuild]       A compatible .NET SDK was not found.
cmderr	[msbuild] Requested SDK version: 7.0.101
cmderr	[msbuild] global.json file: /mnt/vss/_work/1/s/azure-sdk-for-net/global.json
cmderr	[msbuild] Installed SDKs:
cmderr	[msbuild] Install the [7.0.101] .NET SDK or update [/mnt/vss/_work/1/s/azure-sdk-for-net/global.json] to match an installed SDK.
cmderr	[msbuild] Learn about SDK resolution:
cmderr	[msbuild] https://aka.ms/dotnet/sdk-not-found
error	Script return with result [failed] code [145] signal [null] cwd [azure-sdk-for-net]: dotnet
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 1d9bf6880735987cf65df9cda79b7714b0919df7. SDK Automation 14.0.0 
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/costmanagement/armcostmanagement [View full logs]  [Preview SDK Changes] Breaking Change Detected
      Only show 120 items here, please refer to log for details.
      info	[Changelog] - New type alias `CostDetailsMetricType` with values `CostDetailsMetricTypeActualCostCostDetailsMetricType`, `CostDetailsMetricTypeAmortizedCostCostDetailsMetricType`
info	[Changelog] - New type alias `CostDetailsStatusType` with values `CostDetailsStatusTypeCompletedCostDetailsStatusType`, `CostDetailsStatusTypeFailedCostDetailsStatusType`, `CostDetailsStatusTypeNoDataFoundCostDetailsStatusType`
info	[Changelog] - New type alias `CreatedByType` with values `CreatedByTypeApplication`, `CreatedByTypeKey`, `CreatedByTypeManagedIdentity`, `CreatedByTypeUser`
info	[Changelog] - New type alias `DaysOfWeek` with values `DaysOfWeekFriday`, `DaysOfWeekMonday`, `DaysOfWeekSaturday`, `DaysOfWeekSunday`, `DaysOfWeekThursday`, `DaysOfWeekTuesday`, `DaysOfWeekWednesday`
info	[Changelog] - New type alias `FileFormat` with values `FileFormatCSV`
info	[Changelog] - New type alias `ForecastOperatorType` with values `ForecastOperatorTypeIn`
info	[Changelog] - New type alias `ForecastTimeframe` with values `ForecastTimeframeCustom`
info	[Changelog] - New type alias `FunctionName` with values `FunctionNameCost`, `FunctionNameCostUSD`, `FunctionNamePreTaxCost`, `FunctionNamePreTaxCostUSD`
info	[Changelog] - New type alias `Grain` with values `GrainDaily`, `GrainHourly`, `GrainMonthly`
info	[Changelog] - New type alias `GrainParameter` with values `GrainParameterDaily`, `GrainParameterHourly`, `GrainParameterMonthly`
info	[Changelog] - New type alias `LookBackPeriod` with values `LookBackPeriodLast30Days`, `LookBackPeriodLast60Days`, `LookBackPeriodLast7Days`
info	[Changelog] - New type alias `Origin` with values `OriginSystem`, `OriginUser`, `OriginUserSystem`
info	[Changelog] - New type alias `ScheduleFrequency` with values `ScheduleFrequencyDaily`, `ScheduleFrequencyMonthly`, `ScheduleFrequencyWeekly`
info	[Changelog] - New type alias `ScheduledActionKind` with values `ScheduledActionKindEmail`, `ScheduledActionKindInsightAlert`
info	[Changelog] - New type alias `ScheduledActionStatus` with values `ScheduledActionStatusDisabled`, `ScheduledActionStatusEnabled`, `ScheduledActionStatusExpired`
info	[Changelog] - New type alias `Scope` with values `ScopeShared`, `ScopeSingle`
info	[Changelog] - New type alias `Term` with values `TermP1Y`, `TermP3Y`
info	[Changelog] - New type alias `WeeksOfMonth` with values `WeeksOfMonthFirst`, `WeeksOfMonthFourth`, `WeeksOfMonthLast`, `WeeksOfMonthSecond`, `WeeksOfMonthThird`
info	[Changelog] - New function `*BenefitRecommendationProperties.GetBenefitRecommendationProperties() *BenefitRecommendationProperties`
info	[Changelog] - New function `NewBenefitRecommendationsClient(azcore.TokenCredential, *arm.ClientOptions) (*BenefitRecommendationsClient, error)`
info	[Changelog] - New function `*BenefitRecommendationsClient.NewListPager(string, *BenefitRecommendationsClientListOptions) *runtime.Pager[BenefitRecommendationsClientListResponse]`
info	[Changelog] - New function `NewBenefitUtilizationSummariesClient(azcore.TokenCredential, *arm.ClientOptions) (*BenefitUtilizationSummariesClient, error)`
info	[Changelog] - New function `*BenefitUtilizationSummariesClient.NewListByBillingAccountIDPager(string, *BenefitUtilizationSummariesClientListByBillingAccountIDOptions) *runtime.Pager[BenefitUtilizationSummariesClientListByBillingAccountIDResponse]`
info	[Changelog] - New function `*BenefitUtilizationSummariesClient.NewListByBillingProfileIDPager(string, string, *BenefitUtilizationSummariesClientListByBillingProfileIDOptions) *runtime.Pager[BenefitUtilizationSummariesClientListByBillingProfileIDResponse]`
info	[Changelog] - New function `*BenefitUtilizationSummariesClient.NewListBySavingsPlanIDPager(string, string, *BenefitUtilizationSummariesClientListBySavingsPlanIDOptions) *runtime.Pager[BenefitUtilizationSummariesClientListBySavingsPlanIDResponse]`
info	[Changelog] - New function `*BenefitUtilizationSummariesClient.NewListBySavingsPlanOrderPager(string, *BenefitUtilizationSummariesClientListBySavingsPlanOrderOptions) *runtime.Pager[BenefitUtilizationSummariesClientListBySavingsPlanOrderResponse]`
info	[Changelog] - New function `*BenefitUtilizationSummary.GetBenefitUtilizationSummary() *BenefitUtilizationSummary`
info	[Changelog] - New function `NewGenerateCostDetailsReportClient(azcore.TokenCredential, *arm.ClientOptions) (*GenerateCostDetailsReportClient, error)`
info	[Changelog] - New function `*GenerateCostDetailsReportClient.BeginCreateOperation(context.Context, string, GenerateCostDetailsReportRequestDefinition, *GenerateCostDetailsReportClientBeginCreateOperationOptions) (*runtime.Poller[GenerateCostDetailsReportClientCreateOperationResponse], error)`
info	[Changelog] - New function `*GenerateCostDetailsReportClient.BeginGetOperationResults(context.Context, string, string, *GenerateCostDetailsReportClientBeginGetOperationResultsOptions) (*runtime.Poller[GenerateCostDetailsReportClientGetOperationResultsResponse], error)`
info	[Changelog] - New function `*IncludedQuantityUtilizationSummary.GetBenefitUtilizationSummary() *BenefitUtilizationSummary`
info	[Changelog] - New function `NewPriceSheetClient(azcore.TokenCredential, *arm.ClientOptions) (*PriceSheetClient, error)`
info	[Changelog] - New function `*PriceSheetClient.BeginDownload(context.Context, string, string, string, *PriceSheetClientBeginDownloadOptions) (*runtime.Poller[PriceSheetClientDownloadResponse], error)`
info	[Changelog] - New function `*PriceSheetClient.BeginDownloadByBillingProfile(context.Context, string, string, *PriceSheetClientBeginDownloadByBillingProfileOptions) (*runtime.Poller[PriceSheetClientDownloadByBillingProfileResponse], error)`
info	[Changelog] - New function `*SavingsPlanUtilizationSummary.GetBenefitUtilizationSummary() *BenefitUtilizationSummary`
info	[Changelog] - New function `NewScheduledActionsClient(azcore.TokenCredential, *arm.ClientOptions) (*ScheduledActionsClient, error)`
info	[Changelog] - New function `*ScheduledActionsClient.CheckNameAvailability(context.Context, CheckNameAvailabilityRequest, *ScheduledActionsClientCheckNameAvailabilityOptions) (ScheduledActionsClientCheckNameAvailabilityResponse, error)`
info	[Changelog] - New function `*ScheduledActionsClient.CheckNameAvailabilityByScope(context.Context, string, CheckNameAvailabilityRequest, *ScheduledActionsClientCheckNameAvailabilityByScopeOptions) (ScheduledActionsClientCheckNameAvailabilityByScopeResponse, error)`
info	[Changelog] - New function `*ScheduledActionsClient.CreateOrUpdate(context.Context, string, ScheduledAction, *ScheduledActionsClientCreateOrUpdateOptions) (ScheduledActionsClientCreateOrUpdateResponse, error)`
info	[Changelog] - New function `*ScheduledActionsClient.CreateOrUpdateByScope(context.Context, string, string, ScheduledAction, *ScheduledActionsClientCreateOrUpdateByScopeOptions) (ScheduledActionsClientCreateOrUpdateByScopeResponse, error)`
info	[Changelog] - New function `*ScheduledActionsClient.Delete(context.Context, string, *ScheduledActionsClientDeleteOptions) (ScheduledActionsClientDeleteResponse, error)`
info	[Changelog] - New function `*ScheduledActionsClient.DeleteByScope(context.Context, string, string, *ScheduledActionsClientDeleteByScopeOptions) (ScheduledActionsClientDeleteByScopeResponse, error)`
info	[Changelog] - New function `*ScheduledActionsClient.Get(context.Context, string, *ScheduledActionsClientGetOptions) (ScheduledActionsClientGetResponse, error)`
info	[Changelog] - New function `*ScheduledActionsClient.GetByScope(context.Context, string, string, *ScheduledActionsClientGetByScopeOptions) (ScheduledActionsClientGetByScopeResponse, error)`
info	[Changelog] - New function `*ScheduledActionsClient.NewListByScopePager(string, *ScheduledActionsClientListByScopeOptions) *runtime.Pager[ScheduledActionsClientListByScopeResponse]`
info	[Changelog] - New function `*ScheduledActionsClient.NewListPager(*ScheduledActionsClientListOptions) *runtime.Pager[ScheduledActionsClientListResponse]`
info	[Changelog] - New function `*ScheduledActionsClient.Run(context.Context, string, *ScheduledActionsClientRunOptions) (ScheduledActionsClientRunResponse, error)`
info	[Changelog] - New function `*ScheduledActionsClient.RunByScope(context.Context, string, string, *ScheduledActionsClientRunByScopeOptions) (ScheduledActionsClientRunByScopeResponse, error)`
info	[Changelog] - New function `*SharedScopeBenefitRecommendationProperties.GetBenefitRecommendationProperties() *BenefitRecommendationProperties`
info	[Changelog] - New function `*SingleScopeBenefitRecommendationProperties.GetBenefitRecommendationProperties() *BenefitRecommendationProperties`
info	[Changelog] - New struct `AllSavingsBenefitDetails`
info	[Changelog] - New struct `AllSavingsList`
info	[Changelog] - New struct `BenefitRecommendationModel`
info	[Changelog] - New struct `BenefitRecommendationsClient`
info	[Changelog] - New struct `BenefitRecommendationsClientListResponse`
info	[Changelog] - New struct `BenefitRecommendationsListResult`
info	[Changelog] - New struct `BenefitResource`
info	[Changelog] - New struct `BenefitUtilizationSummariesClient`
info	[Changelog] - New struct `BenefitUtilizationSummariesClientListByBillingAccountIDResponse`
info	[Changelog] - New struct `BenefitUtilizationSummariesClientListByBillingProfileIDResponse`
info	[Changelog] - New struct `BenefitUtilizationSummariesClientListBySavingsPlanIDResponse`
info	[Changelog] - New struct `BenefitUtilizationSummariesClientListBySavingsPlanOrderResponse`
info	[Changelog] - New struct `BenefitUtilizationSummariesListResult`
info	[Changelog] - New struct `BenefitUtilizationSummaryProperties`
info	[Changelog] - New struct `BlobInfo`
info	[Changelog] - New struct `CheckNameAvailabilityRequest`
info	[Changelog] - New struct `CheckNameAvailabilityResponse`
info	[Changelog] - New struct `CostDetailsOperationResults`
info	[Changelog] - New struct `CostDetailsTimePeriod`
info	[Changelog] - New struct `ErrorDetailsWithNestedDetails`
info	[Changelog] - New struct `ErrorResponseWithNestedDetails`
info	[Changelog] - New struct `ExportRun`
info	[Changelog] - New struct `ExportRunProperties`
info	[Changelog] - New struct `FileDestination`
info	[Changelog] - New struct `ForecastAggregation`
info	[Changelog] - New struct `ForecastColumn`
info	[Changelog] - New struct `ForecastComparisonExpression`
info	[Changelog] - New struct `ForecastDatasetConfiguration`
info	[Changelog] - New struct `ForecastFilter`
info	[Changelog] - New struct `ForecastProperties`
info	[Changelog] - New struct `ForecastResult`
info	[Changelog] - New struct `ForecastTimePeriod`
info	[Changelog] - New struct `GenerateCostDetailsReportClient`
info	[Changelog] - New struct `GenerateCostDetailsReportClientCreateOperationResponse`
info	[Changelog] - New struct `GenerateCostDetailsReportClientGetOperationResultsResponse`
info	[Changelog] - New struct `GenerateCostDetailsReportErrorResponse`
info	[Changelog] - New struct `GenerateCostDetailsReportRequestDefinition`
info	[Changelog] - New struct `IncludedQuantityUtilizationSummary`
info	[Changelog] - New struct `IncludedQuantityUtilizationSummaryProperties`
info	[Changelog] - New struct `NotificationProperties`
info	[Changelog] - New struct `OperationForCostManagement`
info	[Changelog] - New struct `PriceSheetClient`
info	[Changelog] - New struct `PriceSheetClientDownloadByBillingProfileResponse`
info	[Changelog] - New struct `PriceSheetClientDownloadResponse`
info	[Changelog] - New struct `ProxyResourceForCostManagement`
info	[Changelog] - New struct `RecommendationUsageDetails`
info	[Changelog] - New struct `ReportManifest`
info	[Changelog] - New struct `RequestContext`
info	[Changelog] - New struct `ResourceForCostManagement`
info	[Changelog] - New struct `SavingsPlanUtilizationSummary`
info	[Changelog] - New struct `SavingsPlanUtilizationSummaryProperties`
info	[Changelog] - New struct `ScheduleProperties`
info	[Changelog] - New struct `ScheduledAction`
info	[Changelog] - New struct `ScheduledActionListResult`
info	[Changelog] - New struct `ScheduledActionProperties`
info	[Changelog] - New struct `ScheduledActionProxyResource`
info	[Changelog] - New struct `ScheduledActionsClient`
info	[Changelog] - New struct `ScheduledActionsClientListByScopeResponse`
info	[Changelog] - New struct `ScheduledActionsClientListResponse`
info	[Changelog] - New struct `SharedScopeBenefitRecommendationProperties`
info	[Changelog] - New struct `SingleScopeBenefitRecommendationProperties`
info	[Changelog] - New struct `SystemData`
info	[Changelog] - New field `ExpiryTime` in struct `DownloadURL`
info	[Changelog] - New anonymous field `ForecastResult` in struct `ForecastClientExternalCloudProviderUsageResponse`
info	[Changelog] - New anonymous field `ForecastResult` in struct `ForecastClientUsageResponse`
info	[Changelog] - New field `ActionType` in struct `Operation`
info	[Changelog] - New field `IsDataAction` in struct `Operation`
info	[Changelog] - New field `Origin` in struct `Operation`
info	[Changelog]
info	[Changelog] Total 20 breaking change(s), 244 additive change(s).
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs] Generate from 1d9bf6880735987cf65df9cda79b7714b0919df7. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New major version of npm available! 8.19.2 -> 9.3.1
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.3.1>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-costmanagement [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Added operation group BenefitRecommendationsOperations
info	[Changelog]   - Added operation group BenefitUtilizationSummariesOperations
info	[Changelog]   - Added operation group GenerateCostDetailsReportOperations
info	[Changelog]   - Added operation group GenerateDetailedCostReportOperationResultsOperations
info	[Changelog]   - Added operation group GenerateDetailedCostReportOperationStatusOperations
info	[Changelog]   - Added operation group GenerateDetailedCostReportOperations
info	[Changelog]   - Added operation group PriceSheetOperations
info	[Changelog]   - Added operation group ScheduledActionsOperations
info	[Changelog]   - Model Alert has a new parameter e_tag
info	[Changelog]   - Model AlertPropertiesDetails has a new parameter company_name
info	[Changelog]   - Model AlertPropertiesDetails has a new parameter department_name
info	[Changelog]   - Model AlertPropertiesDetails has a new parameter enrollment_end_date
info	[Changelog]   - Model AlertPropertiesDetails has a new parameter enrollment_number
info	[Changelog]   - Model AlertPropertiesDetails has a new parameter enrollment_start_date
info	[Changelog]   - Model AlertPropertiesDetails has a new parameter invoicing_threshold
info	[Changelog]   - Model CommonExportProperties has a new parameter next_run_time_estimate
info	[Changelog]   - Model CommonExportProperties has a new parameter partition_data
info	[Changelog]   - Model CommonExportProperties has a new parameter run_history
info	[Changelog]   - Model Dimension has a new parameter e_tag
info	[Changelog]   - Model Dimension has a new parameter location
info	[Changelog]   - Model Dimension has a new parameter sku
info	[Changelog]   - Model Export has a new parameter next_run_time_estimate
info	[Changelog]   - Model Export has a new parameter partition_data
info	[Changelog]   - Model Export has a new parameter run_history
info	[Changelog]   - Model ExportDeliveryDestination has a new parameter sas_token
info	[Changelog]   - Model ExportDeliveryDestination has a new parameter storage_account
info	[Changelog]   - Model ExportProperties has a new parameter next_run_time_estimate
info	[Changelog]   - Model ExportProperties has a new parameter partition_data
info	[Changelog]   - Model ExportProperties has a new parameter run_history
info	[Changelog]   - Model Operation has a new parameter action_type
info	[Changelog]   - Model Operation has a new parameter is_data_action
info	[Changelog]   - Model Operation has a new parameter origin
info	[Changelog]   - Model OperationDisplay has a new parameter description
info	[Changelog]   - Operation ExportsOperations.get has a new optional parameter expand
info	[Changelog]   - Operation ExportsOperations.list has a new optional parameter expand
info	[Changelog]
info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog]   - Model Alert no longer has parameter tags
info	[Changelog]   - Model ProxyResource no longer has parameter e_tag
info	[Changelog]   - Model ReportConfigFilter no longer has parameter tag_key
info	[Changelog]   - Model ReportConfigFilter no longer has parameter tag_value
info	[Changelog]   - Model Resource no longer has parameter tags
info	[Changelog]   - Removed operation group SettingsOperations
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs] Generate from 1d9bf6880735987cf65df9cda79b7714b0919df7. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation
    • ️✔️cost-management [View full logs] 
    ️❌ azure-powershell failed [Detail]
    • ❌Failed [Logs] Generate from 1d9bf6880735987cf65df9cda79b7714b0919df7. SDK Automation 14.0.0 
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ❌Az.cost-management [View full logs]  [Preview SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 18, 2023 •
    edited
    Loading

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/costmanagement/armcostmanagement https://apiview.dev/Assemblies/Review/b45bd062d02d44579114d89d929f7644

    @openapi-workflow-bot
    Copy link

    Hi @pednekarpraj, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
     If you need further help, please feedback via swagger feedback.

    @azure-sdk azure-sdk mentioned this pull request Jan 18, 2023
    Closed
    This was referenced Jan 18, 2023
    Closed
    Closed
    Closed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers
    No reviews
    Assignees

    @leni-msft leni-msft

    Labels
    CI-BreakingChange-Go CI-FixRequiredOnFailure resource-manager
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    3 participants
    @pednekarpraj @leni-msft @AzureRestAPISpecReview