From f5c177fac11884fbbaa0afd084a741b4ba1c2641 Mon Sep 17 00:00:00 2001 From: ruowan Date: Tue, 13 Dec 2022 02:49:11 +0000 Subject: [PATCH 1/2] update arc review comments and mail --- .github/comment.yml | 5 +++++ .github/sla.yml | 16 ++++++++++++++++ 2 files changed, 21 insertions(+) diff --git a/.github/comment.yml b/.github/comment.yml index 0703bff9a19f..56d84431da2e 100644 --- a/.github/comment.yml +++ b/.github/comment.yml @@ -51,6 +51,11 @@ label: CI-RpaaSRPNotInPrivateRepo onLabeledComments: "Hi @${PRAuthor} This PR was flagged for attempting to introduce a new RP namespace to the main branch without first merging the new RP to the RPSaaSMaster branch. Please add the new RP in a merge to RPSaaSMaster before continuing the merge to main." +- rule: + type: label + label: ArcReview + onLabeledComments: "Hi @${PRAuthor} and @arcboard, one or more change(s) have been detected in your Arc enabled VM's or Arc enabled Server's RPs. Please review the changes and ensure that no gaps have been introduced with respect to the ARM API modeling consistency across Azure Arc and Azure Compute. For further details, see guidelines at [Consistency in ARM Modeling](https://msazure.visualstudio.com/One/_wiki/wikis/One.wiki/377428/Consistency-in-ARM-Modeling?anchor=general-design-guidance). To approve the change(s), set the label to ArcSignedOff. If you have any questions, please mail to this arcboard@microsoft.com." + - rule: type: label label: CI-FixRequiredOnFailure diff --git a/.github/sla.yml b/.github/sla.yml index e5d345c625d0..dea03369f815 100644 --- a/.github/sla.yml +++ b/.github/sla.yml @@ -28,6 +28,22 @@ - ${AUTHOR} - ${ASSIGNEE} + +- scheduleTask: + action: sendEmail + scope: pull_request + name: "send email to Arc review board" + trigger: + - label + args: + booleanFilterExpression: "ArcReview" + message: "

Hi, Arc review board,

Please review the PR ${URL} . You receive the email because the PR is labeled with ArcReview. One or more change(s) have been detected in your Arc enabled VM or Arc enabled Server RPs. Please review the changes and ensure that no gaps have been introduced with respect to the ARM API modeling consistency across Azure Arc and Azure Compute. For further details, see guidelines at Consistency in ARM Modeling. To approve the change(s), add the label ArcSignedOff.

" + subject: "Action Required ArcReview: Please review PR ${URL}" + to: ruowan@microsoft.com + cc: + - ${AUTHOR} + - ${ASSIGNEE} + - scheduleTask: action: sendEmail scope: pull_request From 60c01a771d1615b77f16676f588f7cf1273bc179 Mon Sep 17 00:00:00 2001 From: Ray Chen Date: Tue, 13 Dec 2022 18:12:56 +0800 Subject: [PATCH 2/2] Update .github/comment.yml --- .github/comment.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/comment.yml b/.github/comment.yml index 56d84431da2e..7906d76917c7 100644 --- a/.github/comment.yml +++ b/.github/comment.yml @@ -54,7 +54,7 @@ - rule: type: label label: ArcReview - onLabeledComments: "Hi @${PRAuthor} and @arcboard, one or more change(s) have been detected in your Arc enabled VM's or Arc enabled Server's RPs. Please review the changes and ensure that no gaps have been introduced with respect to the ARM API modeling consistency across Azure Arc and Azure Compute. For further details, see guidelines at [Consistency in ARM Modeling](https://msazure.visualstudio.com/One/_wiki/wikis/One.wiki/377428/Consistency-in-ARM-Modeling?anchor=general-design-guidance). To approve the change(s), set the label to ArcSignedOff. If you have any questions, please mail to this arcboard@microsoft.com." + onLabeledComments: "Hi @${PRAuthor} and @arcboard, one or more change(s) have been detected in your Arc enabled VM's or Arc enabled Server's RPs. Please review the changes and ensure that no gaps have been introduced with respect to the ARM API modeling consistency across Azure Arc and Azure Compute. For further details, see guidelines at [Consistency in ARM Modeling](https://msazure.visualstudio.com/One/_wiki/wikis/One.wiki/377428/Consistency-in-ARM-Modeling?anchor=general-design-guidance). To approve the change(s), set the label to ArcSignedOff. If you have any questions, please mail to arcboard@microsoft.com." - rule: type: label