Fix add x-ms-enum #18406
Merged
Fix add x-ms-enum #18406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @Frey-Wang Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The integer type does not have a format, please add it. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L4684 |
|
The integer type does not have a format, please add it. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5832 |
|
The integer type does not have a format, please add it. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5957 |
|
The integer type does not have a format, please add it. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L6416 |
|
The integer type does not have a format, please add it. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L6420 |
|
The integer type does not have a format, please add it. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L6452 |
|
The integer type does not have a format, please add it. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L6577 |
|
The integer type does not have a format, please add it. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L6671 |
|
The integer type does not have a format, please add it. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L6675 |
|
The integer type does not have a format, please add it. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L6691 |
|
The integer type does not have a format, please add it. Location: stable/2018-06-01/entityTypes/Trigger.json#L281 |
|
The integer type does not have a format, please add it. Location: stable/2018-06-01/entityTypes/Trigger.json#L281 |
|
The integer type does not have a format, please add it. Location: stable/2018-06-01/entityTypes/Trigger.json#L444 |
|
The integer type does not have a format, please add it. Location: stable/2018-06-01/entityTypes/Trigger.json#L444 |
|
The integer type does not have a format, please add it. Location: stable/2018-06-01/entityTypes/Trigger.json#L496 |
|
The integer type does not have a format, please add it. Location: stable/2018-06-01/entityTypes/Trigger.json#L496 |
|
The integer type does not have a format, please add it. Location: stable/2018-06-01/entityTypes/Trigger.json#L641 |
|
The integer type does not have a format, please add it. Location: stable/2018-06-01/entityTypes/Trigger.json#L641 |
|
The response schema of operations API '/providers/Microsoft.DataFactory/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L36 |
|
The schema 'Resource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L4370 |
|
The schema 'SubResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L4411 |
|
The schema 'SubResourceDebugResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L4437 |
|
The schema 'IntegrationRuntimeReference' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L4568 |
|
The schema 'IntegrationRuntimeReference' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L4568 |
|
The schema 'IntegrationRuntimeReference' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L4568 |
|
The schema 'IntegrationRuntimeResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L4592 |
|
The schema 'IntegrationRuntimeDebugResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L4609 |
|
The schema 'IntegrationRuntimeStatusResponse' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L4626 |
|
The schema 'FactoryRepoUpdate' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5089 |
|
The schema 'GitHubAccessTokenRequest' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5102 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Generation Artifacts
|
| Rule | Message |
|---|---|
|
"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=284613&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Run.ps1 failed with exit code 1 " |
️❌SDK Breaking Change Tracking failed [Detail]
Breaking Changes Tracking
❌azure-sdk-for-go-track2 - armdatafactory - 0.4.0+ Struct `TypeConversionSettings` has been removed
️✔️azure-sdk-for-go - datafactory/mgmt/2018-06-01/datafactory - v62.3.0❌azure-sdk-for-go - preview/datafactory/mgmt/2017-09-01-preview/datafactory - v62.3.0+ Const `Initial` has been removed
+ Const `Limited` has been removed
+ Const `ManagedIntegrationRuntimeNodeStatusAvailable` has been removed
+ Const `ManagedIntegrationRuntimeNodeStatusRecycling` has been removed
+ Const `ManagedIntegrationRuntimeNodeStatusStarting` has been removed
+ Const `ManagedIntegrationRuntimeNodeStatusUnavailable` has been removed
+ Const `NeedRegistration` has been removed
+ Const `Offline` has been removed
+ Const `Online` type has been changed from `IntegrationRuntimeState` to `DynamicsDeploymentType`
+ Const `Started` type has been changed from `IntegrationRuntimeState` to `TriggerRuntimeState`
+ Const `Starting` type has been changed from `IntegrationRuntimeState` to `ManagedIntegrationRuntimeNodeStatus`
+ Const `Stopped` type has been changed from `IntegrationRuntimeState` to `TriggerRuntimeState`
+ Const `Stopping` has been removed
+ Const `TriggerRuntimeStateDisabled` has been removed
+ Const `TriggerRuntimeStateStarted` has been removed
+ Const `TriggerRuntimeStateStopped` has been removed
+ Type of `AzureSearchIndexSink.WriteBehavior` has been changed from `interface{}` to `AzureSearchIndexWriteBehaviorType`
+ Type of `CassandraSource.ConsistencyLevel` has been changed from `interface{}` to `CassandraSourceReadConsistencyLevels`
+ Type of `DatasetDeflateCompression.Level` has been changed from `interface{}` to `DatasetCompressionLevel`
+ Type of `DatasetGZipCompression.Level` has been changed from `interface{}` to `DatasetCompressionLevel`
+ Type of `DatasetZipDeflateCompression.Level` has been changed from `interface{}` to `DatasetCompressionLevel`
+ Type of `DynamicsLinkedServiceTypeProperties.AuthenticationType` has been changed from `interface{}` to `DynamicsAuthenticationType`
+ Type of `DynamicsLinkedServiceTypeProperties.DeploymentType` has been changed from `interface{}` to `DynamicsDeploymentType`
+ Type of `DynamicsSink.WriteBehavior` has been changed from `interface{}` to `*string`
+ Type of `PolybaseSettings.RejectType` has been changed from `interface{}` to `PolybaseSettingsRejectType`
+ Type of `SalesforceSink.WriteBehavior` has been changed from `interface{}` to `SalesforceSinkWriteBehavior`
+ Type of `SalesforceSource.ReadBehavior` has been changed from `interface{}` to `SalesforceSourceReadBehavior`
+ Type of `SapCloudForCustomerSink.WriteBehavior` has been changed from `interface{}` to `SapCloudForCustomerSinkWriteBehavior`
+ Type of `StoredProcedureParameter.Type` has been changed from `interface{}` to `StoredProcedureParameterType`️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-datafactory - 2.3.0️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
warn Skip initScript due to not configured command sudo apt-get install -y dotnet-sdk-6.0 command autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/datafactory/resource-manager/readme.md cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied
️✔️Microsoft.Azure.Management.DataFactory [View full logs] [Release SDK Changes]
️⚠️ azure-sdk-for-python-track2 warning [Detail]
command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json cmderr [automation_generate.sh] npm notice cmderr [automation_generate.sh] npm notice New patch version of npm available! 8.5.0 -> 8.5.5 cmderr [automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.5.5> cmderr [automation_generate.sh] npm notice Run `npm install -g [email protected]` to update! cmderr [automation_generate.sh] npm notice
️✔️track2_azure-mgmt-datafactory [View full logs] [Release SDK Changes]info [Changelog] **Features** info [Changelog] info [Changelog] - Model WebActivity has a new parameter disable_cert_validation
️⚠️ azure-sdk-for-java warning [Detail]
command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json cmderr [generate.py] [ForkJoinPool-1-worker-3] INFO com.azure.core.test.implementation.TestingHelpers - Environment variable 'AZURE_TEST_MODE' has not been set yet. Using 'Playback' mode.
️✔️azure-resourcemanager-datafactory [View full logs] [Release SDK Changes]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
command sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️datafactory/mgmt/2018-06-01/datafactory [View full logs] [Release SDK Changes]info [Changelog] ### Features Added info [Changelog] info [Changelog] - New field `DisableCertValidation` in struct `WebActivityTypeProperties` info [Changelog] info [Changelog] Total 0 breaking change(s), 1 additive change(s).
- Only show 60 items here, please refer to log for details.
️✔️preview/datafactory/mgmt/2017-09-01-preview/datafactory [View full logs]info [Changelog] ### Features Added info [Changelog] info [Changelog] - New const `QueryAll` info [Changelog] - New const `IntegrationRuntimeStateInitial` info [Changelog] - New const `Office365` info [Changelog] - New const `IntegrationRuntimeStateOffline` info [Changelog] - New const `LOCALSERIAL` info [Changelog] - New const `IntegrationRuntimeStateStopping` info [Changelog] - New const `String` info [Changelog] - New const `IntegrationRuntimeStateNeedRegistration` info [Changelog] - New const `IntegrationRuntimeStateStopped` info [Changelog] - New const `Upload` info [Changelog] - New const `ALL` info [Changelog] - New const `EACHQUORUM` info [Changelog] - New const `Available` info [Changelog] - New const `Date` info [Changelog] - New const `Insert` info [Changelog] - New const `Recycling` info [Changelog] - New const `SapCloudForCustomerSinkWriteBehaviorInsert` info [Changelog] - New const `Optimal` info [Changelog] - New const `GUID` info [Changelog] - New const `Percentage` info [Changelog] - New const `Decimal` info [Changelog] - New const `LOCALQUORUM` info [Changelog] - New const `Int64` info [Changelog] - New const `Fastest` info [Changelog] - New const `Value` info [Changelog] - New const `IntegrationRuntimeStateStarted` info [Changelog] - New const `IntegrationRuntimeStateOnline` info [Changelog] - New const `Merge` info [Changelog] - New const `ONE` info [Changelog] - New const `Upsert` info [Changelog] - New const `IntegrationRuntimeStateLimited` info [Changelog] - New const `Disabled` info [Changelog] - New const `LOCALONE` info [Changelog] - New const `Boolean` info [Changelog] - New const `OnPremisesWithIfd` info [Changelog] - New const `QUORUM` info [Changelog] - New const `Ifd` info [Changelog] - New const `Int` info [Changelog] - New const `Unavailable` info [Changelog] - New const `SERIAL` info [Changelog] - New const `Query` info [Changelog] - New const `SapCloudForCustomerSinkWriteBehaviorUpdate` info [Changelog] - New const `IntegrationRuntimeStateStarting` info [Changelog] - New const `TWO` info [Changelog] - New const `THREE` info [Changelog] - New function `PossibleDatasetCompressionLevelValues() []DatasetCompressionLevel` info [Changelog] - New function `PossiblePolybaseSettingsRejectTypeValues() []PolybaseSettingsRejectType` info [Changelog] - New function `PossibleSapCloudForCustomerSinkWriteBehaviorValues() []SapCloudForCustomerSinkWriteBehavior` info [Changelog] - New function `PossibleAzureSearchIndexWriteBehaviorTypeValues() []AzureSearchIndexWriteBehaviorType` info [Changelog] - New function `PossibleStoredProcedureParameterTypeValues() []StoredProcedureParameterType` info [Changelog] - New function `PossibleCassandraSourceReadConsistencyLevelsValues() []CassandraSourceReadConsistencyLevels` info [Changelog] - New function `PossibleDynamicsDeploymentTypeValues() []DynamicsDeploymentType` info [Changelog] - New function `PossibleSalesforceSourceReadBehaviorValues() []SalesforceSourceReadBehavior` info [Changelog] - New function `PossibleSalesforceSinkWriteBehaviorValues() []SalesforceSinkWriteBehavior` info [Changelog] - New function `PossibleDynamicsAuthenticationTypeValues() []DynamicsAuthenticationType` info [Changelog] - New field `DisableCertValidation` in struct `WebActivityTypeProperties` info [Changelog] info [Changelog] Total 28 breaking change(s), 56 additive change(s).
️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]
command sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️armdatafactory [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] ### Breaking Changes info [Changelog] info [Changelog] - Struct `TypeConversionSettings` has been removed info [Changelog] info [Changelog] Total 2 breaking change(s), 0 additive change(s).
️⚠️ azure-sdk-for-js warning [Detail]
command sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json cmderr [automation_init.sh] deprecated [email protected]: The functionality that this package provided is now in @npmcli/arborist cmderr [automation_init.sh] [email protected]: Please upgrade to version 7 or higher. Older versions may use Math.random() in certain circumstances, which is known to be problematic. See https://v8.dev/blog/math-random for details. cmderr [automation_init.sh] deprecated @opentelemetry/[email protected]: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js cmderr [automation_init.sh] @octokit/[email protected] requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself. warn File azure-sdk-for-js_tmp/initOutput.json not found to read command sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
️✔️@azure/arm-datafactory [View full logs] [Release SDK Changes]info [Changelog] **Features** info [Changelog] info [Changelog] - Added Type Alias CredentialReferenceType info [Changelog] - Added Type Alias DataFlowReferenceType info [Changelog] - Added Type Alias ManagedVirtualNetworkReferenceType info [Changelog] - Added Type Alias TriggerReferenceType info [Changelog] - Type Alias WebActivity has a new parameter disableCertValidation info [Changelog] - Added Enum KnownCredentialReferenceType info [Changelog] - Added Enum KnownDataFlowReferenceType info [Changelog] - Added Enum KnownManagedVirtualNetworkReferenceType info [Changelog] - Added Enum KnownTriggerReferenceType error breakingChangeTracking is enabled, but version or changelogItem is not found in output.
️⚠️ azure-resource-manager-schemas warning [Detail]
command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json cmderr [initScript.sh] WARN old lockfile cmderr [initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm, cmderr [initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry. cmderr [initScript.sh] npm WARN old lockfile cmderr [initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient... cmderr [initScript.sh] npm WARN old lockfile warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json warn No file changes detected after generation
️✔️datafactory [View full logs]
|
Hi @Frey-Wang, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Mar 25, 2022
davidzhaoyue
approved these changes
Mar 25, 2022
This was referenced Mar 25, 2022
visingl
pushed a commit
that referenced
this pull request
Mar 30, 2022
* Fix add x-ms-enum * Fix unrelated test add required type
FredericHeem
pushed a commit
to grucloud/azure-rest-api-specs
that referenced
this pull request
May 16, 2022
* Fix add x-ms-enum * Fix unrelated test add required type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.