[Hub Generated] Review request for Microsoft.Security to add version stable/2022-03-01 #17919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @kerend Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
Operations API must be implemented for '/providers/Microsoft.Security/operations'. Location: Microsoft.Security/stable/2022-03-01/pricings.json#L36 |
|
The response of operation:'Pricings_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Security/stable/2022-03-01/pricings.json#L74 |
|
The response of operation:'Pricings_Update' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Security/stable/2022-03-01/pricings.json#L111 |
The following errors/warnings exist before current PR submission:
| Rule | Message |
|---|---|
|
The schema 'PricingList' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Security/stable/2022-03-01/pricings.json#L154 |
| 'PUT' operation 'Pricings_Update' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Security/stable/2022-03-01/pricings.json#L121 |
|
| Based on the response model schema, operation 'Pricings_List' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.Security/stable/2022-03-01/pricings.json#L38 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get pricings on subscription Location: Microsoft.Security/stable/2022-03-01/pricings.json#L75 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️⚠️Cross-Version Breaking Changes: 6 Warnings warning [Detail]
- Compared Swaggers (Based on Oad v0.9.3)
- current:stable/2022-03-01/pricings.json compared with base:stable/2018-06-01/pricings.json
- current:stable/2022-03-01/pricings.json compared with base:preview/2017-08-01-preview/pricings.json
| Rule | Message |
|---|---|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Security/pricings' removed or restructured? Old: Microsoft.Security/preview/2017-08-01-preview/pricings.json#L76:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Security/pricings/{pricingName}' removed or restructured? Old: Microsoft.Security/preview/2017-08-01-preview/pricings.json#L197:5 |
|
| The new version is missing a client parameter that was found in the old version. Was 'ResourceGroupName' removed or renamed? New: Microsoft.Security/stable/2022-03-01/pricings.json#L227:3 Old: Microsoft.Security/preview/2017-08-01-preview/pricings.json#L352:3 |
|
| The operation id has been changed from 'Pricings_GetSubscriptionPricing' to 'Pricings_Get'. This will impact generated code. New: Microsoft.Security/stable/2022-03-01/pricings.json#L74:7 Old: Microsoft.Security/preview/2017-08-01-preview/pricings.json#L119:7 |
|
| The operation id has been changed from 'Pricings_UpdateSubscriptionPricing' to 'Pricings_Update'. This will impact generated code. New: Microsoft.Security/stable/2022-03-01/pricings.json#L111:7 Old: Microsoft.Security/preview/2017-08-01-preview/pricings.json#L156:7 |
|
| The new version is missing a property found in the old version. Was 'nextLink' renamed or removed? New: Microsoft.Security/stable/2022-03-01/pricings.json#L159:7 Old: Microsoft.Security/preview/2017-08-01-preview/pricings.json#L289:7 |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
|
Hi @kerend, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Feb 20, 2022
chshum
reviewed
Feb 20, 2022
...rce-manager/Microsoft.Security/stable/2022-03-01/examples/Pricings/ListPricings_example.json
Show resolved
Hide resolved
chshum
reviewed
Feb 20, 2022
specification/security/resource-manager/Microsoft.Security/stable/2022-03-01/pricings.json
Outdated
Show resolved
Hide resolved
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
Hi, @kerend your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). |
|
Targeting deployment to end of March. |
j5lim
added
ARMSignedOff
This was referenced Mar 10, 2022
FredericHeem
pushed a commit
to grucloud/azure-rest-api-specs
that referenced
this pull request
May 16, 2022
…stable/2022-03-01 (Azure#17919) * Adds base for updating Microsoft.Security from version stable/2018-06-01 to version 2022-03-01 * Updates readme * Updates API version in new specs and examples * . * . * .
kayousef-zz
pushed a commit
to kayousef-zz/azure-rest-api-specs
that referenced
this pull request
Dec 20, 2022
…stable/2022-03-01 (Azure#17919) * Adds base for updating Microsoft.Security from version stable/2018-06-01 to version 2022-03-01 * Updates readme * Updates API version in new specs and examples * . * . * .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.