Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove the unused parameter in mariadb #17233

Merged
merged 1 commit into from
Jan 14, 2022
Merged

remove the unused parameter in mariadb #17233

merged 1 commit into from
Jan 14, 2022

Conversation

ArcturusZhang
Copy link
Member

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @ArcturusZhang Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 5, 2022 •
    edited
    Loading

    Swagger Validation Report

    ️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    ❌ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'SecurityAlertPolicyNameParameter' removed or renamed?
    New: Microsoft.DBforMariaDB/stable/2018-06-01/ServerSecurityAlertPolicies.json#L271:3
    Old: Microsoft.DBforMariaDB/stable/2018-06-01/ServerSecurityAlertPolicies.json#L271:3
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ❌ R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.DBforMariaDB/stable/2018-06-01/PerformanceRecommendations.json#L66
    ❌ R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.DBforMariaDB/stable/2018-06-01/PerformanceRecommendations.json#L102
    ❌ R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.DBforMariaDB/stable/2018-06-01/PerformanceRecommendations.json#L151
    ❌ R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.DBforMariaDB/stable/2018-06-01/PerformanceRecommendations.json#L194
    ❌ R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.DBforMariaDB/stable/2018-06-01/PerformanceRecommendations.json#L240
    ❌ R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.DBforMariaDB/stable/2018-06-01/PerformanceRecommendations.json#L279
    ❌ R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.DBforMariaDB/stable/2018-06-01/PerformanceRecommendations.json#L315
    ❌ R4018 - OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.DBforMariaDB/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.DBforMariaDB/stable/2018-06-01/mariadb.json#L1421
    ❌ R4035 - PrivateEndpointResourceSchemaValidation The private endpoint model 'PrivateLinkResourceListResult' schema does not conform to the common type definition.
    Location: Microsoft.DBforMariaDB/stable/2018-06-01/PrivateLinkResources.json#L133
    ❌ R4037 - MissingTypeObject The schema 'ServerProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DBforMariaDB/stable/2018-06-01/mariadb.json#L1601
    ❌ R4037 - MissingTypeObject The schema 'StorageProfile' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DBforMariaDB/stable/2018-06-01/mariadb.json#L1674
    ❌ R4037 - MissingTypeObject The schema 'ServerPropertiesForCreate' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DBforMariaDB/stable/2018-06-01/mariadb.json#L1713
    ❌ R4037 - MissingTypeObject The schema 'ServerPropertiesForDefaultCreate' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DBforMariaDB/stable/2018-06-01/mariadb.json#L1756
    ❌ R4037 - MissingTypeObject The schema 'ServerPropertiesForRestore' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DBforMariaDB/stable/2018-06-01/mariadb.json#L1781
    ❌ R4037 - MissingTypeObject The schema 'ServerPropertiesForGeoRestore' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DBforMariaDB/stable/2018-06-01/mariadb.json#L1805
    ❌ R4037 - MissingTypeObject The schema 'ServerPropertiesForReplica' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DBforMariaDB/stable/2018-06-01/mariadb.json#L1823
    ❌ R4037 - MissingTypeObject The schema 'Sku' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DBforMariaDB/stable/2018-06-01/mariadb.json#L1841
    ❌ R4037 - MissingTypeObject The schema 'Server' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DBforMariaDB/stable/2018-06-01/mariadb.json#L1880
    ❌ R4037 - MissingTypeObject The schema 'ServerForCreate' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DBforMariaDB/stable/2018-06-01/mariadb.json#L1899
    ❌ R4037 - MissingTypeObject The schema 'ServerUpdateParameters' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DBforMariaDB/stable/2018-06-01/mariadb.json#L1928
    ❌ R4037 - MissingTypeObject The schema 'properties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DBforMariaDB/stable/2018-06-01/mariadb.json#L1934
    ❌ R4037 - MissingTypeObject The schema 'ServerListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DBforMariaDB/stable/2018-06-01/mariadb.json#L1979
    ❌ R4037 - MissingTypeObject The schema 'FirewallRuleProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DBforMariaDB/stable/2018-06-01/mariadb.json#L1991
    ❌ R4037 - MissingTypeObject The schema 'FirewallRule' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DBforMariaDB/stable/2018-06-01/mariadb.json#L2010
    ❌ R4037 - MissingTypeObject The schema 'FirewallRuleListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DBforMariaDB/stable/2018-06-01/mariadb.json#L2028
    ❌ R4037 - MissingTypeObject The schema 'DatabaseProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DBforMariaDB/stable/2018-06-01/mariadb.json#L2108
    ❌ R4037 - MissingTypeObject The schema 'Database' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DBforMariaDB/stable/2018-06-01/mariadb.json#L2121
    ❌ R4037 - MissingTypeObject The schema 'DatabaseListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DBforMariaDB/stable/2018-06-01/mariadb.json#L2136
    ❌ R4037 - MissingTypeObject The schema 'ConfigurationProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DBforMariaDB/stable/2018-06-01/mariadb.json#L2148
    ❌ R4037 - MissingTypeObject The schema 'Configuration' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DBforMariaDB/stable/2018-06-01/mariadb.json#L2181
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/mariadb/resource-manager/readme.md
    tag: specification/mariadb/resource-manager/readme.md#tag-package-2020-01-01
    ️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand] 
    Validation passes for SDKTrack2Validation

    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 5, 2022 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-go-track2 - armmariadb - 0.1.1
    ❌azure-sdk-for-go - mariadb/mgmt/2020-01-01/mariadb - v61.0.0
    +	Const `FiveFullStopSeven` has been removed
+	Const `FiveFullStopSix` has been removed
    ❌azure-sdk-for-go - mariadb/mgmt/2018-06-01/mariadb - v61.0.0
    +	Const `FiveFullStopSeven` has been removed
+	Const `FiveFullStopSix` has been removed
    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-rdbms - 10.0.0
    -	Model FirewallRuleListResult no longer has parameter next_link
-	Operation ConfigurationsOperations.begin_update has a new signature
-	Operation ConfigurationsOperations.get has a new signature
-	Operation ConfigurationsOperations.list_by_server has a new signature
-	Operation FirewallRulesOperations.begin_create_or_update has a new signature
-	Operation FirewallRulesOperations.begin_delete has a new signature
-	Operation FirewallRulesOperations.get has a new signature
-	Operation ServersOperations.get has a new signature
-	Parameter type of model NameAvailabilityRequest is now required
-	Removed operation ConfigurationsOperations.begin_put
-	Removed operation FirewallRulesOperations.list_by_server
-	Removed operation ServersOperations.begin_create
-	Removed operation ServersOperations.begin_delete
-	Removed operation ServersOperations.begin_restart
-	Removed operation ServersOperations.begin_start
-	Removed operation ServersOperations.begin_stop
-	Removed operation ServersOperations.begin_update
-	Removed operation ServersOperations.list
-	Removed operation ServersOperations.list_by_resource_group
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 55bff90. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-6.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/mariadb/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.MariaDB [View full logs]  [Release SDK Changes] 
      warn	Skip artifact folder because it doesn't exist: artifacts/packages
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 55bff90. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.1.2 -> 8.3.1
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.3.1>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-rdbms [View full logs]  [Release SDK Changes] 
      info	[Changelog]
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 55bff90. SDK Automation 14.0.0 
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2022-01-14 02:42:32 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-mariadb;1.0.0-beta.1;1.0.0-beta.2"
cmderr	[generate.py] 2022-01-14 02:42:32 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.2"
cmderr	[generate.py] 2022-01-14 02:42:32 INFO autorest --version=3.6.6 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/mariadb/azure-resourcemanager-mariadb --java.namespace=com.azure.resourcemanager.mariadb   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --generate-samples --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/mariadb/resource-manager/readme.md
cmderr	[generate.py] 2022-01-14 02:43:07 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-mariadb
cmderr	[generate.py] 2022-01-14 02:43:07 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2022-01-14 02:43:07 INFO [POM][Skip] pom already has module azure-resourcemanager-mariadb
cmderr	[generate.py] 2022-01-14 02:43:07 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2022-01-14 02:43:07 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2022-01-14 02:43:07 INFO [POM][Skip] pom already has module sdk/mariadb
cmderr	[generate.py] 2022-01-14 02:43:07 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-mariadb [View full logs]  [Release SDK Changes] 
      cmderr	[Inst] 2022-01-14 02:44:48 DEBUG Got artifact_id: azure-resourcemanager-mariadb
cmderr	[Inst] 2022-01-14 02:44:48 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2022-01-14 02:44:48 DEBUG Got artifact: azure-resourcemanager-mariadb-1.0.0-beta.2-sources.jar
cmderr	[Inst] 2022-01-14 02:44:48 DEBUG Got artifact: azure-resourcemanager-mariadb-1.0.0-beta.2.jar
cmderr	[Inst] 2022-01-14 02:44:48 DEBUG Match jar package: azure-resourcemanager-mariadb-1.0.0-beta.2.jar
cmderr	[Inst] 2022-01-14 02:44:48 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/17233/azure-sdk-for-java/azure-resourcemanager-mariadb/azure-resourcemanager-mariadb-1.0.0-beta.2.jar\" -o azure-resourcemanager-mariadb-1.0.0-beta.2.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-mariadb -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-mariadb-1.0.0-beta.2.jar -Dpackaging=jar -DgeneratePom=true
```"}
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 55bff90. SDK Automation 14.0.0 
      command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️mariadb/mgmt/2020-01-01/mariadb [View full logs]  [Release SDK Changes]
      Only show 60 items here, please refer to log for details.
      info	[Changelog] - New function `ServerSecurityAlertPolicyListResultIterator.Response() ServerSecurityAlertPolicyListResult`
info	[Changelog] - New function `RecoverableServersClient.Get(context.Context, string, string) (RecoverableServerResource, error)`
info	[Changelog] - New function `BaseClient.ResetQueryPerformanceInsightData(context.Context, string, string) (QueryPerformanceInsightResetDataResult, error)`
info	[Changelog] - New function `RecoverableServersClient.GetSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `RecoverableServersClient.GetPreparer(context.Context, string, string) (*http.Request, error)`
info	[Changelog] - New function `ServerSecurityAlertPoliciesClient.ListByServerComplete(context.Context, string, string) (ServerSecurityAlertPolicyListResultIterator, error)`
info	[Changelog] - New function `RecoverableServerResource.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `NewServerSecurityAlertPolicyListResultIterator(ServerSecurityAlertPolicyListResultPage) ServerSecurityAlertPolicyListResultIterator`
info	[Changelog] - New function `ServerParametersClient.ListUpdateConfigurationsPreparer(context.Context, string, string, ConfigurationListResult) (*http.Request, error)`
info	[Changelog] - New function `ServerBasedPerformanceTierClient.ListSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `ServerSecurityAlertPolicyListResultPage.NotDone() bool`
info	[Changelog] - New function `PossibleQueryPerformanceInsightResetDataResultStateValues() []QueryPerformanceInsightResetDataResultState`
info	[Changelog] - New function `ServerBasedPerformanceTierClient.ListResponder(*http.Response) (PerformanceTierListResult, error)`
info	[Changelog] - New function `BaseClient.ResetQueryPerformanceInsightDataSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `ServerSecurityAlertPolicyListResultPage.Values() []ServerSecurityAlertPolicy`
info	[Changelog] - New function `*ServerSecurityAlertPolicyListResultIterator.NextWithContext(context.Context) error`
info	[Changelog] - New function `NewServerParametersClientWithBaseURI(string, string) ServerParametersClient`
info	[Changelog] - New function `NewServerBasedPerformanceTierClient(string) ServerBasedPerformanceTierClient`
info	[Changelog] - New function `NewServerSecurityAlertPolicyListResultPage(ServerSecurityAlertPolicyListResult, func(context.Context, ServerSecurityAlertPolicyListResult) (ServerSecurityAlertPolicyListResult, error)) ServerSecurityAlertPolicyListResultPage`
info	[Changelog] - New function `ServerSecurityAlertPolicyListResult.IsEmpty() bool`
info	[Changelog] - New function `NewRecoverableServersClientWithBaseURI(string, string) RecoverableServersClient`
info	[Changelog] - New function `ServerBasedPerformanceTierClient.List(context.Context, string, string) (PerformanceTierListResult, error)`
info	[Changelog] - New function `ServerBasedPerformanceTierClient.ListPreparer(context.Context, string, string) (*http.Request, error)`
info	[Changelog] - New function `PossibleMinimalTLSVersionEnumValues() []MinimalTLSVersionEnum`
info	[Changelog] - New function `ServerSecurityAlertPolicyListResultIterator.Value() ServerSecurityAlertPolicy`
info	[Changelog] - New function `ServerSecurityAlertPolicyListResultIterator.NotDone() bool`
info	[Changelog] - New function `ServerParametersClient.ListUpdateConfigurationsSender(*http.Request) (ServerParametersListUpdateConfigurationsFuture, error)`
info	[Changelog] - New function `*ServerSecurityAlertPolicyListResultPage.NextWithContext(context.Context) error`
info	[Changelog] - New function `RecoverableServerProperties.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `NewServerParametersClient(string) ServerParametersClient`
info	[Changelog] - New function `*ServerSecurityAlertPolicyListResultPage.Next() error`
info	[Changelog] - New function `*ServerParametersListUpdateConfigurationsFuture.UnmarshalJSON([]byte) error`
info	[Changelog] - New function `ServerSecurityAlertPolicyListResult.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `ServerSecurityAlertPolicyListResultPage.Response() ServerSecurityAlertPolicyListResult`
info	[Changelog] - New function `*RecoverableServerResource.UnmarshalJSON([]byte) error`
info	[Changelog] - New struct `QueryPerformanceInsightResetDataResult`
info	[Changelog] - New struct `RecoverableServerProperties`
info	[Changelog] - New struct `RecoverableServerResource`
info	[Changelog] - New struct `RecoverableServersClient`
info	[Changelog] - New struct `ServerBasedPerformanceTierClient`
info	[Changelog] - New struct `ServerParametersClient`
info	[Changelog] - New struct `ServerParametersListUpdateConfigurationsFuture`
info	[Changelog] - New struct `ServerSecurityAlertPolicyListResult`
info	[Changelog] - New struct `ServerSecurityAlertPolicyListResultIterator`
info	[Changelog] - New struct `ServerSecurityAlertPolicyListResultPage`
info	[Changelog] - New field `MinimalTLSVersion` in struct `ServerPropertiesForDefaultCreate`
info	[Changelog] - New field `MinimalTLSVersion` in struct `ServerPropertiesForGeoRestore`
info	[Changelog] - New field `MinimalTLSVersion` in struct `ServerPropertiesForCreate`
info	[Changelog] - New field `MinimalTLSVersion` in struct `ServerPropertiesForReplica`
info	[Changelog] - New field `MinimalTLSVersion` in struct `ServerPropertiesForRestore`
info	[Changelog] - New field `MinBackupRetentionDays` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MaxStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MinLargeStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MaxLargeStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MinStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MaxBackupRetentionDays` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MinimalTLSVersion` in struct `ServerUpdateParametersProperties`
info	[Changelog] - New field `MinimalTLSVersion` in struct `ServerProperties`
info	[Changelog]
info	[Changelog] Total 2 breaking change(s), 83 additive change(s).
    • ️✔️mariadb/mgmt/2018-06-01/mariadb [View full logs] 
      Only show 60 items here, please refer to log for details.
      info	[Changelog] - New function `*ServerSecurityAlertPolicyListResultPage.Next() error`
info	[Changelog] - New function `ServerSecurityAlertPoliciesClient.ListByServerPreparer(context.Context, string, string) (*http.Request, error)`
info	[Changelog] - New function `NewServerBasedPerformanceTierClientWithBaseURI(string, string) ServerBasedPerformanceTierClient`
info	[Changelog] - New function `ServerSecurityAlertPolicyListResult.IsEmpty() bool`
info	[Changelog] - New function `ServerSecurityAlertPolicyListResultPage.NotDone() bool`
info	[Changelog] - New function `RecoverableServersClient.Get(context.Context, string, string) (RecoverableServerResource, error)`
info	[Changelog] - New function `NewServerBasedPerformanceTierClient(string) ServerBasedPerformanceTierClient`
info	[Changelog] - New function `NewServerSecurityAlertPolicyListResultPage(ServerSecurityAlertPolicyListResult, func(context.Context, ServerSecurityAlertPolicyListResult) (ServerSecurityAlertPolicyListResult, error)) ServerSecurityAlertPolicyListResultPage`
info	[Changelog] - New function `BaseClient.ResetQueryPerformanceInsightDataPreparer(context.Context, string, string) (*http.Request, error)`
info	[Changelog] - New function `ServerSecurityAlertPolicyListResultIterator.Response() ServerSecurityAlertPolicyListResult`
info	[Changelog] - New function `RecoverableServersClient.GetResponder(*http.Response) (RecoverableServerResource, error)`
info	[Changelog] - New function `NewRecoverableServersClientWithBaseURI(string, string) RecoverableServersClient`
info	[Changelog] - New function `NewServerParametersClientWithBaseURI(string, string) ServerParametersClient`
info	[Changelog] - New function `RecoverableServerResource.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `ServerSecurityAlertPoliciesClient.ListByServer(context.Context, string, string) (ServerSecurityAlertPolicyListResultPage, error)`
info	[Changelog] - New function `*RecoverableServerResource.UnmarshalJSON([]byte) error`
info	[Changelog] - New function `ServerSecurityAlertPolicyListResultIterator.NotDone() bool`
info	[Changelog] - New function `NewServerSecurityAlertPolicyListResultIterator(ServerSecurityAlertPolicyListResultPage) ServerSecurityAlertPolicyListResultIterator`
info	[Changelog] - New function `BaseClient.ResetQueryPerformanceInsightData(context.Context, string, string) (QueryPerformanceInsightResetDataResult, error)`
info	[Changelog] - New function `*ServerSecurityAlertPolicyListResultPage.NextWithContext(context.Context) error`
info	[Changelog] - New function `ServerSecurityAlertPolicyListResultPage.Values() []ServerSecurityAlertPolicy`
info	[Changelog] - New function `ServerParametersClient.ListUpdateConfigurationsSender(*http.Request) (ServerParametersListUpdateConfigurationsFuture, error)`
info	[Changelog] - New function `NewRecoverableServersClient(string) RecoverableServersClient`
info	[Changelog] - New function `ServerSecurityAlertPoliciesClient.ListByServerComplete(context.Context, string, string) (ServerSecurityAlertPolicyListResultIterator, error)`
info	[Changelog] - New function `*ServerParametersListUpdateConfigurationsFuture.UnmarshalJSON([]byte) error`
info	[Changelog] - New function `ServerBasedPerformanceTierClient.ListSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `BaseClient.ResetQueryPerformanceInsightDataResponder(*http.Response) (QueryPerformanceInsightResetDataResult, error)`
info	[Changelog] - New function `ServerBasedPerformanceTierClient.ListPreparer(context.Context, string, string) (*http.Request, error)`
info	[Changelog] - New function `ServerParametersClient.ListUpdateConfigurationsResponder(*http.Response) (ConfigurationListResult, error)`
info	[Changelog] - New function `ServerBasedPerformanceTierClient.ListResponder(*http.Response) (PerformanceTierListResult, error)`
info	[Changelog] - New function `ServerSecurityAlertPolicyListResultPage.Response() ServerSecurityAlertPolicyListResult`
info	[Changelog] - New function `RecoverableServerProperties.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `NewServerParametersClient(string) ServerParametersClient`
info	[Changelog] - New function `RecoverableServersClient.GetPreparer(context.Context, string, string) (*http.Request, error)`
info	[Changelog] - New function `ServerSecurityAlertPoliciesClient.ListByServerResponder(*http.Response) (ServerSecurityAlertPolicyListResult, error)`
info	[Changelog] - New struct `QueryPerformanceInsightResetDataResult`
info	[Changelog] - New struct `RecoverableServerProperties`
info	[Changelog] - New struct `RecoverableServerResource`
info	[Changelog] - New struct `RecoverableServersClient`
info	[Changelog] - New struct `ServerBasedPerformanceTierClient`
info	[Changelog] - New struct `ServerParametersClient`
info	[Changelog] - New struct `ServerParametersListUpdateConfigurationsFuture`
info	[Changelog] - New struct `ServerSecurityAlertPolicyListResult`
info	[Changelog] - New struct `ServerSecurityAlertPolicyListResultIterator`
info	[Changelog] - New struct `ServerSecurityAlertPolicyListResultPage`
info	[Changelog] - New field `MinimalTLSVersion` in struct `ServerUpdateParametersProperties`
info	[Changelog] - New field `MinimalTLSVersion` in struct `ServerProperties`
info	[Changelog] - New field `MaxBackupRetentionDays` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MinBackupRetentionDays` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MaxStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MinLargeStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MaxLargeStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MinStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MinimalTLSVersion` in struct `ServerPropertiesForGeoRestore`
info	[Changelog] - New field `MinimalTLSVersion` in struct `ServerPropertiesForRestore`
info	[Changelog] - New field `MinimalTLSVersion` in struct `ServerPropertiesForDefaultCreate`
info	[Changelog] - New field `MinimalTLSVersion` in struct `ServerPropertiesForReplica`
info	[Changelog] - New field `MinimalTLSVersion` in struct `ServerPropertiesForCreate`
info	[Changelog]
info	[Changelog] Total 2 breaking change(s), 83 additive change(s).
    ️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 55bff90. SDK Automation 14.0.0 
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armmariadb [View full logs]  [Release SDK Changes] 
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    ️⚠️ azure-sdk-for-js warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 55bff90. SDK Automation 14.0.0 
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
cmderr	[automation_init.sh] npm WARN deprecated [email protected]: The functionality that this package provided is now in @npmcli/arborist
cmderr	[automation_init.sh] WARN deprecated [email protected]: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
cmderr	[automation_init.sh] WARN deprecated @opentelemetry/[email protected]: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
cmderr	[automation_init.sh] npm notice created a lockfile as package-lock.json. You should commit this file.
cmderr	[automation_init.sh] npm WARN @octokit/[email protected] requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️track2_@azure/arm-mariadb [View full logs]  [Release SDK Changes] 
      info	[Changelog]
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 55bff90. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️mariadb [View full logs]  [Release Schema Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @ArcturusZhang, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    This was referenced Jan 5, 2022
    Closed
    Closed
    Closed
    Closed
    Closed
    @lirenhe lirenhe added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jan 14, 2022
    @lirenhe
    Copy link
    Member

    lirenhe commented Jan 14, 2022

    The removed property is not used in API/SDK code, so it won't cause breaking change.

    @lirenhe lirenhe merged commit 55bff90 into Azure:main Jan 14, 2022
    This was referenced Jan 14, 2022
    Merged
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    mstrisoline pushed a commit to mstrisoline/azure-rest-api-specs that referenced this pull request Feb 1, 2022
    @ArcturusZhang @mstrisoline
    remove the unused parameter (Azure#17233)
    ef129a6
    LeiWang3 pushed a commit to LeiWang3/azure-rest-api-specs that referenced this pull request Mar 31, 2022
    @ArcturusZhang @LeiWang3
    remove the unused parameter (Azure#17233)
    5ba2304
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @lirenhe lirenhe lirenhe approved these changes

    Assignees

    @lirenhe lirenhe

    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    2 participants
    @ArcturusZhang @lirenhe