Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev oep microsoft.open energy platform 2021 06 01 preview #17105

Conversation

komakkar
Copy link
Contributor

@komakkar komakkar commented Dec 15, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month. December
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @komakkar Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Dec 15, 2021

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️LintDiff succeeded [Detail] [Expand]
    Validation passes for LintDiff.
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Dec 15, 2021

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
    ️⌛SDK Breaking Change Tracking pending [Detail]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 23d896b. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.1.2 -> 8.3.0
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.3.0>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-oep [View full logs]  [Release SDK Changes]
      info	[Changelog]   - Initial Release
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 23d896b. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2022-01-05 08:55:57 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-oep"
      cmderr	[generate.py] 2022-01-05 08:55:57 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
      cmderr	[generate.py] 2022-01-05 08:55:57 INFO autorest --version=3.6.6 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/oep/azure-resourcemanager-oep --java.namespace=com.azure.resourcemanager.oep   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --generate-samples --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/oep/resource-manager/readme.md
      cmderr	[generate.py] 2022-01-05 08:56:27 INFO [CI][Success] Write to ci.yml
      cmderr	[generate.py] 2022-01-05 08:56:27 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2022-01-05 08:56:27 INFO [POM][Skip] pom already has module azure-resourcemanager-oep
      cmderr	[generate.py] 2022-01-05 08:56:27 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2022-01-05 08:56:27 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2022-01-05 08:56:27 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-oep [View full logs]  [Release SDK Changes]
      cmderr	[Inst] 2022-01-05 08:58:16 DEBUG Got artifact_id: azure-resourcemanager-oep
      cmderr	[Inst] 2022-01-05 08:58:16 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2022-01-05 08:58:16 DEBUG Got artifact: azure-resourcemanager-oep-1.0.0-beta.1-javadoc.jar
      cmderr	[Inst] 2022-01-05 08:58:16 DEBUG Got artifact: azure-resourcemanager-oep-1.0.0-beta.1.jar
      cmderr	[Inst] 2022-01-05 08:58:16 DEBUG Match jar package: azure-resourcemanager-oep-1.0.0-beta.1.jar
      cmderr	[Inst] 2022-01-05 08:58:16 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/17105/azure-sdk-for-java/azure-resourcemanager-oep/azure-resourcemanager-oep-1.0.0-beta.1.jar\" -o azure-resourcemanager-oep-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-oep -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-oep-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 23d896b. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armoep [View full logs]  [Release SDK Changes]
      Only show 120 items here, please refer to log for details.
      info	[Changelog] - New const `CreatedByTypeUser`
      info	[Changelog] - New const `OriginSystem`
      info	[Changelog] - New const `ProvisioningStateCreating`
      info	[Changelog] - New const `ProvisioningStateSucceeded`
      info	[Changelog] - New const `OriginUserSystem`
      info	[Changelog] - New const `ProvisioningStateFailed`
      info	[Changelog] - New const `CreatedByTypeApplication`
      info	[Changelog] - New const `OriginUser`
      info	[Changelog] - New const `ProvisioningStateCanceled`
      info	[Changelog] - New const `ProvisioningStateUnknown`
      info	[Changelog] - New const `CreatedByTypeManagedIdentity`
      info	[Changelog] - New const `ActionTypeInternal`
      info	[Changelog] - New const `CheckNameAvailabilityReasonInvalid`
      info	[Changelog] - New const `ProvisioningStateDeleting`
      info	[Changelog] - New const `CreatedByTypeKey`
      info	[Changelog] - New const `ProvisioningStateUpdating`
      info	[Changelog] - New const `CheckNameAvailabilityReasonAlreadyExists`
      info	[Changelog] - New function `PossibleCreatedByTypeValues() []CreatedByType`
      info	[Changelog] - New function `*EnergyServicesListBySubscriptionPager.PageResponse() EnergyServicesListBySubscriptionResponse`
      info	[Changelog] - New function `ErrorDetail.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `*EnergyServicesDeletePoller.FinalResponse(context.Context) (EnergyServicesDeleteResponse, error)`
      info	[Changelog] - New function `PossibleCheckNameAvailabilityReasonValues() []CheckNameAvailabilityReason`
      info	[Changelog] - New function `EnergyServicesDeletePollerResponse.PollUntilDone(context.Context, time.Duration) (EnergyServicesDeleteResponse, error)`
      info	[Changelog] - New function `timeRFC3339.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `*EnergyServicesCreatePoller.Poll(context.Context) (*http.Response, error)`
      info	[Changelog] - New function `*EnergyServicesCreatePoller.ResumeToken() (string, error)`
      info	[Changelog] - New function `*EnergyServicesCreatePollerResponse.Resume(context.Context, *EnergyServicesClient, string) error`
      info	[Changelog] - New function `*LocationsClient.CheckNameAvailability(context.Context, CheckNameAvailabilityRequest, *LocationsCheckNameAvailabilityOptions) (LocationsCheckNameAvailabilityResponse, error)`
      info	[Changelog] - New function `*EnergyServicesDeletePoller.ResumeToken() (string, error)`
      info	[Changelog] - New function `*EnergyServicesListBySubscriptionPager.Err() error`
      info	[Changelog] - New function `CheckNameAvailabilityReason.ToPtr() *CheckNameAvailabilityReason`
      info	[Changelog] - New function `EnergyService.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `PossibleOriginValues() []Origin`
      info	[Changelog] - New function `EnergyServicesCreatePollerResponse.PollUntilDone(context.Context, time.Duration) (EnergyServicesCreateResponse, error)`
      info	[Changelog] - New function `SystemData.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `*timeRFC3339.Parse(string) error`
      info	[Changelog] - New function `PossibleActionTypeValues() []ActionType`
      info	[Changelog] - New function `CreatedByType.ToPtr() *CreatedByType`
      info	[Changelog] - New function `*timeRFC3339.UnmarshalText([]byte) error`
      info	[Changelog] - New function `ActionType.ToPtr() *ActionType`
      info	[Changelog] - New function `*timeRFC3339.UnmarshalJSON([]byte) error`
      info	[Changelog] - New function `NewEnergyServicesClient(string, azcore.TokenCredential, *arm.ClientOptions) *EnergyServicesClient`
      info	[Changelog] - New function `*EnergyServicesListByResourceGroupPager.Err() error`
      info	[Changelog] - New function `ErrorResponse.Error() string`
      info	[Changelog] - New function `ProvisioningState.ToPtr() *ProvisioningState`
      info	[Changelog] - New function `*EnergyServicesCreatePoller.FinalResponse(context.Context) (EnergyServicesCreateResponse, error)`
      info	[Changelog] - New function `*SystemData.UnmarshalJSON([]byte) error`
      info	[Changelog] - New function `*EnergyServicesDeletePoller.Poll(context.Context) (*http.Response, error)`
      info	[Changelog] - New function `EnergyServiceProperties.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `*EnergyServicesClient.ListByResourceGroup(string, *EnergyServicesListByResourceGroupOptions) *EnergyServicesListByResourceGroupPager`
      info	[Changelog] - New function `*EnergyServicesClient.Update(context.Context, string, string, *EnergyServicesUpdateOptions) (EnergyServicesUpdateResponse, error)`
      info	[Changelog] - New function `NewOperationsClient(azcore.TokenCredential, *arm.ClientOptions) *OperationsClient`
      info	[Changelog] - New function `*EnergyServicesClient.ListBySubscription(*EnergyServicesListBySubscriptionOptions) *EnergyServicesListBySubscriptionPager`
      info	[Changelog] - New function `EnergyServiceList.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `NewLocationsClient(string, azcore.TokenCredential, *arm.ClientOptions) *LocationsClient`
      info	[Changelog] - New function `Resource.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `*EnergyServicesDeletePoller.Done() bool`
      info	[Changelog] - New function `*EnergyServicesCreatePoller.Done() bool`
      info	[Changelog] - New function `timeRFC3339.MarshalText() ([]byte, error)`
      info	[Changelog] - New function `*EnergyServicesListByResourceGroupPager.NextPage(context.Context) bool`
      info	[Changelog] - New function `*EnergyServicesDeletePollerResponse.Resume(context.Context, *EnergyServicesClient, string) error`
      info	[Changelog] - New function `*EnergyServicesListByResourceGroupPager.PageResponse() EnergyServicesListByResourceGroupResponse`
      info	[Changelog] - New function `Origin.ToPtr() *Origin`
      info	[Changelog] - New function `OperationListResult.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `*EnergyServicesClient.BeginCreate(context.Context, string, string, *EnergyServicesBeginCreateOptions) (EnergyServicesCreatePollerResponse, error)`
      info	[Changelog] - New function `PossibleProvisioningStateValues() []ProvisioningState`
      info	[Changelog] - New function `*EnergyServicesClient.BeginDelete(context.Context, string, string, *EnergyServicesBeginDeleteOptions) (EnergyServicesDeletePollerResponse, error)`
      info	[Changelog] - New function `EnergyResourceUpdate.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `*OperationsClient.List(context.Context, *OperationsListOptions) (OperationsListResponse, error)`
      info	[Changelog] - New function `*EnergyServicesClient.Get(context.Context, string, string, *EnergyServicesGetOptions) (EnergyServicesGetResponse, error)`
      info	[Changelog] - New function `*EnergyServicesListBySubscriptionPager.NextPage(context.Context) bool`
      info	[Changelog] - New struct `CheckNameAvailabilityRequest`
      info	[Changelog] - New struct `CheckNameAvailabilityResponse`
      info	[Changelog] - New struct `DataPartitionNames`
      info	[Changelog] - New struct `EnergyResourceUpdate`
      info	[Changelog] - New struct `EnergyService`
      info	[Changelog] - New struct `EnergyServiceList`
      info	[Changelog] - New struct `EnergyServiceProperties`
      info	[Changelog] - New struct `EnergyServicesBeginCreateOptions`
      info	[Changelog] - New struct `EnergyServicesBeginDeleteOptions`
      info	[Changelog] - New struct `EnergyServicesClient`
      info	[Changelog] - New struct `EnergyServicesCreatePoller`
      info	[Changelog] - New struct `EnergyServicesCreatePollerResponse`
      info	[Changelog] - New struct `EnergyServicesCreateResponse`
      info	[Changelog] - New struct `EnergyServicesCreateResult`
      info	[Changelog] - New struct `EnergyServicesDeletePoller`
      info	[Changelog] - New struct `EnergyServicesDeletePollerResponse`
      info	[Changelog] - New struct `EnergyServicesDeleteResponse`
      info	[Changelog] - New struct `EnergyServicesGetOptions`
      info	[Changelog] - New struct `EnergyServicesGetResponse`
      info	[Changelog] - New struct `EnergyServicesGetResult`
      info	[Changelog] - New struct `EnergyServicesListByResourceGroupOptions`
      info	[Changelog] - New struct `EnergyServicesListByResourceGroupPager`
      info	[Changelog] - New struct `EnergyServicesListByResourceGroupResponse`
      info	[Changelog] - New struct `EnergyServicesListByResourceGroupResult`
      info	[Changelog] - New struct `EnergyServicesListBySubscriptionOptions`
      info	[Changelog] - New struct `EnergyServicesListBySubscriptionPager`
      info	[Changelog] - New struct `EnergyServicesListBySubscriptionResponse`
      info	[Changelog] - New struct `EnergyServicesListBySubscriptionResult`
      info	[Changelog] - New struct `EnergyServicesUpdateOptions`
      info	[Changelog] - New struct `EnergyServicesUpdateResponse`
      info	[Changelog] - New struct `EnergyServicesUpdateResult`
      info	[Changelog] - New struct `ErrorAdditionalInfo`
      info	[Changelog] - New struct `ErrorDetail`
      info	[Changelog] - New struct `ErrorResponse`
      info	[Changelog] - New struct `LocationsCheckNameAvailabilityOptions`
      info	[Changelog] - New struct `LocationsCheckNameAvailabilityResponse`
      info	[Changelog] - New struct `LocationsCheckNameAvailabilityResult`
      info	[Changelog] - New struct `LocationsClient`
      info	[Changelog] - New struct `Operation`
      info	[Changelog] - New struct `OperationDisplay`
      info	[Changelog] - New struct `OperationListResult`
      info	[Changelog] - New struct `OperationsClient`
      info	[Changelog] - New struct `OperationsListOptions`
      info	[Changelog] - New struct `OperationsListResponse`
      info	[Changelog] - New struct `OperationsListResult`
      info	[Changelog] - New struct `Resource`
      info	[Changelog] - New struct `SystemData`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 165 additive change(s).
    ️⚠️ azure-sdk-for-js warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 23d896b. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      cmderr	[automation_init.sh]  [email protected]: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
      cmderr	[automation_init.sh] npm WARN deprecated @opentelemetry/[email protected]: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
      cmderr	[automation_init.sh] notice created a lockfile as package-lock.json. You should commit this file.
      cmderr	[automation_init.sh] npm WARN @octokit/[email protected] requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
      warn	No file changes detected after generation
      warn	No package detected after generation
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @komakkar, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @msyyc
    Copy link
    Member

    msyyc commented Jan 5, 2022

    /azp run

    LeiWang3 pushed a commit to LeiWang3/azure-rest-api-specs that referenced this pull request Mar 31, 2022
    * New Swagger Spec File
    
    * New Swagger Example Spec File
    
    * New Readme Config File
    
    * New Azure AZ Readme Config File
    
    * New Azure CLI Readme Config File
    
    * New Go Language Readme Config File
    
    * New Python Language Readme Config File
    
    * New Typescript Language Readme Config File
    
    * New C# Language Readme Config File
    
    * Updated swagger
    
    * adding examples
    
    * correcting version of api
    
    * Go readme changed
    
    * Changing operation id Names from oepresource to energyservices
    
    * added id for data partition name for linter to pass
    
    * Removing stray operationsgroupget file
    
    * lint fix
    
    * prettier fix
    
    * added multiapi
    
    * testing the SDK pipeline run
    
    * Correcting go readme and adding SDK link
    
    * Correcting go readme and adding SDK link
    
    * Removing ARM schema
    
    * Using common type for availability response and request
    
    * removing definition
    
    * renaming definition from OEPResources to EneryServices
    
    * correcting energy services
    
    * Changing properties name
    
    * Adding v3 error response
    
    * Adding description to Data partion Names list.
    
    * correcting energyservices to energyservice
    
    * adding operation list reponse
    
    * correcting ref for operationlist
    
    * Adding examples and prettier-fix
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants