-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hub Generated] Review request for Microsoft.PowerBIdedicated to add version stable/2017-10-01 #15915
[Hub Generated] Review request for Microsoft.PowerBIdedicated to add version stable/2017-10-01 #15915
Conversation
Hi, @cfurmanczyk Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
Rule | Message |
---|---|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.PowerBIdedicated/stable/2017-10-01/powerbidedicated.json#L670 |
The following errors/warnings exist before current PR submission:
Rule | Message |
---|---|
R3030 - PathResourceProviderMatchNamespace |
The last resource provider 'Microsoft.PowerBIDedicated' doesn't match the namespace. Location: Microsoft.PowerBIdedicated/stable/2017-10-01/powerbidedicated.json#L40 |
R3030 - PathResourceProviderMatchNamespace |
The last resource provider 'Microsoft.PowerBIDedicated' doesn't match the namespace. Location: Microsoft.PowerBIdedicated/stable/2017-10-01/powerbidedicated.json#L266 |
R3030 - PathResourceProviderMatchNamespace |
The last resource provider 'Microsoft.PowerBIDedicated' doesn't match the namespace. Location: Microsoft.PowerBIdedicated/stable/2017-10-01/powerbidedicated.json#L316 |
R3030 - PathResourceProviderMatchNamespace |
The last resource provider 'Microsoft.PowerBIDedicated' doesn't match the namespace. Location: Microsoft.PowerBIdedicated/stable/2017-10-01/powerbidedicated.json#L366 |
R3030 - PathResourceProviderMatchNamespace |
The last resource provider 'Microsoft.PowerBIDedicated' doesn't match the namespace. Location: Microsoft.PowerBIdedicated/stable/2017-10-01/powerbidedicated.json#L408 |
R3030 - PathResourceProviderMatchNamespace |
The last resource provider 'Microsoft.PowerBIDedicated' doesn't match the namespace. Location: Microsoft.PowerBIdedicated/stable/2017-10-01/powerbidedicated.json#L447 |
R3030 - PathResourceProviderMatchNamespace |
The last resource provider 'Microsoft.PowerBIDedicated' doesn't match the namespace. Location: Microsoft.PowerBIdedicated/stable/2017-10-01/powerbidedicated.json#L480 |
R3030 - PathResourceProviderMatchNamespace |
The last resource provider 'Microsoft.PowerBIDedicated' doesn't match the namespace. Location: Microsoft.PowerBIdedicated/stable/2017-10-01/powerbidedicated.json#L529 |
R3030 - PathResourceProviderMatchNamespace |
The last resource provider 'Microsoft.PowerBIDedicated' doesn't match the namespace. Location: Microsoft.PowerBIdedicated/stable/2017-10-01/powerbidedicated.json#L560 |
R4018 - OperationsApiResponseSchema |
The response schema of operations API '/providers/Microsoft.PowerBIDedicated/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.PowerBIdedicated/stable/2017-10-01/powerbidedicated.json#L529 |
R4037 - MissingTypeObject |
The schema 'OperationListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.PowerBIdedicated/stable/2017-10-01/powerbidedicated.json#L614 |
R4037 - MissingTypeObject |
The schema 'display' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.PowerBIdedicated/stable/2017-10-01/powerbidedicated.json#L641 |
R4037 - MissingTypeObject |
The schema 'error' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.PowerBIdedicated/stable/2017-10-01/powerbidedicated.json#L946 |
Based on the response model schema, operation 'Capacities_ListSkus' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.PowerBIdedicated/stable/2017-10-01/powerbidedicated.json#L448 |
|
Based on the response model schema, operation 'Capacities_ListSkusForCapacity' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.PowerBIdedicated/stable/2017-10-01/powerbidedicated.json#L481 |
|
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: nameAvailable Location: Microsoft.PowerBIdedicated/stable/2017-10-01/powerbidedicated.json#L983 |
|
Property 'location' must have ''x-ms-mutability':['read', 'create']' extension defined. Resource Model: 'Resource' Location: Microsoft.PowerBIdedicated/stable/2017-10-01/powerbidedicated.json#L613 |
|
The x-ms-code-generation-setting extension is being deprecated. Please remove it and move settings to readme file for code generation. Location: Microsoft.PowerBIdedicated/stable/2017-10-01/powerbidedicated.json#L7 |
|
Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get details of a capacity Location: Microsoft.PowerBIdedicated/stable/2017-10-01/powerbidedicated.json#L153 |
|
Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get details of a capacity Location: Microsoft.PowerBIdedicated/stable/2017-10-01/powerbidedicated.json#L319 |
|
Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get details of a capacity Location: Microsoft.PowerBIdedicated/stable/2017-10-01/powerbidedicated.json#L411 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️
[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️
[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
Hi @cfurmanczyk, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
NewApiVersionRequired reason: |
76fbd05
to
f882f4a
Compare
Hi @ArcturusZhang Please help confirm breaking change for Go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest looks good to me
...edicated/resource-manager/Microsoft.PowerBIdedicated/stable/2017-10-01/powerbidedicated.json
Show resolved
Hide resolved
...edicated/resource-manager/Microsoft.PowerBIdedicated/stable/2017-10-01/powerbidedicated.json
Show resolved
Hide resolved
...edicated/resource-manager/Microsoft.PowerBIdedicated/stable/2017-10-01/powerbidedicated.json
Show resolved
Hide resolved
...edicated/resource-manager/Microsoft.PowerBIdedicated/stable/2017-10-01/powerbidedicated.json
Show resolved
Hide resolved
@cfurmanczyk please follow the bot advice to ask for approve for swagger breaking change. |
…ary in older api-version.
@ArcturusZhang Added fields are to satisfy s360 issues where the swagger specification is missing fields our service provides. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
…soft.PowerBIdedicated to add version stable/2017-10-01 (#2041) Create to sync Azure/azure-rest-api-specs#15915 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...AzureSDKAutomation:sdkAuto/powerbidedicated?expand=1)
…version stable/2017-10-01 (Azure#15915) * Update missing properties in PowerBIDedicated objects 2017-10-01 * Move PowerBIDedicated properties to new definitions * Realign error response to recommended schema. 202 response not necessary in older api-version.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.