Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev desktopvirtualization microsoft.desktop virtualization 2021 09 03 preview #15913

Conversation

datr93
Copy link
Contributor

@datr93 datr93 commented Sep 3, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @datr93 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Sep 3, 2021

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️⚠️LintDiff: 5 Warnings warning [Detail]
    The following errors/warnings are introduced by current PR:
    Rule Message
    ⚠️ R1006 - PutInOperationName 'PUT' operation 'PrivateEndpointConnections_UpdateByHostPool' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L2599
    ⚠️ R1006 - PutInOperationName 'PUT' operation 'PrivateEndpointConnections_UpdateByWorkspace' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L2834
    ⚠️ R2017 - PutRequestResponseScheme A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'PrivateEndpointConnections_UpdateByHostPool' Request Model: 'PrivateEndpointConnection' Response Model: 'PrivateEndpointConnectionWithSystemData'
    Location: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L2595
    ⚠️ R2017 - PutRequestResponseScheme A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'PrivateEndpointConnections_UpdateByWorkspace' Request Model: 'PrivateEndpointConnection' Response Model: 'PrivateEndpointConnectionWithSystemData'
    Location: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L2830
    ⚠️ R4014 - AllResourcesMustHaveGetOperation The resource 'PrivateLinkResource' does not have get operation, please add it.
    Location: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L5350


    The following errors/warnings exist before current PR submission:

    Only 23 items are listed, please refer to log for more details.

    Rule Message
    ⚠️ R1003 - ListInOperationName Since operation 'MsixImages_Expand' response has model definition 'x-ms-pageable', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L2118
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L3010
    ⚠️ R2066 - PostOperationIdContainsUrlVerb OperationId should contain the verb: 'expandmsiximage' in:'MsixImages_Expand'. Consider updating the operationId
    Location: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L2118
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'applications' with immediate parent 'ApplicationGroup', must have a list by immediate parent operation.
    Location: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L3962
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'desktops' with immediate parent 'ApplicationGroup', must have a list by immediate parent operation.
    Location: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L4195
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'sessionHosts' with immediate parent 'HostPool', must have a list by immediate parent operation.
    Location: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L4480
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'msixPackages' with immediate parent 'HostPool', must have a list by immediate parent operation.
    Location: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L3756
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'userSessions' with immediate parent 'SessionHost', must have a list by immediate parent operation.
    Location: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L4846
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: force
    Location: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L1431
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: force
    Location: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L1750
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: force
    Location: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L2245
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction
    Location: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L3006
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: cloudPcResource
    Location: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L3100
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: cloudPcResource
    Location: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L3262
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: validationEnvironment
    Location: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L3439
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: startVMOnConnect
    Location: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L3499
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: cloudPcResource
    Location: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L3507
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: validationEnvironment
    Location: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L3601
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: startVMOnConnect
    Location: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L3652
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isRegularRegistration
    Location: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L3809
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isActive
    Location: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L3814
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isActive
    Location: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L3867
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isRegularRegistration
    Location: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L3871
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️❌Cross-Version Breaking Changes: 29 Errors, 170 Warnings failed [Detail]
    The following breaking changes are detected by comparison with the latest stable version:

    Only 23 items are listed, please refer to log for more details.

    Rule Message
    1011 - AddingResponseCode The new version adds a response code 'default'.
    New: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L53:11
    1019 - RemovedEnumValue The new version is removing enum value(s) 'Personal, BYODesktop' from the old version.
    New: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L4979:9
    Old: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L4392:9
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L5041:9
    Old: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L4464:9
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L5071:9
    Old: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L4495:9
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L5087:9
    Old: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L4512:9
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L5142:9
    Old: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L4568:9
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L4316:9
    Old: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L3743:9
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L4070:9
    Old: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L3503:9
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L4166:9
    Old: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L3598:9
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L3415:9
    Old: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L2885:9
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L3434:9
    Old: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L2903:9
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L3566:9
    Old: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L3021:9
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L3596:9
    Old: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L3050:9
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L4514:9
    Old: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L3936:9
    1024 - ConstraintIsStronger The new version has a more constraining 'minimum' value than the previous one.
    New: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L5064:9
    Old: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L4488:9
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'hostPoolType' renamed or removed?
    New: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L5238:7
    Old: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L4641:7
    1034 - AddedRequiredProperty The new version has new required property 'hour' that was not found in the old version.
    New: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L5167:7
    1034 - AddedRequiredProperty The new version has new required property 'minute' that was not found in the old version.
    New: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L5167:7
    1034 - AddedRequiredProperty The new version has new required property 'hour, minute' that was not found in the old version.
    New: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L5041:9
    Old: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L4464:9
    1034 - AddedRequiredProperty The new version has new required property 'hour, minute' that was not found in the old version.
    New: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L5071:9
    Old: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L4495:9
    1034 - AddedRequiredProperty The new version has new required property 'hour, minute' that was not found in the old version.
    New: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L5087:9
    Old: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L4512:9
    1034 - AddedRequiredProperty The new version has new required property 'hour, minute' that was not found in the old version.
    New: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L5142:9
    Old: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L4568:9
    1036 - ConstraintChanged The new version has a different 'minimum' value than the previous one.
    New: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L5064:9
    Old: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L4488:9


    The following breaking changes are detected by comparison with latest preview version:

    Only 23 items are listed, please refer to log for more details.

    Rule Message
    ⚠️ 1011 - AddingResponseCode The new version adds a response code 'default'.
    New: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L53:11
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) 'Personal, BYODesktop' from the old version.
    New: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L4979:9
    Old: Microsoft.DesktopVirtualization/preview/2021-04-01-preview/desktopvirtualization.json#L4900:9
    ⚠️ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L5041:9
    Old: Microsoft.DesktopVirtualization/preview/2021-04-01-preview/desktopvirtualization.json#L4972:9
    ⚠️ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L5071:9
    Old: Microsoft.DesktopVirtualization/preview/2021-04-01-preview/desktopvirtualization.json#L5003:9
    ⚠️ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L5087:9
    Old: Microsoft.DesktopVirtualization/preview/2021-04-01-preview/desktopvirtualization.json#L5020:9
    ⚠️ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L5142:9
    Old: Microsoft.DesktopVirtualization/preview/2021-04-01-preview/desktopvirtualization.json#L5076:9
    ⚠️ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L4316:9
    Old: Microsoft.DesktopVirtualization/preview/2021-04-01-preview/desktopvirtualization.json#L4251:9
    ⚠️ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L4070:9
    Old: Microsoft.DesktopVirtualization/preview/2021-04-01-preview/desktopvirtualization.json#L4011:9
    ⚠️ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L4166:9
    Old: Microsoft.DesktopVirtualization/preview/2021-04-01-preview/desktopvirtualization.json#L4106:9
    ⚠️ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L3415:9
    Old: Microsoft.DesktopVirtualization/preview/2021-04-01-preview/desktopvirtualization.json#L3368:9
    ⚠️ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L3434:9
    Old: Microsoft.DesktopVirtualization/preview/2021-04-01-preview/desktopvirtualization.json#L3386:9
    ⚠️ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L3566:9
    Old: Microsoft.DesktopVirtualization/preview/2021-04-01-preview/desktopvirtualization.json#L3517:9
    ⚠️ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L3596:9
    Old: Microsoft.DesktopVirtualization/preview/2021-04-01-preview/desktopvirtualization.json#L3546:9
    ⚠️ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L4514:9
    Old: Microsoft.DesktopVirtualization/preview/2021-04-01-preview/desktopvirtualization.json#L4444:9
    ⚠️ 1024 - ConstraintIsStronger The new version has a more constraining 'minimum' value than the previous one.
    New: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L5064:9
    Old: Microsoft.DesktopVirtualization/preview/2021-04-01-preview/desktopvirtualization.json#L4996:9
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L49:13
    Old: Microsoft.DesktopVirtualization/preview/2021-04-01-preview/desktopvirtualization.json#L49:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L2963:11
    Old: Microsoft.DesktopVirtualization/preview/2021-04-01-preview/desktopvirtualization.json#L2935:11
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L2984:9
    Old: Microsoft.DesktopVirtualization/preview/2021-04-01-preview/desktopvirtualization.json#L2950:9
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L100:13
    Old: Microsoft.DesktopVirtualization/preview/2021-04-01-preview/desktopvirtualization.json#L91:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L155:13
    Old: Microsoft.DesktopVirtualization/preview/2021-04-01-preview/desktopvirtualization.json#L146:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L195:13
    Old: Microsoft.DesktopVirtualization/preview/2021-04-01-preview/desktopvirtualization.json#L186:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L244:13
    Old: Microsoft.DesktopVirtualization/preview/2021-04-01-preview/desktopvirtualization.json#L235:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.DesktopVirtualization/preview/2021-09-03-preview/desktopvirtualization.json#L283:13
    Old: Microsoft.DesktopVirtualization/preview/2021-04-01-preview/desktopvirtualization.json#L274:13
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation

    The following errors/warnings are introduced by current PR:

    |:speech_balloon: AutorestCore/Exception|"readme":"desktopvirtualization/resource-manager/readme.md",
    "tag":"package-preview-2021-09",
    "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"desktopvirtualization/resource-manager/readme.md",
    "tag":"package-preview-2021-09",
    "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"desktopvirtualization/resource-manager/readme.md",
    "tag":"package-preview-2021-09",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|

    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Sep 3, 2021

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️[Staging] SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-go - preview/desktopvirtualization/mgmt/2021-04-01-preview/desktopvirtualization - v57.1.0
    ️✔️azure-sdk-for-go - preview/desktopvirtualization/mgmt/2021-03-09-preview/desktopvirtualization - v57.1.0
    ️✔️azure-sdk-for-go - preview/desktopvirtualization/mgmt/2021-02-01-preview/desktopvirtualization - v57.1.0
    ️✔️azure-sdk-for-go - preview/desktopvirtualization/mgmt/2021-01-14-preview/desktopvirtualization - v57.1.0
    ️✔️azure-sdk-for-go - preview/desktopvirtualization/mgmt/2020-11-10-preview/desktopvirtualization - v57.1.0
    ️✔️azure-sdk-for-go - preview/desktopvirtualization/mgmt/2020-11-02-preview/desktopvirtualization - v57.1.0
    ️✔️azure-sdk-for-go - preview/desktopvirtualization/mgmt/2020-10-19-preview/desktopvirtualization - v57.1.0
    ️✔️azure-sdk-for-go - preview/desktopvirtualization/mgmt/2020-09-21-preview/desktopvirtualization - v57.1.0
    ️✔️azure-sdk-for-go - preview/desktopvirtualization/mgmt/2019-12-10-preview/desktopvirtualization - v57.1.0
    ️✔️azure-sdk-for-go - preview/desktopvirtualization/mgmt/2019-09-24-preview/desktopvirtualization - v57.1.0
    ️✔️azure-sdk-for-go - preview/desktopvirtualization/mgmt/2019-01-23-preview/desktopvirtualization - v57.1.0
    ️❌ azure-powershell failed [Detail]
    • Failed [Logs]Release - Generate from 10ca36b. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
      Resource not accessible by integration
      HttpError: Resource not accessible by integration
          at /home/vsts/work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/@octokit/[email protected]/node_modules/@octokit/request/dist-node/index.js:86:21
          at processTicksAndRejections (internal/process/task_queues.js:95:5)
          at async workflowPkgUpdatePR (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflowPackage.js:346:21)
          at async Object.exports.workflowPkgMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflowPackage.js:41:5)
          at async workflowHandleReadmeMd (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:172:9)
          at async Object.exports.workflowMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:83:9)
          at async Object.exports.sdkAutoMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/entrypoint.js:152:13)
          at async /home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/cli/cli.js:20:18
    • ️✔️Az.DesktopVirtualizationApi [View full logs
      error	Fatal error: Resource not accessible by integration
      error	The following packages are still pending:
      error		Az.DesktopVirtualizationApi
    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 10ca36b. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
      cmderr	[automation_init.sh] azure-mgmt-core 1.3.0 requires azure-core<2.0.0,>=1.15.0, but you have azure-core 1.6.0 which is incompatible.
      cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
      cmderr	[automation_init.sh] azure-mgmt-core 1.3.0 requires azure-core<2.0.0,>=1.15.0, but you have azure-core 1.6.0 which is incompatible.
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️azure-mgmt-desktopvirtualization [View full logs]  [Release SDK Changes]
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 10ca36b. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-09-14 03:25:11 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-desktopvirtualization"
      cmderr	[generate.py] 2021-09-14 03:25:11 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
      cmderr	[generate.py] 2021-09-14 03:25:11 INFO autorest --version=3.6.0 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/desktopvirtualization/azure-resourcemanager-desktopvirtualization --java.namespace=com.azure.resourcemanager.desktopvirtualization   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/desktopvirtualization/resource-manager/readme.md
      cmderr	[generate.py] 2021-09-14 03:25:58 INFO [CI][Success] Write to ci.yml
      cmderr	[generate.py] 2021-09-14 03:25:58 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-09-14 03:25:58 INFO [POM][Skip] pom already has module azure-resourcemanager-desktopvirtualization
      cmderr	[generate.py] 2021-09-14 03:25:58 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-09-14 03:25:58 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-09-14 03:25:58 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-desktopvirtualization [View full logs]  [Release SDK Changes]
      cmderr	[Inst] 2021-09-14 03:28:18 DEBUG Got artifact_id: azure-resourcemanager-desktopvirtualization
      cmderr	[Inst] 2021-09-14 03:28:18 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-09-14 03:28:18 DEBUG Got artifact: azure-resourcemanager-desktopvirtualization-1.0.0-beta.1-javadoc.jar
      cmderr	[Inst] 2021-09-14 03:28:18 DEBUG Got artifact: azure-resourcemanager-desktopvirtualization-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-09-14 03:28:18 DEBUG Match jar package: azure-resourcemanager-desktopvirtualization-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-09-14 03:28:18 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/15913/azure-sdk-for-java/azure-resourcemanager-desktopvirtualization/azure-resourcemanager-desktopvirtualization-1.0.0-beta.1.jar\" -o azure-resourcemanager-desktopvirtualization-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-desktopvirtualization -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-desktopvirtualization-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 10ca36b. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️preview/desktopvirtualization/mgmt/2021-04-01-preview/desktopvirtualization [View full logs]  [Release SDK Changes]
      info	[Changelog] This is a new package
    • ️✔️preview/desktopvirtualization/mgmt/2021-03-09-preview/desktopvirtualization [View full logs
      info	[Changelog] This is a new package
    • ️✔️preview/desktopvirtualization/mgmt/2021-02-01-preview/desktopvirtualization [View full logs
      info	[Changelog] This is a new package
    • ️✔️preview/desktopvirtualization/mgmt/2021-01-14-preview/desktopvirtualization [View full logs
      info	[Changelog] This is a new package
    • ️✔️preview/desktopvirtualization/mgmt/2020-11-10-preview/desktopvirtualization [View full logs
      info	[Changelog] This is a new package
    • ️✔️preview/desktopvirtualization/mgmt/2020-11-02-preview/desktopvirtualization [View full logs
      info	[Changelog] No exported changes
    • ️✔️preview/desktopvirtualization/mgmt/2020-10-19-preview/desktopvirtualization [View full logs
      info	[Changelog] No exported changes
    • ️✔️preview/desktopvirtualization/mgmt/2020-09-21-preview/desktopvirtualization [View full logs
      info	[Changelog] No exported changes
    • ️✔️preview/desktopvirtualization/mgmt/2019-12-10-preview/desktopvirtualization [View full logs
      info	[Changelog] No exported changes
    • ️✔️preview/desktopvirtualization/mgmt/2019-09-24-preview/desktopvirtualization [View full logs
      info	[Changelog] No exported changes
    • ️✔️preview/desktopvirtualization/mgmt/2019-01-23-preview/desktopvirtualization [View full logs
      info	[Changelog] No exported changes
    ️⚠️ azure-sdk-for-js warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 10ca36b. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/desktopvirtualization/resource-manager/readme.md
      warn	No file changes detected after generation
      warn	No package detected after generation
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 10ca36b. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]  WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️desktopvirtualization [View full logs]  [Release Schema Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @datr93, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

    TaskHow to fixPrioritySupport (Microsoft alias)
    AvocadoFix-AvocadoHighruowan
    Semantic validationFix-SemanticValidation-ErrorHighraychen, jianyxi
    Model validationFix-ModelValidation-ErrorHighraychen,jianyxi
    LintDiffFix-LintDiffhighjianyxi, ruoxuan
    If you need further help, please feedback via swagger feedback."

    @datr93 datr93 force-pushed the dev-desktopvirtualization-Microsoft.DesktopVirtualization-2021-09-03-preview branch from 6eeb17f to 8067588 Compare September 3, 2021 17:51
    @datr93 datr93 force-pushed the dev-desktopvirtualization-Microsoft.DesktopVirtualization-2021-09-03-preview branch from fc90060 to 4d026b4 Compare September 4, 2021 16:59
    @lirenhe lirenhe added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 6, 2021
    @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Sep 8, 2021
    @openapi-workflow-bot
    Copy link

    Hi, @datr93 your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]).

    @datr93 datr93 requested a review from dallinlmag September 9, 2021 19:09
    @majastrz majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 9, 2021
    Copy link
    Member

    @majastrz majastrz left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Signed off from ARM side.

    @lirenhe lirenhe merged commit 10ca36b into Azure:main Sep 14, 2021
    ghost pushed a commit to Azure/azure-resource-manager-schemas that referenced this pull request Sep 14, 2021
    LeiWang3 pushed a commit to LeiWang3/azure-rest-api-specs that referenced this pull request Mar 31, 2022
    … preview (Azure#15913)
    
    * Adds base for updating Microsoft.DesktopVirtualization from version preview/2021-04-01-preview to version 2021-09-03-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * add scaling plan changes
    
    * fix pagination
    
    * system data for all
    
    * add object type
    
    * Trigger Build
    
    * more object types
    
    * more object types
    
    * add description
    
    * add error response
    
    * int format
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    5 participants