Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scaleDownMode to agent pool properties #15124

Merged
merged 4 commits into from
Jul 14, 2021
Merged

Add scaleDownMode to agent pool properties #15124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4d5648c
add scale down mode
marwanad Jul 8, 2021
735f55f
address comments
marwanad Jul 9, 2021
bb5ac29
fix markdown link
marwanad Jul 12, 2021
d47924c
update proper api version
marwanad Jul 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...r/Microsoft.ContainerService/stable/2021-07-01/examples/ManagedClustersCreate_Update.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
"vmSize": "Standard_DS1_v2",
"osType": "Linux",
"type": "VirtualMachineScaleSets",
"scaleDownMode": "Deallocate",
"availabilityZones": [
"1",
"2",
Expand Down Expand Up @@ -108,6 +109,7 @@
"provisioningState": "Succeeded",
"orchestratorVersion": "1.9.6",
"type": "VirtualMachineScaleSets",
"scaleDownMode": "Deallocate",
"availabilityZones": [
"1",
"2",
Expand Down Expand Up @@ -209,6 +211,7 @@
"provisioningState": "Creating",
"orchestratorVersion": "1.9.6",
"type": "VirtualMachineScaleSets",
"scaleDownMode": "Deallocate",
"availabilityZones": [
"1",
"2",
Expand Down
27 changes: 27 additions & 0 deletions ...ervice/resource-manager/Microsoft.ContainerService/stable/2021-07-01/managedClusters.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2371,6 +2371,11 @@
"type": "boolean",
"description": "Whether to enable auto-scaler"
},
"scaleDownMode": {
"$ref": "#/definitions/ScaleDownMode",
"title": "The scale down mode to use when scaling the Agent Pool.",
"description": "This also effects the cluster autoscaler behavior. If not specified, it defaults to Delete."
},
"type": {
"$ref": "#/definitions/AgentPoolType"
},
Expand Down Expand Up @@ -4183,6 +4188,28 @@
"title": "The max price (in US Dollars) you are willing to pay for spot instances. Possible values are any decimal value greater than zero or -1 which indicates default price to be up-to on-demand.",
"description": "Possible values are any decimal value greater than zero or -1 which indicates the willingness to pay any on-demand price. For more details on spot pricing, see [spot VMs pricing](https://docs.microsoft.com/azure/virtual-machines/spot-vms#pricing)"
},
"ScaleDownMode": {
marwanad marked this conversation as resolved.
Show resolved Hide resolved
"type": "string",
"enum": [
"Delete",
"Deallocate"
],
"x-ms-enum": {
"name": "ScaleDownMode",
"modelAsString": true,
"values": [
{
"value": "Delete",
"description": "Create new instances during scale up and remove instances during scale down."
},
{
"value": "Deallocate",
"description": "Attempt to start deallocated instances (if they exist) during scale up and deallocate instances during scale down."
}
]
},
"description": "Describes how VMs are added to or removed from Agent Pools. See [billing states](https://docs.microsoft.com/azure/virtual-machines/states-billing)."
},
"ProximityPlacementGroupID": {
"type": "string",
"description": "The ID for Proximity Placement Group."
Expand Down