-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove maxSizeBytes property from Synapse v3 database GET and PUT #13988
Remove maxSizeBytes property from Synapse v3 database GET and PUT #13988
Conversation
Hi, @chzachar Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
Rule | Message |
---|---|
1033 - RemovedProperty |
The new version is missing a property found in the old version. Was 'maxSizeBytes' renamed or removed? New: Microsoft.Synapse/preview/2020-04-01-preview/sqlDatabase.json#L279:7 Old: Microsoft.Synapse/preview/2020-04-01-preview/sqlDatabase.json#L279:7 |
️⚠️
LintDiff: 0 Warnings warning [Detail]
- Linted configuring files (Based on source branch, openapi-validator v1.9.2 , classic-openapi-validator v1.1.6 )
- Linted configuring files (Based on target branch, openapi-validator v1.9.2 , classic-openapi-validator v1.1.6 )
Rule | Message |
---|---|
The enum types should have x-ms-enum type extension set with appropriate options. Property name: createdByType Location: synapse/common/v1/types.json#L86 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Property name: lastModifiedByType Location: synapse/common/v1/types.json#L108 |
|
Guid used in model definition 'SqlPoolProperties' for property 'sqlPoolGuid'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. Location: Microsoft.Synapse/preview/2020-04-01-preview/sqlPool.json#L303 |
|
Guid used in model definition 'SqlDatabaseProperties' for property 'databaseGuid'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. Location: Microsoft.Synapse/preview/2020-04-01-preview/sqlDatabase.json#L306 |
|
The API version:2020-04-01-preview having been in a preview state over one year , please move it to GA or retire. Location: Microsoft.Synapse/preview/2020-04-01-preview/operations.json#L4 |
|
The API version:2020-04-01-preview having been in a preview state over one year , please move it to GA or retire. Location: Microsoft.Synapse/preview/2020-04-01-preview/sqlPool.json#L4 |
|
The API version:2020-04-01-preview having been in a preview state over one year , please move it to GA or retire. Location: Microsoft.Synapse/preview/2020-04-01-preview/sqlDatabase.json#L4 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️
[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
|:speech_balloon: AutorestCore/Exception|"readme":"synapse/resource-manager/readme.md",
"tag":"package-sqlGen3-2020-04-01-preview",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"synapse/resource-manager/readme.md",
"tag":"package-sqlGen3-2020-04-01-preview",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
The following errors/warnings exist before current PR submission:
|:speech_balloon: AutorestCore/Exception|"readme":"synapse/resource-manager/readme.md",
"tag":"package-sqlGen3-2020-04-01-preview",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
️️✔️
[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
Hi @chzachar, Your PR has some issues. Please fix the CI sequentially by following the order of
|
Hi @chzachar, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
…base GET and PUT (#1760) Create to sync Azure/azure-rest-api-specs#13988 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/master...AzureSDKAutomation:sdkAuto/synapse?expand=1)
…ure#13988) * remove maxSizeBytes property * update examples
…ure#13988) * remove maxSizeBytes property * update examples
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Removing property 'maxSizeBytes' from private preview API for Synapse gen3 databases.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.