Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove maxSizeBytes property from Synapse v3 database GET and PUT #13988

Merged

Conversation

chzachar
Copy link
Contributor

@chzachar chzachar commented Apr 16, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Removing property 'maxSizeBytes' from private preview API for Synapse gen3 databases.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify : maxSizeBytes property is not applicable to gen3 sqlDatabases within Synapse, as there are no size limits that customer can configure
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet. May 2021
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet. May 2021
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @chzachar Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 16, 2021

    Swagger Validation Report

    ️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'maxSizeBytes' renamed or removed?
    New: Microsoft.Synapse/preview/2020-04-01-preview/sqlDatabase.json#L279:7
    Old: Microsoft.Synapse/preview/2020-04-01-preview/sqlDatabase.json#L279:7
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    The following errors/warnings exist before current PR submission:
    Rule Message
    ⚠️ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options. Property name: createdByType
    Location: synapse/common/v1/types.json#L86
    ⚠️ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options. Property name: lastModifiedByType
    Location: synapse/common/v1/types.json#L108
    ⚠️ R3017 - GuidUsage Guid used in model definition 'SqlPoolProperties' for property 'sqlPoolGuid'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board.
    Location: Microsoft.Synapse/preview/2020-04-01-preview/sqlPool.json#L303
    ⚠️ R3017 - GuidUsage Guid used in model definition 'SqlDatabaseProperties' for property 'databaseGuid'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board.
    Location: Microsoft.Synapse/preview/2020-04-01-preview/sqlDatabase.json#L306
    ⚠️ R4024 - PreviewVersionOverOneYear The API version:2020-04-01-preview having been in a preview state over one year , please move it to GA or retire.
    Location: Microsoft.Synapse/preview/2020-04-01-preview/operations.json#L4
    ⚠️ R4024 - PreviewVersionOverOneYear The API version:2020-04-01-preview having been in a preview state over one year , please move it to GA or retire.
    Location: Microsoft.Synapse/preview/2020-04-01-preview/sqlPool.json#L4
    ⚠️ R4024 - PreviewVersionOverOneYear The API version:2020-04-01-preview having been in a preview state over one year , please move it to GA or retire.
    Location: Microsoft.Synapse/preview/2020-04-01-preview/sqlDatabase.json#L4
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation

    The following errors/warnings are introduced by current PR:

    |:speech_balloon: AutorestCore/Exception|"readme":"synapse/resource-manager/readme.md",
    "tag":"package-sqlGen3-2020-04-01-preview",
    "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"synapse/resource-manager/readme.md",
    "tag":"package-sqlGen3-2020-04-01-preview",
    "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|


    The following errors/warnings exist before current PR submission:

    |:speech_balloon: AutorestCore/Exception|"readme":"synapse/resource-manager/readme.md",
    "tag":"package-sqlGen3-2020-04-01-preview",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|

    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 16, 2021

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌[Staging] SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-synapse - 2.0.0
    ️✔️azure-sdk-for-go - synapse/mgmt/2021-03-01/synapse - v55.1.0
    ️✔️azure-sdk-for-go - synapse/mgmt/2020-12-01/synapse - v55.1.0
    azure-sdk-for-go - preview/synapse/mgmt/2019-06-01-preview/synapse - v55.1.0
    +	Field `HaveLibraryRequirementsChanged` of struct `BigDataPoolResourceProperties` has been removed
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 836f657. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-5.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/synapse/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.Synapse [View full logs]  [Release SDK Changes]
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 836f657. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/synapse/resource-manager/readme.md
    • ️✔️@azure/arm-synapse [View full logs]  [Release SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/synapseManagementClient.js → ./dist/arm-synapse.js...
      cmderr	[npmPack] created ./dist/arm-synapse.js in 1.3s
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 836f657. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-06-14 15:02:50 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-synapse;1.0.0-beta.1;1.0.0-beta.2"
      cmderr	[generate.py] 2021-06-14 15:02:50 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.2"
      cmderr	[generate.py] 2021-06-14 15:02:50 INFO autorest --version=3.1.3 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/synapse/azure-resourcemanager-synapse --java.namespace=com.azure.resourcemanager.synapse   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/synapse/resource-manager/readme.md
      cmderr	[generate.py] 2021-06-14 15:04:14 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-synapse
      cmderr	[generate.py] 2021-06-14 15:04:14 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-06-14 15:04:14 INFO [POM][Skip] pom already has module azure-resourcemanager-synapse
      cmderr	[generate.py] 2021-06-14 15:04:14 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-06-14 15:04:14 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-06-14 15:04:14 INFO [POM][Skip] pom already has module sdk/synapse
      cmderr	[generate.py] 2021-06-14 15:04:14 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-synapse [View full logs]  [Release SDK Changes]
      cmderr	[Inst] 2021-06-14 15:08:24 DEBUG Got artifact_id: azure-resourcemanager-synapse
      cmderr	[Inst] 2021-06-14 15:08:24 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-06-14 15:08:24 DEBUG Got artifact: azure-resourcemanager-synapse-1.0.0-beta.2-sources.jar
      cmderr	[Inst] 2021-06-14 15:08:24 DEBUG Got artifact: azure-resourcemanager-synapse-1.0.0-beta.2.jar
      cmderr	[Inst] 2021-06-14 15:08:24 DEBUG Match jar package: azure-resourcemanager-synapse-1.0.0-beta.2.jar
      cmderr	[Inst] 2021-06-14 15:08:24 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/13988/azure-sdk-for-java/azure-resourcemanager-synapse/azure-resourcemanager-synapse-1.0.0-beta.2.jar\" -o azure-resourcemanager-synapse-1.0.0-beta.2.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-synapse -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-synapse-1.0.0-beta.2.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 836f657. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
      cmderr	[automation_init.sh] azure-mgmt-core 1.2.2 requires azure-core<2.0.0,>=1.9.0, but you have azure-core 1.6.0 which is incompatible.
      cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
      cmderr	[automation_init.sh] azure-mgmt-core 1.2.2 requires azure-core<2.0.0,>=1.9.0, but you have azure-core 1.6.0 which is incompatible.
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️azure-mgmt-synapse [View full logs]  [Release SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Model CustomerManagedKeyDetails has a new parameter kek_identity
      info	[Changelog]   - Model Workspace has a new parameter csp_workspace_admin_properties
      info	[Changelog]   - Added operation PrivateEndpointConnectionsPrivateLinkHubOperations.get
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 836f657. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-synapse [View full logs]  [Release SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Model Workspace has a new parameter csp_workspace_admin_properties
      info	[Changelog]   - Model CustomerManagedKeyDetails has a new parameter kek_identity
      info	[Changelog]   - Added operation PrivateEndpointConnectionsPrivateLinkHubOperations.get
    ️❌ azure-sdk-for-go failed [Detail]
    • Failed [Logs]Release - Generate from 836f657. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
      Validation Failed: {"resource":"PullRequest","field":"head","code":"invalid"}
      HttpError: Validation Failed: {"resource":"PullRequest","field":"head","code":"invalid"}
          at /home/vsts/work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/@octokit/[email protected]/node_modules/@octokit/request/dist-node/index.js:76:23
          at processTicksAndRejections (internal/process/task_queues.js:95:5)
          at async workflowPkgUpdatePR (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflowPackage.js:330:21)
          at async Object.exports.workflowPkgMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflowPackage.js:41:5)
          at async workflowHandleReadmeMd (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:172:9)
          at async Object.exports.workflowMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:83:9)
          at async Object.exports.sdkAutoMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/entrypoint.js:152:13)
          at async /home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/cli/cli.js:20:18
    • ️✔️synapse/mgmt/2021-03-01/synapse [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️synapse/mgmt/2020-12-01/synapse [View full logs]  [Release SDK Changes]
      Only show 40 items here, please refer to log for details.
      info	[Changelog]
      info	[Changelog] ### New Content
      info	[Changelog]
      info	[Changelog] - New function `*LibraryListResponseIterator.NextWithContext(context.Context) error`
      info	[Changelog] - New function `NewLibraryListResponseIterator(LibraryListResponsePage) LibraryListResponseIterator`
      info	[Changelog] - New function `NewLibrariesClient(string) LibrariesClient`
      info	[Changelog] - New function `LibraryListResponseIterator.Response() LibraryListResponse`
      info	[Changelog] - New function `LibrariesClient.ListByWorkspace(context.Context, string, string) (LibraryListResponsePage, error)`
      info	[Changelog] - New function `LibrariesClient.ListByWorkspaceSender(*http.Request) (*http.Response, error)`
      info	[Changelog] - New function `LibraryListResponse.IsEmpty() bool`
      info	[Changelog] - New function `NewLibrariesClientWithBaseURI(string, string) LibrariesClient`
      info	[Changelog] - New function `LibraryListResponsePage.Values() []LibraryResource`
      info	[Changelog] - New function `*LibraryListResponsePage.Next() error`
      info	[Changelog] - New function `NewLibraryClient(string) LibraryClient`
      info	[Changelog] - New function `LibraryClient.Get(context.Context, string, string, string) (LibraryResource, error)`
      info	[Changelog] - New function `LibrariesClient.ListByWorkspaceResponder(*http.Response) (LibraryListResponse, error)`
      info	[Changelog] - New function `LibrariesClient.ListByWorkspacePreparer(context.Context, string, string) (*http.Request, error)`
      info	[Changelog] - New function `*LibraryResource.UnmarshalJSON([]byte) error`
      info	[Changelog] - New function `LibraryClient.GetPreparer(context.Context, string, string, string) (*http.Request, error)`
      info	[Changelog] - New function `LibraryListResponseIterator.Value() LibraryResource`
      info	[Changelog] - New function `NewLibraryClientWithBaseURI(string, string) LibraryClient`
      info	[Changelog] - New function `*LibraryListResponseIterator.Next() error`
      info	[Changelog] - New function `LibraryResource.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `LibraryListResponsePage.NotDone() bool`
      info	[Changelog] - New function `LibrariesClient.ListByWorkspaceComplete(context.Context, string, string) (LibraryListResponseIterator, error)`
      info	[Changelog] - New function `LibraryClient.GetSender(*http.Request) (*http.Response, error)`
      info	[Changelog] - New function `LibraryListResponseIterator.NotDone() bool`
      info	[Changelog] - New function `*LibraryListResponsePage.NextWithContext(context.Context) error`
      info	[Changelog] - New function `LibraryListResponsePage.Response() LibraryListResponse`
      info	[Changelog] - New function `NewLibraryListResponsePage(LibraryListResponse, func(context.Context, LibraryListResponse) (LibraryListResponse, error)) LibraryListResponsePage`
      info	[Changelog] - New function `LibraryClient.GetResponder(*http.Response) (LibraryResource, error)`
      info	[Changelog] - New struct `LibrariesClient`
      info	[Changelog] - New struct `LibraryClient`
      info	[Changelog] - New struct `LibraryListResponse`
      info	[Changelog] - New struct `LibraryListResponseIterator`
      info	[Changelog] - New struct `LibraryListResponsePage`
      info	[Changelog] - New struct `LibraryResource`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 40 additive change(s).
      info	[Changelog]
    • ️✔️preview/synapse/mgmt/2019-06-01-preview/synapse [View full logsBreaking Change Detected
      Only show 40 items here, please refer to log for details.
      info	[Changelog] - New struct `DynamicExecutorAllocation`
      info	[Changelog] - New struct `LibraryInfo`
      info	[Changelog] - New struct `MaintenanceWindowOptions`
      info	[Changelog] - New struct `MaintenanceWindowOptionsProperties`
      info	[Changelog] - New struct `MaintenanceWindowTimeRange`
      info	[Changelog] - New struct `MaintenanceWindows`
      info	[Changelog] - New struct `MaintenanceWindowsProperties`
      info	[Changelog] - New struct `ManagedVirtualNetworkReference`
      info	[Changelog] - New struct `PrivateLinkHubPrivateLinkResourcesClient`
      info	[Changelog] - New struct `RecommendedSensitivityLabelUpdate`
      info	[Changelog] - New struct `RecommendedSensitivityLabelUpdateList`
      info	[Changelog] - New struct `RecommendedSensitivityLabelUpdateProperties`
      info	[Changelog] - New struct `SQLPoolMaintenanceWindowOptionsClient`
      info	[Changelog] - New struct `SQLPoolMaintenanceWindowsClient`
      info	[Changelog] - New struct `SQLPoolRecommendedSensitivityLabelsClient`
      info	[Changelog] - New struct `SensitivityLabelUpdate`
      info	[Changelog] - New struct `SensitivityLabelUpdateList`
      info	[Changelog] - New struct `SensitivityLabelUpdateProperties`
      info	[Changelog] - New field `CacheSize` in struct `BigDataPoolResourceProperties`
      info	[Changelog] - New field `LastSucceededTimestamp` in struct `BigDataPoolResourceProperties`
      info	[Changelog] - New field `CustomLibraries` in struct `BigDataPoolResourceProperties`
      info	[Changelog] - New field `DynamicExecutorAllocation` in struct `BigDataPoolResourceProperties`
      info	[Changelog] - New field `TenantID` in struct `WorkspaceRepositoryConfiguration`
      info	[Changelog] - New field `LastCommitID` in struct `WorkspaceRepositoryConfiguration`
      info	[Changelog] - New field `SchemaName` in struct `SensitivityLabelProperties`
      info	[Changelog] - New field `Rank` in struct `SensitivityLabelProperties`
      info	[Changelog] - New field `TableName` in struct `SensitivityLabelProperties`
      info	[Changelog] - New field `ColumnName` in struct `SensitivityLabelProperties`
      info	[Changelog] - New field `ManagedBy` in struct `SensitivityLabel`
      info	[Changelog] - New field `ManagedVirtualNetwork` in struct `ManagedIntegrationRuntime`
      info	[Changelog] - New field `IsComputed` in struct `SQLPoolColumnProperties`
      info	[Changelog] - New field `AdlaResourceID` in struct `WorkspaceProperties`
      info	[Changelog]
      info	[Changelog] Total 1 breaking change(s), 119 additive change(s).
      info	[Changelog]
      error	Fatal error: Validation Failed: {"resource":"PullRequest","field":"head","code":"invalid"}
      error	The following packages are still pending:
      error		synapse/mgmt/2021-03-01/synapse
      error		synapse/mgmt/2020-12-01/synapse
      error		preview/synapse/mgmt/2019-06-01-preview/synapse
    ️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 836f657. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️synapse [View full logs]  [Release Schema Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @chzachar, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

    TaskHow to fixPrioritySupport (Microsoft alias)
    AvocadoFix-AvocadoHighruowan
    Semantic validationFix-SemanticValidation-ErrorHighraychen, jianyxi
    Model validationFix-ModelValidation-ErrorHighraychen,jianyxi
    LintDiffFix-LintDiffhighjianyxi, ruoxuan
    If you need further help, please feedback via swagger feedback."

    @openapi-workflow-bot
    Copy link

    Hi @chzachar, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label May 27, 2021
    @chzachar chzachar marked this pull request as ready for review May 27, 2021 17:32
    @ruowan
    Copy link
    Member

    ruowan commented Jun 8, 2021

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    asager pushed a commit to asager/azure-rest-api-specs that referenced this pull request Jun 24, 2021
    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 CI-BreakingChange-Go CI-BreakingChange-Python
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants