Updating AzureCommunicationServices Chat Events Schema for MRI->CommunicationIdentifier transition #13048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
February 10, 2021 07:37
Revert "Create an alias for CommunicationIdentifierModel" This reverts commit 19ef901.
|
Hi, @vikrampraveen Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Communication/stable/2018-01-01/AzureCommunicationServices.json#L70 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Communication/stable/2018-01-01/AzureCommunicationServices.json#L122 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️[Staging] SDK Track2 Validation: 32 Warnings warning [Detail]
Only 10 items are listed, please refer to log for more details.
- The following tags are being changed in this PR
| Rule | Message |
|---|---|
| "readme":"eventgrid/data-plane/readme.md", "tag":"package-2018-01", "details":"The schema 'IotHubDeviceCreatedEventData' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"eventgrid/data-plane/readme.md", "tag":"package-2018-01", "details":"The schema 'IotHubDeviceDeletedEventData' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"eventgrid/data-plane/readme.md", "tag":"package-2018-01", "details":"The schema 'IotHubDeviceConnectedEventData' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"eventgrid/data-plane/readme.md", "tag":"package-2018-01", "details":"The schema 'IotHubDeviceDisconnectedEventData' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"eventgrid/data-plane/readme.md", "tag":"package-2018-01", "details":"The schema 'IotHubDeviceTelemetryEventData' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"eventgrid/data-plane/readme.md", "tag":"package-2018-01", "details":"The schema 'ContainerRegistryImagePushedEventData' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"eventgrid/data-plane/readme.md", "tag":"package-2018-01", "details":"The schema 'ContainerRegistryImageDeletedEventData' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"eventgrid/data-plane/readme.md", "tag":"package-2018-01", "details":"The schema 'ContainerRegistryChartPushedEventData' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"eventgrid/data-plane/readme.md", "tag":"package-2018-01", "details":"The schema 'ContainerRegistryChartDeletedEventData' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"eventgrid/data-plane/readme.md", "tag":"package-2018-01", "details":"The schema 'ContainerRegistryEventData' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
vikrampraveen
requested review from
DominikMe,
RezaJooyandeh,
amrelroumy-msft,
juancamilor,
bashan-git and
VikramDhumal
|
Hi @vikrampraveen, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
Kishp01
approved these changes
Feb 19, 2021
lmazuel
approved these changes
Feb 19, 2021
This was referenced Feb 19, 2021
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
…nicationIdentifier transition (Azure#13048) * Add new communicationIdentifier properties and participant events * Remove deprecated properties and events * Fix one more member to participant * Create an alias for CommunicationIdentifierModel * Stick to "CommunicationIdentifierModel" Revert "Create an alias for CommunicationIdentifierModel" This reverts commit 19ef901. * Rename ACS to Acs Co-authored-by: Vikram Praveen Kumar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The events will be published with both the old/new properties, so the previously released SDKs will continue to work. We are removing the older properties explicitly to ensure that newer SDKs don't continue to expose the older properties.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.