Datr/reg info and enums #12766

datr93 · 2021-02-01T22:56:35Z

REAL CHANGES STARTS FROM: 921b21341c50dae867a344cc939eee45925c8c1c

REAL CHANGES STARTS FROM: 921b21341c50dae867a344cc939eee45925c8c1c

REAL CHANGES STARTS FROM: 921b21341c50dae867a344cc939eee45925c8c1c

REAL CHANGES STARTS FROM: 921b21341c50dae867a344cc939eee45925c8c1c

REAL CHANGES STARTS FROM: 921b21341c50dae867a344cc939eee45925c8c1c

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2021-02-01T22:56:38Z

Hi, @datr93 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

openapi-pipeline-app · 2021-02-01T22:56:39Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

Linted configuring files (Based on source branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- desktopvirtualization/resource-manager/readme.md tag:package-2021-02-01-preview
Linted configuring files (Based on target branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- desktopvirtualization/resource-manager/readme.md tag:default

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

Compared Swaggers (Based on Oad v0.8.6)
- original: preview/2021-01-14-preview/desktopvirtualization.json <---> new: preview/2021-02-01-preview/desktopvirtualization.json

️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️[Staging] SDK Track2 Validation: 7 Warnings warning [Detail]

The following tags are being changed in this PR

desktopvirtualization/resource-manager/readme.md#package-2021-02-01-preview

Rule	Message
⚠️ PreCheck/SchemaMissingType	"readme":"desktopvirtualization/resource-manager/readme.md", "tag":"package-2021-02-01-preview", "details":"The schema 'CloudError' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"desktopvirtualization/resource-manager/readme.md", "tag":"package-2021-02-01-preview", "details":"The schema 'ResourceProviderOperationList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"desktopvirtualization/resource-manager/readme.md", "tag":"package-2021-02-01-preview", "details":"The schema 'ResourceProviderOperation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"desktopvirtualization/resource-manager/readme.md", "tag":"package-2021-02-01-preview", "details":"The schema 'ResourceProviderOperation-display' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"desktopvirtualization/resource-manager/readme.md", "tag":"package-2021-02-01-preview", "details":"The schema 'Resource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"desktopvirtualization/resource-manager/readme.md", "tag":"package-2021-02-01-preview", "details":"The schema 'TrackedResource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/CheckDuplicateSchemas	"readme":"desktopvirtualization/resource-manager/readme.md", "tag":"package-2021-02-01-preview", "details":"Checking for duplicate schemas, this could take a (long) while. Run with --verbose for more detail."

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-02-01T22:56:40Z

Swagger Generation Artifacts

️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 2a6cde4. Schema Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/[email protected] --version=3.0.6369 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/desktopvirtualization/resource-manager/readme.md

️✔️desktopvirtualization [View full logs] [Release Schema Changes]

cmderr	[resource-manager] node-pre-gyp
cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
cmderr	[resource-manager]  [email protected] No repository field.
cmderr	[resource-manager] optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 2a6cde4. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️preview/desktopvirtualization/mgmt/2021-02-01-preview/desktopvirtualization [View full logs] [Release SDK Changes]
```
info	[Changelog] This is a new package
```
️✔️preview/desktopvirtualization/mgmt/2021-01-14-preview/desktopvirtualization [View full logs] [Release SDK Changes]
```
info	[Changelog] This is a new package
```
️✔️preview/desktopvirtualization/mgmt/2020-11-10-preview/desktopvirtualization [View full logs] [Release SDK Changes]
```
info	[Changelog] This is a new package
```
️✔️preview/desktopvirtualization/mgmt/2020-11-02-preview/desktopvirtualization [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️preview/desktopvirtualization/mgmt/2020-10-19-preview/desktopvirtualization [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️preview/desktopvirtualization/mgmt/2020-09-21-preview/desktopvirtualization [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️preview/desktopvirtualization/mgmt/2019-12-10-preview/desktopvirtualization [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️preview/desktopvirtualization/mgmt/2019-09-24-preview/desktopvirtualization [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️preview/desktopvirtualization/mgmt/2019-01-23-preview/desktopvirtualization [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```

️️✔️ azure-cli-extensions succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 2a6cde4. Azure CLI Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	python3 -m venv venv
command	pip install --upgrade setuptools wheel pip
command	pip install pathlib jinja2 msrestazure
command	autorest --az --use=@autorest/az@latest --version=3.0.6271 --clear-output-folder=true --azure-cli-extension-folder=/home/vsts/work/1/s/azure-cli-extensions ../azure-rest-api-specs/specification/desktopvirtualization/resource-manager/readme.md
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'CloudError' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceProviderOperationList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceProviderOperation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceProviderOperation-display' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'Resource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'TrackedResource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
cmdout	[Autorest] WARNING (): Operation Update has already existed in group! Skip split!
cmdout	[Autorest] WARNING (): Operation Update has already existed in group! Skip split!
cmdout	[Autorest] WARNING (): Operation Update has already existed in group! Skip split!
cmdout	[Autorest] WARNING (): Operation Update has already existed in group! Skip split!
cmdout	[Autorest] WARNING (): Operation Update has already existed in group! Skip split!
cmdout	[Autorest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
cmderr	[Autorest] BELOW TEST SCENARIO SECTION CAN BE USED IN readme.cli.md
cmderr	[Autorest] --------------------------------------------------------
cmderr	[Autorest]   test-scenario:
cmderr	[Autorest]     - name: /HostPools/put/HostPool_Create
cmderr	[Autorest]     - name: /HostPools/get/HostPool_Get
cmderr	[Autorest]     - name: /HostPools/get/HostPool_List
cmderr	[Autorest]     - name: /HostPools/get/HostPool_ListByResourceGroup
cmderr	[Autorest]     - name: /HostPools/patch/HostPool_Update
cmderr	[Autorest]     - name: /HostPools/post/HostPools_RetrieveRegistrationToken_Post
cmderr	[Autorest]     - name: /ApplicationGroups/put/ApplicationGroup_Create
cmderr	[Autorest]     - name: /ApplicationGroups/get/ApplicationGroup_Get
cmderr	[Autorest]     - name: /ApplicationGroups/get/ApplicationGroup_List
cmderr	[Autorest]     - name: /ApplicationGroups/get/ApplicationGroup_ListByResourceGroup
cmderr	[Autorest]     - name: /ApplicationGroups/patch/ApplicationGroups_Update
cmderr	[Autorest]     - name: /ApplicationGroups/delete/ApplicationGroup_Delete
cmderr	[Autorest]     - name: /MsixImages/post/MsixImage_Expand
cmderr	[Autorest]     - name: /MSIXPackages/put/MSIXPackage_Create
cmderr	[Autorest]     - name: /MSIXPackages/get/MSIXPackage_Get
cmderr	[Autorest]     - name: /MSIXPackages/get/MSIXPackage_List
cmderr	[Autorest]     - name: /MSIXPackages/patch/MSIXPackage_Update
cmderr	[Autorest]     - name: /MSIXPackages/delete/MSIXPackage_Delete
cmderr	[Autorest]     - name: /ScalingPlans/put/ScalingPlans_Create
cmderr	[Autorest]     - name: /ScalingPlans/get/ScalingPlans_Get
cmderr	[Autorest]     - name: /ScalingPlans/get/ScalingPlans_ListByResourceGroup
cmderr	[Autorest]     - name: /ScalingPlans/get/ScalingPlans_ListBySubscription
cmderr	[Autorest]     - name: /ScalingPlans/get/UserSession_SendMessage_Post
cmderr	[Autorest]     - name: /ScalingPlans/patch/ScalingPlans_Update
cmderr	[Autorest]     - name: /ScalingPlans/delete/ScalingPlans_Delete
cmderr	[Autorest]     - name: /HostPools/delete/HostPool_Delete
cmderr	[Autorest]     - name: /Workspaces/put/Workspace_Create
cmderr	[Autorest]     - name: /Workspaces/get/Workspace_Get
cmderr	[Autorest]     - name: /Workspaces/get/Workspace_ListByResourceGroup
cmderr	[Autorest]     - name: /Workspaces/get/Workspace_ListBySubscription
cmderr	[Autorest]     - name: /Workspaces/patch/Workspace_Update
cmderr	[Autorest]     - name: /Workspaces/delete/Workspace_Delete
cmderr	[Autorest] --------------------------------------------------------

️✔️desktopvirtualization [View full logs] [Release Azure CLI Changes]
- desktopvirtualization-0.1.0-py3-none-any.whl
- desktopvirtualization-0.1.0.zip

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning [Logs]Release - Generate from 2a6cde4. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmdout	[automation_generate.sh] [Autorest]../azure-sdk-for-python_tmp/generateOutput.json does not exist!!!
warn	File azure-sdk-for-python_tmp/generateOutput.json not found to read

️✔️azure-mgmt-desktopvirtualization [View full logs] [Release SDK Changes]

️⚠️ azure-sdk-for-js warning [Detail]

⚠️Warning [Logs]Release - Generate from 2a6cde4. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/desktopvirtualization/resource-manager/readme.md
warn	No file changes detected after generation
warn	No package detected after generation

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 2a6cde4. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-02-09 01:38:16 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-desktopvirtualization"
cmderr	[generate.py] 2021-02-09 01:38:16 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-02-09 01:38:16 INFO autorest --version=3.0.6350 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/desktopvirtualization/azure-resourcemanager-desktopvirtualization --java.namespace=com.azure.resourcemanager.desktopvirtualization   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/desktopvirtualization/resource-manager/readme.md
cmderr	[generate.py] 2021-02-09 01:39:00 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-02-09 01:39:00 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-02-09 01:39:00 INFO [POM][Skip] pom already has module azure-resourcemanager-desktopvirtualization
cmderr	[generate.py] 2021-02-09 01:39:00 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-02-09 01:39:00 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-02-09 01:39:00 INFO [POM][Success] Write to root pom
cmderr	[generate.py] 2021-02-09 01:40:12 ERROR [COMPILE] Maven build fail

️✔️azure-resourcemanager-desktopvirtualization [View full logs] [Release SDK Changes]

cmderr	[Inst] 2021-02-09 01:41:26 DEBUG Got artifact_id: azure-resourcemanager-desktopvirtualization
cmderr	[Inst] 2021-02-09 01:41:26 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-02-09 01:41:26 DEBUG Got artifact: azure-resourcemanager-desktopvirtualization-1.0.0-beta.1-sources.jar
cmderr	[Inst] 2021-02-09 01:41:26 DEBUG Got artifact: azure-resourcemanager-desktopvirtualization-1.0.0-beta.1.jar
cmderr	[Inst] 2021-02-09 01:41:26 DEBUG Match jar package: azure-resourcemanager-desktopvirtualization-1.0.0-beta.1.jar
cmderr	[Inst] 2021-02-09 01:41:26 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/12766/azure-sdk-for-java/azure-resourcemanager-desktopvirtualization/azure-resourcemanager-desktopvirtualization-1.0.0-beta.1.jar\" -o azure-resourcemanager-desktopvirtualization-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-desktopvirtualization -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-desktopvirtualization-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}

️🔄[Staging] ApiDocPreview inProgress [Detail]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-02-01T23:52:02Z

Hi @datr93, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

Task	How to fix	Priority	Support (Microsoft alias)
Avocado	Fix-Avocado	High	ruowan
Semantic validation	Fix-SemanticValidation-Error	High	raychen, jianyxi
Model validation	Fix-ModelValidation-Error	High	raychen,jianyxi
LintDiff	Fix-LintDiff	high	jianyxi, ruoxuan

If you need further help, please feedback via swagger feedback."

remove pagination refactor and remove regtoken in example rename rename

datr93 · 2021-02-02T01:15:44Z

@weidongxu-microsoft is the ci pipeline broken? I see many people with same python error.

openapi-workflow-bot · 2021-02-02T01:22:32Z

Hi, @datr93 your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). cc @weidongxu-microsoft

weidongxu-microsoft · 2021-02-02T05:46:14Z

@datr93

Appear to be CI issue. You can ignore it for now. Maybe later it will get fixed.

If you have commit id that is the real change (instead of copy/bump up version etc.), please write it in description. Multiple party is going to review the PR and it saves time.

weidongxu-microsoft · 2021-02-03T02:08:21Z

spellcheck need to be fixed.

##[error]/home/vsts/work/1/s/specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/preview/2021-02-01-preview/desktopvirtualization.json:3922:34 - Unknown word (Slogix)

datr93 · 2021-02-04T19:21:35Z

@weidongxu-microsoft anyone looking at this pr from the arm side?

weidongxu-microsoft · 2021-02-05T01:31:06Z

@datr93 You can email "Azure Resource Manager RP API Review [email protected]" if urgent (usually "WaitForARMFeedback" label will do, but this month seems got lots of PR).

datr93 · 2021-02-05T22:57:36Z

@weidongxu-microsoft can you approve the pr. Got arm sign off!

weidongxu-microsoft · 2021-02-06T01:48:49Z

@datr93
Approved.
Let me know when it need merged.

datr93 · 2021-02-08T19:07:17Z

@weidongxu-microsoft pls merge! Thanks!!

* copy over * change version * update readme * fix ruby more * add Retrieveregistrationtoken remove pagination refactor and remove regtoken in example rename rename * add enums and better descriptions * model as string true * add FSLogix

datr93 added 3 commits February 1, 2021 14:31

copy over

9d0cab8

change version

63dbb5b

update readme

b8d439a

datr93 requested review from ArcturusZhang and ChenTanyi as code owners February 1, 2021 22:56

openapi-assignment-bot bot assigned weidongxu-microsoft Feb 1, 2021

This was referenced Feb 1, 2021

[AutoPR desktopvirtualization] Datr/reg info and enums AzureSDKAutomation/azure-cli-extensions#601

Closed

[AutoPR desktopvirtualization] Datr/reg info and enums AzureSDKAutomation/azure-resource-manager-schemas#1563

Closed

fix ruby more

60c0882

openapi-sdkautomation bot mentioned this pull request Feb 1, 2021

[AutoPR azure-resourcemanager-desktopvirtualization] Datr/reg info and enums AzureSDKAutomation/azure-sdk-for-java#7370

Closed

datr93 requested review from jsntcy and msyyc as code owners February 1, 2021 23:34

datr93 force-pushed the datr/regInfoAndEnums branch from 6b9643b to 60c0882 Compare February 1, 2021 23:49

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Feb 1, 2021

openapi-pipeline-app bot added CI-FixRequiredOnFailure and removed CI-FixRequiredOnFailure labels Feb 1, 2021

add Retrieveregistrationtoken

921b213

remove pagination refactor and remove regtoken in example rename rename

datr93 force-pushed the datr/regInfoAndEnums branch from 3291d30 to 921b213 Compare February 2, 2021 01:01

add enums and better descriptions

7fd23e1

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 2, 2021

model as string true

fd2d5c1

add FSLogix

6fb17f0

openapi-sdkautomation bot mentioned this pull request Feb 3, 2021

[AutoPR azure-mgmt-desktopvirtualization] Datr/reg info and enums AzureSDKAutomation/azure-sdk-for-python#4071

Closed

jorgecotillo added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Feb 5, 2021

weidongxu-microsoft approved these changes Feb 6, 2021

View reviewed changes

weidongxu-microsoft added the Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates label Feb 6, 2021

Merge branch 'master' into datr/regInfoAndEnums

5f063a5

weidongxu-microsoft merged commit 2a6cde4 into Azure:master Feb 9, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Datr/reg info and enums #12766

Datr/reg info and enums #12766

datr93 commented Feb 1, 2021 •

edited

Loading

openapi-workflow-bot bot commented Feb 1, 2021

openapi-pipeline-app bot commented Feb 1, 2021 •

edited

Loading

openapi-pipeline-app bot commented Feb 1, 2021 •

edited

Loading

openapi-workflow-bot bot commented Feb 1, 2021

datr93 commented Feb 2, 2021

openapi-workflow-bot bot commented Feb 2, 2021

weidongxu-microsoft commented Feb 2, 2021

weidongxu-microsoft commented Feb 3, 2021

datr93 commented Feb 4, 2021

weidongxu-microsoft commented Feb 5, 2021

datr93 commented Feb 5, 2021

weidongxu-microsoft commented Feb 6, 2021

datr93 commented Feb 8, 2021

Datr/reg info and enums #12766

Datr/reg info and enums #12766

Conversation

datr93 commented Feb 1, 2021 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Feb 1, 2021

openapi-pipeline-app bot commented Feb 1, 2021 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Feb 1, 2021 • edited Loading

Swagger Generation Artifacts

openapi-workflow-bot bot commented Feb 1, 2021

datr93 commented Feb 2, 2021

openapi-workflow-bot bot commented Feb 2, 2021

weidongxu-microsoft commented Feb 2, 2021

weidongxu-microsoft commented Feb 3, 2021

datr93 commented Feb 4, 2021

weidongxu-microsoft commented Feb 5, 2021

datr93 commented Feb 5, 2021

weidongxu-microsoft commented Feb 6, 2021

datr93 commented Feb 8, 2021

datr93 commented Feb 1, 2021 •

edited

Loading

openapi-pipeline-app bot commented Feb 1, 2021 •

edited

Loading

openapi-pipeline-app bot commented Feb 1, 2021 •

edited

Loading