-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add query parameter to Namedvalue and Certificate #12659
Conversation
Hi, @KacieKK Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
Rule | Message |
---|---|
1043 - AddingOptionalParameter |
The optional parameter 'isKeyVaultRefreshFailed' was added in the new version. New: Microsoft.ApiManagement/preview/2020-06-01-preview/apimcertificates.json#L69:11 |
1043 - AddingOptionalParameter |
The optional parameter 'isKeyVaultRefreshFailed' was added in the new version. New: Microsoft.ApiManagement/preview/2020-06-01-preview/apimnamedvalues.json#L72:11 |
️⚠️
LintDiff: 2 Warnings warning [Detail]
- Linted configuring files (Based on source branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- Linted configuring files (Based on target branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
Rule | Message |
---|---|
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isKeyVaultRefreshFailed New: Microsoft.ApiManagement/preview/2020-06-01-preview/apimcertificates.json#L70 |
|
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isKeyVaultRefreshFailed New: Microsoft.ApiManagement/preview/2020-06-01-preview/apimnamedvalues.json#L73 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
Swagger Generation Artifacts
|
...ent/resource-manager/Microsoft.ApiManagement/preview/2020-06-01-preview/apimnamedvalues.json
Outdated
Show resolved
Hide resolved
NewApiVersionRequired reason: |
Posting approved breaking change intake, which is discussed and required by @chunyu3 https://msazure.visualstudio.com/One/_workitems/edit/9212580 |
@chunyu3 can you please take a look at this again? |
@chunyu3 we have not published python sdk for preview version. |
* add filter flag * rephrase Co-authored-by: Kacie Kang <[email protected]>
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.