[Hub Generated] Review request for Microsoft.Confluent to add version preview/2020-03-01-preview #11426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The new version is adding a path that was not found in the old version. New: Microsoft.Confluent/preview/2020-03-01-preview/confluent.json#L36:5 |
|
The new version is adding a path that was not found in the old version. New: Microsoft.Confluent/preview/2020-03-01-preview/confluent.json#L75:5 |
️⚠️~[Staging] LintDiff: 3 Warnings warning [Detail] [Expand]
- Linted configuring files (Based on source branch, openapi-validator v1.5.0 , classic-openapi-validator v1.1.4 )
- Linted configuring files (Based on target branch, openapi-validator v1.5.0 , classic-openapi-validator v1.1.4 )
| Rule | Message |
|---|---|
| Consider using x-ms-client-flatten to provide a better end user experience New: Microsoft.Confluent/preview/2020-03-01-preview/confluent.json#L518 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: accepted New: Microsoft.Confluent/preview/2020-03-01-preview/confluent.json#L492 |
|
| 'body' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation. New: Microsoft.Confluent/preview/2020-03-01-preview/confluent.json#L89 |
️️✔️~[Staging] Avocado succeeded [Detail]
Validation passes for Avocado.
️️✔️~[Staging] ModelValidation succeeded [Detail]
Validation passes for ModelValidation.
️️✔️~[Staging] SemanticValidation succeeded [Detail]
Validation passes for SemanticValidation.
️️✔️~[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail]
There are no breaking changes.
️️✔️~[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail]
There are no breaking changes.
|
Azure Pipelines successfully started running 1 pipeline(s). |
Azure CLI Extension Generation - Release
|
azure-sdk-for-java - Release
|
azure-resource-manager-schemas - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-js - Release
|
azure-sdk-for-go - Release
|
azure-sdk-for-python - Release
|
azure-sdk-for-net - Release
|
azure-sdk-for-python-track2 - Release
|
This was referenced Oct 28, 2020
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run unifiedPipeline |
|
No pipelines are associated with this pull request. |
|
Hi, @alluri02 your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). cc @${PRAssignee} |
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
Hi, @alluri02 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
|
Azure Pipelines successfully started running 1 pipeline(s). |
majastrz
added
ARM-Review-Issue
and removed
WaitForARMFeedback
Swagger Generation Artifacts
|
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
chiragg4u
reviewed
Nov 6, 2020
| } | ||
| }, | ||
| "/subscriptions/{subscriptionId}/providers/Microsoft.Confluent/agreements/default": { | ||
| "post": { |
There was a problem hiding this comment.
I thought we agreed to use PUT for these?
chiragg4u
added
ARMSignedOff
|
Please fix the above comment. |
Missed this change
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi @alluri02, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
ruowan
added
the
Approved-BreakingChange
|
Not release yet. No customer impact |
ruowan
approved these changes
Nov 9, 2020
|
Azure Pipelines successfully started running 1 pipeline(s). |
giromm2ms
pushed a commit
to giromm2ms/azure-rest-api-specs
that referenced
this pull request
Dec 20, 2020
… preview/2020-03-01-preview (Azure#11426) * added agreement terms api * fix validation issues * fix validation errors * renamed api to accept terms * Updated confluent swagger spec * Updated the response examples * lint * rename * Updated Post to Put Missed this change * updated version * prettier check fix Co-authored-by: Srinivas Alluri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.