-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Microsoft.AppConfiguration - Correctness + Lint #11338
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Staging] Swagger Validation Report
❌ |
Rule | Message |
---|---|
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AppConfiguration/configurationStores/{configStoreName}/ListKeys' removed or restructured? Old: Microsoft.AppConfiguration/preview/2020-07-01-preview/appconfiguration.json#L365:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AppConfiguration/configurationStores/{configStoreName}/RegenerateKey' removed or restructured? Old: Microsoft.AppConfiguration/preview/2020-07-01-preview/appconfiguration.json#L417:5 |
1041 - AddedPropertyInResponse |
The new version has a new property 'isDataAction' in response that was not found in the old version. New: Microsoft.AppConfiguration/preview/2020-07-01-preview/appconfiguration.json#L1429:7 Old: Microsoft.AppConfiguration/preview/2020-07-01-preview/appconfiguration.json#L1429:7 |
1041 - AddedPropertyInResponse |
The new version has a new property 'origin' in response that was not found in the old version. New: Microsoft.AppConfiguration/preview/2020-07-01-preview/appconfiguration.json#L1429:7 Old: Microsoft.AppConfiguration/preview/2020-07-01-preview/appconfiguration.json#L1429:7 |
1041 - AddedPropertyInResponse |
The new version has a new property 'properties' in response that was not found in the old version. New: Microsoft.AppConfiguration/preview/2020-07-01-preview/appconfiguration.json#L1429:7 Old: Microsoft.AppConfiguration/preview/2020-07-01-preview/appconfiguration.json#L1429:7 |
️️✔️
LintDiff [Detail]
️✔️
Validation passes for LintDiff.
️️✔️
Avocado [Detail]
️✔️
Validation passes for Avocado.
️️✔️
ModelValidation [Detail]
️✔️
Validation passes for ModelValidation.
️️✔️
SemanticValidation [Detail]
️✔️
Validation passes for SemanticValidation.
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-go - Release
|
azure-sdk-for-java - Release
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-js - Release
|
azure-sdk-for-python-track2 - Release
- Breaking Change detected in SDK
|
azure-sdk-for-net - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
This was referenced Oct 22, 2020
This was referenced Oct 22, 2020
To give an idea of the impact of the breaking change alert, this preview version was just added last night in this PR: #10224 |
weidongxu-microsoft
approved these changes
Oct 23, 2020
weidongxu-microsoft
added
the
Approved-BreakingChange
DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374
label
Oct 23, 2020
giromm2ms
pushed a commit
to giromm2ms/azure-rest-api-specs
that referenced
this pull request
Dec 20, 2020
* Fixed lint error. * Added missing operation fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Approved-BreakingChange
DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374
CI-BreakingChange-Python
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes correctness and lint errors for Microsoft.AppConfiguration
The following two problems are addressed: