Update operationId names #10405

fenwickt · 2020-08-10T23:28:41Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

openapi-pipeline-app · 2020-08-10T23:28:44Z

[Staging] Swagger Validation Report

️❌BreakingChange: 2 Errors, 0 Warnings [Detail] [Expand]

Rule	Message
`❌` 1008 - ModifiedOperationId	The operation id has been changed from 'List_ResourceChanges' to 'ResourceChanges'. This will impact generated code. New: Microsoft.ResourceGraph/preview/2020-04-01-preview/resourcegraph.json#L114:7 Old: Microsoft.ResourceGraph/preview/2020-04-01-preview/resourcegraph.json#L114:7
`❌` 1008 - ModifiedOperationId	The operation id has been changed from 'Get_ResourceChangeDetails' to 'ResourceChangeDetails'. This will impact generated code. New: Microsoft.ResourceGraph/preview/2020-04-01-preview/resourcegraph.json#L162:7 Old: Microsoft.ResourceGraph/preview/2020-04-01-preview/resourcegraph.json#L162:7

️️✔️LintDiff [Detail]

 Validation passes for LintDiff.

️️✔️Avocado [Detail]

 Validation passes for Avocado.

_{Posted by Swagger Pipeline | How to fix these errors?}

azure-pipelines · 2020-08-10T23:28:56Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-08-10T23:30:21Z

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-08-10T23:30:21Z

azure-sdk-for-java - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 5b52718 with merge commit d20f0e1. SDK Automation 13.0.17.20200807.2
️✔️sdk/resourcegraph/mgmt-v2019_04_01 [View full logs] [Release SDK Changes]

openapi-sdkautomation · 2020-08-10T23:30:24Z

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 5b52718 with merge commit d20f0e1. SDK Automation 13.0.17.20200807.2

️✔️@azure/arm-resourcegraph [View full logs] [Release SDK Changes]

azure-arm-resourcegraph-2.0.0.tgz

[npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
[npmPack] npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
[npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/resourceGraphClient.js → ./dist/arm-resourcegraph.js...
[npmPack] created ./dist/arm-resourcegraph.js in 200ms
[npmPack] npm notice 
[npmPack] npm notice package: @azure/[email protected]
[npmPack] npm notice === Tarball Contents === 
[npmPack] npm notice 40.1kB dist/arm-resourcegraph.js              
[npmPack] npm notice 13.6kB dist/arm-resourcegraph.min.js          
[npmPack] npm notice 345B   esm/models/index.js                    
[npmPack] npm notice 381B   esm/operations/index.js                
[npmPack] npm notice 23.2kB esm/models/mappers.js                  
[npmPack] npm notice 1.5kB  esm/operations/operations.js           
[npmPack] npm notice 471B   esm/models/operationsMappers.js        
[npmPack] npm notice 771B   esm/models/parameters.js               
[npmPack] npm notice 4.1kB  esm/resourceGraphClient.js             
[npmPack] npm notice 2.3kB  esm/resourceGraphClientContext.js      
[npmPack] npm notice 991B   rollup.config.js                       
[npmPack] npm notice 1.7kB  package.json                           
[npmPack] npm notice 457B   tsconfig.json                          
[npmPack] npm notice 78.4kB dist/arm-resourcegraph.js.map          
[npmPack] npm notice 12.8kB dist/arm-resourcegraph.min.js.map      
[npmPack] npm notice 5.6kB  esm/models/index.d.ts.map              
[npmPack] npm notice 137B   esm/operations/index.d.ts.map          
[npmPack] npm notice 126B   esm/models/index.js.map                
[npmPack] npm notice 152B   esm/operations/index.js.map            
[npmPack] npm notice 1.5kB  esm/models/mappers.d.ts.map            
[npmPack] npm notice 13.0kB esm/models/mappers.js.map              
[npmPack] npm notice 663B   esm/operations/operations.d.ts.map     
[npmPack] npm notice 908B   esm/operations/operations.js.map       
[npmPack] npm notice 225B   esm/models/operationsMappers.d.ts.map  
[npmPack] npm notice 238B   esm/models/operationsMappers.js.map    
[npmPack] npm notice 255B   esm/models/parameters.d.ts.map         
[npmPack] npm notice 471B   esm/models/parameters.js.map           
[npmPack] npm notice 1.8kB  esm/resourceGraphClient.d.ts.map       
[npmPack] npm notice 2.5kB  esm/resourceGraphClient.js.map         
[npmPack] npm notice 457B   esm/resourceGraphClientContext.d.ts.map
[npmPack] npm notice 1.2kB  esm/resourceGraphClientContext.js.map  
[npmPack] npm notice 3.2kB  README.md                              
[npmPack] npm notice 15.3kB esm/models/index.d.ts                  
[npmPack] npm notice 65B    esm/operations/index.d.ts              
[npmPack] npm notice 14.8kB src/models/index.ts                    
[npmPack] npm notice 349B   src/operations/index.ts                
[npmPack] npm notice 2.1kB  esm/models/mappers.d.ts                
[npmPack] npm notice 18.4kB src/models/mappers.ts                  
[npmPack] npm notice 1.1kB  esm/operations/operations.d.ts         
[npmPack] npm notice 2.3kB  src/operations/operations.ts           
[npmPack] npm notice 161B   esm/models/operationsMappers.d.ts      
[npmPack] npm notice 437B   src/models/operationsMappers.ts        
[npmPack] npm notice 214B   esm/models/parameters.d.ts             
[npmPack] npm notice 787B   src/models/parameters.ts               
[npmPack] npm notice 3.9kB  esm/resourceGraphClient.d.ts           
[npmPack] npm notice 7.3kB  src/resourceGraphClient.ts             
[npmPack] npm notice 678B   esm/resourceGraphClientContext.d.ts    
[npmPack] npm notice 2.0kB  src/resourceGraphClientContext.ts      
[npmPack] npm notice 1.1kB  LICENSE.txt                            
[npmPack] npm notice === Tarball Details === 
[npmPack] npm notice name:          @azure/arm-resourcegraph                
[npmPack] npm notice version:       2.0.0                                   
[npmPack] npm notice filename:      azure-arm-resourcegraph-2.0.0.tgz       
[npmPack] npm notice package size:  43.6 kB                                 
[npmPack] npm notice unpacked size: 284.6 kB                                
[npmPack] npm notice shasum:        bb7dafcddbb87782a3be714842a4ce6dbcc79463
[npmPack] npm notice integrity:     sha512-JhoAL8LCK/E/K[...]AhDs+ZUOm1cLw==
[npmPack] npm notice total files:   49                                      
[npmPack] npm notice

openapi-sdkautomation · 2020-08-10T23:30:25Z

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 5b52718 with merge commit d20f0e1. SDK Automation 13.0.17.20200807.2
⚠️preview/resourcegraph/mgmt/2018-09-01 [View full logs]
- preview.resourcegraph.mgmt.2018-09-01.zip
```
No file is changed.
```
⚠️resourcegraph/mgmt/2019-04-01 [View full logs]
- resourcegraph.mgmt.2019-04-01.zip
```
No file is changed.
```

openapi-sdkautomation · 2020-08-10T23:30:26Z

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 5b52718 with merge commit d20f0e1. SDK Automation 13.0.17.20200807.2

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.ResourceGraph [View full logs] [Release SDK Changes]
- Microsoft.Azure.Management.ResourceGraph.2.0.0.nupkg
- Microsoft.Azure.Management.ResourceGraph.2.0.0.snupkg

openapi-sdkautomation · 2020-08-10T23:30:27Z

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 5b52718 with merge commit d20f0e1. SDK Automation 13.0.17.20200807.2

️✔️azure-mgmt-resourcegraph [View full logs] [Release SDK Changes]

[build_conf] INFO:packaging_tools:Building template azure-mgmt-resourcegraph
[build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
[build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
[build_conf] INFO:packaging_tools:Template done azure-mgmt-resourcegraph
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[ChangeLog] Size of delta 46.091% size of original (original: 11499 chars, delta: 5300 chars)
[ChangeLog] **Features**
[ChangeLog] 
[ChangeLog]   - Model QueryRequest has a new parameter management_group_id
[ChangeLog]   - Added operation ResourceGraphClientOperationsMixin.resource_change_details
[ChangeLog]   - Added operation ResourceGraphClientOperationsMixin.resource_changes

openapi-sdkautomation · 2020-08-10T23:30:49Z

Trenton Generation - Release

❌ failed [Logs] [Expand Details]

❌ Generate from 5b52718 with merge commit d20f0e1. Trenton Automation 13.0.17.20200807.2

[AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'ResourceChangesRequestParameters-interval' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
[AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'ResourceChangeData-beforeSnapshot' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
[AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'ResourceChangeData-afterSnapshot' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'QueryRequestOptions' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'FacetRequestOptions' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceChangesRequestParameters-interval' with an undefined type and 'allOf'/'anyOf'/'oneOf' is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceChangeData-beforeSnapshot' with an undefined type and 'allOf'/'anyOf'/'oneOf' is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceChangeData-afterSnapshot' with an undefined type and 'allOf'/'anyOf'/'oneOf' is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'OperationListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Operation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Operation-display' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
[AutoRest] WARNING (Modeler/MissingType): The schema 'ResourceChangeList-$skipToken' has no type or format information whatsoever. Location:
[AutoRest] WARNING (): 'cli.flatten.cli-flatten-set-enabled' is not set to true, skip flattenSetter
[AutoRest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
[AutoRest] ERROR: trenton metadata is not defined, please add readme.md file to the specification.
Failed to run autorest.
Error: /z/node_modules/.bin/autorest --trenton --use=https://trenton.blob.core.windows.net/trenton/autorest-trenton-latest.tgz --version=3.0.6198 --clear-output-folder=true --trenton-output-folder=/z/work/azure-sdk-for-trenton/azurerm/internal/services /z/work/azure-rest-api-specs/specification/resourcegraph/resource-manager/readme.md ERROR: trenton metadata is not defined, please add readme.md file to the specification.
, {} 
Failed to find any changed packages. Please check the changed file list.
/z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/preview/resourcegraph/mgmt/2018-09-01/resourcegraph/client.go
/z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/preview/resourcegraph/mgmt/2018-09-01/resourcegraph/enums.go
/z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/preview/resourcegraph/mgmt/2018-09-01/resourcegraph/graphquery.go
/z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/preview/resourcegraph/mgmt/2018-09-01/resourcegraph/models.go
/z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/preview/resourcegraph/mgmt/2018-09-01/resourcegraph/operations.go
/z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/preview/resourcegraph/mgmt/2018-09-01/resourcegraph/resourcegraphapi/interfaces.go
/z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/preview/resourcegraph/mgmt/2018-09-01/resourcegraph/version.go
/z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/resourcegraph/mgmt/2019-04-01/resourcegraph/client.go
/z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/resourcegraph/mgmt/2019-04-01/resourcegraph/enums.go
/z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/resourcegraph/mgmt/2019-04-01/resourcegraph/models.go
/z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/resourcegraph/mgmt/2019-04-01/resourcegraph/operations.go
/z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/resourcegraph/mgmt/2019-04-01/resourcegraph/resourcegraphapi/interfaces.go
/z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/resourcegraph/mgmt/2019-04-01/resourcegraph/version.go

openapi-sdkautomation · 2020-08-10T23:30:56Z

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

azuresdkci · 2020-08-11T00:04:00Z

Can one of the admins verify this patch?

fenwickt · 2020-08-11T00:05:42Z

The goal of this PR is to update the names of the sections for the new api version. The breraking change errors have no customer impact since this swagger has never been published. They should be ok to suppress.

Update resourcegraph.json

5b52718

openapi-assignment-bot bot assigned fengzhou-msft Aug 10, 2020

fenwickt requested a review from johnthcall August 10, 2020 23:30

johnthcall approved these changes Aug 10, 2020

View reviewed changes

fengzhou-msft added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Aug 11, 2020

fengzhou-msft merged commit d20f0e1 into master Aug 11, 2020

innosam pushed a commit to innosam/azure-rest-api-specs that referenced this pull request Aug 17, 2020

Update resourcegraph.json (Azure#10405)

c1b3f1e

JackTn deleted the dev-update-2020-04-01-preview branch August 9, 2021 10:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update operationId names #10405

Update operationId names #10405

fenwickt commented Aug 10, 2020 •

edited

Loading

openapi-pipeline-app bot commented Aug 10, 2020 •

edited

Loading

azure-pipelines bot commented Aug 10, 2020

openapi-sdkautomation bot commented Aug 10, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 10, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 10, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 10, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 10, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 10, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 10, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 10, 2020 •

edited

Loading

azuresdkci commented Aug 11, 2020

fenwickt commented Aug 11, 2020 •

edited

Loading

Update operationId names #10405

Update operationId names #10405

Conversation

fenwickt commented Aug 10, 2020 • edited Loading

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-pipeline-app bot commented Aug 10, 2020 • edited Loading

[Staging] Swagger Validation Report

azure-pipelines bot commented Aug 10, 2020

openapi-sdkautomation bot commented Aug 10, 2020 • edited Loading

Azure CLI Extension Generation - Release

openapi-sdkautomation bot commented Aug 10, 2020 • edited Loading

azure-sdk-for-java - Release

openapi-sdkautomation bot commented Aug 10, 2020 • edited Loading

azure-sdk-for-js - Release

openapi-sdkautomation bot commented Aug 10, 2020 • edited Loading

azure-sdk-for-go - Release

openapi-sdkautomation bot commented Aug 10, 2020 • edited Loading

azure-sdk-for-net - Release

openapi-sdkautomation bot commented Aug 10, 2020 • edited Loading

azure-sdk-for-python - Release

openapi-sdkautomation bot commented Aug 10, 2020 • edited Loading

Trenton Generation - Release

openapi-sdkautomation bot commented Aug 10, 2020 • edited Loading

azure-sdk-for-python-track2 - Release

azuresdkci commented Aug 11, 2020

fenwickt commented Aug 11, 2020 • edited Loading

fenwickt commented Aug 10, 2020 •

edited

Loading

openapi-pipeline-app bot commented Aug 10, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 10, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 10, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 10, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 10, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 10, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 10, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 10, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 10, 2020 •

edited

Loading

fenwickt commented Aug 11, 2020 •

edited

Loading