-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added swagger files for MySQL Flexible Server preview #10287
Conversation
[Staging] Swagger Validation Report
️✔️ |
Rule | Message |
---|---|
R4018 - OperationsApiResponseSchema |
The response schema of operations API '/providers/Microsoft.DBForMySql/operations' does not match the ARM specification. Please standardize the schema. New: Microsoft.DBforMySQL/preview/2020-07-01-privatepreview/mysql.json#L1287 |
Based on the response model schema, operation 'Operations_List' might be pageable. Consider adding the x-ms-pageable extension. New: Microsoft.DBforMySQL/preview/2020-07-01-privatepreview/mysql.json#L1288 |
|
OperationId should contain the verb: 'checknameavailability' in:'CheckNameAvailability_Execute'. Consider updating the operationId New: Microsoft.DBforMySQL/preview/2020-07-01-privatepreview/mysql.json#L1247 |
|
The response of operation:'MaintenanceWindows_Get' is defined without 'systemData'. Consider adding the systemData to the response. New: Microsoft.DBforMySQL/preview/2020-07-01-privatepreview/mysql.json#L1153 |
|
The response of operation:'Operations_List' is defined without 'systemData'. Consider adding the systemData to the response. New: Microsoft.DBforMySQL/preview/2020-07-01-privatepreview/mysql.json#L1288 |
|
The response of operation:'MaintenanceWindows_ListByServer' is defined without 'systemData'. Consider adding the systemData to the response. New: Microsoft.DBforMySQL/preview/2020-07-01-privatepreview/mysql.json#L1198 |
|
The response of operation:'Servers_Create' is defined without 'systemData'. Consider adding the systemData to the response. New: Microsoft.DBforMySQL/preview/2020-07-01-privatepreview/mysql.json#L38 |
|
The response of operation:'Servers_Update' is defined without 'systemData'. Consider adding the systemData to the response. New: Microsoft.DBforMySQL/preview/2020-07-01-privatepreview/mysql.json#L103 |
|
The response of operation:'Servers_Get' is defined without 'systemData'. Consider adding the systemData to the response. New: Microsoft.DBforMySQL/preview/2020-07-01-privatepreview/mysql.json#L200 |
|
The response of operation:'Servers_ListByResourceGroup' is defined without 'systemData'. Consider adding the systemData to the response. New: Microsoft.DBforMySQL/preview/2020-07-01-privatepreview/mysql.json#L245 |
️️✔️
Avocado [Detail]
️✔️
Validation passes for Avocado.
Azure Pipelines successfully started running 1 pipeline(s). |
Can one of the admins verify this patch? |
azure-sdk-for-go - Release
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-java - Release
|
azure-sdk-for-js - Release
|
azure-sdk-for-net - Release
|
azure-sdk-for-python - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
Azure Pipelines successfully started running 1 pipeline(s). |
This was signed off for POstGreSQL RP recently and its the same changes for the MySQL RP. Signing off from ARM side. |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Let me know when you need it merged.
Pull request contains merge conflicts. |
…and remove updateConfigurations API
Comment was made before the most recent commit for PR 10287 in repo Azure/azure-rest-api-specs |
Azure Pipelines successfully started running 1 pipeline(s). |
@weidongxu-microsoft , this PR is ready for merge. |
@NullMDR Hi Phoenix, any idea of the LintDiff? This seems not an error (
Not sure about this one.
|
Lint does not allow provider name as DBforMySQL. If this requirement is correct, I guess you had to suppress it. https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/85/Swagger-Suppression-Process |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.