Update Microsoft.Resources swagger to include new alias contract #10243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(this is already exposed for some time now, but this part of the spec seems out-of-date). Also added the default API version and the API profile properties
[Staging] Swagger Validation Report
️✔️ |
|
Azure Pipelines successfully started running 1 pipeline(s). |
eladperets
changed the title
|
Can one of the admins verify this patch? |
azure-sdk-for-java - Release
|
azure-sdk-for-js - Release
|
azure-sdk-for-net - Release
|
azure-sdk-for-go - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
pilor
added
the
NotReadyForReview
azure-sdk-for-python - Release
|
eladperets
changed the title
This was referenced Jul 23, 2020
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-python-track2 - Release
|
pilor
added
ARMReviewInProgress
and removed
NotReadyForReview
pilor
approved these changes
Jul 23, 2020
specification/resources/resource-manager/Microsoft.Resources/stable/2020-06-01/resources.json
Outdated
Show resolved
Hide resolved
specification/resources/resource-manager/Microsoft.Resources/stable/2020-06-01/resources.json
Show resolved
Hide resolved
pilor
added
ARMSignedOff
eladperets
commented
Jul 23, 2020
| "200": { | ||
| "body": { | ||
| "namespace": "Microsoft.Storage", | ||
| "resourceTypes": [ |
There was a problem hiding this comment.
This is a partial API response. The full response with the full set of resource types and aliases is huge. LMK if that's a problem
|
Azure Pipelines successfully started running 1 pipeline(s). |
Tiano2017
reviewed
Jul 24, 2020
| @@ -2230,6 +2230,11 @@ | |||
| "tags": [ | |||
| "Providers" | |||
| ], | |||
| "x-ms-examples": { | |||
| "Get a resource provider at tenant scope": { | |||
| "$ref": "./examples/GetNamedProviderAtTenant.json" | |||
There was a problem hiding this comment.
does the change only apply to tenant level providers call?
There was a problem hiding this comment.
It applies to all providers/ calls. I can add example for each individual flavor if you think it's necessary.
Tiano2017
approved these changes
Jul 24, 2020
|
/azp run automation - sdk |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi @raych1 what is the next step? Is there anything else i need to do in order to merge this PR? |
raych1
reviewed
Jul 28, 2020
specification/resources/resource-manager/Microsoft.Resources/stable/2020-06-01/resources.json
Show resolved
Hide resolved
raych1
approved these changes
Jul 30, 2020
00Kai0
pushed a commit
to 00Kai0/azure-rest-api-specs
that referenced
this pull request
Oct 12, 2020
…re#10243) * Update Microsoft.Resources swagger to include new alias contract (this is already exposed for some time now, but this part of the spec seems out-of-date). Also added the default API version and the API profile properties * Fix prettier errors * Address PR comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These properties are already available for some time now, the swagger is out of date.
The main goal is to add the alias path metadata related properties. I also had to add the default API version and API profiles because they show in the example payload and it won't pass validation otherwise.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.