[Datafactory] Add Support for Managed Private Endpoints and Virtual Networks Resources #10191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Staging] Swagger Validation Report
️✔️ |
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-js - Release
|
azure-sdk-for-java - Release
|
azure-sdk-for-python - Release
|
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
|
azure-sdk-for-net - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
|
Can one of the admins verify this patch? |
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
This was referenced Jul 17, 2020
|
Azure Pipelines successfully started running 1 pipeline(s). |
drosales57
changed the title
drosales57
added
WaitForInternalTeamReview
drosales57
removed
the
WaitForARMFeedback
drosales57
changed the title
|
Hi @qianwens my changes are ready for review. Please take a look, thanks #Resolved |
qianwens
approved these changes
Jul 25, 2020
|
As per https://github.com/microsoft/api-guidelines/blob/vNext/azure/Guidelines.md additions of new endpoints fall under the umbrella of evolutionary changes and therefore require an API version bump. #Resolved |
majastrz
added
the
ARMChangesRequested
|
Hi @majastrz I am not adding a new endpoint. I am adding CRUD APIs for two new subresources for Azure Data Factory. The resource names are managed Private Endpoint and managed Virtual Network. #Resolved |
drosales57
changed the title
majastrz
reviewed
Aug 5, 2020
| }, | ||
| "304": { | ||
| "description": "Not modified." | ||
| }, |
There was a problem hiding this comment.
GETs should only return 200 OK or an error. #Resolved
There was a problem hiding this comment.
Fixed, thanks #Resolved
majastrz
reviewed
Aug 5, 2020
| }, | ||
| "304": { | ||
| "description": "Not modified." | ||
| }, |
There was a problem hiding this comment.
GETs should only return 200 OK or an error. #Resolved
There was a problem hiding this comment.
Fixed, thanks #Resolved
majastrz
reviewed
Aug 5, 2020
| "ifMatch": null, | ||
| "managedPrivateEndpoint": { | ||
| "properties": { | ||
| "description": "A managed private endpoint", |
There was a problem hiding this comment.
description [](start = 9, length = 11)
Why is description not being returned in PUT response? #Resolved
There was a problem hiding this comment.
Removed the description. It is not supported. Thanks for catching the issue #Resolved
majastrz
reviewed
Aug 5, 2020
| "ifMatch": null, | ||
| "managedVirtualNetwork": { | ||
| "properties": { | ||
| "description": "A managed Virtual network" |
There was a problem hiding this comment.
description [](start = 9, length = 11)
Same question here #Resolved
There was a problem hiding this comment.
Removed the description as it is currently not supported. #Resolved
There was a problem hiding this comment.
thanks #Resolved
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
majastrz
added
ARMSignedOff
drosales57
added
the
Approved-OkToMerge
|
@qianwens can please help merge this PR? |
innosam
pushed a commit
to innosam/azure-rest-api-specs
that referenced
this pull request
Aug 17, 2020
…etworks Resources (Azure#10191) * initial changes * fix example file name reference * fix error * more fixes * fix typo * add nextlink to PE API * update example for PE List API * fix style issues * address review comments * correct example * fix prettier issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on PR review process.