Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev storageimportexport microsoft.import export 2016 11 01 #10124

Conversation

nivats
Copy link
Contributor

@nivats nivats commented Jul 14, 2020

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jul 14, 2020

[Staging] Swagger Validation Report

️✔️BreakingChange [Detail]
 There are no breaking changes. 
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 14, 2020

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 14, 2020

azure-sdk-for-python - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 14, 2020

Azure CLI Extension Generation - Release

  • Installation instruction for service storageimportexport [Preview Changes]
    az extension add --source=https://sdkautomation.blob.core.windows.net/sdkautomation-pipeline/Azure/azure-rest-api-specs/10124/azure-cli-extensions/Azure/azure-cli-extensions/storageimportexport/storageimportexport-0.1.0-py3-none-any.whl
️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from f263dbd with merge commit 9d13acc. Azure CLI Automation 13.0.17.20200619.4
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorResponse-error' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorResponse-error-detailsItem' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PutJobParameters' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'JobDetails' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'UpdateJobParameters' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'UpdateJobParameters-properties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ListJobsResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'JobResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Operation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Operation-display' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Location' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Location-properties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ReturnAddress' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ReturnShipping' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ShippingInformation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PackageInfomation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'DriveStatus' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Export' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Export-blobList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'LocationsResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'GetBitLockerKeysResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'DriveBitLockerKey' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ListOperationsResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
  • ️✔️storageimportexport [View full logs]  [Release Azure CLI Changes]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 14, 2020

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 14, 2020

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 14, 2020

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from f263dbd with merge commit 9d13acc. SDK Automation 13.0.17.20200619.4
  • ️✔️@azure/arm-storageimportexport [View full logs]  [Release SDK Changes]
    Only show 100 items here, please refer to log for details.
    [npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
    [npmPack] npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
    [npmPack] npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
    [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
    [npmPack] loaded rollup.config.js with warnings
    [npmPack] (!) Unused external imports
    [npmPack] default imported from external module 'rollup' but never used
    [npmPack] 
    [npmPack] ./esm/storageImportExportManagementClient.js → ./dist/arm-storageimportexport.js...
    [npmPack] created ./dist/arm-storageimportexport.js in 266ms
    [npmPack] npm notice 
    [npmPack] npm notice package: @azure/[email protected]
    [npmPack] npm notice === Tarball Contents === 
    [npmPack] npm notice 57.3kB  dist/arm-storageimportexport.js                        
    [npmPack] npm notice 19.1kB  dist/arm-storageimportexport.min.js                    
    [npmPack] npm notice 1.9kB   esm/operations/bitLockerKeys.js                        
    [npmPack] npm notice 487B    esm/models/bitLockerKeysMappers.js                     
    [npmPack] npm notice 345B    esm/models/index.js                                    
    [npmPack] npm notice 467B    esm/operations/index.js                                
    [npmPack] npm notice 8.3kB   esm/operations/jobs.js                                 
    [npmPack] npm notice 626B    esm/models/jobsMappers.js                              
    [npmPack] npm notice 2.3kB   esm/operations/locations.js                            
    [npmPack] npm notice 467B    esm/models/locationsMappers.js                         
    [npmPack] npm notice 25.4kB  esm/models/mappers.js                                  
    [npmPack] npm notice 1.6kB   esm/operations/operations.js                           
    [npmPack] npm notice 474B    esm/models/operationsMappers.js                        
    [npmPack] npm notice 2.5kB   esm/models/parameters.js                               
    [npmPack] npm notice 1.0kB   rollup.config.js                                       
    [npmPack] npm notice 1.9kB   esm/storageImportExportManagementClient.js             
    [npmPack] npm notice 2.6kB   esm/storageImportExportManagementClientContext.js      
    [npmPack] npm notice 1.8kB   package.json                                           
    [npmPack] npm notice 457B    tsconfig.json                                          
    [npmPack] npm notice 119.0kB dist/arm-storageimportexport.js.map                    
    [npmPack] npm notice 17.6kB  dist/arm-storageimportexport.min.js.map                
    [npmPack] npm notice 804B    esm/operations/bitLockerKeys.d.ts.map                  
    [npmPack] npm notice 1.1kB   esm/operations/bitLockerKeys.js.map                    
    [npmPack] npm notice 224B    esm/models/bitLockerKeysMappers.d.ts.map               
    [npmPack] npm notice 237B    esm/models/bitLockerKeysMappers.js.map                 
    [npmPack] npm notice 8.0kB   esm/models/index.d.ts.map                              
    [npmPack] npm notice 202B    esm/operations/index.d.ts.map                          
    [npmPack] npm notice 126B    esm/models/index.js.map                                
    [npmPack] npm notice 217B    esm/operations/index.js.map                            
    [npmPack] npm notice 3.7kB   esm/operations/jobs.d.ts.map                           
    [npmPack] npm notice 5.2kB   esm/operations/jobs.js.map                             
    [npmPack] npm notice 315B    esm/models/jobsMappers.d.ts.map                        
    [npmPack] npm notice 328B    esm/models/jobsMappers.js.map                          
    [npmPack] npm notice 1.0kB   esm/operations/locations.d.ts.map                      
    [npmPack] npm notice 1.4kB   esm/operations/locations.js.map                        
    [npmPack] npm notice 213B    esm/models/locationsMappers.d.ts.map                   
    [npmPack] npm notice 226B    esm/models/locationsMappers.js.map                     
    [npmPack] npm notice 1.1kB   esm/models/mappers.d.ts.map                            
    [npmPack] npm notice 13.9kB  esm/models/mappers.js.map                              
    [npmPack] npm notice 663B    esm/operations/operations.d.ts.map                     
    [npmPack] npm notice 908B    esm/operations/operations.js.map                       
    [npmPack] npm notice 215B    esm/models/operationsMappers.d.ts.map                  
    [npmPack] npm notice 228B    esm/models/operationsMappers.js.map                    
    [npmPack] npm notice 633B    esm/models/parameters.d.ts.map                         
    [npmPack] npm notice 1.8kB   esm/models/parameters.js.map                           
    [npmPack] npm notice 752B    esm/storageImportExportManagementClient.d.ts.map       
    [npmPack] npm notice 906B    esm/storageImportExportManagementClient.js.map         
    [npmPack] npm notice 536B    esm/storageImportExportManagementClientContext.d.ts.map
    [npmPack] npm notice 1.4kB   esm/storageImportExportManagementClientContext.js.map  
    [npmPack] npm notice 3.3kB   README.md                                              
    [npmPack] npm notice 1.9kB   esm/operations/bitLockerKeys.d.ts                      
    [npmPack] npm notice 3.4kB   src/operations/bitLockerKeys.ts                        
    [npmPack] npm notice 177B    esm/models/bitLockerKeysMappers.d.ts                   
    [npmPack] npm notice 448B    src/models/bitLockerKeysMappers.ts                     
    [npmPack] npm notice 21.5kB  esm/models/index.d.ts                                  
    [npmPack] npm notice 151B    esm/operations/index.d.ts                              
    [npmPack] npm notice 20.6kB  src/models/index.ts                                    
    [npmPack] npm notice 435B    src/operations/index.ts                                
    [npmPack] npm notice 10.4kB  esm/operations/jobs.d.ts                               
    [npmPack] npm notice 18.8kB  src/operations/jobs.ts                                 
    [npmPack] npm notice 316B    esm/models/jobsMappers.d.ts                            
    [npmPack] npm notice 616B    src/models/jobsMappers.ts                              
    [npmPack] npm notice 2.2kB   esm/operations/locations.d.ts                          
    [npmPack] npm notice 4.3kB   src/operations/locations.ts                            
    [npmPack] npm notice 157B    esm/models/locationsMappers.d.ts                       
    [npmPack] npm notice 432B    src/models/locationsMappers.ts                         
    [npmPack] npm notice 1.4kB   esm/models/mappers.d.ts                                
    [npmPack] npm notice 19.6kB  src/models/mappers.ts                                  
    [npmPack] npm notice 1.2kB   esm/operations/operations.d.ts                         
    [npmPack] npm notice 2.5kB   src/operations/operations.ts                           
    [npmPack] npm notice 164B    esm/models/operationsMappers.d.ts                      
    [npmPack] npm notice 438B    src/models/operationsMappers.ts                        
    [npmPack] npm notice 724B    esm/models/parameters.d.ts                             
    [npmPack] npm notice 2.5kB   src/models/parameters.ts                               
    [npmPack] npm notice 1.3kB   esm/storageImportExportManagementClient.d.ts           
    [npmPack] npm notice 1.8kB   src/storageImportExportManagementClient.ts             
    [npmPack] npm notice 863B    esm/storageImportExportManagementClientContext.d.ts    
    [npmPack] npm notice 2.3kB   src/storageImportExportManagementClientContext.ts      
    [npmPack] npm notice 1.1kB   LICENSE.txt                                            
    [npmPack] npm notice === Tarball Details === 
    [npmPack] npm notice name:          @azure/arm-storageimportexport          
    [npmPack] npm notice version:       1.2.0                                   
    [npmPack] npm notice filename:      azure-arm-storageimportexport-1.2.0.tgz 
    [npmPack] npm notice package size:  54.0 kB                                 
    [npmPack] npm notice unpacked size: 436.9 kB                                
    [npmPack] npm notice shasum:        92cec06eb7b6102556931976a884c9f0e36c368c
    [npmPack] npm notice integrity:     sha512-AqXLvLxSPZyHo[...]w0V5+89loK4EA==

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 14, 2020

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 14, 2020

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@raych1
Copy link
Member

raych1 commented Jul 14, 2020

Hi @nivats , as identified in the automated checks there are breaking changes, Please follow Azure Breaking changes approval request form as defined.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@raych1
Copy link
Member

raych1 commented Jul 21, 2020

@nivats , As identified in the automated checks there are breaking changes, Please follow Azure Breaking changes approval request form as defined at breaking change process.

@nivats nivats closed this Jul 23, 2020
@nivats nivats force-pushed the dev-storageimportexport-Microsoft.ImportExport-2016-11-01 branch from c4f6fc7 to 7f1b65d Compare July 23, 2020 08:34
@nivats nivats reopened this Jul 23, 2020
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nivats
Copy link
Contributor Author

nivats commented Jul 23, 2020

I have added new version of api swagger along with examples and have reverted changes from swagger and examples of previous version of API

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-assignment-bot openapi-assignment-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 23, 2020
@nivats nivats requested a review from raych1 July 26, 2020 15:17
@ravbhatnagar
Copy link
Contributor

property to take microsoft managed or customer managed keys is added. Signing off from arm side.

@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jul 28, 2020
@raych1 raych1 merged commit 9d13acc into Azure:master Jul 30, 2020
00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
* added swagger for new version of API

* fixed warning

* Fixed failing spell check and other tests

* tried fixing avocado

* tried fixing avocado for readme

* added fix for lintdiff failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants