Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Azure Digital Twins ] API Review #25023

Closed
azure-sdk opened this issue Jul 27, 2023 · 3 comments · Fixed by #25746
Closed

[Azure Digital Twins ] API Review #25023

azure-sdk opened this issue Jul 27, 2023 · 3 comments · Fixed by #25746
Labels
API Review Scoping This is an issue that will track work on a specific set of API changes.

Comments

@azure-sdk
Copy link
Collaborator

New API Review meeting has been requested.

Service Name: Azure Digital Twins
Review Created By: Rachel Teitelbaum
Review Date: 09/05/2023 01:00 PM PT
Onboarding Record:
PR:
Hero Scenarios Link: Not Provided
Core Concepts Doc Link: Not Provided

Description: Would like to take our private previewed Bulk Delete API to GA on an accelerated timeline

Detailed meeting information and documents provided can be accessed here
For more information that will help prepare you for this review, the requirements, and office hours, visit the documentation here

@azure-sdk azure-sdk added the API Review Scoping This is an issue that will track work on a specific set of API changes. label Jul 27, 2023
@azure-sdk
Copy link
Collaborator Author

Meeting updated by Rachel Teitelbaum

Service Name: Azure Digital Twins
Review Created By: Rachel Teitelbaum
Review Date: 09/13/2023 09:00 AM PT
Onboarding Record:
PR:
Hero Scenarios Link: Not Provided
Core Concepts Doc Link: Not Provided

Description: Would like to take our private previewed Bulk Delete API to GA on an accelerated timeline

Detailed meeting information and documents provided can be accessed here
For more information that will help prepare you for this review, the requirements, and office hours, visit the documentation here

@azure-sdk
Copy link
Collaborator Author

Meeting updated by Rachel Teitelbaum

Service Name: Azure Digital Twins
Review Created By: Rachel Teitelbaum
Review Date: 09/13/2023 09:00 AM PT
Onboarding Record:
PR: #25746
Hero Scenarios Link: Not Provided
Core Concepts Doc Link: Not Provided

Description: Would like to take our private previewed Bulk Delete API to General Availability. No major API changes from private preview to GA at the moment.

Detailed meeting information and documents provided can be accessed here
For more information that will help prepare you for this review, the requirements, and office hours, visit the documentation here

@mikekistler mikekistler linked a pull request Sep 13, 2023 that will close this issue
3 tasks
@mikekistler
Copy link
Member

Notes from API Review meeting, 9/13/23

API is essentially unchanged from private preview. [PR 12803]

Discussed during the meeting:

  • Why use POST rather than PUT to create the delete job?
  • What customer feedback did you get from private preview?
  • If we have /jobs/imports collection, should the delete collection then also be called /jobs/deletesin plural?
  • Have any customers used SDKs for this new feature?
  • Why delete on /jobs/imports but not on /jobs/delete ?
  • Need better documentation! When to use delete vs cancel.
  • Using the same API pattern for imports and deletes will make it easier on users
    • PUT will be easier for idempotency as well
  • "deletions" is a better option than "delete"
    • "/jobs/deletions"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Review Scoping This is an issue that will track work on a specific set of API changes.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants