Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Public IP Created in 2021-08-01 Does Not Return ddosSettings. protectionMode in 2022-05-01 #22068

Open
teowa opened this issue Jan 5, 2023 · 1 comment
Open

Public IP Created in 2021-08-01 Does Not Return ddosSettings. protectionMode in 2022-05-01 #22068

teowa opened this issue Jan 5, 2023 · 1 comment
Labels
Network Service Attention Workflow: This issue is responsible by Azure service team.

Comments

@teowa
Copy link
Contributor

teowa commented Jan 5, 2023 •
edited
Loading

swagger

azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2022-05-01/publicIpAddress.json

Lines 615 to 631 in 3dae944

"DdosSettings": {
"properties": {
"protectionMode": {
"readOnly": false,
"type": "string",
"enum": [
"VirtualNetworkInherited",
"Enabled",
"Disabled"
],
"x-ms-enum": {
"name": "DdosSettingsProtectionMode",
"modelAsString": true
},
"description": "The DDoS protection mode of the public IP"
},
"ddosProtectionPlan": {

Same API payload, PUT in 2022-05-01 and then GET in 2022-05-01, we will get ddosSettings. protectionMode="VirtualNetworkInherited", but if we
PUT in 2021-08-01 and then GET in 2022-05-01, this value is missed. The API should also return this value.

PUT in 2021-08-01 and then GET in 2022-05-01

PUT https://management.azure.com/subscriptions/XXXX/resourceGroups/wt-terraform/providers/Microsoft.Network/publicIPAddresses/test-ip-1?api-version=2021-08-01

x-ms-request-id: edf3ba73-d4c0-48e6-94a9-de55f00c2a8c

{
    "location": "westeurope",
    "properties": {
        "publicIPAddressVersion": "IPv4",
        "publicIPAllocationMethod": "Static",
        "idleTimeoutInMinutes": 4,
        "ipTags": []
    },
    "sku": {
        "name": "Standard",
        "tier": "Regional"
    }
}

{
    "name": "test-ip-1",
    "id": "/subscriptions/XXXX/resourceGroups/wt-terraform/providers/Microsoft.Network/publicIPAddresses/test-ip-1",
    "etag": "W/\"3866f0cc-2f25-4782-ae75-b7738b453dc1\"",
    "location": "westeurope",
    "properties": {
        "provisioningState": "Updating",
        "resourceGuid": "0e306475-03e2-46f2-8dbd-3221c94379b5",
        "publicIPAddressVersion": "IPv4",
        "publicIPAllocationMethod": "Static",
        "idleTimeoutInMinutes": 4,
        "ipTags": []
    },
    "type": "Microsoft.Network/publicIPAddresses",
    "sku": {
        "name": "Standard",
        "tier": "Regional"
    }
}

GET https://management.azure.com/subscriptions/XXXX/resourceGroups/wt-terraform/providers/Microsoft.Network/publicIPAddresses/test-ip-1?api-version=2022-05-01

x-ms-request-id: bbe9a22b-ebff-4c06-b002-0ee60d1bcbd5

{
    "name": "test-ip-1",
    "id": "/subscriptions/XXXX/resourceGroups/wt-terraform/providers/Microsoft.Network/publicIPAddresses/test-ip-1",
    "etag": "W/\"152d74c8-f90e-4fbb-abdd-f3ea49f5cbd6\"",
    "location": "westeurope",
    "properties": {
        "provisioningState": "Succeeded",
        "resourceGuid": "0e306475-03e2-46f2-8dbd-3221c94379b5",
        "ipAddress": "20.105.165.128",
        "publicIPAddressVersion": "IPv4",
        "publicIPAllocationMethod": "Static",
        "idleTimeoutInMinutes": 4,
        "ipTags": []
    },
    "type": "Microsoft.Network/publicIPAddresses",
    "sku": {
        "name": "Standard",
        "tier": "Regional"
    }
}

PUT in 2022-05-01 and then GET in 2022-05-01

PUT https://management.azure.com/subscriptions/XXXX/resourceGroups/wt-terraform/providers/Microsoft.Network/publicIPAddresses/test-ip-2?api-version=2022-05-01

x-ms-request-id: 20a4087e-19bb-4603-a744-9214371ed039

{
    "location": "westeurope",
    "properties": {
        "publicIPAddressVersion": "IPv4",
        "publicIPAllocationMethod": "Static",
        "idleTimeoutInMinutes": 4,
        "ipTags": []
    },
    "sku": {
        "name": "Standard",
        "tier": "Regional"
    }
}

{
    "name": "test-ip-2",
    "id": "/subscriptions/XXXX/resourceGroups/wt-terraform/providers/Microsoft.Network/publicIPAddresses/test-ip-2",
    "etag": "W/\"d6190c21-2f81-4214-8003-12a5ae690434\"",
    "location": "westeurope",
    "properties": {
        "provisioningState": "Updating",
        "resourceGuid": "6314370c-6048-4dc1-9d53-d8260299aecd",
        "publicIPAddressVersion": "IPv4",
        "publicIPAllocationMethod": "Static",
        "idleTimeoutInMinutes": 4,
        "ipTags": [],
        "ddosSettings": {
            "protectionMode": "VirtualNetworkInherited"
        }
    },
    "type": "Microsoft.Network/publicIPAddresses",
    "sku": {
        "name": "Standard",
        "tier": "Regional"
    }
}

GET https://management.azure.com/subscriptions/XXXX/resourceGroups/wt-terraform/providers/Microsoft.Network/publicIPAddresses/test-ip-2?api-version=2022-05-01

x-ms-request-id: f6cb438f-3045-4bf8-bfba-c3e6325fbaad

{
    "name": "test-ip-2",
    "id": "/subscriptions/XXXX/resourceGroups/wt-terraform/providers/Microsoft.Network/publicIPAddresses/test-ip-2",
    "etag": "W/\"77504cc7-7f69-401b-a1cf-d6d56189a0e3\"",
    "location": "westeurope",
    "properties": {
        "provisioningState": "Succeeded",
        "resourceGuid": "6314370c-6048-4dc1-9d53-d8260299aecd",
        "ipAddress": "20.160.157.42",
        "publicIPAddressVersion": "IPv4",
        "publicIPAllocationMethod": "Static",
        "idleTimeoutInMinutes": 4,
        "ipTags": [],
        "ddosSettings": {
            "protectionMode": "VirtualNetworkInherited"
        }
    },
    "type": "Microsoft.Network/publicIPAddresses",
    "sku": {
        "name": "Standard",
        "tier": "Regional"
    }
}
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jan 5, 2023
@teowa teowa mentioned this issue Jan 5, 2023
Merged
@JackTn JackTn added Network Service Attention Workflow: This issue is responsible by Azure service team. labels Jan 6, 2023
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jan 6, 2023
@ghost
Copy link

ghost commented Jan 6, 2023

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @aznetsuppgithub.

Issue Details

swagger

azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2022-05-01/publicIpAddress.json

Lines 615 to 631 in 3dae944

"DdosSettings": {
"properties": {
"protectionMode": {
"readOnly": false,
"type": "string",
"enum": [
"VirtualNetworkInherited",
"Enabled",
"Disabled"
],
"x-ms-enum": {
"name": "DdosSettingsProtectionMode",
"modelAsString": true
},
"description": "The DDoS protection mode of the public IP"
},
"ddosProtectionPlan": {

Same API payload, PUT in 2022-05-01 and then GET in 2022-05-01, we will get ddosSettings. protectionMode="VirtualNetworkInherited", but if we
PUT in 2021-08-01 and then GET in 2022-05-01, this value is missed. The API should also return this value.

PUT in 2021-08-01 and then GET in 2022-05-01

PUT https://management.azure.com/subscriptions/XXXX/resourceGroups/wt-terraform/providers/Microsoft.Network/publicIPAddresses/test-ip-1?api-version=2021-08-01

x-ms-request-id: edf3ba73-d4c0-48e6-94a9-de55f00c2a8c

{
    "location": "westeurope",
    "properties": {
        "publicIPAddressVersion": "IPv4",
        "publicIPAllocationMethod": "Static",
        "idleTimeoutInMinutes": 4,
        "ipTags": []
    },
    "sku": {
        "name": "Standard",
        "tier": "Regional"
    }
}

{
    "name": "test-ip-1",
    "id": "/subscriptions/XXXX/resourceGroups/wt-terraform/providers/Microsoft.Network/publicIPAddresses/test-ip-1",
    "etag": "W/\"3866f0cc-2f25-4782-ae75-b7738b453dc1\"",
    "location": "westeurope",
    "properties": {
        "provisioningState": "Updating",
        "resourceGuid": "0e306475-03e2-46f2-8dbd-3221c94379b5",
        "publicIPAddressVersion": "IPv4",
        "publicIPAllocationMethod": "Static",
        "idleTimeoutInMinutes": 4,
        "ipTags": []
    },
    "type": "Microsoft.Network/publicIPAddresses",
    "sku": {
        "name": "Standard",
        "tier": "Regional"
    }
}

GET https://management.azure.com/subscriptions/XXXX/resourceGroups/wt-terraform/providers/Microsoft.Network/publicIPAddresses/test-ip-1?api-version=2022-05-01

x-ms-request-id: bbe9a22b-ebff-4c06-b002-0ee60d1bcbd5

{
    "name": "test-ip-1",
    "id": "/subscriptions/XXXX/resourceGroups/wt-terraform/providers/Microsoft.Network/publicIPAddresses/test-ip-1",
    "etag": "W/\"152d74c8-f90e-4fbb-abdd-f3ea49f5cbd6\"",
    "location": "westeurope",
    "properties": {
        "provisioningState": "Succeeded",
        "resourceGuid": "0e306475-03e2-46f2-8dbd-3221c94379b5",
        "ipAddress": "20.105.165.128",
        "publicIPAddressVersion": "IPv4",
        "publicIPAllocationMethod": "Static",
        "idleTimeoutInMinutes": 4,
        "ipTags": []
    },
    "type": "Microsoft.Network/publicIPAddresses",
    "sku": {
        "name": "Standard",
        "tier": "Regional"
    }
}

PUT in 2022-05-01 and then GET in 2022-05-01

PUT https://management.azure.com/subscriptions/XXXX/resourceGroups/wt-terraform/providers/Microsoft.Network/publicIPAddresses/test-ip-2?api-version=2022-05-01

x-ms-request-id: 20a4087e-19bb-4603-a744-9214371ed039

{
    "location": "westeurope",
    "properties": {
        "publicIPAddressVersion": "IPv4",
        "publicIPAllocationMethod": "Static",
        "idleTimeoutInMinutes": 4,
        "ipTags": []
    },
    "sku": {
        "name": "Standard",
        "tier": "Regional"
    }
}

{
    "name": "test-ip-2",
    "id": "/subscriptions/XXXX/resourceGroups/wt-terraform/providers/Microsoft.Network/publicIPAddresses/test-ip-2",
    "etag": "W/\"d6190c21-2f81-4214-8003-12a5ae690434\"",
    "location": "westeurope",
    "properties": {
        "provisioningState": "Updating",
        "resourceGuid": "6314370c-6048-4dc1-9d53-d8260299aecd",
        "publicIPAddressVersion": "IPv4",
        "publicIPAllocationMethod": "Static",
        "idleTimeoutInMinutes": 4,
        "ipTags": [],
        "ddosSettings": {
            "protectionMode": "VirtualNetworkInherited"
        }
    },
    "type": "Microsoft.Network/publicIPAddresses",
    "sku": {
        "name": "Standard",
        "tier": "Regional"
    }
}

GET https://management.azure.com/subscriptions/XXXX/resourceGroups/wt-terraform/providers/Microsoft.Network/publicIPAddresses/test-ip-2?api-version=2022-05-01

x-ms-request-id: f6cb438f-3045-4bf8-bfba-c3e6325fbaad

{
    "name": "test-ip-2",
    "id": "/subscriptions/XXXX/resourceGroups/wt-terraform/providers/Microsoft.Network/publicIPAddresses/test-ip-2",
    "etag": "W/\"77504cc7-7f69-401b-a1cf-d6d56189a0e3\"",
    "location": "westeurope",
    "properties": {
        "provisioningState": "Succeeded",
        "resourceGuid": "6314370c-6048-4dc1-9d53-d8260299aecd",
        "ipAddress": "20.160.157.42",
        "publicIPAddressVersion": "IPv4",
        "publicIPAllocationMethod": "Static",
        "idleTimeoutInMinutes": 4,
        "ipTags": [],
        "ddosSettings": {
            "protectionMode": "VirtualNetworkInherited"
        }
    },
    "type": "Microsoft.Network/publicIPAddresses",
    "sku": {
        "name": "Standard",
        "tier": "Regional"
    }
}
Author: teowa
Assignees: -
Labels:

Network, Service Attention, needs-triage
Milestone: -

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Network Service Attention Workflow: This issue is responsible by Azure service team.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JackTn @teowa