Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R2008 erroneously fails when property narrows mutability from the base definition #15666

Closed
forteddyt opened this issue Aug 16, 2021 · 1 comment
Closed

R2008 erroneously fails when property narrows mutability from the base definition #15666

forteddyt opened this issue Aug 16, 2021 · 1 comment
Assignees
@jianyexi
Labels
needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team.

Comments

@forteddyt
Copy link
Contributor

PR in question: #15439
LintDiff Gate: https://github.com/Azure/azure-rest-api-specs/pull/15439/checks?check_run_id=3344805888
Fails with: When property is modeled as 'readOnly': true then x-ms-mutability extension can only have 'read' value. When property is modeled as 'readOnly': false then applying x-ms-mutability extension with only 'read' value is not allowed. Extension contains invalid values: 'read'.

This was originally caught in #12554 (comment). For example, EnvironmentVersion.environmentType is correctly marked as ReadOnly, with the correct x-ms-mutability extension. However, since EnvironmentType has a wider mutability scope, R2008 is erroneously thrown.
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Aug 16, 2021
This was referenced Aug 16, 2021
Closed
Open
@forteddyt
Copy link
Contributor Author

moving to Azure/azure-openapi-validator#248

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jianyexi jianyexi

Labels
needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@forteddyt @jianyexi